terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	a43b7df282	core: Handle forced-create_before_destroy during the plan walk Previously we used a single plan action "Replace" to represent both the destroy-before-create and the create-before-destroy variants of replacing. However, this forces the apply graph builder to jump through a lot of hoops to figure out which nodes need it forced on and rebuild parts of the graph to represent that. If we instead decide between these two cases at plan time, the actual determination of it is more straightforward because each resource is represented by only one node in the plan graph, and then we can ensure we put the right nodes in the graph during DiffTransformer and thus avoid the logic for dealing with deposed instances being spread across various different transformers and node types. As a nice side-effect, this also allows us to show the difference between destroy-then-create and create-then-destroy in the rendered diff in the CLI, although this change doesn't fully implement that yet.	7 years ago
Martin Atkins	a37d5268eb	command/format: Render unified diff for list and tuple value changes	7 years ago
Martin Atkins	30a46ed8ed	command/format: Further refinement on the heuristic JSON-based diff We'll now show an "update" symbol prior to the argument to this synthetic jsonencode(...) call, for consistency with how we show nested values in other cases and to attach a verb to any "# forces replacement". We'll also show a special form in the case where the value seems to differ only in whitespace, so users can understand what's going on in that hopefully-rare situation, particularly if those whitespace-only changes end up forcing us to replace a remote object.	7 years ago
Martin Atkins	783205948c	command/format: JSON value formatting heuristic not for primitive values Since our own syntax for primitive values is similar to that of JSON, and since we permit automatic conversions from number and bool to string, we must do this special JSON value diff formatting only if the value is a JSON array or object to avoid confusing results.	7 years ago
Martin Atkins	4406b06ef8	command/format: Don't include commas after elements in map diffs Although commas are allowed in this context, it's not idiomatic to use them.	7 years ago
Martin Atkins	ce157c7f23	command/format: show deep diffs for old/new JSON strings Because so far we've not supported dynamically-typed complex data structures, several providers have used strings containing JSON to stand in for these. In order to get a readable diff in those cases, we'll recognize situations where old and new are both JSON and present a diff of the effective value of the JSON, using a faux call to the jsonencode(...) function to indicate when we've done so. This is a bit of a "cute" heuristic, but is important at least for now until we can migrate away from that practice of passing large JSON strings to providers and use dynamically-typed attributes instead.	7 years ago
Martin Atkins	9706a00b3a	command/format: correct alignment for multi-line values in map diff	7 years ago
Martin Atkins	04d8c17be8	command/format: Nice rendering for changes to map values	7 years ago
Martin Atkins	a2f4b8b058	command/format: Show resource diff with header "comment" This extra comment line gives us a place to show the full resource address (since the block header line only includes type and name) and also allows us to explain in long form the meaning of the change icon on the following line.	7 years ago
Martin Atkins	239a54ad6f	command: initial structural diff rendering This is a light adaptation of our earlier prototype of structural diff rendering, as a starting point for what we'll actually ship. This is not consistent with the latest mocks, so will need some additional work before it is ready, but integrating this allows us to at least see the plan contents while fixing up remaining issues elsewhere.	7 years ago

10 Commits (f1657bb3e35acad90f6aff79110c593b9462cc4d)