154 Commits (f031b14ece87951a7ec6fb4e925bafe337ca7d68)

Author	SHA1	Message	Date
Radek Simko	bfa011e88b	command/views: Fix flaky hook tests (#36104)	1 year ago
Bruno Schaatsbergen	a5d8673a41	Revert "Merge pull request #35929 from bschaatsbergen/b/fix-retry-messages-in-cloud-backend-json" ... This reverts commit f8cb25a246, reversing changes made to a25831d6ef.	1 year ago
Bruno Schaatsbergen	6b0ba4d20d	refactor: gracefully handle marshalling error with empty output	1 year ago
Bruno Schaatsbergen	b358e333ee	refactor: make methods private	1 year ago
Bruno Schaatsbergen	515897a125	copyright: add missing header ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	45c38a6469	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	ae661f3568	views: add comments for clarity ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Daniel Schmidt	90973698bf	Merge branch 'main' into pass-ephemeral-variables-to-terraform-apply	1 year ago
Bruno Schaatsbergen	94c732b7a5	views: refactor RetryLog to use an elapsed time ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	93ae38dadf	views: add tests for cloud view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
James Bardin	c2a1070c23	create a ui hook for unknown ephemeral config ... This is a stopgap to give users some feedback when an ephemeral resource contains unknowns and cannot be opened. There is no json hook implementation so that the machine-readable spec is not bound to the new output until further review. It doesn't really fit with the current json ui model to have messages about what isn't going to happen.	1 year ago
Bruno Schaatsbergen	c71a1a775e	views: refactor retry logic with retryHelper function ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	558aa18be7	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	ad1f3e0adc	views: add tests for cloud view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	c9f418d853	views: add PrepareMessage to cloud view interface ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Radek Simko	8176657c5b	command/views: Attempt to fix flaky JSON hook test (#35940)	1 year ago
Daniel Schmidt	fa44937977	ephemeral: improve diagnostic message through compactValueStr	1 year ago
Bruno Schaatsbergen	6c14e52d8e	test: use Cloud view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	377c959c33	views: add cloud view ... The cloud view is responsible for rendering messages related to cloud operations, presenting them to the user in either a human-readable format or as JSON output in the terminal. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	a90930427a	chore: remove the retrylog hook from the init view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	fb878889f2	Merge branch 'main' into b/fix-retry-messages-in-cloud-backend-json	1 year ago
Bruno Schaatsbergen	f9797595e3	chore: initialize new view in meta backend ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Radek Simko	3d4dab01a0	command/views: Attempt to fix flaky hook test (#35927) ... Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>	1 year ago
Bruno Schaatsbergen	f5dc158709	views: render retry messages using the view ... Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Bruno Schaatsbergen	8635cb1cfb	views: move retryLog hook to init view ... The cloud backend includes a retry hook that relies on a go-tfe implementation. Since these retry messages were not rendered through a view, the `-json` flag was not respected, leading to mixed (non-pure JSON) output in the terminal whenever retry messages were printed. Before passing the init view to the cloud backend, we ensure the retryLog hook is included in the init view. Signed-off-by: Bruno Schaatsbergen <git@bschaatsbergen.com>	1 year ago
Radek Simko	0a266c88c4	terraform: Emit lifecycle phases of ephemeral resources to the UI (#35919)	1 year ago
Sebastian Rivera	ee1a2a7858	Implement the modules command ... The modules command provides a holistic view of all installed modules for a given root module. It also includes information on whether a installed module is currently referenced by configuration. As of now, this command only supports a machine-readable view format.	1 year ago
Daniel Schmidt	b9f273639d	handle ephemeral and sensitive case in diagnostics	2 years ago
Daniel Schmidt	97ba67edea	test: ensure ephemeral values are not shown in diagnostics and warning is printed	2 years ago
Radek Simko	06fd817b7c	Remove handling of ephemeral root outputs (#35809) ... * Remove handling of ephemeral root outputs This is effectively reverting ~99% of https://github.com/hashicorp/terraform/pull/35676 The only changes not being reverted are some formatting and deprecation fixes which remain relevant. The code being removed is basically dead code now in the context of root ephemeral outputs being rejected per https://github.com/hashicorp/terraform/pull/35791 * Remove unrelated changes	2 years ago
kmoe	a2039517a5	states: store ephemeral output values in memory (#35676) ... Ephemeral root output values must be kept in the in-memory state representation, but not written to the state file. To achieve this, we store ephemeral root outputs separately from non-ephemeral root outputs, so Terraform can access them during a single plan or apply phase. Ephemeral root outputs always have a value of null in the state file. This means that the "terraform output" command, that reads the state file, reports null values for these outputs. Consumers of 'terraform output -json' should use the presence of '"ephemeral": true' in such output to interpret the value correctly.	2 years ago
James Bardin	16231373a4	update changes in command pkgs	2 years ago
Liam Cervante	3ce9e517ae	fix flaky test in views package (#35469)	2 years ago
Martin Atkins	6f84623cb6	terraform: Initial partial support for ephemeral values ... This is a checkpoint commit on the path to supporting ephemeral values as a cross-cutting concern in the Terraform language. An ephemeral value is one that lives only in RAM during a single phase and so cannot persist from the plan phase to the apply phase, or between consecutive plan/apply rounds. Terraform tracks whether each value is ephemeral using the cty "marks" concept, thus achieving the same dynamic analysis as we already employ for the concept of "sensitive values" that prevents displaying a value in the user interface. This commit is just a starting point which gets some of the basics into place: - input variables and output values can both be statically declared as being ephemeral. Only ephemeral inputs/outputs can have ephemeral values assigned to them, and the recipient of the value sees it as ephemeral even if the assigned value was not already ephemeral. This creates a dynamic analysis cutoff point at module boundaries so that it's possible to determine in isolation whether a single module is using ephemeral values correctly, without having to test it in every possible calling context. - Managed and data resources cannot have ephemeral values assigned into their configurations because Terraform and providers both expect the resource attributes to persist between phases. - Ephemeral values _can_ be used in provider and provisioner configurations, because both of those effectively meet the definition of the new "ephemeral" concept despite it not previously having a name. - Ephemeral markings propagate through all of the built-in language features for dynamic analysis purposes, largely relying on cty's efforts to do that in similar vein as for sensitive marks. In particular, it's possible to define a local value whose expression produces an ephemeral result, and passing ephemeral values to functions should propagate the ephemeral mark to the results when appropriate. (I've not yet thoroughly reviewed all of the built-in functions for correct marks handling though, so there may be some gaps to address in later commits.) The next step for this work will be to change the modules runtime to have support for a workflow involving ephemeral _root_ input variables, where their values must be re-supplied during the apply phase. That will then achieve (in experimental capacity) the first goal of ephemeral values: to be able to provide non-persistent settings such as time-limited API tokens to use in provider configuration blocks.	2 years ago
Brandon Croft	3a5221269b	Revert "Add Warning for Deprecated Modules in `Init` (Second Revision)"	2 years ago
Mark DeCrane	1e7c29243e	Added Extra field for TFC diagnostic processing	2 years ago
Sebastian Rivera	015f795ff0	Rebrand Terraform Cloud to HCP Terraform	2 years ago
UKEME BASSEY	a4415c030a	making json data more useful for client consumption	2 years ago
UKEME BASSEY	7fb13b8868	fixing tests	2 years ago
UKEME BASSEY	c7bbc09631	move all command args from command/init to args/init	2 years ago
UKEME BASSEY	0ea25e3b40	fixing tests internal/command/init, view and argumento	2 years ago
UKEME BASSEY	ea8d0869d8	convert all logs to be view type exclusive for human or json format	2 years ago
UKEME BASSEY	7709db45dc	add init view test	2 years ago
UKEME BASSEY	14c53f74f2	add init view for json and human type view	2 years ago
Martin Atkins	c1342f4f6a	terraform test: Include test case execution time in JUnit XML ... Our currently-experimental JUnit XML output didn't previously include the "time" attribute for test runs at all, but from testing with common JUnit XML consumers we've learned that populating this is effectively mandatory because otherwise software just assumes that it's zero, producing a misleading result. We'll now populate it based on the test runner's measure of the execution time, assuming that the test runner actually measured it. If not, we'll leave it omitted and thus get the same behavior as before, which in practice means that most software will treat it as zero anyway. Because JUnit XML output is still experimental with the goal of getting feedback on exactly how we map the Terraform testing model onto that Java-oriented format, this is intentionally not supported for remote test runs in Terraform Cloud yet. It isn't really practical for Terraform Cloud to participate in short-lived Terraform CLI experiments, because Terraform Cloud has a different release schedule than Terraform CLI does. However, if this experiment is successful then we will eventually need to find a way to plumb this additional information through the JSON logs and ensure that it arrives in the locally-generated JUnit XML output.	2 years ago
Martin Atkins	c8611b51d7	terraform test: JUnit XML output sets testcase classname ... JUnit XML output from "terraform test" is currently experimental, because we're still trying to decide how best to map Terraform's testing concepts onto the Java-oriented JUnit XML format. The first round of feedback showed that some JUnit consumers completely ignore test suite names, and instead expect each test case to specify which "class" it belongs to. Those tools then might allow grouping or filtering the tests by "class". Despite the Java-oriented terminology, it seems that "classname" is really just interpreted something like "test group name", where the classname and the name together represent the full test case identifier. With that in mind then, we'll now duplicate the test suite name (which in our case is the filename of the test scenario file) into the classname attribute of each testcase element. For now we'll retain the per-suite names, always containing the same value, because we also have evidence of some consumers preferring to find this information in that location.	2 years ago
Nick Fagerlund	ccab5f1e55	Rename some UiHook tests for easier ad-hoc runs	2 years ago
Nick Fagerlund	94ea534e40	Refactor terraform.Hook to use a resource-identifying wrapper struct ... The terraform.Hook interface lets other areas of code perform streaming reactions to various events, generally in the service of some UI somewhere. Nearly all of the methods on this interface take an `addrs.AbsResourceInstance` as their first argument, to identify the resource that's being operated on. However, that addrs struct doesn't necessarily contain everything you might want in order to uniquely and usefully identify a resource. It has the module instance and resource instance addresses, but it lacks the provider source address, which can affect how the consuming UI should display the resource's events. (For example, Terraform Cloud wants reliable info about who maintains a given provider, what cloud provider it operates on, and where to find its documentation.) Instead of polluting `addrs.AbsResourceInstance` with extra information that isn't relevant to other call sites, let's change the first argument of each Hook method to be a wrapper struct defined in the package that owns the Hook interface, and add the provider address to that wrapper as a sibling of the resource address. This causes a big noisy commit today, but should streamline future updates to the UI-facing "identity" of a resource; existing callers can ignore any new fields they're uninterested in, or exploit new info as needed. Other than making new information available for future edits to Hook implementing types, this commit should have no effect on existing behavior.	2 years ago
Nick Fagerlund	d81a546e55	Lints: hook_count_test, "redundant type from slice composite literal" ... I was in the file for other reasons, and wanted to reduce noise in my editor.	2 years ago
Liam Cervante	f0b61090a2	Move the testing MockProvider into a dedicated shared package (#34681) ... * move the testing MockProvider into a dedicated shared package * address comments * fix new changes	2 years ago