terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	ca2be46b0e	workflows/checks: Run tests for all modules in this repository A few of the packages in this repository are separated into their own Go modules to reflect boundaries of code ownership and/or boundaries with significantly different external Go module dependencies. However, that means that the "./..." pattern in a Go command run at the root doesn't include those packages. The tests in the remote backends are mostly disabled in our unit test context because they require credentials for external network services, but nonetheless it's still useful to visit them and check if their packages can even compile. Therefore we'll now visit each of the modules and run tests for all packages in each one. This restores the coverage we had before the module split, with the only slight difference being that the remote backend tests now run only after all of the main Terraform tests, rather than being interleaved with Terraform's own packages as before. Since we're only visiting them to see if they compile anyway, this doesn't seem like a big deal.	2 years ago
Martin Atkins	5811be26f8	go.mod: Separate modules at code ownership boundaries Historically it's been hard for us to keep on top of dependency upgrades as a matter of course because it's unclear which code owners might be affected by or responsible for an upgrade of each module. After trying a few different techniques to try to mitigate this, the most promising one seems to be to tell the Go toolchain that each of these components is a separate Go module, but then to stitch them all back together again using replace directives so that we can mostly ignore these module boundaries in everyday development. The one case where we _do_ need to pay attention to these boundaries is also the case where the separation is useful: upgrading a dependency of any one of these modules might potentially force upgrading it for another module too, and so the Go toolchain will help us notice that interaction and we can immediately which code owners might need to be involved in reviewing and testing that particular upgrade. To make that process less onerous, this adds a new makefile target "make syncdeps" which runs "go mod tidy" in all of the modules at once and thus forces the toolchain to align their dependencies to the extent required for them all to be linked together successfully, and to generate go.mod and/or go.sum diffs that will match our configured code ownership paths to trigger the appropriate code review requests. Hopefully before too long we'll be able to move all the backends out into provider plugins and delete the "legacy" module entirely and then this oddness won't be needed anymore, but as long as we're all trying to play together in this same sandbox this is a small amount of extra ceremony in return for hopefully reducing the level of anxiety involved in keeping the system's dependencies up to date more consistently.	2 years ago
Alisdair McDiarmid	1317cda8e7	build: Run checks on all pushed branches It is helpful to see the result of the checks workflow prior to opening a PR, to avoid wasting time fixing unexpectedly failing checks while the PR is open and awaiting review. This commit configures GitHub Actions to run checks on all pushed branches.	2 years ago
Radek Simko	0c509183d1	ci: Add test for license headers (#34624 ) * ci: Add test for copyright headers * replace GHA workflow with make target (copyright) This makes it reusable for outside of CI, such that anyone cloning the repo locally can still easily verify compliance before raising a PR. * remove go:generate for copywrite This should no longer be needed as we leverage copywrite via a shell script now. * introduce make copyrightfix	2 years ago
Craig Wright	5848d8a2b4	Limiting lock behavior to issues and PRs; ignoring discussions. Currently, discussions are not a feature we use on GitHub. However, we did not want to enable an automated behavior that would be difficult and confusing to track down for a future enabler of GitHub Discussions.	2 years ago
kyu08	9e12056cfb	chore(GitHub Actions): fix inputs of Lock Threads, and bump version	2 years ago
CJ Horton	617fb35ad1	pin the image sha for good measure	2 years ago
CJ Horton	49eba459f1	use latest backport-assistant	2 years ago
Liam Cervante	9d330d2b0a	Fix cross build file link from build.yml (#33735 )	3 years ago
Rose M Koron	cfc26c3e21	Update file name	3 years ago
sarahethompson	633f6a6528	update linux package license to BUSL-1.1 update copywrite.hcl to BUS-1.1	3 years ago
hashicorp-tsccr[bot]	4671514676	Result of tsccr-helper -log-level=info -pin-all-workflows . (#33527 ) Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>	3 years ago
Bryce Kalow	c42e0ee89c	chore(docs): delete check-legacy-links-format.yml (#33300 )	3 years ago
Scott Macfarlane	fa3980b77d	Disable reproducability check in actions-go-build (#33095 ) Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>	3 years ago
Liam Cervante	1a36d07ead	Add new actions for executing the equivalence tests after a CRT release (#32959 ) * add new actions for executing the equivalence tests after a CRT release * ready for review * Update .github/actions/equivalence-test/action.yml Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com> * address comments --------- Co-authored-by: CJ Horton <17039873+radditude@users.noreply.github.com>	3 years ago
Daniel Kimsey	1d9581682b	ci: Smoke test docker builds This adds a test to catch the glibc build issue that caused #32947. We check both the container executes and the version is correct.	3 years ago
Daniel Kimsey	64c4e1b4c1	Merge pull request #32951 from hashicorp/fix-incorrect-cgo-flag ci: Correctly pass cgo_enabled=0 flag	3 years ago
Daniel Kimsey	e9628c5eba	ci: Correctly pass cgo_enabled=0 flag This flag was not being passed correctly, it caused the value to be read as unset. Which effectively defaults to enabled. Related to incident 230330-1	3 years ago
emily neil	649d6d3f12	Upload ECR image to correct ECR repo (#32948 ) Co-authored-by: emilymianeil <eneil@hashicorp.com>	3 years ago
emily neil	880b87a0e7	Releng/migrate common release tooling (#32797 ) * Migrate set-output to GITHUB_OUTPUT Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com> * Migrate terraform to CRT * Update ci branches & ci notification channel * Use version/VERSION file to parse version * Remove fetch raw version script and update pipeline to run on current branch * PR feedback: cgo-enabled now required flag, updated comments & include promotion steps in ci.hcl * Update version for main --------- Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com> Co-authored-by: Scott Macfarlane <smacfarlane@hashicorp.com> Co-authored-by: emilymianeil <eneil@hashicorp.com>	3 years ago
Ashlee M Boyer	b431b4ab80	Update check-legacy-links-format.yml	3 years ago
Ashlee M Boyer	e793729602	Delete test-link-rewrites.yml	3 years ago
Ashlee Boyer	c850399c0d	Updating main-branch-preview-url	3 years ago
Ashlee Boyer	534366d0ff	Adding test-link-rewrites workflow	3 years ago
Ashlee Boyer	e81c849617	Adding docs-content-check-legacy-links-format workflow	3 years ago
CJ Horton	25d8f26e41	Remove docs bundle from build workflow	3 years ago
Liam Cervante	6a1a9928a2	[equivalence tests] Use the latest equivalence testing version when executing equivalence tests. (#32659 )	3 years ago
Liam Cervante	2325ec716c	Update Terraform equivalence tests to remove unneeded input. (#32288 ) * test * update equivalence testing framework version * Remove debugging statements * remove more debugging statements * s/liamcervante/hashicorp/g * remove and update deprecated set-output statements	3 years ago
Liam Cervante	37b88b33ce	Rollout equivalence testing during Terraform releases and builds (#31928 ) * add some basic equivalence tests and execute them in the build pipeline * remove old file, now unused * update terraform-equivalence-testing to v0.2.0 * add separate action * make sure to read from hashicorp repo * remove elevated github token where possible * Don't need elevated token anymore * update with official mock provider * last change: don't need the authorization header for public repositories.	3 years ago
Liam Cervante	4d7ba14f72	Add skeleton action for equivalence tests (#31940 )	3 years ago
Martin Atkins	d735de3656	build: checks.yml GitHub Actions workflow doesn't need goimports installed The importscheck script now uses "go run" to run this program and so the Go toolchain will install it automatically using the version number of golang.org/x/tools specified in our go.mod file.	4 years ago
Alvin Huang	634c875bea	set PRODUCT_VERSION for default docker build	4 years ago
Liam Cervante	afd273d636	Add goimports as a check to the Github commit actions (#31432 ) * Add goimports as a check to the Github commit actions * check diff against main instead of last commit * goimports should fix the problems * fix up conditionals and wildcard matching * specify origin/main in diff * fetch main branch when checkout * back to origin main	4 years ago
Martin Atkins	284a38a04c	build: Accept version numbers with prereleases containing dashes Previously we'd discard everything after the second dash.	4 years ago
Martin Atkins	096f0dc0da	build: Write the detected version number into the generated executable This also sets an additional variable if it detects that this is an alpha or development build, which currently does nothing but might eventually turn on the ability to use experimental features, if we make that something available only in prereleases.	4 years ago
Martin Atkins	7dd3cdfab4	build: Fetch all tags before deciding which version we're building The actions/checkout workflow does some heroics to try to fetch exactly the commit being built and nothing else, even if asked to fetch the history leading up to that commit. That means we don't end up having enough information to get an accurate answer from "git describe". Since we're intentionally relying on the git history here, we'll fetch all of the tags explicitly after initial checkout. Although that does add some delay to this step, we're intentionally doing this version calculation only once as a separate workflow job so that all of the other jobs can still benefit from this action's quicker checkout behavior.	4 years ago
James Bardin	2bd72914d8	add internal/states to the race detector tests This runs relatively quickly, and there is at least 1 test with concurrent operations.	4 years ago
Claire Labry	dd2decf921	change action to pull v1 instead of main	4 years ago
James Bardin	0693c8dfe7	enable the race detector in tests	4 years ago
Martin Atkins	5b615882e2	build: "Quick Checks" to run for external contributions The "push" event is only for pushes to branches within the same repository. Since external contributors make commits in their own repositories rather than directly in the target repository, we also need the pull_request event to react to opening a pull request and to pushing new code to an external branch associated with a pull request. Since internal pull requests would in principle trigger both "push" _and_ "pull_request", we also constrain the push event only to the branches we typically release from, on the assumption that all other branches will merge into those via pull requests. This avoids redundantly running the same checks in response to two events at the same time.	4 years ago
Martin Atkins	bbf540e0e3	build: "Quick Checks" caches protoc between runs Building our protobuf files requires the protoc tool, which takes a little while to download and install. Hopefully downloading it out of the GitHub Actions cache will make it a little faster in the common case where we're still using the same version as the previous run.	4 years ago
Martin Atkins	42a618f7c1	build: "Quick Checks" runs consistency checks concurrently with others Originally we had this running as part of the Unit Tests job because most of the checks are relatively fast. However, the addition of the protobuf generation check made that no longer be true because it needs to download and run protoc. With that extra overhead it now _is_ productive to spend the time booting and installing Go on third worker, as long as GitHub Actions continues to let us run all three of these jobs concurrently most of the time.	4 years ago
Martin Atkins	95f26b340b	build: "Quick Checks" no longer uses goenv goenv was making things more complicated than needed since it's really designed to help with interactive use in a shell more than automated use like this. Instead, we'll follow the same strategy that our build.yml was doing of just reading the .go-version file directly and then using the official actions/setup-go action to do the actual installation. The key advantage here is that Go ends up installed in a way where just running "go" will do the right thing, and we no longer need to fuss with shims and version-based path prefixes. Rather than duplicating the logic from build.yml, instead it's factored out into a separate composite action which both build.yml and checks.yml will now share, in case we want to change the Go version selection methodology in the future.	4 years ago
Martin Atkins	67fedd48a6	build: "Quick Checks" avoid repeating Install Go This factors out the "Install Go" step into a separate composite action which we can then call from both of the jobs that need it. We can't factor out the "Cache Go Modules" because GitHub doesn't allow composite actions to refer to other external actions.	4 years ago
Martin Atkins	9210ce6cdd	build: GitHub Actions "Quick Checks" workflow This is intended to eventually replace the CircleCI-based checks we use as part of the PR process in this repository. We're already using GitHub Actions for various other processes in this repository, so this change is motivated by consistency of having all of our automation running in the same system and written in the same language. This is not a complete replacement for our CircleCI workflow yet, and probably won't ever be because the CircleCI workflow contains some steps that are arguably redundant with other processes we follow elsewhere. However, the CircleCI workflow remains for now and won't be removed until we're satisfied that enough of it is replicated by this GitHub Actions workflow.	4 years ago
Alisdair McDiarmid	636499830b	Add merged pull request reminder	4 years ago
Michele Degges	2f465e6047	Update packaging action name	4 years ago
Martin Atkins	4ec1feaa3d	build: CGO_ENABLED when building for macOS Normally when we cross-compile we do so without CGo, because we don't have suitable C headers available for systems other than the host. However, building for macOS on macOS is special because there are sufficient headers available on darwin_amd64 to build for both darwin_amd64 _and_ darwin_arm64. Also, we _must_ use CGo on macOS because the system resolver is only available via darwin's libc, and so building without CGo produces executables that don't resolve hostnames correctly. This is a conditional in bash to avoid having to duplicate the entire step. Perhaps later we'll find a more general version of this which can avoid the special case, but this is sufficient for the moment.	4 years ago
Martin Atkins	28a6036cf2	build: Separate Linux distro package builds into separate job In our build workflow we'll treat Linux distribution packaging (currently .deb and .rpm packages) as a separate job, instead of embedding it into the "build" job, so that this step can happen concurrently with the other derived actions like the docker image build, and the e2etest runs.	4 years ago
Martin Atkins	c1699ea80c	build: Constrain permissions for the "build" workflow steps This workflow only generates artifacts and doesn't need to modify anything about the repository.	4 years ago

1 2

61 Commits (eecbfbf2cccedfb581469ee63599c4b4abc5c60f)