13 Commits (ee0dfba56571e127ff4d8351358c19def830e2cd)

Author	SHA1	Message	Date
Martin Atkins	cc8e8a55de	helper/schema: Default hashing function for sets ... A common issue with new resource implementations is not considering parts of a complex structure that's used inside a set, which causes quirky behavior. The schema helper has enough information to provide a default reasonable implementation of a set function that includes all non-computed attributes in a deterministic way. Here we implement such a function and use it when no explicit hashing function is provided. In order to achieve this we encapsulate the construction of the zero value for a schema in a new method schema.ZeroValue, which allows us to put the fallback logic to the new default function in a single spot. It is no longer valid to use &Set{F: schema.Set} and all uses of that construct should be replaced with schema.ZeroValue().(*Set) .	11 years ago
Mitchell Hashimoto	6e509aedcb	helper/schema: diff should include removed set items [GH-1823]	11 years ago
Sam Boyer	b82bd0c280	Condense switch fallthroughs into expr lists	11 years ago
Mitchell Hashimoto	2212d6895d	helper/schema: diff with set going to 0 elements removes it from state	11 years ago
Paul Hinze	4e8e3dad86	DiffFieldReader: filter all '#' fields from sets ... Now that readMap filters out '#' fields, when maps are nested in sets, we exposed a related bug where a set was iterating over nested maps and expected the '#' key to be present in those nested maps. By skipping _all_ count fields when iterating over set keys, all is right with the world again.	11 years ago
Paul Hinze	219aa3e788	helper/schema: fix DiffFieldReader map handling ... An `InstanceDiff` will include `ResourceAttrDiff` entries for the "length" / `#` field of maps. This makes sense, since for something like `terraform plan` it's useful to see when counts are changing. The `DiffFieldReader` was not taking these entries into account when reading maps out, and was therefore incorrectly returning maps that included an extra `'#'` field, which was causing all sorts of havoc for providers (extra tags on AWS instances, broken google compute instance launch, possibly others). * fixes #914 - extra tags on AWS instances * fixes #883 - general core issue sprouted from #757 * removes the hack+TODO from #757	11 years ago
Dave Cunningham	18c26cb2eb	Add some missing Float cases	11 years ago
Mitchell Hashimoto	1fcd24cf67	helper/schema: add float type	11 years ago
Mitchell Hashimoto	b4bf813151	helper/schema: too big to fail	11 years ago
Mitchell Hashimoto	7e379cb1a1	helper/schema: field readers no longer take a schema as arg	11 years ago
Mitchell Hashimoto	0b1da37b20	helper/schema: diff field reader should merge result with source	11 years ago
Mitchell Hashimoto	91a57b42e8	helper/schema: reading a diff with computed should return zero value	11 years ago
Mitchell Hashimoto	73726e83b2	helper/schema: DiffFieldReader for reading data from a diff	11 years ago