430 Commits (eccfa6de5ca33867f83ea2ea950579c7a2bd4d9c)

Author	SHA1	Message	Date
Jake Champlin	3600f0b730	Merge pull request #15723 from hashicorp/f-get-boolean-non-default ... core: Add `GetOkExists` schema function	9 years ago
Jake Champlin	d969f97e73	update tests	9 years ago
Jake Champlin	fa272e8c9c	Add more specific exists tests	9 years ago
Jake Champlin	268138dbd4	Rename to GetOkExists	9 years ago
Jake Champlin	270bbdb19b	core: Add `GetOkRaw` schema function ... Adds `GetOkRaw` as a schema function. This should only be used to verify boolean attributes are either set or not set, regardless of their zero value for their type. There are a few small use cases outside of the boolean type where this will be helpful as well. Overall, this shouldn't detract from the zero-value checks that `GetOK()` currently has, and should only be used when absolutely needed. However, there are enough use-cases for this addition without checking for the zero-value of the type, that this is needed. Primary use case is for a boolean attribute that is `Optional` and `Computed`, without a default value. There's currently no way to verify that the boolean attribute was explicitly set to the zero-value literal with the current `GetOk()` function. This new function allows for that check, keeping the `Computed` check for the returned `exists` boolean. ``` $ make test TEST=./helper/schema TESTARGS="-run=TestResourceDataGetOkRaw" ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/08/02 11:17:32 Generated command/internal_plugin_list.go go test -i ./helper/schema || exit 1 echo ./helper/schema | \ xargs -t -n4 go test -run=TestResourceDataGetOkRaw -timeout=60s -parallel=4 go test -run=TestResourceDataGetOkRaw -timeout=60s -parallel=4 ./helper/schema ok github.com/hashicorp/terraform/helper/schema 0.005s ```	9 years ago
James Bardin	ca68723c91	memoize DiffFieldReader.ReadField ... The field reader code path is extremely inefficient, but refactoring it all is much to invasive a change at the moment. Have DiffFieldReader internally cache results for ReadField.	9 years ago
Radek Simko	f979b8feef	Enforce field names to be alphanum lowercase + underscores (#15562)	9 years ago
Radek Simko	07cbd54fbc	Actively disallow reserved field names in schema (#15522)	9 years ago
joel.ringuette	ffddf96603	Fix issue with reading timeouts on Delete ... Original fix by @jringuette but I couldn't get his patch to apply after the repo split :/	9 years ago
clint shryock	11dc0c5fdf	Regression test for #767 (https://github.com/hashicorp/terraform/issues/14444)	9 years ago
Sander van Harmelen	7e180aec92	Refactor the provisioner validation function (#15273) ... It turns out that `d.GetOk` also returns `false` when the user _did_ actually supply a value for it in the config, but the value itself needs to be evaluated before it can be used. So instead of passing a `ResourceData` we now pass a `ResourceConfig` which makes much more sense for doing the validation anyway.	9 years ago
Radek Simko	1244309579	Fix stringer comments (#15069)	9 years ago
He Guimin	87562be855	provider/alicloud: Add the function of replacing ecs instance's system disk (#15048) ... * add replacing system disk function for ecs * remove ForceNew of system_disk_size	9 years ago
Jake Champlin	ac177492fb	core: Revert stringer changes from earlier commits	9 years ago
Thomas Schaaf	79c91e11c8	provider/aws: Add aws elastic beanstalk solution stack (#14944) ... * Add aws elastic beanstalk solution stack Signed-off-by: Thomas Schaaf <thomaschaaf@Thomass-MBP.fritz.box> * Fix incorrect naming Signed-off-by: Thomas Schaaf <thomaschaaf@Thomass-MBP.fritz.box> * Use unique go variable/function names Signed-off-by: Thomas Schaaf <thomaschaaf@Thomass-MacBook-Pro.local> * Add docs to sidebar * Sort provider by alphabet * Fix indent * Add required statement * Fix acceptance test	9 years ago
Jake Champlin	7894478c8c	Merge pull request #14681 from svanharmelen/f-review ... Use `helpers.shema.Provisoner` in Chef provisioner V2	9 years ago
James Bardin	6bc52be0a5	check for IsComputed when validating a schema obj ... GH-14784 allowed nested structures to be validate, rather than relying on the raw value. However this still returns the same validation error if the structures contain a computed value, since Get will return the raw string in that case. This simply skips the validation in the IsComputed case, since there's nothing that can be checked.	9 years ago
Matt Robenolt	b9a3433f6b	helper/schema: fix validating nested objects ... When interpreting a nested object, we were validating against the "raw" value, and not the interpolated value, causing incorrect errors. This affects structures such as: ```tf tags = "${list(map("foo", "bar"))}" ``` Prior to this, a complaint about "expected object, got string" since the raw value is obviously a string, when the interpolated value is the correct shape.	9 years ago
Sander van Harmelen	0e422737ba	Fix and refactor the Chef provisioner ... The tests did pass, but that was because they only tested part of the changes. By using the `schema.TestResourceDataRaw` function the schema and config are better tested and so they pointed out a problem with the schema of the Chef provisioner. The `Elem` fields did not have a `*schema.Schema` but a `schema.Schema` and in an `Elem` schema only the `Type` field may (and must) be set. Any other fields like `Optional` are not allowed here. Next to fixing that problem I also did a little refactoring and cleaning up. Mainly making the `ProvisionerS` private (`provisioner`) and removing the deprecated fields.	9 years ago
Vladislav Rassokhin	f5449a62e0	Various built-in provisioners improvements: ... 1. Migrate `chef` provisioner to `schema.Provisioner`: * `chef.Provisioner` structure was renamed to `ProvisionerS`and now it's decoded from `schema.ResourceData` instead of `terraform.ResourceConfig` using simple copy-paste-based solution; * Added simple schema without any validation yet. 2. Support `ValidateFunc` validate function : implemented in `file` and `chef` provisioners.	9 years ago
Radek Simko	44a99e0ae5	core: Avoid crash on empty TypeSet blocks (#14305)	9 years ago
Radek Simko	9867ce4dde	helper/schema: Disallow validation+diff suppression on computed-only fields	9 years ago
James Bardin	9aaf220efb	Merge pull request #13863 from hashicorp/jbardin/computed-list-requires-new ... make sure a computed list is can be RequiresNew	9 years ago
James Bardin	caadb4297f	make sure a computed list is can be RequiresNew ... If a schema.TypeList had a Schema with ForceNew, and if that list was NewComputed, the diff would not have RequiresNew set. This causes apply to fail when the diffs didn't match because of the change to RequiresNew. Set the RequiresNew field on the list's ResourceAttrDiff based on the Schema value.	9 years ago
Martin Atkins	b1763e262a	Restore stringer-generated files back to new version ... stringer has changed the boilerplate it generates in a recent version. We'd previously updated to the new format but accientally rolled back to the old while merging a long-running feature branch. This restores us back to the new format again.	9 years ago
Jasmin Gacic	61499cfcf0	Provider Oneandone (#13633) ... * Terraform Provider 1&1 * Addressing pull request remarks * Fixed imports * Fixing remarks * Test optimiziation	9 years ago
Sander van Harmelen	3d0073e05c	core: fix a crash by suggesting a different approach to solve #11170 (#13541) ... * Revert #11245, #11321, #11498 and #11757 These PR’s are all related to issue #11170 for which I would like to propose a different solution then the one currently implemented. * A different approach to solve #11170 This approach has (IMHO) a few advantages with regards to the solution currently implemented. I will elaborate on this in the PR.	9 years ago
James Bardin	735dfc416d	Merge pull request #13427 from hashicorp/jbardin/context-keys ... Fix context key types in schema	9 years ago
Martin Atkins	a0269c688c	helper/schema: Clarify the expectations for DefaultFunc ... Discussion in #9512 revealed that some of the comments here were inaccurate and that the comments here did not paint a complete enough picture of the behavior and expectations of Default and DefaultFunc. This is a comments-only change that aims to clarify the situation and call attention to the fact that the defaults only affect the handling of the configuration and that changes to defaults may require migration of existing resource states. This closes #9512.	9 years ago
James Bardin	8a1089a161	convert the other context keys to the correct type	9 years ago
James Bardin	812f9fb253	don't use primitive types for context value keys ... A context value key should be typed within the package namespace, otherwise different packages could have colliding values in a context.	9 years ago
Martin Atkins	21cd5595e2	Update stringer-generated files to new boilerplate ... golang/tools commit 23ca8a263 changed the format of the leading comment to comply with some new standards discussed here: https://golang.org/issue/13560 This is the result of running generate with the latest version of stringer. Everyone working on Terraform will need to update stringer after this is merged, to avoid reverting this: go get -u golang.org/x/tools/cmd/stringer	9 years ago
James Bardin	2e6a44d5ff	reify the list values before validation ... If the list was marked as computed, all values will be raw config values. Fetch the individual keys from the config to get any known values before validating.	9 years ago
James Bardin	99a12f5df3	interpolation strings were beeing validated ... Interpolation strings for non-computed values in a list were being passed to the schema's ValidateFunc.	9 years ago
James Bardin	efd0f5b0db	Fix logic when skipping schema input ... The Required||Optional logic in schemaMap.Input was incorrect, causing it to always request input. Fix the logic, and the associated tests which were passing "just because".	9 years ago
Radek Simko	1df1c21d5b	schema: Allow *Resource as Elem of TypeMap in validation (#12722)	9 years ago
Radek Simko	afd34f79df	schema: Enable map value validation (#12638)	9 years ago
Clint	3fdeacdca7	helper/schema: Rename Timeout resource block to Timeouts (#12533) ... helper/schema: Rename Timeout resource block to Timeouts - Pluralize configuration argument name to better represent that there is one block for many timeouts - use a const for the configuration timeouts key - update docs	9 years ago
James Bardin	ecb1944c31	Merge pull request #12498 from hashicorp/jbardin/test-reset ... Add schema.Provider.TestReset to reset StopContext between tests	9 years ago
James Bardin	1d9d7be28c	Add schema.Provider.TestReset method ... Provider.TestReset resets the internal state of the Provider at the start of a test. This also adds a MetaReset function field to schema.Provider, which is called by TestReset and can be used to reset any other tsated stored in the provider metadata. This is currently used to reset the internal Context returned by StopContext between tests, and should be implemented by a provider if it stores a Context from a previous test.	9 years ago
clint shryock	aa3677cd89	helper/schema: Guard against a panic if Timeout is not properly ... structured	9 years ago
Clint	2fe5976aec	helper/schema: Add configurable Timeouts (#12311) ... * helper/schema: Add custom Timeout block for resources * refactor DefaultTimeout to suuport multiple types. Load meta in Refresh from Instance State * update vpc but it probably wont last anyway * refactor test into table test for more cases * rename constant keys * refactor configdecode * remove VPC demo * remove comments * remove more comments * refactor some * rename timeKeys to timeoutKeys * remove note * documentation/resources: Document the Timeout block * document timeouts * have a test case that covers 'hours' * restore a System default timeout of 20 minutes, instead of 0 * restore system default timeout of 20 minutes, refactor tests, add test method to handle system default * rename timeout key constants * test applying timeout to state * refactor test * Add resource Diff test * clarify docs * update to use constants	9 years ago
Mitchell Hashimoto	3342aa580c	terraform: InstanceState.Meta is value type interface{} ... This changes the type of values in Meta for InstanceState to `interface{}`. They were `string` before. This will allow richer structures to be persisted to this without flatmapping them (down with flatmap!). The documentation clearly states that only primitives/collections are allowed here. The only thing using this was helper/schema for schema versioning. Appropriate type checking was added to make this change safe. The timeout work @catsby is doing will use this for a richer structure.	9 years ago
Mitchell Hashimoto	c6d0333dc0	flatmap: mark computed list as a computed value in Expand ... Fixes #12183 The fix is in flatmap for this but the entire issue is a bit more complex. Given a schema with a computed set, if you reference it like this: lookup(attr[0], "field") And "attr" contains a computed set within it, it would panic even though "field" is available. There were a couple avenues I could've taken to fix this: 1.) Any complex value containing any unknown value at any point is entirely unknown. 2.) Only the specific part of the complex value is unknown. I took route 2 so that the above works without any computed (since "name" is not computed but something else is). This may actually have an effect on other parts of Terraform configs, however those similar configs would've simply crashed previously so it shouldn't break any pre-existing configs.	9 years ago
James Bardin	7359a18a71	Make sure to diff all nested schema.Set elements ... This follows on GH-11498, using the same method to ensure all set elements are marked as NewRemoved if the set is being removed in the diff.	9 years ago
Mitchell Hashimoto	61881d2795	Merge pull request #10934 from hashicorp/f-provisioner-stop ... core: stoppable provisioners, helper/schema for provisioners	9 years ago
Radek Simko	d5ac48de2a	helper/schema: Remove missed subfields when parent list is removed (#11498)	9 years ago
Mitchell Hashimoto	487a37b0dd	helper/schema: PromoteSingle for legacy support of "maybe list" types	9 years ago
Mitchell Hashimoto	3c0c81957a	provisioners/remote-exec: switch to helper/schema	9 years ago
Mitchell Hashimoto	a2e044829b	provisioners/file: use the old communicator.New just to minimize risk	9 years ago