22 Commits (ec4f62078a43835feb98778317110e51d5aa6331)

Author	SHA1	Message	Date
Liam Cervante	8d61c5bfc4	Use the new structured renderer in place of the old diffs package (#32520) ... * Use the new structured renderer in place of the old diffs package * remove old plan tests * refresh only plans should show moved resources in the refresh section	3 years ago
Martin Atkins	4660dacd59	command: Prototype of handling errored plans ... This is a prototype of how the CLI layer might make use of Terraform Core's ability to produce a partial plan if it encounters an error during planning, with two new situations: - When using local CLI workflow, Terraform will show the partial plan before showing any errors. - "terraform plan" has a new option -always-out=..., which is similar to the existing -out=... but additionally instructs Terraform to produce a plan file even if the plan is incomplete due to errors. This means that the plan can still be inspected by external UI implementations. This is just a prototype to explore how these parts might fit together. It's not a complete implementation and so should not be shipped. In particular, it doesn't include any mention of a plan being incomplete in the "terraform show -json" output or in the "terraform plan -json" output, both of which would be required for a complete solution.	3 years ago
kmoe	621af43c04	fix missing output for applyable refresh plans (#31469)	4 years ago
James Bardin	09dde8d5ed	improve the contributing attributes filter ... The initial rough implementation contained a bug where it would incorrectly return a NilVal in some cases. Improve the heuristics here to insert null values more precisely when parent objects change to or from null. We also check for dynamic types changing, in which case the entire object must be taken when we can't match the individual attribute values.	4 years ago
James Bardin	f0cd8be66f	add whole resource references	4 years ago
James Bardin	e2b74247f2	track contributing instances ... Track individual instance drift rather than whole resources which contributed to the plan. This will allow the output to be more precise, and we can still use NoKey instances as a proxy for containing resources when needed.	4 years ago
James Bardin	25f4c0d3dd	filter attribute refresh changes from plan UI ... Filter the refresh changes from the normal plan UI at the attribute level. We do this by constructing fake plans.Change records for diff generation, reverting all attribute changes that do not match any of the plan's ContributingResourceReferences.	4 years ago
James Bardin	0e7cec83db	decode change before creating diff ... This is functionally equivalent, but will allow us to filter the change values directly for reduced drift output.	4 years ago
James Bardin	c02e8bc5b3	change plan to store individual relevant attrs ... Storing individual contributing attributes will allow finer tuning of the plan rendering. add contributing to outputs	4 years ago
James Bardin	f1e8aed48d	output drift footer in the right place	4 years ago
James Bardin	c5c7045a89	filter out non-relevant drift changes ... Only show drift changes which may have affected the plan output.	4 years ago
James Bardin	a151aaef05	only show drift when there are changes	4 years ago
Alisdair McDiarmid	638784b195	cli: Omit move-only drift, except for refresh-only ... The set of drifted resources now includes move-only changes, where the object value is identical but a move has been executed. In normal operation, we previousl displayed these moves twice: once as part of drift output, and once as part of planned changes. As of this commit we omit move-only changes from drift display, except for refresh-only plans. This fixes the redundant output.	5 years ago
Alisdair McDiarmid	f0cf4235f9	cli: Refactor resource drift rendering	5 years ago
Alisdair McDiarmid	29999c1d6f	command: Render "moved" annotations in plan UI ... For resources which are planned to move, render the previous run address as additional information in the plan UI. For the case of a move-only resource (which otherwise is unchanged), we also render that as a planned change, but without any corresponding action symbol. If all changes in the plan are moves without changes, the plan is no longer considered "empty". In this case, we skip rendering the action symbols in the UI.	5 years ago
James Bardin	3bf498422c	typo	5 years ago
James Bardin	45b5c289a0	no drift with only deposed changes ... Changes to deposed instances should not triggers any drift to be rendered, as they will have nothing to display.	5 years ago
James Bardin	57aa7c6025	skip drift rendering for deposed resources ... Deposed instances have no current state and are only scheduled for deletion, so there is no reason to try and render drift on these instances.	5 years ago
Martin Atkins	36d0a50427	Move terraform/ to internal/terraform/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	f40800b3a4	Move states/ to internal/states/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	034e944070	Move plans/ to internal/plans/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago
Martin Atkins	ffe056bacb	Move command/ to internal/command/ ... This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago