103 Commits (eb6ffdeba29279bf0185654e52cb09489f2a8eec)

Author	SHA1	Message	Date
James Bardin	ef1d53934c	Merge pull request #14746 from hashicorp/jbardin/s3-consistency ... store and verify s3 remote state checksum to avoid consistency issues.	9 years ago
James Bardin	91be40a577	add detailed error message s3 checksum mismatch ... Have the s3 RemoteClient return a detailed error message to the user in the case of a mismatch state checksum.	9 years ago
James Bardin	0022d224e8	store and verify s3 remote state checksum ... Updates to objects in S3 are only eventually consistent. If the RemoteClient has a DynamoDB table available, use that to store a checksum of the last written state, so the object can be verified by the next client to call Get. Terraform currently doesn't have any sort of user feedback around RefreshState/Get, so we poll only for a short time before returning an error.	9 years ago
James Bardin	e1d9ad40d3	Merge pull request #14680 from hashicorp/jbardin/unlock-s3 ... Check that a named state in s3 doesn't exist before acquiring a lock	9 years ago
Martin Atkins	9cda37205d	backend/local: create local state file if backend write fails ... In the old remote state system we had the idea of a local backup, which is actually still present for the legacy backends but no longer applies for the new-style backends like the s3 backend. It's problematic when an apply runs for long enough that someone's time-limited AWS STS credentials expire and then Terraform fails and can't persist state to S3. To reduce the risk of lost state, here we add some extra fallback code for the local apply operation in particular. If either state writing or state persisting fail then we attempt to write the state to a special backup file errored.tfstate, and produce an error message that guides the user on how to retry uploading this state. In the unlikely event that we can't write to local disk either (e.g. permissions problems) we take a last-ditch attempt to dump the JSON onto stdout and advise the user to manually copy it into a file for import. If even that doesn't work for some reason, we assume a critical Terraform bug (JSON-serialization problem with states?) and bail out with an apologetic error message. This is implemented for the apply command in particular because this is the one command where new objects are created in real APIs that we don't want to lose track of. For other operations it's less bad to just generate a simple error message and have the user retry. This fixes #14298.	9 years ago
James Bardin	b279b1abb5	check for named s3 states before acquiring a lock ... In order to force-unlock a named state, we have to fetch that state first. Don't attempt to acquire a lock if we know the state already exists in s3.	9 years ago
James Bardin	a2d452acec	failing test to force-unlock a named state in s3 ... The State call attempts to get a lock before determining if a named state exists. This prevents force-unlock, since we need the state to call Unlock.	9 years ago
James Bardin	58759b1167	Merge pull request #13941 from hashicorp/jbardin/sigint-message ... improve SIGINT output	9 years ago
James Bardin	7dad3f4d48	remove redundant output when interrupting apply ... The backend apply operation doesn't need to output the same text as the cli itself. Instead notify the user that we are in the process of stopping the operation.	9 years ago
James Bardin	563cfd00df	always wrap remote state in a BackupState ... Use a local backup for remote state operations. This allows for manual recovery in the case of a put failure.	9 years ago
Martin Atkins	b1763e262a	Restore stringer-generated files back to new version ... stringer has changed the boilerplate it generates in a recent version. We'd previously updated to the new format but accientally rolled back to the old while merging a long-running feature branch. This restores us back to the new format again.	9 years ago
Jasmin Gacic	61499cfcf0	Provider Oneandone (#13633) ... * Terraform Provider 1&1 * Addressing pull request remarks * Fixed imports * Fixing remarks * Test optimiziation	9 years ago
James Bardin	928e60672f	context Refresh and Apply sometimes return nil ... The documentation for Refresh indicates that it will always return a valid state, but that wasn't true in the case of a graph builder error. While this same concept wasn't documented for Apply, it was still assumed in the terraform apply code. Since the helper testing framework relies on the absence of a state to determine if it can call Destroy, the Context can't can't start returning a state in all cases. Document this, and use the State method to fetch the correct state value after Apply. Add a nil check to the WriteState function, so that writing a nil state is a noop. Make sure to init before sorting the state, to make sure we're not attempting to sort nil values. This isn't technically needed with the current code, but it's just safer in general.	9 years ago
James Bardin	9c431aee1b	only list environments when the keyName matches ... Prevent extra keys in the s3 envPrefix path from showing up as listed environments. Better handle keys containing slashes Add tests for unexpected keys in s3.	9 years ago
James Bardin	5621d97925	cleanup consul lock entries ... This matches the consul cli behavior, where locks are cleaned up after use. Return an error from re-locking the state. This isn't required by the Locker interface, but it's an added sanity check for state operations. What was incorrect here was returning an empty ID and error, which would indicate that Lock/Unlock isn't supported.	9 years ago
James Bardin	6e136c848a	use the aws provider client initialization ... Use the aws provider code to create the clients for the s3 backend, so that all the behavior matches that of the provider. Remove the fake creds from the test, as the aws provider will attempt to validate them.	9 years ago
James Bardin	54aa466b74	initialize the s3 lock path in one place	9 years ago
James Bardin	d059939f88	Merge pull request #13262 from hashicorp/jbardin/lock-timeouts ... lock timeouts	9 years ago
James Bardin	305ef43aa6	provide contexts to clistate.Lock calls ... Add fields required to create an appropriate context for all calls to clistate.Lock. Add missing checks for Meta.stateLock, where we would attempt to lock, even if locking should be skipped.	9 years ago
James Bardin	3f0dcd1308	Have the clistate Lock use LockWithContext ... - Have the ui Lock helper use state.LockWithContext. - Rename the message package to clistate, since that's how it's imported everywhere. - Use a more idiomatic placement of the Context in the LockWithContext args.	9 years ago
James Bardin	75458a182d	remove extra state.Locker assertions ... All states are lockers, so get rid of extra asertions.	9 years ago
Paul Stack	4501be7e5c	backend/remote-state: Add support for assume role extensions to s3 backend (#13236) ... Fixes: #13234 This now matches the AWS provider for the Assume Role support	9 years ago
Martin Atkins	21cd5595e2	Update stringer-generated files to new boilerplate ... golang/tools commit 23ca8a263 changed the format of the leading comment to comply with some new standards discussed here: https://golang.org/issue/13560 This is the result of running generate with the latest version of stringer. Everyone working on Terraform will need to update stringer after this is merged, to avoid reverting this: go get -u golang.org/x/tools/cmd/stringer	9 years ago
James Bardin	7b8e1aff3d	fix local backend test ... The local backend can't define a StateOut path if we want to test writing multiple named state files. Use a default local backend.	9 years ago
James Bardin	49b9a6ad92	test for proper state persistence ... The backend state tests weren't properly checking for persistence. Update the test to persist states and fetch them again from the backend, checking that lineage is preserved.	9 years ago
James Bardin	575e7f1811	Properly create a new named state in s3 ... If the state doesn't exist, we need to initialize one so that it can be listed be States.	9 years ago
James Bardin	fa4dc01cf4	add named state support to the s3 backend ... This adds named state (environment) support to the S3 backend. A state NAME will prepend the configured s3 key with `env:/NAME/`. The default state will remain rooted in the bucket for backwards compatibility. Locks in DynamoDB use the S3 key as the as the primary key value, so locking will work as expected for multiple states.	9 years ago
James Bardin	4980fa20e7	move s3 config from client to backend ... The RemoteClient needs to be configured for the named state, so move the general config to the backend. Rename some fields for consistency.	9 years ago
James Bardin	9f5cf2b105	convert S3 remote state to a backend ... Move the S3 State from a legacy remote state to an official backend. This increases test coverage, uses a set schema for configuration, and will allow new backend features to be implemented for the S3 state, e.g. "environments".	9 years ago
Mitchell Hashimoto	d01886a644	command: remove legacy remote state on migration ... Fixes #12871 We were forgetting to remove the legacy remote state from the actual state value when migrating. This only causes an issue when saving a plan since the plan contains the state itself and causes an error where both a backend + legacy state exist. If saved plans aren't used this causes no noticable issue. Due to buggy upgrades already existing in the wild, I also added code to clear the remote section if it exists in a standard unchanged backend	9 years ago
Mitchell Hashimoto	23dd2a0ee5	backend/atlas: accept ATLAS_ADDRESS env var for address ... This is required for on-premise TFE.	9 years ago
Mitchell Hashimoto	2be1f55cbb	backend/local: allow refresh on empty/non-existent state ... This allows a refresh on a non-existent or empty state file. We changed this in 0.9.0 to error which seemed reasonable but it turns out this complicates automation that runs refresh since it now needed to determine if the state file was empty before running. Its easier to just revert this into a warning with exit code zero. The reason this changed is because in 0.8.x and earlier, the output would be simply empty with exit code zero which seemed odd.	9 years ago
Mitchell Hashimoto	2969b29d9b	backend/local: call new test API correctly	9 years ago
Mitchell Hashimoto	1ca0352e5f	Merge pull request #12558 from hashicorp/f-backend-testing ... backend/local: run backend.TestBackend	9 years ago
Mitchell Hashimoto	0cd15176ff	backend/consul: rebase and modify gzip test	9 years ago
Mitchell Hashimoto	1daff7a826	backend/consul: support "lock" option to disable locking ... This adds a "lock" config (default true) to allow users to optionally disable state locking with Consul. This is necessary if the token given doesn't have session permission and is necessary for backwards compatibility.	9 years ago
James Bardin	08d2b44ada	add gzip to consul backend tests	9 years ago
James Bardin	1527eae6b7	Merge pull request #8748 from christoe/christoe/8491-gzip-consul-remote-state ... state/remote: Add gzip support to consul remote state (#8491)	9 years ago
James Bardin	86f711f6fc	Make consul backend tests opt-in ... This way we don't require contributers to have consul installed to run make test.	9 years ago
James Bardin	fa7743b627	quiet the consul server during backend tests ... Don't display logs unless using `-v`	9 years ago
James Bardin	90055c6ae2	convert the consul backend to use consul/testutil ... Start up our own consul server for unit tests.	9 years ago
Christoffer Kylvåg	abfa35db7c	backend/remote-state/consul: Make gzip compression configurable (#8491)	9 years ago
Mitchell Hashimoto	f63e8b3398	backend/local: run backend.TestBackend ... This verifies that local behaves in an expected way by the backend package.	9 years ago
Christoffer Kylvåg	e098c7c24a	backend/remote-state/consul: Add gzip support to consul backend client (#8491)	9 years ago
Mitchell Hashimoto	35afb7bc86	backend/consul: some comments	9 years ago
Mitchell Hashimoto	b842fd0c27	backend/consul: support named states	9 years ago
Mitchell Hashimoto	3db55cf747	backend/consul: build your own backend	9 years ago
Mitchell Hashimoto	08b47cf73b	backend/atlas: adhere to new multi-state interface	9 years ago
Mitchell Hashimoto	e6a87cf8de	backend/atlas: adhere to backend.CLI	9 years ago
Mitchell Hashimoto	942572b574	backend/init: add atlas, remove legacy atlas remote state	9 years ago