852 Commits (eac87798708e714fd3a7e2ae496bddc021a32fa0)

Author	SHA1	Message	Date
Martin Atkins	3c10a3b213	helper/schema: Tolerate incorrectly-specified collection elems ... We historically tolerated this, so we need to tolerate it here too in order to work correctly with existing provider code.	8 years ago
Martin Atkins	c937c06a03	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	5782357c28	backend: Update interface and implementations for new config loader ... The new config loader requires some steps to happen in a different order, particularly in regard to knowing the schema in order to decode the configuration. Here we lean directly on the configschema package, rather than on helper/schema.Backend as before, because it's generally sufficient for our needs here and this prepares us for the helper/schema package later moving out into its own repository to seed a "plugin SDK".	8 years ago
Martin Atkins	1fb714ea3b	helper/schema: CoreConfigSchema method for Backend ... This is just like the method of the same name on Resource, adapting the helper/schema model of schema into Terraform Core's idea of schema.	8 years ago
Martin Atkins	d6c6f8852c	configschema: include description in schema ... We will need access to this information in order to render interactive input prompts, and it will also be useful in returning schema information to external tools such as text editors that have autocomplete-like functionality.	8 years ago
Paddy	35d82b0555	Merge pull request #18795 from hashicorp/paddy_diff_nested_checkKey ... Allow for nested fields with checkKey on ResourceDiffs.	8 years ago
Paddy Carver	2eadc8f625	Don't allow sub-blocks for SetNew. ... You can't set individual items in lists, you can only set the list as a whole, so we shouldn't allow sub-blocks to SetNew or SetNewComputed.	8 years ago
Paddy Carver	393c32624a	Add tests to ensure clearing sub-blocks works.	8 years ago
Paul Hinze	470ab3869f	helper/pathorcontents: Skip one test when root ... One of the tests in this package doesn't work when the tests are run as root - like inside of a Docker container. The test is still useful to specify `pathorcontents` behavior when a file is not readable, so it's better to skip than just delete it. See linked issue for further disussion. Closes #7707	8 years ago
Kristin Laemmert	813b5fd27f	Merge pull request #18825 from sean-/master-make-dev-drift ... build: Updates required to bump golang version to 1.11	8 years ago
Brian Flad	a47583d3a8	Merge pull request #18688 from hashicorp/f-resource-paralleltest ... helper/resource: Add ParallelTest() function to allow opt-in acceptance testing concurrency with t.Parallel()	8 years ago
Sean Chittenden	d749420a25	Fix drift caused from gofmt when running make dev and go 1.11. ... A fresh checkout of `origin/master` does not build atm using the `dev` target because `master` has not been formatted using `gofmt` from Go 1.11 (tis has been the case for a while if you've been running devel). None of the drift in question is especially new but now that Go 1.11 has been released and gofmt's formatting guidelines have been updated, it would be *really* nice if the code in `master` reflected the current tooling in order to avoid having to fight this drift locally. * 8mo: https://github.com/hashicorp/terraform/blame/master/backend/remote-state/s3/backend_test.go#L260-L261 * 6mo: https://github.com/hashicorp/terraform/blame/master/builtin/provisioners/chef/linux_provisioner_test.go#L124 * 1yr: 7cfeffe36b/command/init.go (L75-L76) * 12d: 7cfeffe36b/command/meta_backend_test.go (L1437) * 2yr: 7cfeffe36b/helper/schema/resource_timeout_test.go (L26) * 4yr: 7cfeffe36b/helper/schema/schema_test.go (L2059) * 1yr: 7cfeffe36b/plugin/discovery/get_test.go (L151)	8 years ago
Paddy Carver	7ee4339555	Allow for nested fields with checkKey on ResourceDiffs. ... When checking if a ResourceDiff key is valid, allow for keys that exist on sub-blocks. This allows things like diff.Clear to be called on sub-block fields, instead of just on top-level fields.	8 years ago
Sander van Harmelen	3e935c846f	terraform/terraform_remote_state: accept complex configs ... The `remote` backend config contains an attribute that is defined as a `*schema.Set`, but currently only `string` values are accepted as the `config` attribute is defined as a `schema.TypeMap`. Additionally the `b.Validate()` method wasn’t called to prevent a possible panic in case of unexpected configurations being passed to `b.Configure()`. This commit is a bit of a hack to be able to support this in the 0.11 series. The 0.12 series will have proper support, so when merging 0.12 this should be reverted again.	8 years ago
Paul Tyng	74eae6825a	Fix typo in comment	8 years ago
Brian Flad	798162125b	helper/resource: Add ParallelTest() function to allow opt-in acceptance testing concurrency with t.Parallel() ... While this initial implementation is a very simple wrapper function, implementing this in the helper/resource package provides some downstream benefits: * Provides a standard interface for plugin developers to enable parallel acceptance testing * Existing plugins can simply convert resource.Test to resource.ParallelTest references (as appropriate) to enable the functionality, rather than worrying about additional line(s) to each acceptance test function or TestCase * Potential enhancements to ParallelTest (e.g. adding an environment variable to skip enabling the behavior) are consistently propagated	8 years ago
Dana Hoffman	40225061b4	pretty-print json in http requests/responses	8 years ago
Chris Marchesi	67182d06d7	Merge pull request #18125 from hashicorp/f-testing-taint ... helper/resource: Add ability to pre-taint resources	8 years ago
Paddy Carver	b7d19e40f8	Deprecated -> DeprecationMessage. ... At the Enablement team's request, change from using `Deprecated` to `DeprecationMessage`, as it's a string value, not a boolean.	8 years ago
Paddy Carver	0dd2408d65	Export resource deprecation. ... We already had the functionality to make resources deprecated, which was used when migrating resources to data sources, but the functionality was unexported, so only the schema package could do it. Now it's exported, meaning providers can mark entire resources as deprecated. I also added a test in hopefully-the-right place?	8 years ago
Chris Marchesi	3505769600	helper/resource: Add ability to pre-taint resources ... This adds the Taint field to the acceptance testing framework, allowing the ability to pre-taint resources at the beginning of a particular TestStep. This can be useful for when an explicit ForceNew is required for a specific resource for troubleshooting things like diff mismatches, etc. The field accepts resource addresses as a list of strings. To keep things simple for the time being, only addresses in the root module are accepted. If we ever want to expand this past that, I'd be almost inclined to add some facilities to the core terraform package to help translate actual module resource addresses (ie: module.foo.module.bar.some_resource.baz) into the correct state, versus the current convention in some acceptance testing facilities that take the module address as a list of strings (ie: []string{"root", "foo", "bar"}).	8 years ago
kt	a182a53108	Add a HashInt helper/schema function	8 years ago
Chris Marchesi	d7048cb640	helper/schema: ResourceDiff ForceNew attribute correctness ... A couple of bugs have been discovered in ResourceDiff.ForceNew: * NewRemoved is not preserved when a diff for a key is already present. This is because the second diff that happens after customization performs a second getChange on not just state and config, but also on the pre-existing diff. This results in Exists == true, meaning nil is never returned as a new value. * ForceNew was doing the work of adding the key to the list of changed keys by doing a full SetNew on the existing value. This has a side effect of fetching zero values from what were otherwise undefined values and creating diffs for these values where there should not have been (example: "" => "0"). This update fixes these scenarios by: * Adding a new private function to check the existing diff for NewRemoved keys. This is included in the check on new values in diffChange. * Keys that have been flagged as ForceNew (or parent keys of lists and sets that have been flagged as ForceNew) are now maintained in a separate map. UpdatedKeys now returns the results of both of these maps, but otherwise these keys are ignored by ResourceDiff. * Pursuant the above, values are no longer pushed into the newDiff writer by ForceNew. This prevents the zero value problem, and makes for a cleaner implementation where the provider has to "manually" SetNew to update the appropriate values in the writer. It also prevents non-computed keys from winding up in the diff, which ResourceDiff normally blocks by design. There are also a couple of tests for cases that should never come up right now involving Optional/Computed values and NewRemoved, for which explanations are given in annotations of each test. These are here to guard against future regressions.	8 years ago
James Bardin	61eae050ab	Merge pull request #17588 from creack/creack/fix-deepcopy-type ... Fix issue with deepcopy returning wrong type causing panic	8 years ago
Chris Marchesi	db5ed51703	Merge pull request #17667 from hashicorp/f-resource-diff-getokexists-computed ... helper/schema: Add Computed to ResourceDiff, expose GetOkExists	8 years ago
Adam Lewandowski	56a330c533	Remove attribute values from ConflictsWith validation message	8 years ago
Chris Marchesi	fdfe89ed1d	helper/schema: Computed -> NewValueKnown, add comments to GetOkExists ... Added some more context to GetOkExists, moved Computed to NewValueKnown to accommodate some changes that will be coming up in HCL2 that may make "Computed" less intuitive of a function name, and updated the docs for NewValueKnown as well.	8 years ago
Chris Marchesi	274b933077	helper/schema: Add Computed to ResourceDiff, expose GetOkExists ... This adds a new method to ResourceDiff: Computed, which exposes the computed read result field to ResourceDiff. In the context of customizing the diff, this is important as interpolated and otherwise computed values will show up in the diff as blank, with no way of determining if the value is actually blank or if it's a computed value not available at diff customization time. Currently assumptions need to be made on this, but this does not help in validation scenarios where one needs to differentiate between an actual blank value and a value that will be available later. This is exposed for the most part via NewComputed in the diff, but the tests cover both the config reader as well (with no diff, even though this should not come up in normal operation) and also the newDiff reader when someone sets a new value using SetNew and SetNewComputed. This commit also exposes GetOkExists. The tests were mostly pulled from ResourceData but a few were added to ensure that config was being properly covered as well, in addition to covering SetNew and SetNewComputed.	8 years ago
Adit Sarfaty	dfa623250a	helper/validation: IP address and IP address range validation helpers	8 years ago
James Bardin	798df9dafa	make sure ResourceData timeouts are always set ... Return the global default timeout if the ResourceData timeouts are nil. Set the timeouts from the Resource when calling Resource.Data, so that the config values are always available.	8 years ago
Brian Flad	077b828902	Merge pull request #17484 from hashicorp/f-validation-ValidateRFC3339TimeString ... validation: Add ValidateRFC3339TimeString	8 years ago
Brian Flad	994a78dbc7	validation: Return "invalid RFC3339 timestamp" in ValidateRFC3339TimeString	8 years ago
Guillaume J. Charmes	a4f941368b	Fix issue with deepcopy returning wrong type causing panic ... Signed-off-by: Guillaume J. Charmes <gcharmes@magicleap.com>	8 years ago
James McGill	035d56409f	helper/schema: handle TypeMap elem consistently with other collection types ... For historical reasons, the handling of element types for maps is inconsistent with other collection types. Here we begin a multi-step process to make it consistent, starting by supporting both the "consistent" form of using a schema.Schema and an existing erroneous form of using a schema.Type directly. In subsequent commits we will phase out the erroneous form and require the schema.Schema approach, the same as we do for TypeList and TypeSet.	8 years ago
Radek Simko	f6c3e40439	Merge pull request #17463 from hashicorp/b-helper-r-diff-nested-keys ... helper/schema: Allow ResourceDiff.ForceNew on nested fields (avoid crash)	8 years ago
Chase	02ff60d083	Fixing small typo in resource/wait.go	8 years ago
Paul Tyng	528cbecfce	Make failure message more explicit	8 years ago
Paul Tyng	707d7febe3	Use constants in test	8 years ago
Paul Tyng	f18e4f2921	Export a const for validation methods	8 years ago
Brian Flad	ea64b24cd9	validation: Add ValidateRFC3339TimeString	8 years ago
Radek Simko	ccf8a31cbb	helper/schema: Allow ResourceDiff.ForceNew on nested fields (avoid crash)	8 years ago
Stuart Auld	7d1f594f54	helper/resource: don't panic if a requested module does not exist	8 years ago
Stuart Auld	df9446f490	helper/resource: allow tests to opt out of temporary file cleanup ... This is rarely needed, but sometimes tests need to create temporary files as part of their operation. This should be used sparingly, since it prevents the pro-active cleanup of the temporary working directory.	8 years ago
Radek Simko	7af1c2b3a4	helper/schema: Prevent crash on removal of computed field in CustomizeDiff	8 years ago
Stefan Schmidt	ee6c8a777a	s/repalce/replace	8 years ago
Gauthier Wallet	1b3f5fcbfb	helper/structure: More cases for NormalizeJsonString tests ... In terraform-providers/terraform-provider-aws#2935, we have been cleaning code duplication by benefiting from the "NormalizeJsonString" present in the "structure" helper. It appears that tests in the AWS provider are covering more use-cases, which are added in this work.	8 years ago
James Bardin	d91dc1a13e	unused variable ... vet can now catch these in closures	8 years ago
James Bardin	4b49a323c3	go fmt ... slight change to go fmt coming in 0.10	8 years ago
James Bardin	0df8da59f7	add FIXMEs ... This new codepath with the getDiff "customzed" return value, along with the associated test need to be removed as soon as we can support unset fields from the config, so we don't continue to carry this broken behavior forward any longer than needed.	8 years ago
Chris Marchesi	cb5ce1d35e	helper/schema: Extend diffChange and bubble up customized values ... This extends the internal diffChange method so that ResourceDiff's implementation of it can report back whether or not the value came from a customized diff. This is an effort to work to preserve the pre-ResourceDiff behaviour that ignores the diff for computed keys when the old value was populated but the new value wasn't - this behaviour is actually being depended on by users that are using it to exploit using zero values in modules. This should allow both scenarios to co-exist by shifting the NewComputed exemption over to exempting values that come from diff customization.	8 years ago