16 Commits (ea93b91a80201c19c00d12dfd6fddc46f443bd2a)

Author	SHA1	Message	Date
Clint	a84aa5e914	Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)	10 years ago
Radek Simko	917ad44cf0	helper/schema: Fix readSet implementation (DiffFieldReader)	10 years ago
Sander van Harmelen	ef4726bd50	Change Set internals and make (extreme) performance improvements ... Changing the Set internals makes a lot of sense as it saves doing conversions in multiple places and gives a central place to alter the key when a item is computed. This will have no side effects other then that the ordering is now based on strings instead on integers, so the order will be different. This will however have no effect on existing configs as these will use the individual codes/keys and not the ordering to determine if there is a diff or not. Lastly (but I think also most importantly) there is a fix in this PR that makes diffing sets extremely more performand. Before a full diff required reading the complete Set for every single parameter/attribute you wanted to diff, while now it only gets that specific parameter. We have a use case where we have a Set that has 18 parameters and the set consist of about 600 items (don't ask 😉). So when doing a diff it would take 100% CPU of all cores and stay that way for almost an hour before being able to complete the diff. Debugging this we learned that for retrieving every single parameter it made over 52.000 calls to `func (c *ResourceConfig) get(..)`. In this function a slice is created and used only for the duration of the call, so the time needed to create all needed slices and on the other hand the time the garbage collector needed to clean them up again caused the system to cripple itself. Next to that there are also some expensive reflect calls in this function which also claimed a fair amount of CPU time. After this fix the number of calls needed to get a single parameter dropped from 52.000+ to only 2! 😃	11 years ago
Martin Atkins	cc8e8a55de	helper/schema: Default hashing function for sets ... A common issue with new resource implementations is not considering parts of a complex structure that's used inside a set, which causes quirky behavior. The schema helper has enough information to provide a default reasonable implementation of a set function that includes all non-computed attributes in a deterministic way. Here we implement such a function and use it when no explicit hashing function is provided. In order to achieve this we encapsulate the construction of the zero value for a schema in a new method schema.ZeroValue, which allows us to put the fallback logic to the new default function in a single spot. It is no longer valid to use &Set{F: schema.Set} and all uses of that construct should be replaced with schema.ZeroValue().(*Set) .	11 years ago
Svend Sorensen	943bf3c00a	Use name of function in comment string ... Name of function is Difference, not Differences.	11 years ago
Phil Frost	b082117e92	Implement AWS IAM resources ... - Users - Groups - Roles - Inline policies for the above three - Instance profiles - Managed policies - Access keys This is most of the data types provided by IAM. There are a few things missing, but the functionality here is probably sufficient for 95% of the cases. Makes a dent in #28.	11 years ago
Phil Frost	33183c078b	Implement a hash function for string sets ... Sets of strings are pretty common. Let's not duplicate the function necessary to create a set of strings in so many places.	11 years ago
Trevor Pounds	17b31925fe	Prevent negative hashcodes for all set operations.	11 years ago
Mitchell Hashimoto	77314a01d2	helper/schema: disallow negative hash codes	11 years ago
Mitchell Hashimoto	87948b68fc	helper/schema: use interface for equality check ... /cc @svanharmelen	11 years ago
Sander van Harmelen	133a40d77f	Sets should init only once... ... Currently the `sync.Once` call is only used to init a Set in the add() func. So when you add a value to a Set that is the result of one of the Set operations (i.e. union, difference, intersect) the Set will be reinitialised and the exiting values will be lost. I don’t have a clue why this is showing up in my ACC tests just now, as this code is in there for quite some time already. Somehow it seems to have something to do with the refactoring of the helper/schema done last week, as I cannot reproduce this with 47f02f80bc	11 years ago
Mitchell Hashimoto	864a8f24ec	helper/schema: GoString for Set	11 years ago
Mitchell Hashimoto	81913c58fb	providers/aws: fixing faililng test	12 years ago
Mitchell Hashimoto	9ab5577beb	helper/schema: set diff tests	12 years ago
Mitchell Hashimoto	475528adc3	helper/schema: Set operations	12 years ago
Mitchell Hashimoto	56dde5c0c1	helper/schema: can read and get the state of sets	12 years ago