375 Commits (ea93b91a80201c19c00d12dfd6fddc46f443bd2a)

Author	SHA1	Message	Date
James Bardin	01be1a5ecd	Check for interpolated values when reading a map ... Accessing an interpolated value in a map through ConfigFieldReader can fail, because GetRaw can't access interpolated values, so check if the value exists at all by looking in the config. If the config has a value, assume our map's value is interpolated and proceed as such. We also need to lookup the correct schema to properly read a field from a nested structure. - Maps previously always defaulted to TypeString. Now check if Elem is a ValueType and use that if applicable - Lists now return the schema for nested element types, defaulting to a TypeString like maps. This only allows maps and lists to be nested one level deep, and the inner map or list must only contain string values.	10 years ago
Mitchell Hashimoto	0634aada69	Revert "core: Ensure hasComputedSubKeys iterates over Sets and Lists properly" ... This reverts commit 4d8208d840.	10 years ago
Mitchell Hashimoto	f2fcf1494a	Merge branch 'fix-field-reader-setsubkeys-computed' of https://github.com/vancluever/terraform into vancluever-fix-field-reader-setsubkeys-computed	10 years ago
Chris Marchesi	8d06d68d0f	core: Backport NewComputed change to nested list/set tests ... Needed due to work done in 95d37ea, we may need to adjust hasComputedSubKeys to propagate NewComputed in the same way that we have added "~", however will wait for comment from @mitchellh.	10 years ago
Chris Marchesi	f258056731	core: Tests for hasComputedSubKeys fix ... This covers: * Complex sets with computed fields in a set * Complex lists with computed fields in a set Adding a test to test basic lists with computed fields seemed to fail, but possibly for an unrelated reason (the list returned as nil). The fix to this inparticular case may be out of the scope of this specific issue. Reference gist and details in hashicorp/terraform#9171.	10 years ago
Chris Marchesi	4d8208d840	core: Ensure hasComputedSubKeys iterates over Sets and Lists properly ... This fixes some edge-ish cases where a set in a config has a set or list in it that contains computed values, but non-set or list values in the parent do not. This can cause "diffs didn't match during apply" errors in a scenario such as when a set's hash is calculated off of child items (including any sub-lists or sets, as it should be), and the hash changes between the plan and apply diffs due to the computed values present in the sub-list or set items. These will be marked as computed, but due to the fact that the function was not iterating over the list or set items properly (ie: not adding the item number to the address, so set.0.set.foo was being yielded instead of set.0.set.0.foo), these computed values were not being properly propagated to the parent set to be marked as computed. Fixes hashicorp/terraform#6527. Fixes hashicorp/terraform#8271. This possibly fixes other non-CloudFront related issues too.	10 years ago
James Bardin	c4eefd4b5e	Allow primitive type in maps via all FieldReaders ... Now that we can read primitive type out of a map, each field reader needs to be able to set the proper type as expected.	10 years ago
James Bardin	730014b33e	Convert the map fields values when reading diff ... Convert the value to the correct type when reading a diff and the map schema has an primitive Elem type.	10 years ago
Radek Simko	ad34f1ec74	Add (failing) test for map w/ non-string values	10 years ago
Mitchell Hashimoto	39542898b0	helper/schema: mark diff as forcenew if element is computed ... Fixes #10125 If the elements are computed and the field is ForceNew, then we should mark the computed count as potentially forcing a new operation. Example, assuming `groups` forces new... **Step 1:** groups = ["1", "2", "3"] At this point, the resource isn't create, so this should result in a diff like: CREATE resource: groups: "" => ["1", "2", "3"] **Step 2:** groups = ["${computedvar}"] The OLD behavior was: UPDATE resource groups.#: "3" => "computed" This would cause a diff mismatch because if `${computedvar}` was different then it should force new. The NEW behavior is: DESTROY/CREATE resource: groups.#: "3" => "computed" (forces new)	10 years ago
Mitchell Hashimoto	15f50b86bf	helper/schema: passing tests for computed complex sets	10 years ago
Mitchell Hashimoto	29485f6167	terraform: ResourceConfig.IsComputed cases	10 years ago
Mitchell Hashimoto	5792b2cba2	helper/schema: convert _Diff to subtests	10 years ago
Mitchell Hashimoto	2b7177cfe7	Merge pull request #9607 from hashicorp/f-provider-stop-redo ... terraform: ResourceProvider.Stop (redo)	10 years ago
Mitchell Hashimoto	e45debe0e5	helper/schema: only mark "ForceNew" on resources that cause the ForceNew ... Fixes #2748 This changes the diff to only mark "forces new resource" on the fields that actually caused the new resource, not every field that changed. This makes diffs much more accurate. I'd like to request a review but I'm going to defer merging until Terraform 0.8. Changes like this are very possible to cause "diffs didn't match" errors and I want some real world testing in a beta before we hit prod with this.	10 years ago
Mitchell Hashimoto	b7bee66df5	helper/schema: sort errors in helper/schema test for deterministic tests	10 years ago
Mitchell Hashimoto	f0abe6d1a0	Merge pull request #9812 from hashicorp/b-bool-computed-crash ... helper/schema: computed bool fields should not crash	10 years ago
Mitchell Hashimoto	65b17ccd06	helper/schema: allow ConflictsWith and Computed Optional fields	10 years ago
Mitchell Hashimoto	7834cf7190	helper/schema: computed bool fields should not crash ... Fixes #7715 If a bool field was computed and the raw value was not convertable to a boolean, helper/schema would crash. The correct behavior is to try not to read the raw value when the value is computed and to simply mark that it is computed. This does that (and matches the behavior of the other primitives).	10 years ago
Mitchell Hashimoto	2d84582881	Merge pull request #9699 from hashicorp/b-removed-forcenew ... helper/schema: removed optional items force new	10 years ago
Mitchell Hashimoto	f7a234bc71	helper/schema: validate Read, Delete are set	10 years ago
Mitchell Hashimoto	5489d8c549	helper/schema: removed optional items force new ... Fixes #5138 If an item is optional and is removed completely from the configuration, it should still trigger a destroy/create if the field itself was marked as "ForceNew". See the example in #5138.	10 years ago
Mitchell Hashimoto	3f36787207	Merge pull request #9618 from hashicorp/b-computed-prim ... helper/schema,terraform: handle computed primitives in diffs	10 years ago
Mitchell Hashimoto	95d37ea79c	helper/schema,terraform: handle computed primtives in diffs ... Fixes #3309 There are two primary changes, one to how helper/schema creates diffs and one to how Terraform compares diffs. Both require careful understanding. == 1. helper/schema Changes helper/schema, given any primitive field (string, int, bool, etc.) _used to_ create a basic diff when given a computed new value (i.e. from an unkown interpolation). This would put in the plan that the old value is whatever the old value was, and the new value was the actual interpolation. For example, from #3309, the diff showed the following: ``` ~ module.test.aws_eip.test-instance.0 instance: "<INSTANCE ID>" => "${element(aws_instance.test-instance.*.id, count.index)}" ``` Then, when running `apply`, the diff would be realized and you would get a diff mismatch error because it would realize the final value is the same and remove it from the diff. **The change:** `helper/schema` now marks unknown primitive values with `NewComputed` set to true. Semantically this is correct for the diff to have this information. == 2. Terraform Diff.Same Changes Next, the way Terraform compares diffs needed to be updated Specifically, the case where the diff from the plan had a NewComputed primitive and the diff from the apply _no longer has that value_. This is possible if the computed value ended up being the same as the old value. This is allowed to pass through. Together, these fix #3309.	10 years ago
Mitchell Hashimoto	5ee8042dff	helper/schema: expose stop information as a Context	10 years ago
Mitchell Hashimoto	d1bb2f3487	helper/schema: support Stop()	10 years ago
Mitchell Hashimoto	60140b28f4	Revert "Merge pull request #9536 from hashicorp/f-provider-stop" ... This reverts commit c3a4cff133, reversing changes made to 791a02e6e4. This change requires plugin recompilation and we should hold off until a minor release for that.	10 years ago
Mitchell Hashimoto	86eb30b8a2	helper/schema: expose stop information as a Context	10 years ago
Mitchell Hashimoto	8c11f137f5	helper/schema: support Stop()	10 years ago
James Nugent	43dd13cd36	helper/schema: Introduce Noop and RemoveFromState ... This commit implements reusable functions for when resources have no need to implement a particular operation: - Noop - does nothing and returns no error. - RemoveFromState - sets the resource ID to empty string (removing it from state) and returns no error.	10 years ago
Mitchell Hashimoto	fa9758e162	helper/schema: test with DiffSuppress and Default	10 years ago
stack72	5a537cdbf9	helper/schema: Adding of MinItems as a validation to Lists and Maps ... This is required for the times when the configuration cannot have an empty configuration. An example would be in AzureRM, when you create a LoadBalancer with a configuration, you can delete *all* but 1 of these configurations	10 years ago
Paul Hinze	534a5a3b75	Merge pull request #8891 from gotascii/fix-diff-set-update ... Unchanged NestedSets are not returned by DiffFieldReader.	10 years ago
Justin Marney	895d10a627	Use DeepEqual instead of multiple if statements to reduce noise.	10 years ago
Justin Marney	53e10dfa89	Name test appropriately.	10 years ago
Justin Marney	9217f5a063	Unchanged NestedSets are not returned by DiffFieldReader.	10 years ago
James Nugent	e0226c9039	core: Check for attrV being nil before dereference ... This can be an issue with unset computed fields. Fixes #8815.	10 years ago
Paul Stack	bf755bb5c9	Merge pull request #8585 from hashicorp/f-diff-suppression ... helper/schema: Add diff suppression callback	10 years ago
James Nugent	85ec09111b	helper/schema: Add diff suppression callback ... This commit adds a new callback, DiffSuppressFunc, to the schema.Schema structure. If set for a given schema, a callback to the user-supplied function will be made for each attribute for which the default type-based diff mechanism produces an attribute diff. Returning `true` from the callback will suppress the diff (i.e. pretend there was no diff), and returning false will retain it as part of the plan. There are a number of motivating examples for this - one of which is included as an example: 1. On SSH public keys, trailing whitespace does not matter in many cases - and in some cases it is added by provider APIs. For digitalocean_ssh_key resources we previously had a StateFunc that trimmed the whitespace - we now have a DiffSuppressFunc which verifies whether the trimmed strings are equivalent. 2. IAM policy equivalence for AWS. A good proportion of AWS issues relate to IAM policies which have been "normalized" (used loosely) by the IAM API endpoints. This can make the JSON strings differ from those generated by iam_policy_document resources or template files, even though the semantics are the same (for example, reordering of `bucket-prefix/` and `bucket-prefix/*` in an S3 bucket policy. DiffSupressFunc can be used to test for semantic equivalence rather than pure text equivalence, but without having to deal with the complexity associated with a full "provider-land" diff implementation without helper/schema.	10 years ago
Radek Simko	b90ab0b705	schema: Return all validation errors together from InternalValidate	10 years ago
Paul Hinze	3dccfa0cc9	terraform: diffs with only tainted set are non-empty ... Fixes issue where a resource marked as tainted with no other attribute diffs would never show up in the plan or apply as needing to be replaced. One unrelated test needed updating due to a quirk in the testDiffFn logic - it adds a "type" field diff if the diff is non-Empty. NBD	10 years ago
Clint	a84aa5e914	Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)	10 years ago
Radek Simko	37d57f4a85	Improve naming convention (resultSet -> exists)	10 years ago
Radek Simko	917ad44cf0	helper/schema: Fix readSet implementation (DiffFieldReader)	10 years ago
Radek Simko	c738c5a9a3	helper/schema: Implement reader-specific readList method	10 years ago
Radek Simko	378b526dc3	helper/schema: Add regression tests for nested Set/List ... Although DiffFieldReader was the one mostly responsible for a buggy behaviour more tests were added throughout the debugging process most of which would fail without the bugfix. - ResourceData - MultiLevelFieldReader - MapFieldReader - DiffFieldReader	10 years ago
James Nugent	dbf725bd68	core: Allow dynamic attributes in helper/schema ... The helper/schema framework for building providers previously validated in all cases that each field being set in state was in the schema. However, in order to support remote state in a usable fashion, the need has arisen for the top level attributes of the resource to be created dynamically. In order to still be able to use helper/schema, this commit adds the capability to assign additional fields. Though I do not forsee this being used by providers other than remote state (and that eventually may move into Terraform Core rather than being a provider), the usage and semantics are: To opt into dynamic attributes, add a schema attribute named "__has_dynamic_attributes", and make it an optional string with no default value, in order that it does not appear in diffs: "__has_dynamic_attributes": { Type: schema.TypeString Optional: true } In the read callback, use the d.UnsafeSetFieldRaw(key, value) function to set the dynamic attributes. Note that other fields in the schema _are_ copied into state, and that the names of the schema fields cannot currently be used as dynamic attribute names, as we check to ensure a value is not already set for a given key.	10 years ago
clint shryock	7d71b8cc3c	helper and terraform interpolate test update	10 years ago
James Bardin	2c7b702d1f	Merge pull request #7091 from hashicorp/jbardin/serialize ... Serialization for hash panics on TypeMap	10 years ago
James Bardin	bab031aac5	Add test for TypeMap in a Schema	10 years ago