13 Commits (ea93b91a80201c19c00d12dfd6fddc46f443bd2a)

Author	SHA1	Message	Date
Kristinn Örn Sigurðsson	bc5518f993	provisioners: Allow provisioning over IPv6	10 years ago
Paul Hinze	96c20f0dd7	communicator/{ssh,winrm}: seed random script paths ... Without a seed, the "random" script path locations for the remote-exec provisioner were actually deterministic! Every rand.Int31() would return the same pseudorandom chain starting w/ the numbers: 1298498081, 2019727887, 1427131847, 939984059, ... So here we properly seed the communicators so the script paths are actually random, and multiple runs on a single remote host have much less chance of clobbering each other. Fixes #4186 Kudos to @DustinChaloupka for the correct hunch leading to this fix!	10 years ago
David Meyer	f46a629d72	communicator/winrm: Fixed HTTPS when using copy client.	10 years ago
Paul Hinze	9cbaacad32	communicator/winrm: fix data race in io copy ... As the command completes, the winrm.Command does not wait for its copy of the remote.Command streams to report itself completed. This adds an additional sync.WaitGroup to ensure that copy is finished up before moving on, solving the data race. Fixes the following data race: ``` ================== WARNING: DATA RACE Read by goroutine 6: github.com/hashicorp/terraform/communicator/winrm.TestStart() /Users/phinze/go/src/github.com/hashicorp/terraform/communicator/winrm/communicator_test.go:79 +0xa44 testing.tRunner() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:456 +0xdc Previous write by goroutine 14: bytes.(*Buffer).ReadFrom() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/bytes/buffer.go:174 +0x465 io.copyBuffer() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/io/io.go:375 +0x1a5 io.Copy() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/io/io.go:351 +0x78 Goroutine 6 (running) created at: testing.RunTests() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:561 +0xaa3 testing.(*M).Run() /private/var/folders/vd/7l9ys5k57l91x63sh28wl_kc0000gn/T/workdir/go/src/testing/testing.go:494 +0xe4 main.main() github.com/hashicorp/terraform/communicator/winrm/_test/_testmain.go:62 +0x20f Goroutine 14 (finished) created at: github.com/hashicorp/terraform/communicator/winrm.runCommand() /Users/phinze/go/src/github.com/hashicorp/terraform/communicator/winrm/communicator.go:151 +0xf8 ================== ```	10 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Sander van Harmelen	a8dacede24	Improved some logging... ... I added a debug log line in the last commit, only to find out it’s now logging the same info twice. So removed the double entry and tweaked the existing once.	11 years ago
Sander van Harmelen	e55169b39b	Typo...	11 years ago
Sander van Harmelen	7f408cf8aa	Adding an import needed for the tests ... This will likely be a temp fix until `make updated eps` is made a little smarter by @phinze 😉	11 years ago
Sander van Harmelen	a1a1ea5cf9	Removing stray comments/commands	11 years ago
Sander van Harmelen	b6660a1abe	Updated test as the winrmtest package was tweaked a little... ... The winrmtest package update is merged now, so this can be merged now as well…	11 years ago
Sander van Harmelen	2689601bc3	And here are the tests... ... Pretty nice test coverage this way, covering all WinRM actions/logic by using the winrmtest package. I had to extend/update/fix that package a little here and there, but it now serves a nice purpose for testing WinRM stuff…	11 years ago
Sander van Harmelen	41748003c0	Updated the PR according to the review comments ... * We now return an error when you set the script_path to C:\Windows\Temp explaining this is currently not supported * The fix in PR #1588 is converted to the updated setup in this PR including the unit tests Last thing to do is add a few tests for the WinRM communicator…	11 years ago
Sander van Harmelen	4a29c714e5	Adding support for WinRM	11 years ago