terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	6aefa5835c	Merge #17218 : Add -auto-approve to "terraform destroy" for consistency	8 years ago
James Bardin	dc8036636a	Merge pull request #17422 from hashicorp/jbardin/state-locking Add StateLocker interface to backend operations	8 years ago
James Bardin	2b97585d46	improve clistate.Locker docs	8 years ago
Uriel Corfa	07a20365de	cli: "terraform state list" -id argument A new -id option to "terraform state list" which constraints the output of the command to resources whose id is equal to the flag value.	8 years ago
James Bardin	bdd475e149	use the new clistate.Locker in commands Use the new StateLocker field to provide a wrapper for locking the state during terraform.Context creation in the commands that directly manipulate the state.	8 years ago
James Bardin	e9a76808df	create clistate.Locker interface Simplify the use of clistate.Lock by creating a clistate.Locker instance, which stores the context of locking a state, to allow unlock to be called without knowledge of how the state was locked. This alows the backend code to bring the needed UI methods to the point where the state is locked, and still unlock the state from an outer scope. Provide a NoopLocker as well, so that callers can always call Unlock without verifying the status of the lock. Add the StateLocker field to the backend.Operation, so that the state lock can be carried between the different function scopes of the backend code. This will allow the backend context to lock the state before it's read, while allowing the different operations to unlock the state when they complete.	8 years ago
James Bardin	12bda53558	Revert "create clistate.Locker interface" This reverts commit `e88bd74bb7`.	8 years ago
James Bardin	3de0d24554	Revert "use the new clistate.Locker in commands" This reverts commit `400f6ca4c5`.	8 years ago
James Bardin	400f6ca4c5	use the new clistate.Locker in commands Use the new StateLocker field to provide a wrapper for locking the state during terraform.Context creation in the commands that directly manipulate the state.	8 years ago
James Bardin	e88bd74bb7	create clistate.Locker interface Simplify the use of clistate.Lock by creating a clistate.Locker instance, which stores the context of locking a state, to allow unlock to be called without knowledge of how the state was locked. This alows the backend code to bring the needed UI methods to the point where the state is locked, and still unlock the state from an outer scope.	8 years ago
James Bardin	a37acb1837	gofmt with go1.10	8 years ago
James Bardin	ecd9ef0f77	ignore error in plan shutdown test The error was being silently dropped before. There is an interpolation error, because the plan is canceled before some of the resources can be evaluated. There might be a better way to handle this in the walk cancellation, but the behavior has not changed. Make the plan and apply shutdown match implementation-wise	8 years ago
James Bardin	67a6152091	move backend operation cancellation into meta Create a single command method for running and operation with cancellation.	8 years ago
James Bardin	7cba68326a	always wait for a RunningOperation to return If the user wishes to interrupt the running operation, only the first interrupt was communicated to the operation by canceling the provided context. A second interrupt would start the shutdown process, but not communicate this to the running operation. This order of event could cause partial writes of state. What would happen is that once the command returns, the plugin system would stop the provider processes. Once the provider processes dies, all pending Eval operations would return return with an error, and quickly cause the operation to complete. Since the backend code didn't know that the process was shutting down imminently, it would continue by attempting to write out the last known state. Under the right conditions, the process would exit part way through the writing of the state file. Add Stop and Cancel CancelFuncs to the RunningOperation, to allow it to easily differentiate between the two signals. The backend will then be able to detect a shutdown and abort more gracefully. In order to ensure that the backend is not in the process of writing the state out, the command will always attempt to wait for the process to complete after cancellation.	8 years ago
Laura Martin	6e1e614a56	Change -force to -auto-approve when destroying Since an early version of Terraform, the `destroy` command has always had the `-force` flag to allow an auto approval of the interactive prompt. 0.11 introduced `-auto-approve` as default to `false` when using the `apply` command. The `-auto-approve` flag was introduced to reduce ambiguity of it's function, but the `-force` flag was never updated for a destroy. People often use wrappers when automating commands in Terraform, and the inconsistency between `apply` and `destroy` means that additional logic must be added to the wrappers to do similar functions. Both commands are more or less able to run with similar syntax, and also heavily share their code. This commit updates the command in `destroy` to use the `-auto-approve` flag making working with the Terraform CLI a more consistent experience. We leave in `-force` in `destroy` for the time-being and flag it as deprecated to ensure a safe switchover period.	8 years ago
James Bardin	6f41a80b3a	slow down the plan shutdown tests for slow hosts The plan shutdown test often fail on slow CI hosts, becase the plan completes befor the main thread can cancel it. Since attempting to make the MockProvider concurrent proved too invasive for now, just slow the test down a bit to help ensure Stop gets called.	8 years ago
Masayuki Morita	338d5cad70	Remove duplicated help messages from `workspace --help` Fixes #17165	8 years ago
Masayuki Morita	f440dba137	Standardize on log level "WARN" rather than "WARNING"	8 years ago
Martin Atkins	a6008b8a48	v0.11.2	8 years ago
James Bardin	61c2be3e95	Merge pull request #16969 from hashicorp/jbardin/reset-plugin-dir allow init to reset -plugin-dir	8 years ago
James Bardin	7d5f7cb22f	Merge pull request #16961 from hashicorp/jbardin/mock-provider-race minor race issue in mockResourceProvider	8 years ago
James Bardin	504ea578ee	Merge pull request #16920 from hashicorp/jbardin/init-future-state check state version during init	8 years ago
James Bardin	dec2da1dda	Merge pull request #17044 from hashicorp/jbardin/plugin-dir-internal -plugin-dir short-circuits discovery of internal plugins	8 years ago
James Bardin	6367572455	Merge pull request #16882 from Techcadia/f-provider-logging [Add] Pathing and Override to DEBUG Command	8 years ago
James Bardin	fe3aff91f3	missingPlugins should not return internal plugins Filter the internal plugins out beforehand, so we don't attempt to locate them at all during init.	8 years ago
James Bardin	5a975d9997	add test for internal plugins with -plugin-dir -plugin-dir was short-circuiting the discovery for internal plugins	8 years ago
James Bardin	5a9e0cf763	create a new InternalProviders test Remove the legacy InternalProviders global. The terraform provider is the only one run internally.	8 years ago
James Bardin	ba84faf4e1	remove the plugin path only for an empty string To avoid breaking automation where plugin-path was assumed to be set permanently, only remove the plugin-path record if it was explicitly set to and empty string.	8 years ago
James Bardin	f62b71710a	Merge pull request #16939 from hashicorp/jbardin/migrate-confirm remove extra backend migration prompts	8 years ago
James Bardin	f45205feb7	re-word state migration prompts The existing prompts were worded as if backend configurations were named, but they can only really be referenced by their type. Change the wording to reference them as type "X backend". When migrating state, refer to the backends as the "previously configured" and "newly configured", since they will often have the same type.	8 years ago
James Bardin	4b49a323c3	go fmt slight change to go fmt coming in 0.10	8 years ago
James Bardin	79e985366f	allow init to reset -plugin-dir Remove the recorded -plugin-dir during init if the flag is not provided.	8 years ago
James Bardin	d76482cd89	don't try to interrupt diff in shutdown test Rather than relying on interrupting Diff, just make sure Stop was called on the provider. The DiffFn is protected by a mutex in the mock provider, which means that the tests can't rely on concurent calls to diff working.	8 years ago
James Bardin	e63a3474d5	kill the flag error writer after 2 seconds There's no point in trying to track these, they're lost after each test. Kill them after a short delay so we don't have goroutines from every single command test to wade through if we have a stack dump.	8 years ago
James Bardin	885e4cde81	don't loop indefinitely in confirm method Only check for input twice in the meta.confirm method. This prevents an errant newline from aborting the run while allowing Terraform to exit if there is no input available. We don't just check for a tty, since we still rely on being able to pipe input in for testing. Remove the redundant confirmation loops in the migration code, and only use the confirm method.	8 years ago
James Bardin	7d2da9865e	inputFalse test should attempt migration and check error Make sure the init inputFalse test actually errors from missing input, since skipping input will still fail later during provider initialization. We need to make sure there are two different states that aren't a noop for migration, and reset the command struct for each run. Also verify that we don't go into an infinite loop if there is no input.	8 years ago
James Bardin	909dff36a8	remove extra "yes" confirmation in tests There were two tests that had the duplicate confirmations hard-coded in the input stream.	8 years ago
James Bardin	7c93b2e5e6	remove duplicate backend migration prompts The duplicate prompts can be confusing when the user confirms that a migration should happen and we immediately prompt a second time for the same thing with slightly different wording. The extra hand-holding that this provides for legacy remote states is less critical now, since it's been 2 major release cycles since those were removed.	8 years ago
James Bardin	ea4cb6a20e	check state version during init The init command needs to parse the state to resolve providers, but changes to the state format can cause that to fail with difficult to understand errors. Check the terraform version during init and provide the same error that would be returned by plan or apply.	8 years ago
Martin Atkins	f1079257ac	command: show a special error message when importing in an empty dir If users run "terraform import" in a directory with no Terraform configuration files, it's likely that they've made a mistake either by being in the wrong directory or forgetting to use the -config option on the command line. To help users find their mistake in this case, we'll now produce a specialized error message for this situation: Error: No Terraform configuration files The directory /home/user/example does not contain any Terraform configuration files (.tf or .tf.json). To specify a different configuration directory, use the -config="..." command line option. While here, this also converts some of the other existing messages to diagnostics so that we can show any configuration warnings along with the error message, and move towards the new standard error presentation.	8 years ago
Techcadia	e681907c50	[Add] Pathing and Override Output to DEBUG Command	8 years ago
Nolan Davidson	653db95df7	Initial implementation of a habitat provisioner First pass at loading the config data using the TF schema. Signed-off-by: Nolan Davidson <ndavidson@chef.io>	8 years ago
Martin Atkins	9a5c865040	command: validate config as part of loading it Previously we required callers to separately call .Validate on the root module to determine if there were any value errors, but we did that inconsistently and would thus see crashes in some cases where later code would try to use invalid configuration as if it were valid. Now we run .Validate automatically after config loading, returning the resulting diagnostics. Since we return a diagnostics here, it's possible to return both warnings and errors. We return the loaded module even if it's invalid, so callers are free to ignore returned errors and try to work with the config anyway, though they will need to be defensive against invalid configuration themselves in that case. As a result of this, all of the commands that load configuration now need to use diagnostic printing to signal errors. For the moment this just allows us to return potentially-multiple config errors/warnings in full fidelity, but also sets us up for later when more subsystems are able to produce rich diagnostics so we can show them all together. Finally, this commit also removes some stale, commented-out code for the "legacy" (pre-0.8) graph implementation, which has not been available for some time.	8 years ago
James Bardin	12b7dac124	Merge pull request #16833 from hashicorp/jbardin/plan-shutdown Fully enable shutdown for plan and refresh in the local backend	8 years ago
Eyal Posener	e1dadaae44	command: use newer version of "complete" library This takes care of filtering results for us, so we don't need to do it on our end anymore.	8 years ago
James Bardin	2941ed464c	replace the testShutdownHook with a check for Stop Now that the local backend can be cancelled during plan and refresh, we don't really need the testShutdownHook. Simplify the tests by just checking for Stop being called on the provider.	8 years ago
James Bardin	e2501d7830	make apply shutdown test completely deterministic Add a shutdown hook to verify that a context has been correctly cancelled, so we can remove the sleep and stop guessing. Add a plan version of the shutdown test as well.	8 years ago
James Bardin	3aaa1e9d04	make plans cancellable There was no cancellation context for a plan, so it would always have to run to completion as SIGINT was being swallowed. Move the shutdown channel to the command Meta since it's used in multiple commands.	8 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	8 years ago
James Bardin	3c807e5427	update state test strings in command package	8 years ago

1 2 3 4 5 ...

944 Commits (e4b0a989f353a0e9bbca45331c8ae3f9fd69dc50)