1099 Commits (e4270993be013de410ffd7ca76aa2f00a27df688)

Author	SHA1	Message	Date
Martin Atkins	8c54da0ad2	command: TestInit_fromModule_explicitDest guard against other tests ... Some other test is leaving behind a terraform.tfstate after it concludes, which can cause this test to fail in a strange way due to picking up extra provider requirements from that state. This check doesn't fix that problem, but it at least makes the test fail in a more helpful way to avoid time wasted trying to debug this test when it's some other test that actually has the bug.	7 years ago
Martin Atkins	ced06a4ca3	command: fix panic in TestStatePush_lineageMismatch ... This test is currently failing due to the command completing successfully, which would previously cause a panic because we didn't properly initialize the MockUi and so its error buffer is nil unless written to. (The failure this was masking will be fixed in a subsequent commit.)	7 years ago
Martin Atkins	544c2932ce	command: Fix TestInit_checkRequiredVersion ... In prior refactoring we lost the required core version check from "terraform init", which we restore here. Additionally, this test used to have an incorrect name that suggested it was testing something in the "getProvider" codepath, but version checking happens regardless of what other options are selected.	7 years ago
Martin Atkins	9ba399bca8	command: Fix TestInit_getProvider ... After all of the refactoring we were no longer checking the Terraform version field in a state file, causing this test to fail. This restores that check, though with a slightly different error message.	7 years ago
Martin Atkins	f6d468ffd5	command: Fix TestInit_inputFalse ... This test was using old-style state files as its input, differing only by lineage. Since lineages are now managed within the state manager itself, the test can't use that to distinguish the two files and so we put a different output in each one instead. This also introduces some TRACE logging to the migration codepaths. There's some hard-to-follow control flow here and so this extra logging helps to understand the reason for a particular outcome, and since this codepath is visited only in "terraform init" anyway it doesn't hurt to be a bit more verbose here.	7 years ago
Martin Atkins	c0b7f58143	command: Fix detection of necessary backend migration ... In the refactoring for new HCL this codepath stopped taking into account changes to the CLI -backend-config options when deciding if a backend migration is required. This restores that behavior in a different way than it used to be: rather than re-hashing the merged config and comparing the hashes, we instead just compare directly the configuration values, which must be exactly equal in order to skip migration. This change is covered by the test TestInit_inputFalse, although as of this commit it is still not passing due a downstream problem within the migration code itself.	7 years ago
Sander van Harmelen	5e9414bf03	backend/migrations: only select workspaces if supported ... If the backend does not support workspaces, we don't have to try to select a workspace and we should not return an error.	7 years ago
Martin Atkins	297b3b8830	command: Fix TestInit_backendReinitConfigToExtra ... This test was re-using the same InitCommand value to run multiple times, which is not realistic. Since we now cache configuration source code inside command.Meta on load, it's important that we use a fresh InitCommand instance here so it'll see the modified configuration file we've left on disk.	7 years ago
Martin Atkins	b5547f00f6	command: backendConfig must mutate its copy, not the original ... Here we were going to the trouble of copying the body so we could mutate it, but then ended up mutating the original anyway and then returning the unmodified copy. Whoops! This fix is verified by a number of "init" command tests that exercise the -backend-config option, including TestInit_backendConfigFile and several others whose names have the prefix TestInit_backendConfig .	7 years ago
Martin Atkins	8b603e4877	command: Name the Terraform Registry specifically in error message ... When we originally wrote this message we struggled a bit for how to refer to the releases server without writing an awkwardly-ungrammatical sentence, and so "the official repository" became a placeholder name for it. Now that we'll be looking in Terraform Registry this gives us a nice proper noun to use. This message will need to evolve more as our integration with the registry gets more sophisticated, but for now this works.	7 years ago
Martin Atkins	592850e22c	command: Fix TestApply_plan_remoteState ... Some over-zealous bulk updating of this test file caused this test to be producing a remote state config cache file on disk when it doesn't actually need one: the backend config comes from the plan file when applying a saved plan.	7 years ago
Martin Atkins	c05a556c0e	command: Fix TestRefresh_backup ... This test intentionally overrides the backup file location using the -backup option, so the backup file is not in the default location for this one.	7 years ago
Martin Atkins	ad276142b4	command: Fix the command package test build ... Some merging conflict shenanigans here led to this usage not lining up with the imported symbol name, meaning that the tests couldn't compile any more.	7 years ago
Martin Atkins	1e45d30036	command: Fix TestPlan_outBackend ... We missed fixing this up during the big updates for the new plan/state models since the failures were being masked by testBackendState being broken. This is the same sort of update made to many other tests: add schema to the mock provider, adjust for the new plan/state types, and make allowances for the new built-in diffing behavior in core.	7 years ago
Martin Atkins	c3d11b762b	command: Fix testBackendState ... The hashing function for cached backend configuration is different now, so our hard-coded hash of the HTTP backend address wasn't working anymore. Here we update the hash so that tests using this test backend will work again. Rather than leaving it hard-coded, we'll instead compute it the same way as "terraform init" would. In practice only one test is actually using this function right now, so we also update the test fixture for that test (TestPlan_outBackend) to match the new expectations, though as of this commit it's still failing with an unrelated error.	7 years ago
Martin Atkins	e20346bf4f	command: fix TestMeta_process ... The mission of this process method used to include dealing with auto-loaded tfvars files, but it doesn't do that anymore. It does still deal with the -no-color option, but the test wasn't exercising that part before. Now the test here focuses on the -no-color behavior. The process method still has a "vars" flag argument which is no longer used. Since this is an unexported method we could potentially address this but this commit is intentionally limited only to fixing the test.	7 years ago
Martin Atkins	fcf3f643ce	command: Fix TestPlan_shutdown ... Comments here indicate that this was erroneously returning an error but we accepted it anyway to get the tests passing again after other work. The tests over in the "terraform" package agree that cancelling should be a successful outcome rather than an error. I think that cancelling _should_ actually be an error, since Terraform did not complete the operation it set out to complete, but that's a change we'd need to make cautiously since automation wrapper scripts may be depending on the success-on-cancel behavior. Therefore this just fixes the command package test to agree with the Terraform package tests and adds some FIXME notes to capture the potential that we might want to update this later.	7 years ago
Martin Atkins	0ea8aa6fe5	command: Fix TestWorkspace_createWithState ... The State.Equal function is now more precise than this test needs. It's only trying to distinguish between an empty state and a non-empty state, so the string representation of state is good enough to get that done while disregarding other subtle differences.	7 years ago
Sander van Harmelen	52a1b22f7a	Implement the remote enhanced backend ... This is a refactored version of the `remote` backend that was initially added to Terraform v0.11.8 which should now be compatible with v0.12.0.	7 years ago
Sander van Harmelen	b62a22ab62	Add a VariableSourceType for names .tfvars files ... This new source type should be used for variables loaded from .tfvars files that were explicitly passed as command line arguments (e.g. -var-file=foo.tfvars)	7 years ago
Sander van Harmelen	178ec8f7b4	Remove support for the -module-depth flag ... # Conflicts: # backend/backend.go	7 years ago
Sander van Harmelen	643fccc923	Merge pull request #19250 from hashicorp/f-inputs ... Fix the ability to ask for and save user input	7 years ago
Sander van Harmelen	5944e8e34f	Fix the ability to ask for and save user input	7 years ago
Sander van Harmelen	5458a91985	command/state: update and fix the state show command	7 years ago
Sander van Harmelen	7ec3f96e3a	command/state: update and fix the state mv command	7 years ago
Sander van Harmelen	19c1241a50	command/state: update and fix the state rm command	7 years ago
James Bardin	e93d69f18b	more nil/known checks before val.LengthInt	7 years ago
Sander van Harmelen	536c2fe6f1	Make `state mv` use the new `states.Filter`	7 years ago
Sander van Harmelen	5e11de460a	Merge pull request #19130 from hashicorp/f-state-push-pull ... command/state: update and fix the state push and pull	7 years ago
Sander van Harmelen	7fbd93b5cd	command/state: update and fix the state push and pull	7 years ago
Sander van Harmelen	a88ba31b63	Merge pull request #19129 from hashicorp/f-show-list ... command/state: update and fix the state list command	7 years ago
Sander van Harmelen	83168ea25f	Merge pull request #19127 from hashicorp/b-prepare-provider ... Make the test compile again	7 years ago
Sander van Harmelen	af1a471a05	command/state: update and fix the state list command	7 years ago
Sander van Harmelen	4d6626b3a8	Terraform show didn’t show absolute paths ... Without using absolute paths any module info is lost in the output. And the attributes were randomly ordered and so changed between different executions of the command.	7 years ago
Sander van Harmelen	b846c5f653	Make the test compile again ... Not sure if these checks still make sense, but without this change the test don’t compile for the related packages.	7 years ago
Martin Atkins	17b883f592	command/format: Include variable values in diagnostic messages ... When HCL encounters an error during expression evaluation, it annotates its diagnostics with information about the expression that was being evaluated and the EvalContext it was evaluated in. This gives us enough information to show helpful hints to the user about the final values of any reference expressions that are present in the expression, which is very useful extra context for expressions that get evaluated multiple times, such as: - Any expression in a block with "count" or "for_each" set - The sub-expressions within a "for" expression	7 years ago
James Bardin	e08a388d3c	check IsKnown on values that may panic	7 years ago
Sander van Harmelen	48ef7ecfa6	Updates after running `make fmt` with Go v1.11.1	7 years ago
James Bardin	fe9ed37dfc	minor fixes for command Apply tests	7 years ago
Martin Atkins	541952bb8f	Revert some work that happened since v0.12-dev branched ... This work was done against APIs that were already changed in the branch before work began, and so it doesn't apply to the v0.12 development work. To allow v0.12 to merge down to master, we'll revert this work out for now and then re-introduce equivalent functionality in later commits that works against the new APIs.	7 years ago
Martin Atkins	8e51363f04	command: Don't allow -var and -var-file when applying saved plan ... This reinstates an old behavior that was lost in the reorganization of how we deal with the -var and -var-file options. This fix is verified by TestApply_planVars now passing.	7 years ago
Martin Atkins	7abf81d8da	command: Restore support for terraform.tfvars.json ... In the new implementation of collecting variables I initially forgot the JSON variant of terraform.tfvars. This fix is verified by TestApply_varFileDefaultJSON now passing.	7 years ago
Martin Atkins	66f96cf842	command: Un-stub and reimplement "terraform state rm" ... This was previously targeting the old state manager and state types, so it needed some considerable rework to get it working again with the new state types. Since our new resource address syntax lacks the weird extra .deposed special case we had before, we instead interpret addresses as whole-instance addresses here and remove the deposed objects along with the current one (if present), since this is more likely to match with user expectations because we don't consider deposed objects to be independently addressable in any other situation. With that said, to be more explicit about what is going on we do now have a -dry-run mode and maintain separate counts of current and deposed instances so that we can expose that in the UI where relevant.	7 years ago
Martin Atkins	40eda180d6	command: go fmt in import_test.go and refresh_test.go	7 years ago
Martin Atkins	8b466811d2	command: Fix a few tests from meta_backend_test.go	7 years ago
Martin Atkins	86b7963bba	command: Fix tests for "terraform providers"	7 years ago
Martin Atkins	5b61cc919b	command: Fix "terraform import" tests	7 years ago
Martin Atkins	7b77e20bdc	command: Fix several "terraform init" tests	7 years ago
Martin Atkins	89d0944e5b	command: Fix even more of the "terraform refresh" tests	7 years ago
Martin Atkins	5d1d6a95f9	command: "go fmt" of plan_test.go	7 years ago