209 Commits (e37526b4e5d09da129e51474a8ce722ca767fbf8)

Author	SHA1	Message	Date
Liam Cervante	e37526b4e5	Refactor cloud test run cancellation logic to always intercept signals (#33930) ... * Refactor cloud test run cancellation logic to always intercept signals * add test * add more comments explaining cancellation flow	3 years ago
Liam Cervante	ae6b36b247	fix panic when tests don't finish executing (#33929)	3 years ago
Liam Cervante	ffbcaf8bef	Implement TFC integration for private module registry test runs (#33710) ... * implement module testing via TFC * ready for review * fix static checks * licence headers	3 years ago
Brandon Croft	70cf13cae3	cloud: don't update snapshot interval unless response is from tfe.v2	3 years ago
Brandon Croft	f5463ce77c	cloud: fix ShouldPersistIntermediateState should be false when header absent	3 years ago
Brandon Croft	6500b7c740	change visibility of cloud.Backend Hostname field	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Brandon Croft	b1d4f18a9b	Create provisional configuration version when saving cloud plan	3 years ago
Karl Kirch	d7e07e66fc	Add ability to specify Terraform Cloud Project in cloud block (#33489) ... * Add ability to specify Terraform Cloud Project in cloud block Adds project configuration to the workspaces section of the cloud block. Also configurable via the `TF_CLOUD_PROJECT` environment variable. When a project is configured, the following behaviors will occur: - `terraform init` with workspaces.name configured will create the workspace in the given project - `terraform workspace new <name>` with workspaces.tags configured will create workspaces in the given project - `terraform workspace list` will list workspaces only from the given project The following behaviors are NOT affected by project configuration - `terraform workspace delete <name>` does not validate the workspace's inclusion in the given project - When initializing a workspace that already exists in Terraform Cloud, the workspace's parent project is NOT validated against the given project Adds tests for cloud block configuration of project Update changelog * Update cloud block docs * Fix typos and changelog entry * Add speculative project lookup early in the cloud initialize process to capture inability to find a configured project * Add project config for alias test	3 years ago
Nick Fagerlund	f98f920b67	Add error wrapper types to highlight bad plan/state data ... This commit uses Go's error wrapping features to transparently add some optional info to certain planfile/state read errors. Specifically, we wrap errors when we think we've identified the file type but are somehow unable to use it. Callers that aren't interested in what we think about our input can just ignore the wrapping; callers that ARE interested can use `errors.As()`.	3 years ago
Nick Fagerlund	1f35173192	Tests: Add tests for `(*Cloud).ShowPlanForRun()`	3 years ago
Nick Fagerlund	7f6b827987	Modify tfe client mocks to meet some new requirements ... - Add plausible unredacted plan json for `plan-json-{basic,full}` testdata -- Created by just running the relevant terraform commands locally. - Add plan-json-no-changes testdata -- The unredacted json was organically grown, but I edited the log and redacted json by hand to match what I observed from a real but unrelated planned-and-finished run in TFC. - Add plan-json-basic-no-unredacted testdata -- This mimics a lack of admin permissions, resulting in a 404. - Hook up `MockPlans.ReadJSONOutput` to test fixtures, when present. This method has been implemented for ages, and has had a backing store for unredacted plan json, but has been effectively a no-op since nothing ever fills that backing store. So, when creating a mock plan, make an attempt to read unredacted json and stow it in the mocks on success. - Make it possible to get the entire MockClient for a test backend In order to test some things, I'm going to need to mess with the internal state of runs and plans beyond what the go-tfe client API allows. I could add magic special-casing to the mock API methods, or I could locate the shenanigans next to the test that actually exploits it. The latter seems more comprehensible, but I need access to the full mock client struct in order to mess with its interior. - Fill in some missing expectations around HasChanges when retrieving a run + plan.	3 years ago
Nick Fagerlund	d5938f6b45	Add `(*Cloud).ShowPlanForRun` method to support `terraform show` ... To do the "human" version of showing a plan, we need more than just the redacted plan JSON itself; we also need a bunch of extra information that only the Cloud backend is in a position to find out (since it's the only one holding a configured go-tfe client instance). So, this method takes a run ID and hostname, finds out everything we're going to need, and returns it wrapped up in a RemotePlanJSON struct.	3 years ago
Nick Fagerlund	e0af3e25e0	Add `cloudplan.RemotePlanJSON` wrapper struct for keeping plan metadata together	3 years ago
Nick Fagerlund	2a08a5b46e	Cloud: Split private `readRedactedPlan` func into two ... Since `terraform show -json` needs to get a raw hunk of json bytes and sling it right back out again, it's going to be more convenient if plain `show` can ALSO take in raw json. In order for that to happen, I need a function that basically acts like `client.Plans.ReadJSONOutput()`, without eagerly unmarshalling that `jsonformat.Plan` struct. As a slight bonus, this also lets us make the tfe client mocks slightly stupider.	3 years ago
Nick Fagerlund	da963a13b9	Implement plan -out for Cloud ... - Don't save errored plans. - Call op.View.PlanNextStep for terraform plan in cloud mode (We never used to show this footer, because we didn't support -out.) - Create non-speculative config version if saving plan - Rewrite TestCloud_planWithPath to expect success!	3 years ago
Nick Fagerlund	f9d937a4dd	Apply a confirmable run when given a saved cloud plan (#33270) ... It displays a run header with link to web UI, like starting a new plan does, then confirms the run and streams the apply logs. If you can't apply the run (it's from a different workspace, is in an unconfirmable state, etc. etc.), it displays an error instead. Notable points along the way: * Implement `WrappedPlanFile` sum type, and update planfile consumers to use it instead of a plain `planfile.Reader`. * Enable applying a saved cloud plan * Update TFC mocks — add org name to workspace, and minimal support for includes on MockRuns.ReadWithOptions.	3 years ago
Nick Fagerlund	9d85f18930	Add NewSavedPlanBookmark function ... so we don't have to remember the format version number	3 years ago
Lauren	dcccd3b266	Add error handling and tests for saved plan bookmark load/save (#33268)	3 years ago
Nick Fagerlund	df7a1c821a	Move SavedPlanBookmark to dedicated `internal/cloud/cloudplan` package ... Having this sitting loose in `cloud` proved problematic because of circular import dependencies. Putting it in a sub-package under cloud frees us up to reference the type from places like `internal/backend`!	3 years ago
Lauren	717a36036d	codify saved plan artifact contents (#33185)	3 years ago
Brandon Croft	c1a730314d	Relocate localterraform.com aliasing to backend configurators ... Previously, remote and cloud backends would automatically alias localterraform.com as the configured hostname during configuration. This turned out to be an issue with how backends could potentially be used within the builtin terraform_remote_state data source. Those data sources each configure the same service discovery with different targets for localterraform.com, and do so simultaneously, creating an occasional concurrent map read & write panic when multiple data sources are defined. localterraform.com is obviously not useful for every backend configuration. Therefore, I relocated the alias configuration to the callers, so they may specify when to use it. The modified design adds a new method to backend.Enhanced to allow configurators to ask which aliases should be defined.	3 years ago
Liam Cervante	6882dd9530	testing framework: introduce test command optional flags (#33504) ... * testing framework: introduce test command optional flags * address consistency checks	3 years ago
James Bardin	cf5ebaf685	s/Schemas/ProviderSchema/	3 years ago
James Bardin	36d34135ad	replace remaining types in tests	3 years ago
Brandon Croft	9fe3f7a7b4	cloud: when saving state, create a pending state version then upload ... Create a pending state version followed by a separate state upload When this version of the endpoint fails (It is not yet generally available, or when using with Terraform Enterprise) Fall back to the original call with state content included in the request. This strategy will reduce the amount of save failures due to network latency and gateway timeouts.	3 years ago
kmoe	5900d1177c	cloud: assert import block compatibility (#33282) ... * cloud: assert import block compatibility * check for import <> TFC compatibility during init * imports are not in alphabetical order 🙃 --------- Co-authored-by: CJ Horton <cjhorton@hashicorp.com>	3 years ago
CJ Horton	8213513e2b	Merge pull request #33278 from hashicorp/radditude/cloud-config-generation ... plannable import: allow writing generated config when using the cloud integration	3 years ago
CJ Horton	6ca13bfc1e	fix static check errors	3 years ago
Brandon Croft	86eed095b3	Rename disableIntermediateSnapshots > enableIntermediateSnapshots	3 years ago
CJ Horton	cdce4c4a6d	write generated config when using the cloud integration	3 years ago
CJ Horton	b88bae2ec4	tests for cloud backend config generation	3 years ago
Sebastian Rivera	d03fd37ee6	Add interval header check to enable snapshots	3 years ago
Martin Atkins	f6737d47e7	cloud: Allow Cloud API to lower the intermediate state snapshot interval ... Previously we just made a hard rule that the state storage for Terraform Cloud would never save any intermediate snapshots at all, as a coarse way to mitigate concerns over heightened Terraform Enterprise storage caused by saving intermediate snapshots. As a better compromise, we'll now create intermediate snapshots at the default interval unless the Terraform Cloud API responds with a special extra header field X-Terraform-Snapshot-Interval, which specifies a different number of seconds (up to 1 hour) to wait before saving the next snapshot. This will then allow Terraform Cloud and Enterprise to provide some dynamic backpressure when needed, either to reduce the disk usage in Terraform Enterprise or in situations where Terraform Cloud is under unusual load and needs to calm the periodic intermediate snapshot writes from clients. This respects the "force persist" mode so that if Terraform CLI is interrupted with SIGINT then it'll still be able to urgently persist a snapshot of whatever state it currently has, in anticipation of probably being terminated with a more aggressive signal very soon.	3 years ago
Martin Atkins	efdc6e52bc	cloud: Skip intermediate state snapshots in Terraform Cloud/Enterprise ... We've seen some concern about the additional storage usage implied by creating intermediate state snapshots for particularly long apply phases that can arise when managing a large number of resource instances together in a single workspace. This is an initial coarse approach to solving that concern, just restoring the original behavior when running inside Terraform Cloud or Enterprise for now and not creating snapshots at all. This is here as a solution of last resort in case we cannot find a better compromise before the v1.5.0 final release. Hopefully a future commit will implement a more subtle take on this which still gets some of the benefits when running in a Terraform Enterprise environment but in a way that will hopefully be less concerning for Terraform Enterprise administrators. This does not affect any other state storage implementation except the Terraform Cloud integration and the "remote" backend's state storage when running inside a TFC/TFE-driven remote execution environment.	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Glenn Sarti	7e2e834aff	Emit warnings for certain run events in cloud backend (#33020) ... The cloud backend, which communicates with TFC like APIs, can create runs which may have one more configuration parameters altered. These alterations are emitted as run-events on the run so that API clients can consume and display them to users. This commit adds a step in plan operation to query the run-events once a run is created and then emit specific run-event descriptions to the console as warnings for the user.	3 years ago
Sebastian Rivera	5634ae3e18	Unit tests to ensure renderer is appropriately called	3 years ago
Sebastian Rivera	b23cfaefe8	Refactor SRO check to prevent duplicate plan output	3 years ago
Alisdair McDiarmid	ca53ca00f4	Remove failing DNS query in cloud tests ... This test case was making a real DNS call in a non-acceptance test, and since it was intended to fail it would introduce a several second delay. This commit replaces the test with a similar one which uses the mocked disco services for a non-TFE host. Also restructure the test to use t.Run for clarity.	3 years ago
Alisdair McDiarmid	19e635bfc8	Remove polling delays in run tasks test ... These delays are not relevant to the test and result in increased test execution time.	3 years ago
Brandon Croft	3d1a58d5b5	Merge pull request #32708 from mrinalirao/mr/taskStage-race ... Bug Fix where CLI exits if run is not confirmable.	3 years ago
Brandon Croft	ec4f62078a	Merge pull request #32666 from hashicorp/sebasslash/fix-credentials-sourcing-backend ... Fix SRO authorization bug when token is fetched from cloud config	3 years ago
Mrinali Rao	afc9235f17	Update internal/cloud/backend_taskStages.go ... Co-authored-by: Glenn Sarti <glennsarti@users.noreply.github.com>	3 years ago
mrinalirao	3104811c7d	add test to see if override continues to poll on success	3 years ago
mrinalirao	190858b9e4	Bug Fix where CLI exits if run is not confirmable.	3 years ago
Sebastian Rivera	6d0a191ec4	Handle provisioner log types in renderer	3 years ago
Brandon Croft	26e85685d1	Merge pull request #32647 from hashicorp/TF-4390-backport-initial-remote-state-serial-fix ... Begin cloud remote state with serial > 0	3 years ago
Sebastian Rivera	71dac9bf5e	Add token field to cloud backend	3 years ago
Sebastian Rivera	de574ae6d4	Initial implementation of structured logging in cloud backend (#32504) ... * Implementation of structured logging. These are the changes that enable the cloud backend to consume structured logs and make use of the new plan renderer. This will enable CLI-driven runs to view the structured output in the Terraform Cloud UI. * Cloud structured logging unit tests * Remove deferred logs logic, fix minor issues Color formatting fixes, log type stop lists, default behavior for logs that are unknown * Use service disco path in redacted plan url	3 years ago