52 Commits (e2d73e78ad8a01dc486b23f90dc9bd1c8a09ba34)

Author	SHA1	Message	Date
James Bardin	756e889697	remove unused DependsOn usage in state	6 years ago
Kristin Laemmert	27a794062e	Mildwonkey/command tests (#24535) ... * command: refactor testBackendState to write states.State testBackendState was using the older terraform.State format, which is no longer sufficient for most tests since the state upgrader does not encode provider FQNs automatically. Users will run `terraform 0.13upgrade` to update their state to include provider FQNs in resources, but tests need to use the modern state format instead of relying on the automatic upgrade. * plan tests passing * graph tests passing * json packages test update * command test updates * update show test fixtures * state show tests passing	6 years ago
James Bardin	b3fc0dab94	use addrs.ConfigResource for dependency tracking ... We can't get module instances during transformation, so we need to reduce the Dependencies to using `addrs.ConfigResource` for now.	6 years ago
Kristin Laemmert	47a16b0937	addrs: embed Provider in AbsProviderConfig instead of Type ... a large refactor to addrs.AbsProviderConfig, embedding the addrs.Provider instead of a Type string. I've added and updated tests, added some Legacy functions to support older state formats and shims, and added a normalization step when reading v4 (current) state files (not the added tests under states/statefile/roundtrip which work with both current and legacy-style AbsProviderConfig strings). The remaining 'fixme' and 'todo' comments are mostly going to be addressed in a subsequent PR and involve looking up a given local provider config's FQN. This is fine for now as we are only working with default assumption.	6 years ago
James Bardin	886af20f07	fixup some test comparisons	6 years ago
James Bardin	2c3c011f20	change state dependencies to AbsResource addrs ... We need to be able to reference all possible dependencies for ordering when the configuration is no longer present, which means that absolute addresses must be used. Since this is only to recreate the proper ordering for instance destruction, only resources addresses need to be listed rather than individual instance addresses.	6 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
James Bardin	ac2219ba6e	don't lose Private state data during copy ... Fix the scope of the private data copy in DeepCopy. Make sure Dependencies matches nil vs empty so that Equal compares correctly between copied states	7 years ago
Sander van Harmelen	79a9a15879	command/state: lock when pushing state ... Next to adding the locking for the `state push` command, this commit also fixes a small bug where the lock would not be propertly released when running the `state show` command. And finally it renames some variables in the `[un]taint` code in order to try to standardize the var names of a few frequently used variables (e.g. statemgr.Full, states.State, states.SyncState).	7 years ago
Martin Atkins	5255e85238	"go fmt" fixups ... Apparently my editor is still not reliably formatting on save, so I missed a few formatting quirks in these files.	7 years ago
Martin Atkins	53b5b95ef5	command: Fix TestRefresh_backup ... The local filesystem state manager no longer creates backup files eagerly, instead creating them only if on first write there is already a snapshot present in the target file. Therefore for this test to exercise the codepaths it intends to we must create an initial state snapshot for it to overwrite, creating the backup in the process. There are several other tests for this behavior elsewhere, so this test is primarily to verify that the refresh command is configuring the backend appropriately to get the backups written in the desired location.	7 years ago
Martin Atkins	762a173c7f	command: Fix TestRefresh_outPath ... We now only create a backup state file if the given output file already exists, which it does not in this test. (The behavior of creating the backup files is already covered by other tests, so no need for this one go out of its way to do it.)	7 years ago
Martin Atkins	c05a556c0e	command: Fix TestRefresh_backup ... This test intentionally overrides the backup file location using the -backup option, so the backup file is not in the default location for this one.	7 years ago
Martin Atkins	40eda180d6	command: go fmt in import_test.go and refresh_test.go	7 years ago
Martin Atkins	89d0944e5b	command: Fix even more of the "terraform refresh" tests	7 years ago
Martin Atkins	e54848b86f	command: Fix many (but not all) "terraform refresh" tests	7 years ago
Martin Atkins	dc0b5292a6	command: Update refresh_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	7 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	7 years ago
James Bardin	e980156451	cleanup temp files from command tests ... Rather than try to modify all the hundreds of calls to the temp helper functions, and cleanup the temp files at every call site, have all tests work within a single temp directory that is removed at the end of TestMain.	8 years ago
James Bardin	3c807e5427	update state test strings in command package	8 years ago
James Bardin	36b8be43e8	use the new version package ... Update all references to the version values to use the new package. The VersionString function was left in the terraform package specifically for the aws provider, which is vendored. We can remove that last call once the provider is updated.	8 years ago
James Bardin	fb397060eb	add some Serial checks to apply and refresh tests	9 years ago
Martin Atkins	8364383c35	Push plugin discovery down into command package ... Previously we did plugin discovery in the main package, but as we move towards versioned plugins we need more information available in order to resolve plugins, so we move this responsibility into the command package itself. For the moment this is just preserving the existing behavior as long as there are only internal and unversioned plugins present. This is the final state for provisioners in 0.10, since we don't want to support versioned provisioners yet. For providers this is just a checkpoint along the way, since further work is required to apply version constraints from configuration and support additional plugin search directories. The automatic plugin discovery behavior is not desirable for tests because we want to mock the plugins there, so we add a new backdoor for the tests to use to skip the plugin discovery and just provide their own mock implementations. Most of this diff is thus noisy rework of the tests to use this new mechanism.	9 years ago
Mitchell Hashimoto	2be1f55cbb	backend/local: allow refresh on empty/non-existent state ... This allows a refresh on a non-existent or empty state file. We changed this in 0.9.0 to error which seemed reasonable but it turns out this complicates automation that runs refresh since it now needed to determine if the state file was empty before running. Its easier to just revert this into a warning with exit code zero. The reason this changed is because in 0.8.x and earlier, the output would be simply empty with exit code zero which seemed odd.	9 years ago
Mitchell Hashimoto	4c7c46bf40	command: fix test for new Meta type	9 years ago
James Bardin	ec00564be6	Clean up LockInfo and LockError and use them ... Gove LockInfo a Marshal method for easy serialization, and a String method for more readable output. Have the state.Locker implementations use LockError when possible to return LockInfo and an error.	9 years ago
James Bardin	b80ae5e13e	Add source path argument to testLockState ... The new test pattern is to chdir into a temp location for the test, but the prevents us from locating the testdata directory in the source. Add a source path to testLockState so we can find the statelocker.go source.	9 years ago
James Bardin	bd65ddbcaa	Add test for apply/refresh on locked state files ... Verify that these operations fail when a state file is locked.	9 years ago
Mitchell Hashimoto	ad7b063262	command: convert to use backends	9 years ago
Paul Hinze	84bbbfbe18	command: Fixup comment typo ... Hat tip to @Ninir :)	10 years ago
James Bardin	cdb80f68a8	Ensure better state normalization ... Fix checksum issue with remote state If we read a state file with "null" objects in a module and they become initialized to an empty map the state file may be written out with empty objects rather than "null", changing the checksum. If we can detect this, increment the serial number to prevent a conflict in atlas. Our fakeAtlas test server now needs to decode the state directly rather than using the ReadState function, so as to be able to read the state unaltered. The terraform.State data structures have initialization spread out throughout the package. More thoroughly initialize State during ReadState, and add a call to init() during WriteState as another normalization safeguard. Expose State.init through an exported Init() method, so that a new State can be completely realized outside of the terraform package. Additionally, the internal init now completely walks all internal state structures ensuring that all maps and slices are initialized. While it was mentioned before that the `init()` methods are problematic with too many call sites, expanding this out better exposes the entry points that will need to be refactored later for improved concurrency handling. The State structures had a mix of `omitempty` fields. Remove omitempty for all maps and slices as part of this normalization process. Make Lineage mandatory, which is now explicitly set in some tests.	10 years ago
Mitchell Hashimoto	35c87836b4	core: Add terraform_version to state ... This adds a field terraform_version to the state that represents the Terraform version that wrote that state. If Terraform encounters a state written by a future version, it will error. You must use at least the version that wrote that state. Internally we have fields to override this behavior (StateFutureAllowed), but I chose not to expose them as CLI flags, since the user can just modify the state directly. This is tricky, but should be tricky to represent the horrible disaster that can happen by enabling it. We didn't have to bump the state format version since the absense of the field means it was written by version "0.0.0" which will always be older. In effect though this change will always apply to version 2 of the state since it appears in 0.7 which bumped the version for other purposes.	10 years ago
James Nugent	a5e51f6dad	command/refresh: Fix import formats to prevent flapping	10 years ago
James Nugent	890e214c00	Add failing test replicating #4013	10 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Paul Hinze	ad680b1832	core: show outputs after `terraform refresh` ... closes #25	11 years ago
Mitchell Hashimoto	82e92e7024	command: fmt	12 years ago
Mitchell Hashimoto	91eb3c73fc	command: fix failing tests	12 years ago
Mitchell Hashimoto	15564b04a5	command: tests pass	12 years ago
Mitchell Hashimoto	cdad3036ae	command: closer to compiling	12 years ago
Mitchell Hashimoto	642fed0356	command: terraform.tfvars loaded by default if it exists	12 years ago
Armon Dadgar	16ef3f5733	command: Testing the -backup feature	12 years ago
Armon Dadgar	f26f432f4c	command/refresh: Testing backup option	12 years ago
Mitchell Hashimoto	7b4119027a	command: -var-file works	12 years ago
Mitchell Hashimoto	3534470ca3	command: -var flag works	12 years ago
Mitchell Hashimoto	3a851bece0	command: convert all to use the new Meta thing	12 years ago
Mitchell Hashimoto	ff75d15f51	command/refresh: better error message if bad state	12 years ago
Mitchell Hashimoto	9a6f1e594b	command/refresh: default state path, optional args	12 years ago
Mitchell Hashimoto	d3d45ca064	command: fix some issues with refresh, tests passing	12 years ago
Mitchell Hashimoto	a6ae7230d1	command: use new API	12 years ago