14 Commits (e2d73e78ad8a01dc486b23f90dc9bd1c8a09ba34)

Author	SHA1	Message	Date
Alisdair McDiarmid	b6739829e7	command: Fix 0.13upgrade to preserve more comments ... Previously, any comments inside the required provider configuration for a given provider would be wiped out upon rerunning the 0.13upgrade command. This commit attempts to preserve those comments if the existing entry is semantically equivalent to the entry we are about to write.	6 years ago
Kristin Laemmert	5450e8515d	command/013upgrade: detect builtin terraform provider (#25215) ... * command/013upgrade: detect builtin terraform provider	6 years ago
Masayuki Morita	ee913a1c87	command/0.13upgrade: make confirmation more user-friendly (#25142) ... I feel the current confirmation prompt for 0.13upgrade command is ambiguous what is expected. Actually, when I used it for the first time, I cancelled it by typing `y` instead of `yes`. I believe it would be great if the 0.13upgrade command tell us the expected value for confirmation like 0.12upgrade.	6 years ago
Alisdair McDiarmid	fbb966b97b	command: Fix 0.13upgrade usage	6 years ago
Masayuki Morita	f266956a5d	Add `-yes` flag to 0.13upgrade help message ... It seems to be implemented but not shown in help message. FYI: A help message for 0.12upgrade command on the 0.12 branch. https://github.com/hashicorp/terraform/blob/v0.12.26/command/012_config_upgrade.go#L235-L243	6 years ago
Kristin Laemmert	8d28d73de3	getproviders: add a registry-specific error and modify output when a ... provider is not found. Previously a user would see the following error even if terraform was only searching the local filesystem: "provider registry registry.terraform.io does not have a provider named ...." This PR adds a registry-specific error type and modifies the MultiSource installer to check for registry errors. It will return the registry-specific error message if there is one, but if not the error message will list all locations searched.	6 years ago
Alisdair McDiarmid	82ebbf9a23	command: Add prompt & confirmation to 0.13upgrade	6 years ago
Alisdair McDiarmid	1fdcbc4825	command: Fix 0.13upgrade bug with multiple blocks ... If a configuration had multiple blocks in the versions.tf file, it would be added to the `rewritePaths` list multiple times. We would then remove it from this slice, but only once, and so the output file would later be rewritten to remove the required providers block. This commit uses a set instead of a list to prevent this case, and adds a regression test.	6 years ago
Alisdair McDiarmid	e2be704d81	command: Extract reused hclwrite helper code	6 years ago
Alisdair McDiarmid	a740b739e0	command: Change 0.13upgrade default to versions.tf ... Instead of using providers.tf as the default output file for the upgrader, we now default to versions.tf. This means that if the configuration has no `required_providers` blocks at all, or has multiple, the provider version requirements will be stored in the versions.tf file. We now also update the versions.tf file to set a `required_version` attribute in the first `terraform` block, with value ">= 0.13". This is similar to the behaviour of the 0.12upgrade command, and signals that the configuration should not be used with older versions of Terraform.	6 years ago
Alisdair McDiarmid	01a3376ead	command: Check required_version before upgrading ... If a configuration has a version constraint which prevents use with Terraform 0.13, the upgrade command should exit before making any changes.	6 years ago
Alisdair McDiarmid	ae98bd12a7	command: Rework 0.13upgrade sub-command ... This commit implements most of the intended functionality of the upgrade command for rewriting configurations. For a given module, it makes a list of all providers in use. Then it attempts to detect the source address for providers without an explicit source. Once this step is complete, the tool rewrites the relevant configuration files. This results in a single "required_providers" block for the module, with a source for each provider. Any providers for which the source cannot be detected (for example, unofficial providers) will need a source to be defined by the user. The tool writes an explanatory comment to the configuration to help with this.	6 years ago
Alisdair McDiarmid	67203dade8	command: Simplify Meta.process helper method ... After some refactoring, this helper method had an unused argument (vars) and an always-nil error return value. This commit cleans this up.	6 years ago
Alisdair McDiarmid	3b0b29ef52	command: Add scaffold for 0.13upgrade command	6 years ago