115 Commits (e2b6ccad8a755fb9ea1b32fb71eec02216438111)

Author	SHA1	Message	Date
Mitchell Hashimoto	609219fc65	command/meta: validate config immediately ... * config: test for validating multi-vars (passes) * command/plan: test invalid run * command/meta: validate module on load	10 years ago
James Bardin	94674fe93c	Add a test load of a data source with count	10 years ago
Sander van Harmelen	47dd1ad153	Add wildcard (match all) support to ignore_changes (#8599)	10 years ago
Mitchell Hashimoto	706b2e2aea	Merge pull request #8482 from hashicorp/b-output-dup ... config: variable names and outputs must be unique	10 years ago
Mitchell Hashimoto	0fceeaaeb0	config: test for var uniqueness in overrides	10 years ago
Mitchell Hashimoto	8a3559560d	config: JSON resource keys with only one item load properly GH-5140 ... When a resource has only a single key set, the HCL parser treats that key as part of the overall set of object keys. This isn't valid since we expect resources to have exactly two keys. In this scenario, we have to "unwrap" the keys back into a set of objects.	10 years ago
Mitchell Hashimoto	fbf06e2a59	config: vars must be unique	10 years ago
Mitchell Hashimoto	099293b690	config: outputs must be unique	10 years ago
Mitchell Hashimoto	f4faf2274b	config: count can't be a SimpleVariable	10 years ago
Paul Hinze	ffa29090ec	core: Better error for dot indexing on user vars ... Dot indexing worked in the "regexps and strings" world of 0.6.x, but it no longer works on the 0.7 series w/ proper List / Map types. There is plenty of dot-indexed config out in the wild, so we need to do what we can to point users to the new syntax. Here is one place we can do it for user variables (`var.somemap`). We'll also need to address Resource Variables and Module Variables in a separate PR. This fixes the panic in #7103 - a proper error message is now returned.	10 years ago
James Nugent	01cd596c60	core: Fix detection of empty list/map defaults ... This commit changes config parsing from weak decoding lists and maps into []string and map[string]string respectively to decode into []interface{} and map[string]interface{} respectively. This is in order to take advantage of the work integrated in #7082 to defeat the backward compatibility features of the mapstructure library. Test coverage of loading empty variables and validating their default types against expectation.	10 years ago
Martin Atkins	860140074f	config: Data source loading ... This allows the config loader to read "data" blocks from the config and turn them into DataSource objects. This just reads the data from the config file. It doesn't validate the data nor do anything useful with it.	10 years ago
James Nugent	f49583d25a	core: support native list variables in config ... This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
Paul Hinze	567a9b9e06	config: remove missing equals test to fix build ... This is behavior that's covered in the parser now - and the error message is nicer to boot!	10 years ago
Paul Hinze	3f72837f4b	core: Make copies when creating destroy nodes ... Fixes an interpolation race that was occurring when a tainted destroy node and a primary destroy node both tried to interpolate a computed count in their config. Since they were sharing a pointer to the _same_ config, depending on how the race played out one of them could catch the config uninterpolated and would then throw a syntax error. The `Copy()` tree implemented for this fix can probably be used elsewhere - basically we should copy the config whenever we drop nodes into the graph - but for now I'm just applying it to the place that fixes this bug. Fixes #4982 - Includes a test covering that race condition.	10 years ago
James Nugent	cb6cb8b96a	core: Support explicit variable type declaration ... This commit adds support for declaring variable types in Terraform configuration. Historically, the type has been inferred from the default value, defaulting to string if no default was supplied. This has caused users to devise workarounds if they wanted to declare a map but provide values from a .tfvars file (for example). The new syntax adds the "type" key to variable blocks: ``` variable "i_am_a_string" { type = "string" } variable "i_am_a_map" { type = "map" } ``` This commit does _not_ extend the type system to include bools, integers or floats - the only two types available are maps and strings. Validation is performed if a default value is provided in order to ensure that the default value type matches the declared type. In the case that a type is not declared, the old logic is used for determining the type. This allows backwards compatiblity with previous Terraform configuration.	10 years ago
Paul Hinze	87a9701f91	config: validation error when output is missing value field ... Also lists out invalid keys in errmsg when they are present Closes #4398	10 years ago
Mitchell Hashimoto	99fbb91ba2	config: validate lifecycle keys [GH-4413]	10 years ago
Paul Hinze	b6626eed57	config: friendlier error message on resource arity mismatch ... closes #2072	11 years ago
James Nugent	5ea25363a1	Add regression test for #4069 ... This may be brittle as it makes use of .gitattributes to override the autocrlf setting in order to have an input file with Windows line endings across multiple platforms.	11 years ago
Paul Hinze	d90eb2d88e	config: test replicating #4079 ... Should help cover terraform against regression once https://github.com/hashicorp/hcl/pull/70 lands.	11 years ago
James Nugent	7f5f8d300d	Add failing test replicating #4065	11 years ago
Paul Hinze	afb5136ac2	Merge pull request #3986 from hashicorp/phinze/hcl-escaped-quotes ... config: test covering escaped quotes syntax error	11 years ago
Paul Hinze	15e7927009	config: test covering escaped quotes syntax error ... This was never intended to be valid syntax, but it worked in the old HCL parser, and we've found a decent number of examples of it in the wild. Fixed in https://github.com/hashicorp/hcl/pull/62 and we'll keep this test in Terraform to cover the behavior.	11 years ago
James Nugent	6ae3218f8a	Add failing tests for JSON configuration parsing ... Reproduces the issue reported by @svanharmelen in #3964.	11 years ago
James Nugent	f4164b5322	Add resource with heredoc to config load tests ... This test reproduces the issue which is likely the root cause of #3840. Test is currently failing with an "illegal character" message corresponding with the location of the heredoc, which is also seen in various acceptance tests for providers.	11 years ago
Rob Zienert	a1939e70f7	Adding ignore_changes lifecycle meta property	11 years ago
Mitchell Hashimoto	aa1e66c16c	config: parse lifecycle block with mapstructure for weak decode	11 years ago
Mitchell Hashimoto	cca4964552	config: error in validation if module has self variable	11 years ago
Mitchell Hashimoto	d0a6d78b97	config: test that resources reference good providers	11 years ago
Mitchell Hashimoto	8ee18e2e14	config: happy case test for multiple providers	11 years ago
Mitchell Hashimoto	a599d5f224	config: validate that a multi provider is only configured once each	11 years ago
Paul Hinze	975a96f271	core: protect against count.index in modules ... Modules should get a validation error just like outputs do. refs #1528	11 years ago
Paul Hinze	347690a73e	core: don't crash when count.index is used in the wrong context ... It's bad manners! :) Also adds a validation error up at the configuration layer so the user sees the case from #1528 as an error message. fixes #1528	11 years ago
Mitchell Hashimoto	fdded8ca14	config: allow atlas block	11 years ago
Radek Simko	f794f30b7d	Ignore hidden files per Unix conventions	11 years ago
Mitchell Hashimoto	965fe45b9e	config: self var validation	11 years ago
Mitchell Hashimoto	a31f2a276b	Merge pull request #1015 from hashicorp/b-depends-on-var ... config: depends on cannot contain interpolations [GH-985]	11 years ago
Mitchell Hashimoto	c14e84a657	config: validate provisioner splats can only reference others	11 years ago
Mitchell Hashimoto	f156d0d1bd	config: test we can ref splat of other resources	11 years ago
Mitchell Hashimoto	90a6a627ed	config: validate configuration doens't contain splats to ourselves	11 years ago
Mitchell Hashimoto	0e7b150c5b	config: depends on cannot contain interpolations [GH-985]	11 years ago
Mitchell Hashimoto	4bcf6cf6b2	config: bare splat variables should not be allowed in provisioners ... [GH-636]	11 years ago
Mitchell Hashimoto	91a3405e88	config: understand provisioner blocks in JSON [GH-807]	11 years ago
Mitchell Hashimoto	a2e40ad731	config: multi-variable access in slice validation fixed [GH-798]	11 years ago
Mitchell Hashimoto	d24082da1e	config: validate that module variables can go to ints, convert [GH-624]	12 years ago
Kushal Pisavadia	b40b7ce01a	Do not read temporary editor files, fixes #548 ... This fixes a bug where Terraform would error with the following: ``` Error loading config: Error reading /Users/rhenrichs/work/example/.#example.tf: open /Users/rhenrichs/work/example/.#example.tf: no such file or directory ``` The solution implemented here ignores the common emacs and vim temporary file formats. Note: the potential danger with merging this is that Terraform could quickly have requests to ignore other file formats.	12 years ago
Mitchell Hashimoto	4cb1ea6ae1	config: allow exact multi-resource references outside slices	12 years ago
Mitchell Hashimoto	7b48924532	config: validate that multi-variables are only used in slices	12 years ago
Mitchell Hashimoto	67d9188a29	config: validate module names are valid	12 years ago