28 Commits (e1590d0a70c084a47dbe5ec12db4f236d493defc)

Author	SHA1	Message	Date
James Bardin	52c0032aed	update provisioners for multiple processes ... The "internal" provisioners are still run in a separate process, and need to be updated to restart on each walk.	7 years ago
James Bardin	795161f615	update to start a new process for each plugin ... Modify the plugin factories to create a new plugin process for each individual plugin.	7 years ago
Martin Atkins	44bc7519a6	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	7 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	7 years ago
James Bardin	61c2be3e95	Merge pull request #16969 from hashicorp/jbardin/reset-plugin-dir ... allow init to reset -plugin-dir	8 years ago
James Bardin	dec2da1dda	Merge pull request #17044 from hashicorp/jbardin/plugin-dir-internal ... -plugin-dir short-circuits discovery of internal plugins	8 years ago
James Bardin	fe3aff91f3	missingPlugins should not return internal plugins ... Filter the internal plugins out beforehand, so we don't attempt to locate them at all during init.	8 years ago
James Bardin	ba84faf4e1	remove the plugin path only for an empty string ... To avoid breaking automation where plugin-path was assumed to be set permanently, only remove the plugin-path record if it was explicitly set to and empty string.	8 years ago
James Bardin	79e985366f	allow init to reset -plugin-dir ... Remove the recorded -plugin-dir during init if the flag is not provided.	8 years ago
Techcadia	e681907c50	[Add] Pathing and Override Output to DEBUG Command	8 years ago
Martin Atkins	d4ee58ce59	Re-integrate the "terraform" provider into the main binary ... As part of the 0.10 core/provider split we moved this provider, along with all the others, out into its own repository. In retrospect, the "terraform" provider doesn't really make sense to be separated since it's just a thin wrapper around some core code anyway, and so re-integrating it into core avoids the confusion that results when Terraform Core and the terraform provider have inconsistent versions of the backend code and dependencies. There is no good reason to use a different version of the backend code in the provider than in core, so this new "internal provider" mechanism is stricter than the old one: it's not possible to use an external build of this provider at all, and version constraints for it are rejected as a result. This provider is also run in-process rather than in a child process, since again it's just a very thin wrapper around code that's already running in Terraform core anyway, and so the process barrier between the two does not create enough advantage to warrant the additional complexity.	8 years ago
Martin Atkins	5c0670fdf4	command: allow callers to activate a plugin cache ... Here we add a new caller-settable field to command.Meta that activates a read-through cache directory for plugin installation.	9 years ago
James Bardin	54998933f5	load Meta.PluginOverrides in dicovery ... Make sure the override paths from the legacy rc file are loaded for discovery.	9 years ago
James Bardin	4893fcc24f	improve plugin error formatting ... Remove "checksum" from the error, and only indicate that the plugin has changed. Always show requested versions even if it's "any", and found versions of plugins.	9 years ago
James Bardin	103ab20b00	add required and found versions to error output ... Provide the user with feedback showing the version requirements and the versions found when there's is a plugin error	9 years ago
James Bardin	7a955f990c	make display plugin checksum error to user ... The error follows a generic message, so can be ignored by users who may not understand the implications.	9 years ago
James Bardin	be2069ac81	add -plugin-dir option ... The -plugin-dir option lets the user specify custom search paths for plugins. This overrides all other plugin search paths, and prevents the auto-installation of plugins. We also make sure that the availability of plugins is always checked during init, even if -get-plugins=false or -plugin-dir is set.	9 years ago
James Bardin	000e860706	Add plugin dir scaffolding ... add pluginDir to command.Meta, the flag to initialize it, and the methods to save and restore it.	9 years ago
James Bardin	f723270e3e	search the vendor directory for plugins ... The default location for users to manually add plugins will be ./terraform.d/plugins/	9 years ago
Martin Atkins	f753974bb3	plugin/discovery: Installer interface, and provider implementation ... Previously we had a "getProvider" function type used to implement plugin fetching. Here we replace that with an interface type, initially with just a "Get" function. For now this just simplifies the interface by allowing the target directory and protocol version to be members of the struct rather than passed as arguments. A later change will extend this interface to also include a method to purge unused plugins, so that upgrading frequently doesn't leave behind a trail of unused executable files.	9 years ago
James Bardin	fdbfc17fae	missing constraints passed erroniously ... ConstrainVersions was documented as returning nil, but it was instead returning an empty set. Use the Count() method to check for nil or empty. Add test to verify failed constraints will show up as missing.	9 years ago
Martin Atkins	032f71f1ff	command: produce provider lock file during "terraform init" ... Once we've installed the necessary plugins, we'll do one more walk of the available plugins and record the SHA256 hashes of all of the plugins we select in the provider lock file. The file we write here gets read when we're building ContextOpts to initialize the main terraform context, so any command that works with the context will then fail if any of the provider binaries change.	9 years ago
Martin Atkins	7d0a98af46	command: provider resolver to also check SHA256 constraints when set ... In addition to looking for matching versions, the caller can also optionally require a specific executable by its SHA256 digest.	9 years ago
James Bardin	66ebff90cd	move some more plugin search path logic to command ... Make less to change when we remove the old search path	9 years ago
James Bardin	2749946f5c	basic plugin getter ... Add discovery.GetProviders to fetch plugins from the relases site. This is an early version, with no tests, that only (probably) fetches plugins from the default location. The URLs are still subject to change, and since there are no plugin releases, it doesn't work at all yet.	9 years ago
Martin Atkins	7ca592ac06	core: use ResourceProviderResolver to resolve providers ... Previously the set of providers was fixed early on in the command package processing. In order to be version-aware we need to defer this work until later, so this interface exists so we can hold on to the possibly-many versions of plugins we have available and then later, once we've finished determining the provider dependencies, select the appropriate version of each provider to produce the final set of providers to use. This commit establishes the use of this new mechanism, and thus populates the provider factory map with only the providers that result from the dependency resolution process. This disables support for internal provider plugins, though the mechanisms for building and launching these are still here vestigially, to be cleaned up in a subsequent commit. This also adds a new awkward quirk to the "terraform import" workflow where one can't import a resource from a provider that isn't already mentioned (implicitly or explicitly) in config. We will do some UX work in subsequent commits to make this behavior better. This breaks many tests due to the change in interface, but to keep this particular diff reasonably easy to read the test fixes are split into a separate commit.	9 years ago
Martin Atkins	9b4f15c261	plugin: move Client function into plugin, from plugin/discovery ... Having this as a method of PluginMeta felt most natural, but unfortunately that means that discovery must depend on plugin and plugin in turn depends on core Terraform, thus making the discovery package hard to use without creating dependency cycles. To resolve this, we invert the dependency and make the plugin package be responsible for instantiating clients given a meta, using a top-level function.	9 years ago
Martin Atkins	8364383c35	Push plugin discovery down into command package ... Previously we did plugin discovery in the main package, but as we move towards versioned plugins we need more information available in order to resolve plugins, so we move this responsibility into the command package itself. For the moment this is just preserving the existing behavior as long as there are only internal and unversioned plugins present. This is the final state for provisioners in 0.10, since we don't want to support versioned provisioners yet. For providers this is just a checkpoint along the way, since further work is required to apply version constraints from configuration and support additional plugin search directories. The automatic plugin discovery behavior is not desirable for tests because we want to mock the plugins there, so we add a new backdoor for the tests to use to skip the plugin discovery and just provide their own mock implementations. Most of this diff is thus noisy rework of the tests to use this new mechanism.	9 years ago