15 Commits (e024960c745f0a464cb081d04765d93f94deaba0)

Author	SHA1	Message	Date
James Bardin	657932261b	Make sure shadow.closeWalker doesn't copy Mutexes ... The Close methods on shadow.Values require pointer receivers because they contain a sync.Mutex, but that value was being copied through Value.Interface by the closeWalker. Because reflectwalk passes the struct fields to the StructField method as they are defined in the struct, and they may have been read as a value, we can't immediately call Interface() to check the method set without possibly copying the internal mutex values. Use the Implements method to first check if we need to call Interface, and if it's not, then we can check if the value is addressable. Because of this use of reflection, we can't vet for the copying of these locks. The minimal amount of code in the Close method left us only with a race detected within the mutex itself, which leads to a stacktrace pointing to the runtime rather than our code.	9 years ago
James Bardin	c66dd48b6e	make shadow.Value a Locker ... This way it's correctly handled by CopyStructure	9 years ago
Mitchell Hashimoto	6557a3de18	helper/shadow: Close for auto-closing all values ... Fixes #10122 The simple fix was that we forgot to close `ReadDataApply` for the provider. But I've always felt that this section of the code was brittle and I wanted to put in a more robust solution. The `shadow.Close` method uses reflection to automatically close all values.	9 years ago
Mitchell Hashimoto	de827887bf	helper/shadow: keyedValue.WaitForChange must unlock	10 years ago
Mitchell Hashimoto	10bcdd04d4	helper/shadow: KeyedValue.Init	10 years ago
Mitchell Hashimoto	50e0647c53	helper/shadow: ComparedValue	10 years ago
Mitchell Hashimoto	c92ee5a8bd	helper/shadow: KeyedValue.WaitForChange returns immediately if closed	10 years ago
Mitchell Hashimoto	0408c2dfb2	helper/shadow: KeyedValue.WaitForChange	10 years ago
Mitchell Hashimoto	47f4343bf5	helper/shadow: KeyedValue add test case to avoid panic	10 years ago
Mitchell Hashimoto	136ac4728d	helper/shadow: KeyedValue.Close	10 years ago
Mitchell Hashimoto	d2fb630df8	helper/shadow: Value.Close	10 years ago
Mitchell Hashimoto	d6168edc50	helper/shadow: KeyedValue.ValueOk	10 years ago
Mitchell Hashimoto	bd69e41c14	helper/shadow: KeyedValue	10 years ago
Mitchell Hashimoto	8426cea6b0	helper/shadow: OrderedValue	10 years ago
Mitchell Hashimoto	1df3bbdc37	terraform: working on the resource provider shadow, not working yet	10 years ago