94 Commits (e024960c745f0a464cb081d04765d93f94deaba0)

Author	SHA1	Message	Date
Brian Flad	3d908f56aa	helper/schema: Add deprecation to ResourceData.UnsafeSetFieldRaw ... This functionality is no longer supported in Terraform 0.12 and above.	7 years ago
James Bardin	bc5eecd7f2	make sure id really gets set in SetId ... SetId needs to overwrite the newState as well, since the internal calls to DataSource.Id() will override the set attribute.	7 years ago
James Bardin	3112b707be	SetId should set the attribute as well ... The update protocol shims will also check for this this, but eventually "id" will only be a normal attribute, and we shouldn't have to special case this.	8 years ago
Sander van Harmelen	3e935c846f	terraform/terraform_remote_state: accept complex configs ... The `remote` backend config contains an attribute that is defined as a `*schema.Set`, but currently only `string` values are accepted as the `config` attribute is defined as a `schema.TypeMap`. Additionally the `b.Validate()` method wasn’t called to prevent a possible panic in case of unexpected configurations being passed to `b.Configure()`. This commit is a bit of a hack to be able to support this in the 0.11 series. The 0.12 series will have proper support, so when merging 0.12 this should be reverted again.	8 years ago
James Bardin	798df9dafa	make sure ResourceData timeouts are always set ... Return the global default timeout if the ResourceData timeouts are nil. Set the timeouts from the Resource when calling Resource.Data, so that the config values are always available.	8 years ago
Chris Marchesi	cb5ce1d35e	helper/schema: Extend diffChange and bubble up customized values ... This extends the internal diffChange method so that ResourceDiff's implementation of it can report back whether or not the value came from a customized diff. This is an effort to work to preserve the pre-ResourceDiff behaviour that ignores the diff for computed keys when the old value was populated but the new value wasn't - this behaviour is actually being depended on by users that are using it to exploit using zero values in modules. This should allow both scenarios to co-exist by shifting the NewComputed exemption over to exempting values that come from diff customization.	8 years ago
Radek Simko	e93d64b18c	helper/schema: Opt-in panic on invalid ResourceData.Set	8 years ago
Jake Champlin	268138dbd4	Rename to GetOkExists	9 years ago
Jake Champlin	270bbdb19b	core: Add `GetOkRaw` schema function ... Adds `GetOkRaw` as a schema function. This should only be used to verify boolean attributes are either set or not set, regardless of their zero value for their type. There are a few small use cases outside of the boolean type where this will be helpful as well. Overall, this shouldn't detract from the zero-value checks that `GetOK()` currently has, and should only be used when absolutely needed. However, there are enough use-cases for this addition without checking for the zero-value of the type, that this is needed. Primary use case is for a boolean attribute that is `Optional` and `Computed`, without a default value. There's currently no way to verify that the boolean attribute was explicitly set to the zero-value literal with the current `GetOk()` function. This new function allows for that check, keeping the `Computed` check for the returned `exists` boolean. ``` $ make test TEST=./helper/schema TESTARGS="-run=TestResourceDataGetOkRaw" ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/08/02 11:17:32 Generated command/internal_plugin_list.go go test -i ./helper/schema || exit 1 echo ./helper/schema | \ xargs -t -n4 go test -run=TestResourceDataGetOkRaw -timeout=60s -parallel=4 go test -run=TestResourceDataGetOkRaw -timeout=60s -parallel=4 ./helper/schema ok github.com/hashicorp/terraform/helper/schema 0.005s ```	9 years ago
Clint	2fe5976aec	helper/schema: Add configurable Timeouts (#12311) ... * helper/schema: Add custom Timeout block for resources * refactor DefaultTimeout to suuport multiple types. Load meta in Refresh from Instance State * update vpc but it probably wont last anyway * refactor test into table test for more cases * rename constant keys * refactor configdecode * remove VPC demo * remove comments * remove more comments * refactor some * rename timeKeys to timeoutKeys * remove note * documentation/resources: Document the Timeout block * document timeouts * have a test case that covers 'hours' * restore a System default timeout of 20 minutes, instead of 0 * restore system default timeout of 20 minutes, refactor tests, add test method to handle system default * rename timeout key constants * test applying timeout to state * refactor test * Add resource Diff test * clarify docs * update to use constants	9 years ago
Mitchell Hashimoto	3342aa580c	terraform: InstanceState.Meta is value type interface{} ... This changes the type of values in Meta for InstanceState to `interface{}`. They were `string` before. This will allow richer structures to be persisted to this without flatmapping them (down with flatmap!). The documentation clearly states that only primitives/collections are allowed here. The only thing using this was helper/schema for schema versioning. Appropriate type checking was added to make this change safe. The timeout work @catsby is doing will use this for a richer structure.	9 years ago
James Nugent	dbf725bd68	core: Allow dynamic attributes in helper/schema ... The helper/schema framework for building providers previously validated in all cases that each field being set in state was in the schema. However, in order to support remote state in a usable fashion, the need has arisen for the top level attributes of the resource to be created dynamically. In order to still be able to use helper/schema, this commit adds the capability to assign additional fields. Though I do not forsee this being used by providers other than remote state (and that eventually may move into Terraform Core rather than being a provider), the usage and semantics are: To opt into dynamic attributes, add a schema attribute named "__has_dynamic_attributes", and make it an optional string with no default value, in order that it does not appear in diffs: "__has_dynamic_attributes": { Type: schema.TypeString Optional: true } In the read callback, use the d.UnsafeSetFieldRaw(key, value) function to set the dynamic attributes. Note that other fields in the schema _are_ copied into state, and that the names of the schema fields cannot currently be used as dynamic attribute names, as we check to ensure a value is not already set for a given key.	10 years ago
Sander van Harmelen	8560f50cbc	Change taint behaviour to act as a normal resource ... This means it’s shown correctly in a plan and takes into account any actions that are dependant on the tainted resource and, vice verse, any actions that the tainted resource depends on. So this changes the behaviour from saying this resource is tainted so just forget about it and make sure it gets deleted in the background, to saying I want that resource to be recreated (taking into account the existing resource and it’s place in the graph).	10 years ago
Mitchell Hashimoto	b728e55861	helper/schema: Resource.Data should set latest schema version	10 years ago
Mitchell Hashimoto	1685054a9a	helper/schema: cleaner way to store Ephemeral	10 years ago
Radek Simko	4c6ceef9b8	helper/schema: Allow identification of a new resource in update func	10 years ago
Sander van Harmelen	ef4726bd50	Change Set internals and make (extreme) performance improvements ... Changing the Set internals makes a lot of sense as it saves doing conversions in multiple places and gives a central place to alter the key when a item is computed. This will have no side effects other then that the ordering is now based on strings instead on integers, so the order will be different. This will however have no effect on existing configs as these will use the individual codes/keys and not the ordering to determine if there is a diff or not. Lastly (but I think also most importantly) there is a fix in this PR that makes diffing sets extremely more performand. Before a full diff required reading the complete Set for every single parameter/attribute you wanted to diff, while now it only gets that specific parameter. We have a use case where we have a Set that has 18 parameters and the set consist of about 600 items (don't ask 😉). So when doing a diff it would take 100% CPU of all cores and stay that way for almost an hour before being able to complete the diff. Debugging this we learned that for retrieving every single parameter it made over 52.000 calls to `func (c *ResourceConfig) get(..)`. In this function a slice is created and used only for the duration of the call, so the time needed to create all needed slices and on the other hand the time the garbage collector needed to clean them up again caused the system to cripple itself. Next to that there are also some expensive reflect calls in this function which also claimed a fair amount of CPU time. After this fix the number of calls needed to get a single parameter dropped from 52.000+ to only 2! 😃	10 years ago
Mitchell Hashimoto	58a8776c41	helper/schema: test real nil pointer to ResourceData.Set	11 years ago
Mitchell Hashimoto	c030148259	helper/schema: allow pointer values to ResourceData.Set	11 years ago
Mitchell Hashimoto	7d32c8946a	helper/schema: GetOk now only returns true if set to non-zero value	11 years ago
Mitchell Hashimoto	e04def93e6	Merge pull request #991 from hashicorp/b-autoscale-lc-update ... providers/aws: allow in-place update of launch configuration	11 years ago
Mitchell Hashimoto	5a64d0900b	providers/aws: test for allowing in-place lC update	11 years ago
Mitchell Hashimoto	66f7731995	helper/schema: GetChange shouldn't return true when no change	11 years ago
Mitchell Hashimoto	2212d6895d	helper/schema: diff with set going to 0 elements removes it from state	11 years ago
Mitchell Hashimoto	87948b68fc	helper/schema: use interface for equality check ... /cc @svanharmelen	11 years ago
Sander van Harmelen	c7550595a3	Fixing two related bugs in HasChange and GetChange ... This was actually quite nasty as the first bug covered the second one… The first bug is with HasChange. This function uses reflect.DeepEqual to check if two instances are the same/have the same content. This works fine for all types except for Set’s as they contain a function. And reflect.DeepEqual will only say the functions are equal if they are both nil (which they aren’t in a Set). So in effect it means that currently HasChange will always say true for Set’s, even when they are actually being equal. As soon as you fix this problem, you will notice the second one (which the added test is written for). Without saying you want the exact diff, you will end up with a merged value which will (in most cases) be the same. Run all unit tests and a good part of the acc tests to verify this works as expected and all look good.	11 years ago
Mitchell Hashimoto	4d067f4d6d	helper/schema: don't put things into the state that don't exist or are ... computed [GH-805]	11 years ago
Mitchell Hashimoto	db02541d31	helper/schema: fix failing tests ... /cc @svanharmelen - I think some logic changed after my refactor. I now return Exists: true when Computed: true but the value might be blank to note that the FieldReader FOUND a value, its just unknown. I think before it didn't do that so the logic for GetOk has to be "does it exist and is it _not_ computed" Seems weird because I just realized there is no way to get the OLD value of something if it is being computed now, but I looked and there are tests that verify this and they're like... test #5 of Get. So, they're not new meaning that must've been expected behavior? Hm. Let me know if you find any other issues from acceptance tests	11 years ago
Mitchell Hashimoto	3cbcafe989	helper/schema: remove unused field	11 years ago
Mitchell Hashimoto	9ab128899a	helper/schema: make the getSource enum easier	11 years ago
Mitchell Hashimoto	d89446391a	helper/schema: make the get API cleaner	11 years ago
Mitchell Hashimoto	3c1b55a75f	helper/schema: use the field reader/writer for state	11 years ago
Mitchell Hashimoto	e77b2b17c4	helper/schema: remove unused method	11 years ago
Mitchell Hashimoto	03c6453a72	helper/schema: FieldWriter, replace Set	11 years ago
Mitchell Hashimoto	e57f3f69b1	helper/schema: empty maps, support reading objects directly	11 years ago
Mitchell Hashimoto	f0af1c36f5	helper/schema: nested resource fields should be zero-valued on get	11 years ago
Mitchell Hashimoto	942a988ac2	helper/schema: zero value of a set should be a set	11 years ago
Mitchell Hashimoto	b4bf813151	helper/schema: too big to fail	11 years ago
Sander van Harmelen	40fa6c3aaa	Fixed a type and reordered the case statements ... Making in more inline with the existing code…	11 years ago
Sander van Harmelen	83c760fcb3	core: refactoring the way sets work internally v2 ... This is a refactored solution for PR #616. Functionally this is still the same change, but it’s implemented a lot cleaner with less code and less changes to existing parts of TF.	11 years ago
Mitchell Hashimoto	61811fce23	helper/schema: remove debug info	12 years ago
Mitchell Hashimoto	f63a5d24e9	helper/schema: diffs for sets should include the full set [GH-457] ... Prior to this, the diff only contained changed set elements. The issue with this is that `getSet`, the internal function that reads a set from the ResourceData, expects that each level (state, config, diff, etc.) has the _full set_ information. This change was done to fix merging issues. Because of this, we need to make sure the full set is visible in the diff.	12 years ago
Mitchell Hashimoto	d1324678dd	helper/schema: setting empty map works [GH-464]	12 years ago
Mitchell Hashimoto	17d1bb7dde	Revert "Merge pull request #422 from svanharmelen/f-shaving-off-some-cpu-cycles" ... This reverts commit 428cce2478, reversing changes made to 517c5b2ea8.	12 years ago
Mitchell Hashimoto	428cce2478	Merge pull request #422 from svanharmelen/f-shaving-off-some-cpu-cycles ... helper/schema: Shaving off some unneeded calls, saving CPU cycles	12 years ago
Mitchell Hashimoto	5390357e45	helper/schema: sets properly take into account the diff	12 years ago
Sander van Harmelen	e003334429	Shaving off some unneeded calls, saving CPU cycles ... I know it’s very unlikely that a user will notice the difference, but why range through the list, generate the set and calculate the hashcode, only to find out that indexMap == nil (e.g. don’t do anything with the generated hashcode). As indexMap is only needed when len(parts) > 0, why not only create and fill it (in one go) when len(parts) > 0?	12 years ago
Mitchell Hashimoto	59349cca11	helper/schema: sets must be treated atomically within ResourceData ... This fixes a seemingly minor issue (GH-255) around plans showing changes when in fact there are none. But in reality this turned out to uncover a really terrible bug. The effect of what was happening was that multiple items in a set were being merged. Now, they were being merged in the right order, so if you didn't have rich types (lists in a set) then you never saw the effect since the later value would overwrite the earlier. But with lists (such as in security groups), you would end up with the lists merging. So, if you had one ingress rule with CIDR blocks and one with SGs, then after the merge both ingress rules would have BOTH CIDR and SGs, resulting in an incorrect plan (GH-255). This fixes the issue by introducing a `getSourceExact` bitflag to the ResourceData source. When this is set, ALL data must come from this level, instead of merging lower levels. In the case of sets and diffs, this is exactly what you want: "Get me the set 'foo' from the config and the config ONLY (not the state or diff or w/e)". Andddddd its fixed. GH-255	12 years ago
Mitchell Hashimoto	3a107d2e50	helper/schema: set the field to empty if it is a list and computed	12 years ago
Mitchell Hashimoto	e5d64318bf	helper/schema: don't say that a set is computed if it exists	12 years ago