terraform

Commit Graph

Author	SHA1	Message	Date
James McGill	035d56409f	helper/schema: handle TypeMap elem consistently with other collection types For historical reasons, the handling of element types for maps is inconsistent with other collection types. Here we begin a multi-step process to make it consistent, starting by supporting both the "consistent" form of using a schema.Schema and an existing erroneous form of using a schema.Type directly. In subsequent commits we will phase out the erroneous form and require the schema.Schema approach, the same as we do for TypeList and TypeSet.	8 years ago
James Bardin	c4eefd4b5e	Allow primitive type in maps via all FieldReaders Now that we can read primitive type out of a map, each field reader needs to be able to set the proper type as expected.	9 years ago
Justin Marney	895d10a627	Use DeepEqual instead of multiple if statements to reduce noise.	10 years ago
Justin Marney	53e10dfa89	Name test appropriately.	10 years ago
Justin Marney	9217f5a063	Unchanged NestedSets are not returned by DiffFieldReader.	10 years ago
Clint	a84aa5e914	Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436 )	10 years ago
Radek Simko	378b526dc3	helper/schema: Add regression tests for nested Set/List Although DiffFieldReader was the one mostly responsible for a buggy behaviour more tests were added throughout the debugging process most of which would fail without the bugfix. - ResourceData - MultiLevelFieldReader - MapFieldReader - DiffFieldReader	10 years ago
James Nugent	074545e536	core: Use .% instead of .# for maps in state The flatmapped representation of state prior to this commit encoded maps and lists (and therefore by extension, sets) with a key corresponding to the number of elements, or the unknown variable indicator under a .# key and then individual items. For example, the list ["a", "b", "c"] would have been encoded as: listname.# = 3 listname.0 = "a" listname.1 = "b" listname.2 = "c" And the map {"key1": "value1", "key2", "value2"} would have been encoded as: mapname.# = 2 mapname.key1 = "value1" mapname.key2 = "value2" Sets use the hash code as the key - for example a set with a (fictional) hashcode calculation may look like: setname.# = 2 setname.12312512 = "value1" setname.56345233 = "value2" Prior to the work done to extend the type system, this was sufficient since the internal representation of these was effectively the same. However, following the separation of maps and lists into distinct first-class types, this encoding presents a problem: given a state file, it is impossible to tell the encoding of an empty list and an empty map apart. This presents problems for the type checker during interpolation, as many interpolation functions will operate on only one of these two structures. This commit therefore changes the representation in state of maps to use a "%" as the key for the number of elements. Consequently the map above will now be encoded as: mapname.% = 2 mapname.key1 = "value1" mapname.key2 = "value2" This has the effect of an empty list (or set) now being encoded as: listname.# = 0 And an empty map now being encoded as: mapname.% = 0 Therefore we can eliminate some nasty guessing logic from the resource variable supplier for interpolation, at the cost of having to migrate state up front (to follow in a subsequent commit). In order to reduce the number of potential situations in which resources would be "forced new", we continue to accept "#" as the count key when reading maps via helper/schema. There is no situation under which we can allow "#" as an actual map key in any case, as it would not be distinguishable from a list or set in state.	10 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Mitchell Hashimoto	2212d6895d	helper/schema: diff with set going to 0 elements removes it from state	11 years ago
Paul Hinze	219aa3e788	helper/schema: fix DiffFieldReader map handling An `InstanceDiff` will include `ResourceAttrDiff` entries for the "length" / `#` field of maps. This makes sense, since for something like `terraform plan` it's useful to see when counts are changing. The `DiffFieldReader` was not taking these entries into account when reading maps out, and was therefore incorrectly returning maps that included an extra `'#'` field, which was causing all sorts of havoc for providers (extra tags on AWS instances, broken google compute instance launch, possibly others). * fixes #914 - extra tags on AWS instances * fixes #883 - general core issue sprouted from #757 * removes the hack+TODO from #757	11 years ago
Mitchell Hashimoto	1fcd24cf67	helper/schema: add float type	11 years ago
Mitchell Hashimoto	361d00347a	helper/schema: refactor tests for fieldreader to be common	11 years ago
Mitchell Hashimoto	b4bf813151	helper/schema: too big to fail	11 years ago
Mitchell Hashimoto	7e379cb1a1	helper/schema: field readers no longer take a schema as arg	11 years ago
Mitchell Hashimoto	0b1da37b20	helper/schema: diff field reader should merge result with source	11 years ago
Mitchell Hashimoto	91a57b42e8	helper/schema: reading a diff with computed should return zero value	11 years ago
Mitchell Hashimoto	73726e83b2	helper/schema: DiffFieldReader for reading data from a diff	11 years ago

18 Commits (e024960c745f0a464cb081d04765d93f94deaba0)