terraform

Commit Graph

Author	SHA1	Message	Date
James McGill	035d56409f	helper/schema: handle TypeMap elem consistently with other collection types For historical reasons, the handling of element types for maps is inconsistent with other collection types. Here we begin a multi-step process to make it consistent, starting by supporting both the "consistent" form of using a schema.Schema and an existing erroneous form of using a schema.Type directly. In subsequent commits we will phase out the erroneous form and require the schema.Schema approach, the same as we do for TypeList and TypeSet.	8 years ago
James Bardin	01be1a5ecd	Check for interpolated values when reading a map Accessing an interpolated value in a map through ConfigFieldReader can fail, because GetRaw can't access interpolated values, so check if the value exists at all by looking in the config. If the config has a value, assume our map's value is interpolated and proceed as such. We also need to lookup the correct schema to properly read a field from a nested structure. - Maps previously always defaulted to TypeString. Now check if Elem is a ValueType and use that if applicable - Lists now return the schema for nested element types, defaulting to a TypeString like maps. This only allows maps and lists to be nested one level deep, and the inner map or list must only contain string values.	10 years ago
James Bardin	c4eefd4b5e	Allow primitive type in maps via all FieldReaders Now that we can read primitive type out of a map, each field reader needs to be able to set the proper type as expected.	10 years ago
Mitchell Hashimoto	15f50b86bf	helper/schema: passing tests for computed complex sets	10 years ago
Mitchell Hashimoto	29485f6167	terraform: ResourceConfig.IsComputed cases	10 years ago
Mitchell Hashimoto	7834cf7190	helper/schema: computed bool fields should not crash Fixes #7715 If a bool field was computed and the raw value was not convertable to a boolean, helper/schema would crash. The correct behavior is to try not to read the raw value when the value is computed and to simply mark that it is computed. This does that (and matches the behavior of the other primitives).	10 years ago
James Nugent	7b6df27e4a	helper/schema: Read native maps from configuration This adds a test and the support necessary to read from native maps passed as variables via interpolation - for example: ``` resource ...... { mapValue = "${var.map}" } ``` We also add support for interpolating maps from the flat-mapped resource config, which is necessary to support assignment of computed maps, which is now valid. Unfortunately there is no good way to distinguish between a list and a map in the flatmap. In lieu of changing that representation (which is risky), we assume that if all the keys are numeric, this is intended to be a list, and if not it is intended to be a map. This does preclude maps which have purely numeric keys, which should be noted as a backwards compatibility concern.	10 years ago
James Nugent	f49583d25a	core: support native list variables in config This commit adds support for native list variables and outputs, building up on the previous change to state. Interpolation functions now return native lists in preference to StringList. List variables are defined like this: variable "test" { # This can also be inferred type = "list" default = ["Hello", "World"] } output "test_out" { value = "${var.a_list}" } This results in the following state: ``` ... "outputs": { "test_out": [ "hello", "world" ] }, ... ``` And the result of terraform output is as follows: ``` $ terraform output test_out = [ hello world ] ``` Using the output name, an xargs-friendly representation is output: ``` $ terraform output test_out hello world ``` The output command also supports indexing into the list (with appropriate range checking and no wrapping): ``` $ terraform output test_out 1 world ``` Along with maps, list outputs from one module may be passed as variables into another, removing the need for the `join(",", var.list_as_string)` and `split(",", var.list_as_string)` which was previously necessary in Terraform configuration. This commit also updates the tests and implementations of built-in interpolation functions to take and return native lists where appropriate. A backwards compatibility note: previously the concat interpolation function was capable of concatenating either strings or lists. The strings use case was deprectated a long time ago but still remained. Because we cannot return `ast.TypeAny` from an interpolation function, this use case is no longer supported for strings - `concat` is only capable of concatenating lists. This should not be a huge issue - the type checker picks up incorrect parameters, and the native HIL string concatenation - or the `join` function - can be used to replicate the missing behaviour.	10 years ago
Trevor Pounds	0cd0ff0f8e	Use built-in schema.HashString.	10 years ago
Mitchell Hashimoto	4576eaa966	helper/schema: replace config/lang	10 years ago
Sander van Harmelen	ef4726bd50	Change Set internals and make (extreme) performance improvements Changing the Set internals makes a lot of sense as it saves doing conversions in multiple places and gives a central place to alter the key when a item is computed. This will have no side effects other then that the ordering is now based on strings instead on integers, so the order will be different. This will however have no effect on existing configs as these will use the individual codes/keys and not the ordering to determine if there is a diff or not. Lastly (but I think also most importantly) there is a fix in this PR that makes diffing sets extremely more performand. Before a full diff required reading the complete Set for every single parameter/attribute you wanted to diff, while now it only gets that specific parameter. We have a use case where we have a Set that has 18 parameters and the set consist of about 600 items (don't ask 😉). So when doing a diff it would take 100% CPU of all cores and stay that way for almost an hour before being able to complete the diff. Debugging this we learned that for retrieving every single parameter it made over 52.000 calls to `func (c *ResourceConfig) get(..)`. In this function a slice is created and used only for the duration of the call, so the time needed to create all needed slices and on the other hand the time the garbage collector needed to clean them up again caused the system to cripple itself. Next to that there are also some expensive reflect calls in this function which also claimed a fair amount of CPU time. After this fix the number of calls needed to get a single parameter dropped from 52.000+ to only 2! 😃	11 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Mitchell Hashimoto	fa934d96d0	helper/schema: FieldReaderConfig detects computed maps	11 years ago
Mitchell Hashimoto	2feaebdca5	config: substring containing computed value replaces element	11 years ago
Paul Hinze	5d4e69cc80	helper/schema: apply schema defaults at the field level when reading from config We were waiting until the higher-level (m schemaMap) diffString method to apply defaults, which was messing with set hashcode evaluation for cases when a field with a default is included in the hash function. fixes #824	11 years ago
Mitchell Hashimoto	1fcd24cf67	helper/schema: add float type	11 years ago
Mitchell Hashimoto	361d00347a	helper/schema: refactor tests for fieldreader to be common	11 years ago
Mitchell Hashimoto	b4bf813151	helper/schema: too big to fail	11 years ago
Mitchell Hashimoto	7e379cb1a1	helper/schema: field readers no longer take a schema as arg	11 years ago
Mitchell Hashimoto	73726e83b2	helper/schema: DiffFieldReader for reading data from a diff	11 years ago
Mitchell Hashimoto	9447973015	helper/schema: ConfigFieldReader and generic helpers	11 years ago

21 Commits (e024960c745f0a464cb081d04765d93f94deaba0)