34 Commits (e024960c745f0a464cb081d04765d93f94deaba0)

Author	SHA1	Message	Date
James Bardin	c02f1d7256	allow 0 and unset to be equal in count tests ... This was changed in the single attribute test cases, but the AttrPair test is used a lot for data source. As far as tests are concerned, 0 and unset should be treated equally for flatmapped collections.	7 years ago
Martin Atkins	4c99864dad	helper/resource: TestCheckResourceAttrPair allow nonexist ... This checking helper is frequently used in provider tests for data sources, as a shorthand to verify that an attribute of the data source matches with the corresponding attribute on a managed resource. Since we now leave empty collections null in more cases, this function is sometimes effectively asked to verify that a given attribute is _unset_ in both the data source and the resource, so here we slightly adjust the definition of the check to consider two nulls to be equal to one another, which at this layer manifests as the keys not being present in the state attributes map at all. This check function didn't previously have tests, so this commit also adds a basic suite of tests, including coverage for the new behavior.	7 years ago
James Bardin	7973872524	allow TestCheckNoResourceAttr for empty containers ... Stricter type handling in the new shims may add empty containers into the state where they were previously elided. Since the detection of missing and empty containers in the legacy state was never reliable, allow TestCheckNoResourceAttr to succeed if the key is a container count index, and the value is "0"	7 years ago
James Bardin	c63040c737	have TestCheckResourceAttr accept missing counts ... Missing containers were often erroneously kept in the state, but since the addition of the new provider shims, they can often be correctly eliminated. There are however many tests that check for a "0" count in the flatmap state when there shouldn't be a key at all. This addition looks for a container count key and "0" pair, and allows for the key to be missing. There may be some tests negatively effected by this which were legitimately checking for empty containers, but those were also not reliably detected, and there should be much fewer tests involved.	7 years ago
Martin Atkins	cdad78d69b	helper/resource: Allow multiple providers in a single TestCase ... Due to incorrect use of a loop iterator variable inside a closure, all of the given providers were ending up with the same factory function. Now we copy the factory function to a local within the loop first so that each iteration has its own variable. This is the second round of similar bugs in this function, so we'll also add a test case for it to reduce the risk of future regressions given that most real callers don't exercise this with multiple providers in practice.	7 years ago
James Bardin	a5ef403dfd	skip resource tests for now ... These aren't going to be fixed in the immediate future, and are preventing the CI tests from being helpful.	7 years ago
James Bardin	1ab96f42b7	fail nonfunctional resource tests ... The helper/resource unit tests will panic, because they were using the legacy terraform.MockResourceProvider, which doesn't have the same internals required by the new GRPC shims. Fail these tests for now, and a new test provider will need to be made out of a schema.Provider instance.	8 years ago
Brian Flad	798162125b	helper/resource: Add ParallelTest() function to allow opt-in acceptance testing concurrency with t.Parallel() ... While this initial implementation is a very simple wrapper function, implementing this in the helper/resource package provides some downstream benefits: * Provides a standard interface for plugin developers to enable parallel acceptance testing * Existing plugins can simply convert resource.Test to resource.ParallelTest references (as appropriate) to enable the functionality, rather than worrying about additional line(s) to each acceptance test function or TestCase * Potential enhancements to ParallelTest (e.g. adding an environment variable to skip enabling the behavior) are consistently propagated	8 years ago
Chris Marchesi	3505769600	helper/resource: Add ability to pre-taint resources ... This adds the Taint field to the acceptance testing framework, allowing the ability to pre-taint resources at the beginning of a particular TestStep. This can be useful for when an explicit ForceNew is required for a specific resource for troubleshooting things like diff mismatches, etc. The field accepts resource addresses as a list of strings. To keep things simple for the time being, only addresses in the root module are accepted. If we ever want to expand this past that, I'd be almost inclined to add some facilities to the core terraform package to help translate actual module resource addresses (ie: module.foo.module.bar.some_resource.baz) into the correct state, versus the current convention in some acceptance testing facilities that take the module address as a list of strings (ie: []string{"root", "foo", "bar"}).	8 years ago
Chris Marchesi	3f8dad30c9	helper/resource: Fail tests with no error that have ExpectError set ... Looks like while we were checking errors correctly when ExpectError was set, we weren't checking for the *absence* of an error, which is should be checked as well (no error is still not the error we are looking for). Added a few more tests for ExpectError as well.	8 years ago
Radek Simko	4052a8f956	helper: Allow logs isolation per acceptance test	9 years ago
Radek Simko	db97555e3e	helper/resource: Add TestStep.SkipFunc	9 years ago
Martin Atkins	0573ff6793	helper/resource: pass config when testing import ... Previously having a config was mutually exclusive with running an import, but we need to provide a config so that the provider is declared, or else we can't actually complete the import in the future world where providers are installed dynamically based on their declarations.	9 years ago
Clint	372a80bc42	provider/aws: Add Sweeper setup, Sweepers for DB Option Group, Key Pair (#14773) ... * provider/aws: Add Sweeper setup, Sweepers for DB Option Group, Key Pair * provider/google: Add sweeper for any leaked databases * more recursion and added LC sweeper, to test out the Dependency path * implement a dependency example * implement sweep-run flag to filter runs * stub a test for TestMain * test for multiple -sweep-run list	9 years ago
clint shryock	61355c33c5	testing: Add option to run only a plan on a TestStep configuration	9 years ago
James Bardin	5238f51dc7	move TestReset mock from terraform to helper ... the terraform package doesn't know about TestProvider, so don't put the hooks in terraform.MockResourceProvider. Wrap the mock in the test where we need to check the TestProvider functionality.	9 years ago
James Bardin	4b2e96b2e2	test for TestReset and fixed resource factories	9 years ago
James Nugent	b551981cc7	testing: Add ComposeAggregateTestFunc ... This commit adds a function which composes a series of TestFuncs, but will run all tests before returning an error, unlike ComposeTestFunc. This is useful when verifying contents of state in acceptance tests and it is desirable to see all the failing cases in one run for slow resources.	10 years ago
Mitchell Hashimoto	e0da21d381	helper/resource: make id-only check opt-in ... As I've been working through the resources, I'm finding that a lot are going to need some serious work. Given we have hundreds, I think it might be prudent to make this opt-in for now and we can revisit automatic/opt-out at some future point. Importability will likely be opt-in it appears so this will match up with that.	10 years ago
Mitchell Hashimoto	0c8b0bff2c	helper/resource: can specify specific name to id refresh test	10 years ago
Mitchell Hashimoto	1a9fae6b2e	helper/resource: can disable ID refresh check	10 years ago
Mitchell Hashimoto	f2c4f8e9ba	helper/resource: fix tests	10 years ago
Mitchell Hashimoto	86e0c853db	helper/resource: test for failing id-only refresh check	10 years ago
Mitchell Hashimoto	4f6edf4fe4	helper/resource: id-only refresh testing	10 years ago
Paul Hinze	24048b4dca	providers: Mention check number when acctest fails	10 years ago
Paul Hinze	88744d569f	helper/resource/testing: unit tests to cover #1770 ... Also clarified that final return value of testStep is now only for the happy path.	11 years ago
Paul Hinze	149e52ad1f	helper/resource: verify refresh+plan after each step ... I forgot to add `Computed: true` when I made the "key_name" field optional in #1751. This made the behavior: * Name generated in Create and set as ID * Follow up plan (without refresh) was nice and empty * During refresh, name gets cleared out on Read, causing a bad diff on subsequent plans We can automatically catch bugs like this if we add yet another verification step to our resource acceptance tests -> a post Refresh+Plan that we verify is empty. I left the non-refresh Plan verification in, because it's important that _both_ of these are empty after an Apply.	11 years ago
Paul Hinze	7fe34d4547	providers: check for empty plan after each test step ... Each acceptance test step plays a Refresh, Plan, Apply for a given config. This adds a follow up Plan and fails the test if it does not come back empty. This will catch issues with perpetual, unresolvable diffs that crop up here and there. This is going to cause a lot of our existing acceptance tests to fail - too many to roll into a single PR. I think the best plan is to land this in master and then fix the failures (each of which should be catching a legitimate provider bug) one by one until we get the provider suites back to green.	11 years ago
Mitchell Hashimoto	9b2b3a963f	ResourceDiff => InstanceDiff	12 years ago
Mitchell Hashimoto	0bcbccf046	helper/resource: compiles, fails because Context doesn't work, probably	12 years ago
Mitchell Hashimoto	4a3d51f40e	helper/resource: can compose TestCheckFuncs	12 years ago
Mitchell Hashimoto	83f73e63aa	helper/resource: add PreCheck	12 years ago
Mitchell Hashimoto	55c1bf7f79	helper/resource: more tests	12 years ago
Mitchell Hashimoto	e0fbd48afd	helper/resource: Acceptance test framework	12 years ago