7891 Commits (e024960c745f0a464cb081d04765d93f94deaba0)

Author	SHA1	Message	Date
James Bardin	8b9fa6d05f	add test provider coverage around unknown vals	7 years ago
Martin Atkins	87786484ea	lang/eval: Apply attr-as-nested-block fixup in EvalBlock ... For any block content we evaluate dynamically via this API, we'll make a special allowance for users to optionally write members of a list attribute instead as a sequence of nested blocks, thus allowing some existing provider features that were assuming this capability to continue to support it after v0.12. This should not be used for any new provider features, and should ideally be eventually phased out so that there aren't two similar-but-slightly-different syntaxes for saying the same thing.	7 years ago
Martin Atkins	135121562e	helper/plugin: Implement Schema.SkipCoreTypeCheck ... The previous commit added this flag but did not implement it. Here we implement it by adjusting the shape of schema we return to Terraform Core to mark the attribute as untyped and then ensure that gets handled correctly on the SDK side.	7 years ago
Martin Atkins	1987a92386	helper/schema: Implementation of the AsSingle mechanism ... The previous commit added a new flag to schema.Schema which is documented to make a list with MaxItems: 1 be presented to Terraform Core as a single value instead, giving a way to switch to non-list nested resources without it being a breaking change for Terraform v0.11 users as long as it's done prior to a provider's first v0.12-compatible release. This is the implementation of that mechanism. It's intentionally implemented as a suite of extra fixups rather than direct modifications to existing shim code because we want to ensure that this has no effect whatsoever on the result of a resource type that _isn't_ using AsSingle. Although there is some small unit test coverage of the fixup steps here, the primary testing for this is in the test provider since the integration of all of these fixup steps in the correct order is the more important result than any of the intermediate fixup steps.	7 years ago
James Bardin	4006c0fc84	add test for set value drift ... The changed value for the set attribute should be correctly read from the provider.	7 years ago
James Bardin	6ecf9b143b	we can normalize nulls in Read again ... This should be the final change from removing the flatmap normalization. Since we're no longer trying to a consistent zero or null value in the flatmap config, rather we're trying to maintain the previously applied value, ReadResource also needs to apply the normalizeNullValues step in order to prevent unexpected diffs.	7 years ago
James Bardin	4c23e990e2	add test for complex schema diff apply ... This schema was taken from an actual google resource which often shows perpetual diffs.	7 years ago
Martin Atkins	4de0b33097	helper/schema: Honor ConfigMode when building core schema ... This makes some slight adjustments to the shape of the schema we present to Terraform Core without affecting how it is consumed by the SDK and thus the provider. This mechanism is designed specifically to avoid changing how the schema is interpreted by the SDK itself or by the provider, so that prior behavior can be preserved in Terraform v0.11 mode. This also includes a new rule that Computed-only (i.e. not also Optional) schemas _always_ map to attributes, because that is a better mapping of the intent: they are object values to be used in expressions. Nested blocks conceptually represent nested objects that are in some sense independent of what they are embedded in, and so they cannot themselves be computed.	7 years ago
James Bardin	9d4bb6ec14	stop removing empty flatmap containers ... As we've improved the cty.Value normalization, we need to remove normalization procedures from the flatmap handling. Keeping the empty containers in the flatmap will prevent unexpected nils from being added to some schema configurations	7 years ago
James Bardin	3600f59bb7	Merge pull request #20525 from hashicorp/jbardin/extra-set-value ... remove the partially-known ~ set sigil in diffs	7 years ago
James Bardin	2b4d030a69	don't re-add removed list values even when planned ... Providers were not strict (and were not forced to be) about customizing the diff when a computed attribute needed to be updated during apply. The fix we have in place to prevent loss of information during the helper/schema apply process would add in single missing value back in. The first place this was caught was when we attempt to fix up the flatmapped attributes. The 1->0 count error is now better handled by our cty.Value normalization step, so we can remove the special apply case here altogether The next place is in normalizeNullValues, and since the intent was to re-insert missing zero-value lists and sets, adding a check for a length of 0 protects us from adding in extra elements. The new test fixture emulated common provider behavior of re-computing values without customizing the diff. Since we can work around it, and core will provider appropriate warnings, the shims should try to maintain the legacy behavior.	7 years ago
James Bardin	47604c36c8	remove the partially-known ~ set sigil in diffs ... The NewExtra values are stored outside the diff from plan, and the original keys may not contain the ~ prefix. Adding the NewExtra back into the diff with the mismatched key was causing an entire new set element to be populated. Since this symbol isn't used to apply the diff in helper/schema, we can simply strip them out.	7 years ago
James Bardin	c814f2da37	Change backend.ValidateConfig to PrepareConfig ... This mirrors the change made for providers, so that default values can be inserted into the config by the backend implementation. This is only the interface and method name changes, it does not yet add any default values.	7 years ago
Jurnell Cockhren	1242e08473	fix(salt-masterless): Compare retrieved variable values with defaults	7 years ago
Jurnell Cockhren	996f845d4b	fix(salt-masterless): set the default values for state and pillar remote locations	7 years ago
James Bardin	da389d6cd4	simple list diffs may also have missing elements ... Like was done for list blocks, simple lists of strings may be missing empty string elements, and any list may be implicitly truncated.	7 years ago
James Bardin	931f459336	add a trouble test schema from the aws provider	7 years ago
James Bardin	f932e11a50	create a test that removes a RequiresReplace path ... One of the paths that triggers RequiresReplace does not apply to the new value.	7 years ago
James Bardin	1ca7531cc7	allow implicit empty strings in lists ... The helper/schema handling of lists loses empty string values, but retains the correct count. Only re-count the values if the count is missing entirely, and allow our shims to re-populate the zero values.	7 years ago
James Bardin	1bfc27817e	process state even after provider.Apply errors ... Terraform core expects a sane state even when the provider returns an error. Make sure at the prior state is always the default value to return, and then alway attempt to process any state returned by provider.Apply.	7 years ago
James Bardin	be127725cc	Additional tests with interpolated values	7 years ago
James Bardin	411df99f33	only force top-level id's back to unknown ... Nested structures may have "id" fields, which should be treated normally.	7 years ago
James Bardin	3b18dd7c01	Merge pull request #20224 from hashicorp/jbardin/sdk ... SDK set fixes	7 years ago
James Bardin	79d1e0d7cf	add failing test for multiple computed set elems	7 years ago
James Bardin	2e2374cfcb	add failing test for set elements with custom diff ... Adding a DiffSuppressFunc for set elements can cause them to be missed in the set diff entirely.	7 years ago
Martin Atkins	bdcac8792d	plugin: Use correct schema when marshaling imported resource objects ... Previously we were using the type name requested in the import to select the schema, but a provider is free to return additional objects of other types as part of an import result, and so it's important that we perform schema selection separately for each returned object. If we don't do this, we get confusing downstream errors where the resulting object decodes to the wrong type and breaks various invariants expected by Terraform Core. The testResourceImportOther test in the test provider didn't catch this previously because it happened to have an identical schema to the other resource type being imported. Now the schema is changed and also there's a computed attribute we can set as part of the refresh phase to make sure we're completing the Read call properly during import. Refresh was working correctly, but we didn't have any tests for it as part of the import flow.	8 years ago
James Bardin	89c1ba099f	add computed set test with CustomizeDiff	8 years ago
James Bardin	fa92e69e17	simplify test check	8 years ago
James Bardin	3b04b41250	fix RequiresNew in diff ... With the new diff.Apply we can keep the diff mostly intact, but we need turn off all RequiresNew flags so that the prior state is not removed from the apply.	8 years ago
Martin Atkins	477da57a92	helper/plugin: Honor resource type overrides in import ... One quirky aspect of our import feature is that we allow the importer to produce additional resources alongside the one that was imported, such as to create separate rules for each rule of an imported security group. Providers need to be able to set the types of these other resources since they may not match the "main" resource type. They do this by calling ResourceData.SetType, which in turn sets InstanceState.Ephemeral.Type. In our shims here we therefore need to copy that out into our new TypeName field so that the new core import code can see it and create the right type in the state. Testing this required a minor change to the test harness to allow the ImportStateCheck function to see the resource type.	8 years ago
James Bardin	775df57217	add more tests ... verify that changes to defaults are detected	8 years ago
James Bardin	7dd0acc46b	don't count empty containers in diff.Apply ... If there were no matching keys, and there was no diff at all, don't set a zero count for the container. Normally Providers can't reliably detect empty vs unset here, but there are some cases that worked.	8 years ago
James Bardin	675d700a5f	test for missing map entries	8 years ago
James Bardin	93d78c4ee7	disable broken import test for now	8 years ago
James Bardin	f78b5045d0	add failing test for lost elements in list blocks ... Modifying an element loses the modification, and other elements in a TypeList.	8 years ago
James Bardin	c045d3e6a3	disable known failing tests ... We need these changes in master for testing, worry about these test after.	8 years ago
James Bardin	4439a7dcf4	add tests for nested default values ... Don't lose default values set within a nested block.	8 years ago
James Bardin	0d1252812b	add more tests for a computed nested list and set	8 years ago
James Bardin	9b89f6ecc6	add tests for deprecated/removed attrs	8 years ago
James Bardin	3e3802c36f	update existing test provider test	8 years ago
James Bardin	f4fe6d6716	add tests with set hashes to the test provider ... These are representative of things that real-world providers use in tests.	8 years ago
James Bardin	7455bf2a55	provider tests for empty values ... Add tests to make limited use of empty container values and empty strings.	8 years ago
James Bardin	725ccea6d4	Merge pull request #19732 from hashicorp/jbardin/terraform-remote-state ... there is always an implied workspace of "default"	8 years ago
Martin Atkins	364d3ffc4a	provider/test: Test for nested dynamic blocks ... This is a HCL feature rather than a Terraform feature really, but we want to make sure it keeps working consistently in future versions of Terraform so this is a Terraform-flavored test for the block expansion behavior. In particular, it tests that a nested dynamic block can access the parent iterator, so that we won't regress #19543 in future.	8 years ago
James Bardin	41002e1a24	there is always an implied workspace of "default" ... Fetching a state requires a workspace name, which should default to "default"	8 years ago
Martin Atkins	e39c69750c	core: Specialized errors for incorrect indexes in resource reference ... In prior versions of Terraform we permitted inconsistent use of indexes in resource references, but in as of 0.12 the index usage must correlate properly with whether "count" is set on the resource. Since users are likely to have existing configurations with incorrect usage, here we introduce some specialized error messages for situations where we can detect such issues statically. This seems to cover all of the common patterns we've seen in practice. Some usage patterns will fall back on a less-helpful dynamic error here, but no configurations coming from 0.11 can end up that way because 0.11 did not permit forms such as aws_instance.no_count[count.index].bar that this validation would not be able to "see". Our configuration upgrade tool also contains a fix for this already, but it takes a more conservative approach of adding the index [1] rather than [count.index] because it can't be sure (without human help) if correlation of indices is what was intended.	8 years ago
James Bardin	c70be3c328	failing tests when using resources with count ... Two different tests failing around resourced with count	8 years ago
James Bardin	53ff35b9ca	StateFunc tests	8 years ago
James Bardin	f0e51aca1a	test a nil computed value within an expression ... Comparing a nil-computed value was returning unknown, preventing the data source from being evaluated.	8 years ago
James Bardin	622f5cc6fb	add test for computed map value ... This ensures that a computed map can be correctly applied.	8 years ago