28198 Commits (dc71cd449581e5718fdbff69bced1fab92ba0ea5)

 

All Branches   

Search

Author	SHA1	Message	Date
James Bardin	1a158743b3	Merge pull request #28228 from hashicorp/jbardin/destroy-deps ... Stored dependency handling during plan	5 years ago
Alisdair McDiarmid	4fb505631c	Merge pull request #28230 from hashicorp/alisdair/only-rewrite-provider-locks-file-if-changed ... cli: Only rewrite provider locks file if changed	5 years ago
Alisdair McDiarmid	786d99207e	cli: Only rewrite provider locks file if changed ... If the provider locks have not changed, there is no need to rewrite the locks file. Preventing this needless rewrite should allow Terraform to operate in a read-only directory, so long as the provider requirements don't change.	5 years ago
Alisdair McDiarmid	340543d122	Merge pull request #28201 from hashicorp/alisdair/planfile-sensitive-required-replace ... Add sensitivity and required-replace fields to plan file, and expose sensitivity to JSON plan	5 years ago
James Bardin	7964328f34	merge dependencies when refreshing ... The resource configuration was always being used to determine dependencies during refresh, because if there were no changes to a resource, there was no chance to replace any incorrect stored dependencies. Now that we are refreshing during plan, we can determine that a resource has no changes and opt to store the new dependencies immediately. Here we clean up the writeResourceInstanceState calls to no longer modify the resource instance state, removing the `dependencies` argument. Callers are now expected to set the Dependencies field as needed.	5 years ago
Robin Norwood	e3bd661470	Merge pull request #28164 from hashicorp/rln-add-resource-targeting-tutorial-callout ... Add callout to resource targeting tutorial	5 years ago
Alisdair McDiarmid	5e30d58dc2	command/jsonplan: Add output change sensitivity ... When an output value changes, we have a small amount of information we can convey about its sensitivity. If either the output was previously marked sensitive, or is currently marked sensitive in the config, this is tracked in the output change data. This commit encodes this boolean in the change struct's `before_sensitive` and `after_sensitive` fields, in the a way which matches resource value sensitivity. Since we have so little information to work with, these two values will always be booleans, and always equal each. This is logically consistent with how else we want to obscure sensitive data: a changing output which was or is marked sensitive should not have the value shown in human-readable output.	5 years ago
Alisdair McDiarmid	63613ca1b0	command/jsonconfig: Add variable sensitive flag	5 years ago
Alisdair McDiarmid	e27aacebf9	command/jsonplan: Add sensitive value mapping data ... Similar to `after_unknown`, `before_sensitive` and `after_sensitive` are values with similar structure to `before` and `after` which encode the presence of sensitive values in a planned change. These should be used to obscure sensitive values from human-readable output. These values follow the same structure as the `before` and `after` values, replacing sensitive values with `true`, and non-sensitive values with `false`. Following the `after_unknown` precedent, we omit non-sensitive `false` values for object attributes/map values, to make serialization more compact. One difference from `after_unknown` is that a sensitive complex value (collection or structural type) is replaced with `true`. If the complex value itself is sensitive, all of its contents should be obscured.	5 years ago
Matthew Frahry	15779013da	backend/azurerm: Bug fixes and updated dependencies #28181	5 years ago
Judith Malnick	75fbbe8065	clarify version that pull upgrades local state to (#28204)	5 years ago
Alisdair McDiarmid	fd7c4105f2	Merge pull request #28202 from hashicorp/alisdair/fmt-multiline-value-expr-unwrap ... cli: Fix fmt output for multi-line value exprs	5 years ago
James Bardin	985124bfa8	failing test for removed cbd reference ... A stored dependency is documented as being honored even after it is removed from the configuration, until the referenced resource is destroyed.	5 years ago
James Bardin	bac4e0a3de	fix ResourceInstanceObject.DeepCopy ... missing CreateBeforeDestroy	5 years ago
Martin Atkins	6f35c2847b	command: Reorganize docs of the local backend's legacy CLI options ... We have these funny extra options that date back to before Terraform even had remote state, which we've preserved along the way by most recently incorporating them as special-case overrides for the local backend. The documentation we had for these has grown less accurate over time as the details have shifted, and was in many cases missing the requisite caveats that they are only for the local backend and that backend configuration is the modern, preferred way to deal with the use-cases they were intended for. We always have a bit of a tension with this sort of legacy option because we want to keep them documented just enough to be useful to someone who finds an existing script/etc using them and wants to know what they do, but not to take up so much space that they might distract users from finding the modern alternative they should consider instead. As a compromise in that vein here I've created a new section about these options under the local backend documentation, which then gives us the space to go into some detail about the various behaviors and interactions and also to discuss their history and our recommended alternatives. I then simplified all of the other mentions of these in command documentation to just link to or refer to the local backend documentation. My hope then is that folks who need to know what these do can still find the docs, but that information can be kept out of the direct path of new users so they can focus on learning about remote backends instead. This is certainly not the most ideal thing ever, but it seemed like the best compromise between the competing priorities I described above.	5 years ago
Matthew Frahry	13b41d59f5	Website Test Fix	5 years ago
Alisdair McDiarmid	d71f0c6149	cli: Fix fmt output for multi-line value exprs ... The formatter for value expressions which use legacy interpolation syntax was previously behaving incorrectly with some multi-line expressions. Any HCL expression which requires parenthesis to be allowed to span multiple lines could be skip those parens if already inside string interpolation (`"${}"`). When removing string interpolation, we now check for a resulting multi-line expression, and conservatively ensure that it starts and ends with parenthesis. These may be redundant, as not all expressions require parens to permit spanning multiple lines, but at least it will be valid output.	5 years ago
Alisdair McDiarmid	a12c413b84	plans/planfile: Add required-replace and sensitive ... The stored planfile now serializes the required-replace path set and the collection of before/after sensitivity marks. This ensures that storing a plan and displaying it with `terraform show` renders the same output for plans with required-replace resources, and those with sensitive values in the diff.	5 years ago
Dennis Gursky	550de86135	Set Intersection #performance (#28183) ... * Set Intersection #performance Intersection is faster for sets of different sizes if one iterates over the shorter set and checks the presence of an element in a larger one. For an edge case consider `s` having 1M entries and `other` no entries at all. In this case original code will iterate over 1M entries in `s` not finding anything and then returning an empty result set. In the patched code the iteration won't happen at all and result is returned immediately. This change is inspired by profiling a relatively large terraform configuration, where the time to validate was sped up 4x with this change.	5 years ago
James Bardin	07ecfb13f0	Merge pull request #28180 from hashicorp/jbardin/mark-provider-sensitive ... check for unknowns when marking resource values	5 years ago
James Bardin	8cba2bfc39	check for unknowns when marking resource values ... When we map schema sensitivity to resource values, there may be unknowns when dealing with planned objects. Check for unknowns before iterating over block values.	5 years ago
Alisdair McDiarmid	841cced6c9	Merge pull request #28138 from hashicorp/alisdair/command-views-validate ... cli: Migrate validate command to views	5 years ago
James Bardin	b5e5948b64	Merge pull request #28176 from hashicorp/jbardin/destroy-doc ... update destroying doc to show show more CBD detail	5 years ago
James Bardin	44199ae4ba	update destroying doc to show show more CBD detail ... Update the create-before-destroy cases in the destroying.md document.	5 years ago
James Bardin	0ebc71383b	Merge pull request #28165 from hashicorp/jbardin/destroy-update-dep ... Destroy then update dependency ordering	5 years ago
Alisdair McDiarmid	0e43fa9834	Merge pull request #28166 from hashicorp/alisdair/fix-typo ... Fix typo in plan no changes output message	5 years ago
Matthew Frahry	0bbb0dc200	Fix for #27809	5 years ago
Alisdair McDiarmid	7242d9af2b	Fix typo in plan no changes output message	5 years ago
Alisdair McDiarmid	46c2dce0fb	Fix broken test	5 years ago
James Bardin	dcb12195a3	update destroying.md ... Update the full-replacement example graph to show the transitive dependency that is required for the destroy-then-update case. Add another example describing the case where we reduce the graph to only an update and replace and the dependency on the destroy node remains.	5 years ago
James Bardin	0bc64e3cc4	tests for destroy-then-update dependency ordering	5 years ago
Matthew Frahry	3546650ac6	backend/azurerm: adding the right role name	5 years ago
Matthew Frahry	3722b1b613	backend/azurerm: support for using azuread authentication for blobs	5 years ago
Kristin Laemmert	b9138f4465	terraform: validate providers' schemas during NewContext (#28124) ... * checkpoint save: update InternalValidate tests to compare exact error * configschema: extract and extend attribute validation This commit adds an attribute-specific InternalValidate which was extracted directly from the block.InternalValidate logic and extended to verify any NestedTypes inside an Attribute. Only one error message changed, since it is now valid to have a cty.NilType for Attribute.Type as long as NestedType is set. * terraform: validate provider schema's during NewContext We haven't been able to guarantee that providers are validating their own schemas using (some version of) InternalValidate since providers were split out of the main codebase. This PR adds a call to InternalValidate when provider schemas are initially loaded by NewContext, which required a few other changes: InternalValidate's handling of errors vs multierrors was a little weird - before this PR, it was occasionally returning a non-nil error which only stated "0 errors occurred" - so I addressed that in InternalValidate. I then tested this with a configuration that was using all of our most popular providers, and found that at least on provider had some invalid attribute names, so I commented that particular validation out. Adding that in would be a breaking change which we would have to coordinate with enablement and providers and (especially in this case) make sure it's well communicated to external provider developers. I ran a few very unscientific tests comparing the timing with and without this validation, and it appeared to only cause a sub-second increase. * refactor validate error message to closer match the sdk's message * better error message * tweak error message: move the instruction to run init to the end of the message, after the specific error.	5 years ago
Matthew Frahry	341479087c	backend/azurerm: adding support for azuread authentication	5 years ago
Robin Norwood	31323b911b	Add callout to resource targeting tutorial	5 years ago
Matthew Frahry	a978d4ee99	website: adding the new fields to azurerm	5 years ago
Matthew Frahry	b0b0a44a67	backend/azurerm: added a feature flag for using AzureAD to authenticate	5 years ago
Matthew Frahry	05b45ab4f3	backend/azurerm: removing support for the deprecated fields	5 years ago
Matthew Frahry	3961f08e63	dependencies: upgrade all the azure things	5 years ago
Kristin Laemmert	77562d9b57	command/jsonprovider: bump format version (#28115) ... Support for attributes with NestedTypes was added in https://github.com/hashicorp/terraform/pull/28055, and should have included a format version bump: this is a backwards-compatible change, but consumers will need to be updated in order to properly decode attributes (with NestedTypes) going forward.	5 years ago
Tej-Singh-Rana	2a49d908b8	fix the typo (#28140)	5 years ago
Kristin Laemmert	125e9d69d4	terraform-bundle: return an error if "versions" argument is omitted (#28158)	5 years ago
James Bardin	8671f40768	connect destroyers to all stored create deps ... We currently count on interconnecting destroy nodes to handle the create->destroy dependency edge for replacement, but when the create node is only an update we don't connect that edge directly. Lookup all creators that are dependencies of the destory node and ensure they are connected.	5 years ago
Alisdair McDiarmid	dd380d0b58	cli: Migrate validate command to views	5 years ago
Pam Selle	683422e54f	Merge pull request #28113 from hashicorp/pselle/provider_sensitive_attrs_docs ... Update documentation for provider_sensitive_attrs experiment	5 years ago
James Bardin	c6278bbe37	Merge pull request #28042 from jasons42/update-workspaces-docs ... Indicate etcdv3 support for multiple workspaces in docs	5 years ago
James Bardin	2e3aa96988	Merge pull request #28099 from jasons42/duplicate-default-workspace ... Fix duplicate default state	5 years ago
James Bardin	439bf9a96d	Merge pull request #28097 from jasons42/etcdv3-acceptance-tests ... Fix type conversion panic	5 years ago
Martin Atkins	df1d932fd2	build: Use Go 1.16.2 ... Unfortunately at the moment I'm adding this the release isn't yet available in the current version of goenv, but due to these including security stuff and because we're about to make a Terraform release we're letting this get slightly ahead of goenv on the assumption that it will catch up shortly.	5 years ago