183 Commits (db08ee4ac59d5eb8bcfffc175489ebf461bf4a92)

Author	SHA1	Message	Date
Martin Atkins	c12d64f340	Use t.Helper() in our test helpers ... Go 1.9 adds this new function which, when called, marks the caller as being a "helper function". Helper function stack frames are then skipped when trying to find a line of test code to blame for a test failure, so that the code in the main test function appears in the test failure output rather than a line within the helper function itself. This covers many -- but probaly not all -- of our test helpers across various packages.	9 years ago
Martin Atkins	2e0c1d07ae	Merge #15793: Locking support in HTTP remote backend	9 years ago
Ross McFarland	d889ac38b0	Change remote/http store to update, more consistent with doc	9 years ago
Ross McFarland	510563b67f	Fully test conf handling in httpFactory	9 years ago
Ross McFarland	69546c4b33	Pass at much more flexible remote/http backend ... - Configurable Put (store) method, default POST to preserve behavior - Configurable Lock method & address - Configurable Unlock method & address More thorough testing still needed, but this if functional	9 years ago
James Bardin	68da0390b7	remove legacy azure remote state code ... The implementation has been moved to a backend.	9 years ago
Peter McAtominey	f9e8e54835	backend: convert Azure remote state to a backend ... Added locking support via blob leasing (requires that an empty state is created before any lock can be acquired. Added support for "environments" in much the same way as the S3 backend.	9 years ago
Ross McFarland	6cdea5af5d	Clean up code and make the state/http behavior more consistent	9 years ago
Ross McFarland	ce4d9fb3c2	Add tests for state/http with locking	9 years ago
Ross McFarland	1d38569c91	Add Lock/Unlock support to remote/http	9 years ago
James Bardin	32ae05c342	fix strict remote.State lineage check ... We can't check lineage in the remote state instance, because we may need to overwrite a state with a new lineage. Whil it's tempting to add an optional interface for this, like OverwriteState(), optional interfaces are never _really_ optional, and will have to be implemented by any wrapper types as well. Another solution may be to add a State.Supersedes field to indicate that we intend to replace an existing state, but that may not be worth the extra check either.	9 years ago
James Bardin	fba5decae5	update TestState helper ... In practice, States must all implement the full interface, so checking for each method set only leaves gaps where tests could be skipped. Change the helper to only accept a full state.State implementation. Add some Lineage, Version, and TFVersion checks to TestState to avoid regressions. Compare the copy test against the immediate State returnedm rather than our previous "current" state. Check that the states round-trip and still marhsal identically via MarshalEqual.	9 years ago
Martin Atkins	4d53eaa6df	state: more robust handling of state Serial ... Previously we relied on a constellation of coincidences for everything to work out correctly with state serials. In particular, callers needed to be very careful about mutating states (or not) because many different bits of code shared pointers to the same objects. Here we move to a model where all of the state managers always use distinct instances of state, copied when WriteState is called. This means that they are truly a snapshot of the state as it was at that call, even if the caller goes on mutating the state that was passed. We also adjust the handling of serials so that the state managers ignore any serials in incoming states and instead just treat each Persist as the next version after what was most recently Refreshed. (An exception exists for when nothing has been refreshed, e.g. because we are writing a state to a location for the first time. In that case we _do_ trust the caller, since the given state is either a new state or it's a copy of something we're migrating from elsewhere with its state and lineage intact.) The intent here is to allow the rest of Terraform to not worry about serials and state identity, and instead just treat the state as a mutable structure. We'll just snapshot it occasionally, when WriteState is called, and deal with serials _only_ at persist time. This is intended as a more robust version of #15423, which was a quick hotfix to an issue that resulted from our previous slopping handling of state serials but arguably makes the problem worse by depending on an additional coincidental behavior of the local backend's apply implementation.	9 years ago
Gavin Williams	96e6bf89ec	remote/swift: Remove un-used code	9 years ago
Gavin Williams	ee2e390f85	remote/swift: Migrate Swift remote state to a backend ... Move the Swift State from a legacy remote state to an official backend. Add `container` and `archive_container` configuration variables, and deprecate `path` and `archive_path` variables. Future improvements: Add support for locking and environments.	9 years ago
James Bardin	808b504bcf	rename openstack provider for swift remote state	9 years ago
Tom Harvey	13583b4b8b	provider/azurerm: Upgrading to AutoRest v8 (#15006) ... * Upgrading to AutoRest 8 * Upgrading to AutoRest v8 * Updating the Remote State to v8	9 years ago
Tom Harvey	df2875045d	provider/azurerm: Upgrading to v10 of the Azure SDK (#14004) ... provider/azurerm: Upgrading to v10.0.2 of the Azure SDK	9 years ago
James Bardin	4866f35645	add mutexes to Local, Backup, and InmemState	9 years ago
James Bardin	f0f2220abb	add mutexes to remote.State	9 years ago
Gavin Williams	c63ad9c0f8	state/remote/swift: Support Openstack request logging (#13583) ... * provider/openstack: Expose LogRoundTripper fields externally * state/remote/swift: Add support for debugging Openstack calls using OS_DEBUG env variable. * provider/openstack: Update LogRoundTripper to log headers aswell as body. * Add `RedactHeaders` function in order to redact sensitive http Headers. Refactor `logRequest` and `logResponse` to use `RedactHeaders` func.	9 years ago
James Bardin	eeddc3f8ea	add some nil checks for unexpected lock failures	9 years ago
James Bardin	af2e289212	remove Sleep from TestLockWithContext	9 years ago
James Bardin	d1460d8c82	test LockWithContext	9 years ago
James Bardin	93b1dd6323	give LockWithContext a little backoff ... Backoff the Lock calls exponentially, to a reasonable limit.	9 years ago
James Bardin	3f0dcd1308	Have the clistate Lock use LockWithContext ... - Have the ui Lock helper use state.LockWithContext. - Rename the message package to clistate, since that's how it's imported everywhere. - Use a more idiomatic placement of the Context in the LockWithContext args.	9 years ago
James Bardin	826771a830	add state.LockWithContext ... LockWithContext will retry a lock until the context expires or is cancelled. This will let us implement a `-lock-timeout` flag, and make use of existing contexts when applicable.	9 years ago
James Bardin	75458a182d	remove extra state.Locker assertions ... All states are lockers, so get rid of extra asertions.	9 years ago
James Bardin	bf6384a163	All states are lockers ... Since moving to the new backends, all states (except InmemState) are Lockers. Add the methods to the State interface to remove a heap of assertion checks.	9 years ago
James Bardin	9f5cf2b105	convert S3 remote state to a backend ... Move the S3 State from a legacy remote state to an official backend. This increases test coverage, uses a set schema for configuration, and will allow new backend features to be implemented for the S3 state, e.g. "environments".	9 years ago
Mitchell Hashimoto	1daff7a826	backend/consul: support "lock" option to disable locking ... This adds a "lock" config (default true) to allow users to optionally disable state locking with Consul. This is necessary if the token given doesn't have session permission and is necessary for backwards compatibility.	9 years ago
Ash Berlin	70de22253a	Fix error message in Azure state backend (#12424) ... The error led me to try adding `resource_group` but the code wanted `resource_group_name`. This fixes the error message to match the code.	9 years ago
Peter McAtominey	cbed463b44	state/azure: add environment option for non-public cloud usage (#12364)	9 years ago
Mitchell Hashimoto	942572b574	backend/init: add atlas, remove legacy atlas remote state	9 years ago
James Bardin	7f40f90c4c	remove the legacy Inmem remote state ... moved to a new backend	9 years ago
James Bardin	a4283d23f6	fix windows locking ... Don't create a new windows handle for the lock.	9 years ago
James Bardin	c0dda6a7b3	test failure for windows local locks	9 years ago
Mitchell Hashimoto	03f6c650ca	state/remote: ClientLocker is just a Client that is a state.Locker	9 years ago
Mitchell Hashimoto	9451acc5da	state/remote: add unit test to verify s3 is a ClientLocker as well	9 years ago
Mitchell Hashimoto	efe754183b	state/remote: export ClientLocker, test for implementation ... This adds unit tests (that will fail at compile time) if various structs don't implement the right interfaces for locking	9 years ago
James Bardin	ec00564be6	Clean up LockInfo and LockError and use them ... Gove LockInfo a Marshal method for easy serialization, and a String method for more readable output. Have the state.Locker implementations use LockError when possible to return LockInfo and an error.	9 years ago
James Bardin	888af93356	Have S3 check the lockID on Unlock ... This needs to be improved to happen in a transaction, but it gets the implementation passing the new tests.	9 years ago
James Bardin	67bbebce08	Have consul state reutrn the lock ID ... The lock ID isn't used because the lock is tied to the client, but return the lock ID to match the behavior of other locks.	9 years ago
James Bardin	08cff7cc13	have LocalState check Lock ID on Unlock ... Have LocalState store and check the lock ID, and strictly enforce unlocking with the correct ID. This isn't required for local lock correctness, as we track the file descriptor to unlock, but it does provide a varification that locking and unlocking is done correctly throughout terraform.	9 years ago
James Bardin	6aa1066f7c	Store and use the correct IDs in TestRemoteLocks	9 years ago
James Bardin	f5ed8cd288	Use NewLockInfo to get a pre-populated value ... Using NewLockInfo ensure we start with all required fields filled.	9 years ago
James Bardin	52b2343672	make state test pass with new state.Locker	9 years ago
James Bardin	4f0c465187	make command tests pass with new state.Locker	9 years ago
James Bardin	6d32b70637	Make S3 remote state pass tests ... TODO: update S3Client to make full use of the state.Locker interface	9 years ago
James Bardin	0ad6f08204	Make remote state test run ... Make them compile against the new interface. The tests will be updated later to check new behavior.	9 years ago