66 Commits (da74b59ea1d3aa4d7706579c95f63c778f2e515e)

Author	SHA1	Message	Date
Radek Simko	0fe906fa8c	make copyrightfix	5 days ago
Radek Simko	922fdb2382	Implement LockState & UnlockState provider methods (#37711)	5 months ago
Radek Simko	51fc4c161f	PSS: Implement `ReadStateBytes` + `WriteStateBytes` (#37440) ... * Implement ReadStateBytes + WriteStateBytes * [WIP] - Testing ReadStateBytes and WriteStateBytes (#37464) * Fix nil pointer error * Add WIP test for ReadStateBytes * Move test mock to separate testing file * Update mock to send unexpected EOF when there's a problem returning data and it's not a true EOF * Add test case for when length != expected length * Add test for when trying to read state from a store type that doesn't exist * Change symbol names to lowercase * Add ability to force a diagnostic to be returned from `mockReadStateBytesClient`'s `Recv` method * Add test showing error diagnostics raised by the ReadStateBytes client are returned * Add missing header * Simplify mock by using an embedded type * Rename `mockOpts` to `mockReadStateBytesOpts` * Update existing tests to assert what arguments are passed to the RPC method call * Add mock WriteStateBytesClient which uses `go.uber.org/mock/gomock` to enable assertions about calls to Send * Add a test for WriteStateBytes that makes assertions about calls to the Send method * Update test case to explicitly test writing data smaller than the chunk size * Implement chunking in WriteStateBytes, add test case to assert expected chunking behaviour * Add generated mock for Provider_WriteStateBytesClient in protocol v6 * Update tests to use new `MockProvider_WriteStateBytesClient`, remove handwritten mock * Update code comments in test * Add tests for diagnostics and errors returned during WriteStateBytes * Add generated mock for Provider_ReadStateBytesClient in protocol v6, replace old mock * Add test case for grpc errors in ReadStateBytes, fix how error is returned * Typo in comment * Add missing warning test, rename some test cases * Update proto file definition of Read/WriteStateBytes RPCs (#37529) * Update Read/WriteStateBytes RPCs to match https://github.com/hashicorp/terraform-plugin-go/pull/531 * Run `make protobuf` * Run `make generate` * Update use of `proto.ReadStateBytes_ResponseChunk` in tests * Fix how diagnostics are handled alongside EOF error, update ReadStateBytes test * More fixes - test setup was incorrect I think? I assume that a response would be returned full of zero-values when EOF is encountered. * WIP - avoid crash if chunk is nil * Sarah's updates to radek/pss-read-write (#37642) * Update code to not expect a chunk when EOF encountered * Return early if any grpc errors are encountered during ReadStateBytes * Close the stream with CloseSend once everything's read without error. Add test case about handling grpc errors from CloseSend. * Fix test case about warnings: We would expect to receive a chunk with data alongside the warning and have a normal closing of the stream after EOF * Add log line, remove unneeded type info * Implement configurable state chunk size * handle metadata in WriteStateBytes correctly * validate chunk sizes received from provider * ReadStateBytes: avoid early return on warnings --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	5 months ago
James Bardin	cc74e2eb20	udpate provider mocks	6 months ago
Kristin Laemmert	0374f04424	Add ValidateActionConfig to provider interface, protocol & internal implementations (#37345) ... * Add ValidateActionConfig to provider interface and protocol * Update internal/provider-simple-v6/provider.go Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	7 months ago
Daniel Schmidt	ac132d1b15	add provider implementation for actions	8 months ago
Sarah French	0f8e77a50f	PSS: Add GetStates and DeleteState RPCs to plugin protocol v6 (#37288) ... * Add GetStates RPC method to Plugin Protocol v6 * Add DeleteState RPC method to Plugin Protocol v6 * Add methods to provider-simple * Fix error messages * Apply suggestions from code review Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * Change how GetStates RPC returns the list of state names * Change GetStates implementation to use new data type * `make protobuf` to accommodate new code comments --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	8 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092) ... * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	9 months ago
Radek Simko	643266dc90	Add initial state store protocol skeleton (#37197) ... * Add initial state store protocol skeleton Introduce ValidateStateStoreConfig + ConfigureStateStore Update GetProviderSchema + GetMetadata (for mux) * address PR feedback	9 months ago
Daniel Banck	44ae7da18e	Update Plugin Protocol for List and Implement `ValidateListResourceConfig` (#37007) ... * Minor auto-formatting changes * Add list RPC and schema protobuf definitions * make protobuf * make generate * Add ValidateListResourceConfig implementation	9 months ago
Daniel Schmidt	fec6e4b552	send resource identities to provider calls	12 months ago
Daniel Banck	b2b42c0fb4	Store resource identities in state (TF-23255) (#36464) ... * Persist resource identity in Terraform state * make syncdeps * Move identity schema merging closer to the protocol * mock GetResourceIdentitySchemas * Fix identity refresh tests * Add more tests * Change grcpwrap upgrade identity * Review feedback * Remove unnecessary version conversion * Check if GetResourceIdentitySchemas RPC call is implemented * Update function signature docs * Adapt protocol changes * Check unimplemented error for identities in GetSchema	12 months ago
Daniel Banck	10c9b64007	Rename schema.Block to Body (#36629)	12 months ago
James Bardin	69337ca005	make sure schemas aren't nil in tests	1 year ago
Sarah French	d5efc81427	Use different summaries and details when reporting errors about non-null write-only attribute values (#36274) ... * Use different summaries when reporting errors about non-null write-only attribute values * Refactor `ValidateWriteOnlyAttributes` to use custom details for diagnostics * Update affected unit tests * Add change file	1 year ago
Daniel Schmidt	17581e4c48	ephemeral: validate provider responses for write-only attributes	1 year ago
James Bardin	3a1a9408d9	fix Descendants spelling ... this has proliferated everywhere	1 year ago
James Bardin	9c3dc8f73a	ephemeral protocol rename ... Add `Resource` to all the ephemeral protocol symbols to make them consistent with existing naming conventions.	1 year ago
James Bardin	03e1a9835d	add ephemeral validation to existing implementations	1 year ago
James Bardin	7e767490c8	ephemeral in refacroing mock	1 year ago
Liam Cervante	14418bd198	terraform test: move override evaluation into expander (#35030) ... * terraform test: move override evaluation into expander * clarify comment	2 years ago
James Bardin	4f1ba8f235	check move target module exists ... We already check if a move target resource still exists, but it's possible the entire module no longer exists.	2 years ago
Brian Flad	c7a44bfc9a	Support Private State with MoveResourceState (#34575) ... This change ensures that providers receive the source private state and can store potentially differing private state as part of a move, rather than always copying the source private state to the target. This functionality has not yet been released and therefore there are no compatibility concerns.	2 years ago
James Bardin	d8a335f520	add unknown val error for MoveResourceState	2 years ago
Liam Cervante	0ca03ecf08	Extend refactoring package to support cross-provider moves (#34501) ... * Extend refactoring package to support cross-provider moves * implement provider cache * make generate	2 years ago
kmoe	a718f70f85	Add removed block (#34251) ... * terraform: remove redundant code NodeDestroyResourceInstance is never instantiated with a DeposedKey of anything other than states.NotDeposed, so the deleted code is never run. Deposed objects get a NodeDestroyDeposedResourceInstanceObject instead. * tfdiags: add helper func * configs: introduce removed block type * terraform: add forget action * renderer: render forget actions * terraform: deposed objects can be forgotten Deposed objects encountered during planning spawn NodePlanDeposedResourceInstanceObject, which previously generated a destroy change. Now it will generate a forget change if the deposed object is a forget target, and a destroy change otherwise. The apply graph gains a new node type, NodeForgetDeposedResourceInstanceObject, whose execution simply removes the object from the state. * configs: add RemoveTarget address type * terraform: modules can be forgotten * terraform: error if removed obj still in config * tests: better error on restore state fail * Update CHANGELOG.md	2 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
James Bardin	ea1144995f	update callers of InstallModules ... Update callers of InstallModules and have `get` return only install errors.	3 years ago
Liam Cervante	6882dd9530	testing framework: introduce test command optional flags (#33504) ... * testing framework: introduce test command optional flags * address consistency checks	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Alisdair McDiarmid	8df065a2fe	initwd: Switch from earlyconfig to configs ... This is a mostly mechanical refactor with a handful of changes which are necessary due to the semantic difference between earlyconfig and configs. When parsing root and descendant modules in the module installer, we now check the core version requirements inline. If the Terraform version is incompatible, we drop any other module loader diagnostics. This ensures that future language additions don't clutter the output and confuse the user. We also add two new checks during the module load process: * Don't try to load a module with a `nil` source address. This is a necessary change due to the move away from earlyconfig. * Don't try to load a module with a blank name (i.e. `module ""`). Because our module loading manifest uses the stringified module path as its map key, this causes a collision with the root module, and a later panic. This is the bug which triggered this refactor in the first place.	3 years ago
kmoe	56a1e0d1c6	allow cross-package move statements (#31556)	4 years ago
James Bardin	e3ca4be4b9	goimports	4 years ago
James Bardin	dc9d7108dd	use TopologicalOrder for evaluating moves ... The dag package did not previously provide a topological walk of a given graph. While the existing combination of a transitive reduction with a depth-first walk appeared to accomplish this, depth-first is only equivalent with a simple tree. If there are multiple paths to a node, a depth-first approach will skip dependencies from alternate paths.	4 years ago
Radek Simko	7feef1c4aa	Use hashicorp/terraform-registry-address as a decoupled library (#28338) ... * refactor: Use tfaddr for provider address parsing * refactor: Use tfaddr for module address parsing * deps: introduce hashicorp/terraform-registry-address	4 years ago
Martin Atkins	dc5964f8a3	refactoring: Use addrs.Map for maps with addresses as keys ... We introduced the addrs.UniqueKey and addrs.UniqueKeyer mechanics as part of implementing the ValidateMoves and ApplyMoves functions, as a way to better encapsulate the solution to the problem that lots of our address types aren't comparable and so cannot be used directly as map keys. However, exposing addrs.UniqueKey handling directly in the logic adds various noise to the algorithms and, in particular, obscures the fact that MoveResults.Changes and MoveResult.Blocked both have different map key types. Here then we'll use the new addrs.Map helper type, which encapsulates the idea of a map from an addrs.UniqueKeyer type to an arbitrary value type, using the unique keys as the map keys internally. This does unfortunately mean that we lose the conventional Go map access syntax and have to use a method-based API instead, but I (subjectively) think that's an okay compromise in return for avoiding the need to keep track inline of which addrs.UniqueKey values correspond with which real addresses. This is intended as an entirely-mechanical change, with equivalent behavior to what it replaced. If anything here is doing something materially different than what it replaced then that's a mistake.	4 years ago
Martin Atkins	bdc5f152d7	refactoring: Implied move statements can be cross-package ... Terraform uses "implied" move statements to represent the situation where it automatically handles a switch from count to no-count on a resource. Because that situation requires targeting only a specific resource instance inside a specific module instance, implied move statements are always presented as if they had been declared in the root module and then traversed through the exact module instance path to reach the target resource. However, that means they can potentially cross a module package boundary, if the changed resource belongs to an external module. Normally we prohibit that to avoid the root module depending on implementation details of the called module, but Terraform generates these implied statements based only on information in the called module and so there's no need to apply that same restriction to implied move statements, which will always have source and destination addresses belonging to the same module instance. This change therefore fixes a misbehavior where Terraform would reject an attempt to switch from no-count to count in a called module, where previously the author of the calling configuration had no recourse to fix it because the change has actually happened upstream.	4 years ago
James Bardin	f46cf7b8bc	cleanup some move graph handling ... Create a separate `validateMoveStatementGraph` function so that `ValidateMoves` and `ApplyMoves` both check the same conditions. Since we're not using the builtin `graph.Validate` method, because we may have multiple roots and want better cycle diagnostics, we need to add checks for self references too. While multiple roots are an error enforced by `Validate` for the concurrent walk, they are OK when using `TransitiveReduction` and `ReverseDepthFirstWalk`, so we can skip that check. Apply moves must first use `TransitiveReduction` to reduce the graph, otherwise nodes may be skipped if they are passed over by a transitive edge.	4 years ago
James Bardin	22dc685052	check for nested module index changes ... Changing only the index on a nested module will cause all nested moves to create cycles, since their full addresses will match both the From and To addresses. When building the dependency graph, check if the parent is only changing the index of the containing module, and prevent the backwards edge for the move.	4 years ago
James Bardin	deb82daf2b	find implied moves in nested modules ... Implied moves in nested modules were being skipped	4 years ago
Alisdair McDiarmid	d7ef123c12	refactoring: Move nested modules ... When applying module `moved` statements by iterating through modules in state, we previously required an exact match from the `moved` statement's `from` field and the module address. This permitted moving resources directly inside a module, but did not recur into module calls within those moved modules. This commit moves that exact match requirement so that it only applies to `moved` statements targeting resources. In turn this allows nested modules to be moved.	4 years ago
Katy Moe	aeecc6a627	add AffectedAbsResource to interface	4 years ago
Katy Moe	11566b1d11	introduce AbsMoveableResource ... AbsMoveableResource is an AbsMoveable that is either a resource or a resource instance. This interface represents a moveable that has a resource type.	4 years ago
Katy Moe	7162e79fdf	return error on resource type mismatch ... A resource move is invalid if the two resource( instance)s are of different resource types. Check for this during move validation.	4 years ago
Katy Moe	dc3ed6271c	add failing test for resource type mismatch	4 years ago
Katy Moe	4305271cff	remove occurrences of AbsMovable	4 years ago
kmoe	40ec62c139	command: make module installation interruptible ... Earlier work to make "terraform init" interruptible made the getproviders package context-aware in order to allow provider installation to be cancelled. Here we make a similar change for module installation, which is now also cancellable with SIGINT. This involves plumbing context through initwd and getmodules. Functions which can make network requests now include a context parameter whose cancellation cancels those requests. Since the module installation code is shared, "terraform get" is now also interruptible during module installation.	4 years ago
Martin Atkins	94cbc8fb5d	experiments: config_driven_move has concluded ... Based on feedback during earlier alpha releases, we've decided to move forward with the current design for the first phase of config-driven refactoring. Therefore here we've marked the experiment as concluded with no changes to the most recent incarnation of the functionality. The other changes here are all just updating test fixtures to no longer declare that they are using experimental features.	4 years ago
James Bardin	cac1f5c264	refactoring: exhaustive NestedWithin checks ... When checking dependencies between statements, we need to check all combinations of To and From addresses.	4 years ago
Martin Atkins	7b99861b1c	refactoring: Don't implicitly move for resources with for_each ... Our previous rule for implicitly moving from IntKey(0) to NoKey would apply that move even when the current resource configuration uses for_each, because we were only considering whether "count" were set. Previously this was relatively harmless because the resource instance in question would end up planned for deletion anyway: neither an IntKey nor a NoKey are valid keys for for_each. Now that we're going to be announcing these moves explicitly in the UI, it would be confusing to see Terraform report that IntKey moved to NoKey in a situation where the config changed from count to for_each, so to address that we'll only generate the implied statement if neither repetition argument is set.	4 years ago