terraform

Commit Graph

Author	SHA1	Message	Date
Radek Simko	0fe906fa8c	make copyrightfix	2 months ago
Austin Valle	a48e873790	PSS: Adjust `StateRange.End` logic in `ReadStateBytes` and `WriteStateBytes` (#38127 ) * fix usage of StateRange.End * add test for last chunk is single byte	3 months ago
stephybun	c9d024062a	Generate Resource Config: set state in proto req (#37895 ) * marshal state and set in the proto req for generate resource config * changelog * set state in the proto req for generate resource config in plugin6 * add GRPC tests for GenerateResourceConfig * remove changelog entry since this fix is backported to 1.14	4 months ago
Sarah French	cf047be4e4	PSS: Use interfaces to configure state stores (#37899 ) * refactor: Move chunk size limit constants to new `chunks` package * refactor: Make `NewPluggable` return a `Pluggable` concrete type, instead of an instance of the `backend.Backend` interface. * refactor: Configure state stores through the backend.Backend interface, instead of directly using methods related to RPCs. This requires changing where we call `SetStateStoreChunkSize`. * docs: Add godocs comment to `StateStoreChunkSizeSetter` interface To summarize, we don't really need the `SetStateStoreChunkSize` method, and instead methods like `(GRPCProvider).ConfigureStateStore` in the `plugin6` package can directly inspect the negotiation process that passes through that code and pull out the chunk size. However that means that that code would also need to implement validation. And that's just `(GRPCProvider).ConfigureStateStore`; what about all the test mocks that are used in different types of test? They would all need to be implemented similarly to GRPCProvider to be good, useful mocks, and then a lot of things that fulfil the provider.Interface interface are coupled to each other. Instead, it's easier to have validation in the `grpcClient` struct's methods in the `remote` package, as that code is common to all scenarios. That code needs a method to 'reach into' the provider.Interface value, so we use the `SetStateStoreChunkSize` method. * chore: Make it clearer that the v6 GRPCProvider implements `SetStateStoreChunkSize` * fix: Remove unnecessary assignment of chunk size I'm surprised that removing this doesn't break E2E tests of PSS that use grpcwrap, but I think there's `plugin6` code that runs in that situation, so maybe chunking is handled elsewhere. * chore: Add panic to try detect unexpected cases when setting chunk size. * feat: Add `providers.StateStoreChunkSizeSetter` implementation to provider-simple-v6 * docs: Update code comments for NewPluggable describing its intended use	5 months ago
Sarah French	2e5b5dee5d	Upgrade protoc and protoc-gen-go-grpc versions to matching terraform-plugin-go (#37647 ) * Update protoc version in downloader script * go get google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1 This matched terraform-plugin-go * make protobuf * Run `make protobuf` * Update generator to handle generic types from google.golang.org/grpc Looks like this was added in v1.69.3 in https://github.com/grpc/grpc-go/pull/7057 ? * Run `make generate` * Fix "cannot infer Res" compile error - more usage of generics * More fixing compile errors due to switching to use of a generic * Make putting `google.golang.org/grpc` import into generated files conditional * Run `make generate` * Update more places where generics now need to be used * Update generator to handle any types from google.golang.org/grpc in same switch case.	6 months ago
Radek Simko	51fc4c161f	PSS: Implement `ReadStateBytes` + `WriteStateBytes` (#37440 ) * Implement ReadStateBytes + WriteStateBytes * [WIP] - Testing ReadStateBytes and WriteStateBytes (#37464) * Fix nil pointer error * Add WIP test for ReadStateBytes * Move test mock to separate testing file * Update mock to send unexpected EOF when there's a problem returning data and it's not a true EOF * Add test case for when length != expected length * Add test for when trying to read state from a store type that doesn't exist * Change symbol names to lowercase * Add ability to force a diagnostic to be returned from `mockReadStateBytesClient`'s `Recv` method * Add test showing error diagnostics raised by the ReadStateBytes client are returned * Add missing header * Simplify mock by using an embedded type * Rename `mockOpts` to `mockReadStateBytesOpts` * Update existing tests to assert what arguments are passed to the RPC method call * Add mock WriteStateBytesClient which uses `go.uber.org/mock/gomock` to enable assertions about calls to Send * Add a test for WriteStateBytes that makes assertions about calls to the Send method * Update test case to explicitly test writing data smaller than the chunk size * Implement chunking in WriteStateBytes, add test case to assert expected chunking behaviour * Add generated mock for Provider_WriteStateBytesClient in protocol v6 * Update tests to use new `MockProvider_WriteStateBytesClient`, remove handwritten mock * Update code comments in test * Add tests for diagnostics and errors returned during WriteStateBytes * Add generated mock for Provider_ReadStateBytesClient in protocol v6, replace old mock * Add test case for grpc errors in ReadStateBytes, fix how error is returned * Typo in comment * Add missing warning test, rename some test cases * Update proto file definition of Read/WriteStateBytes RPCs (#37529) * Update Read/WriteStateBytes RPCs to match https://github.com/hashicorp/terraform-plugin-go/pull/531 * Run `make protobuf` * Run `make generate` * Update use of `proto.ReadStateBytes_ResponseChunk` in tests * Fix how diagnostics are handled alongside EOF error, update ReadStateBytes test * More fixes - test setup was incorrect I think? I assume that a response would be returned full of zero-values when EOF is encountered. * WIP - avoid crash if chunk is nil * Sarah's updates to radek/pss-read-write (#37642) * Update code to not expect a chunk when EOF encountered * Return early if any grpc errors are encountered during ReadStateBytes * Close the stream with CloseSend once everything's read without error. Add test case about handling grpc errors from CloseSend. * Fix test case about warnings: We would expect to receive a chunk with data alongside the warning and have a normal closing of the stream after EOF * Add log line, remove unneeded type info * Implement configurable state chunk size * handle metadata in WriteStateBytes correctly * validate chunk sizes received from provider * ReadStateBytes: avoid early return on warnings --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	7 months ago
Samsondeen	a7504719ef	list: send non-null "config" object to provider when not present in the list block (#37620 )	7 months ago
Kristin Laemmert	df113486a1	actions: remove references to action types, linked resources (#37616 ) * action renaming * actions: remove references to action types * actions: remove references to linked_resources or action types from the plan proto	7 months ago
Daniel Schmidt	871451122f	actions: move schema to single action type and remove linked resources we want to leave the door open to evolve the design in the future based on feedback	7 months ago
Daniel Schmidt	176263d936	actions: remove future action types removing them for now, this gives us more flexibility in the future since the schema is not yet locked in	8 months ago
Sarah French	037ed81e9e	PSS: Implement first gRPC methods: config validation and usage, listing and deleting workspaces (#37418 ) * Implement first grpc methods: config validation and use, listing and deleting workspaces * Add a state store to the default provider schema used in protocol 6 GRPCProvider tests * Add `ValidateStateStoreConfig` test that shows diagnostics are returned as expected * Add `ValidateStateStoreConfig` test that shows schema-related errors are returned before the `ValidateStateStoreConfig` RPC takes place * Add similar tests for `ConfigureStateStore` - check errors are returned and schema errors are caught early * Refactor to avoid looping over cases * Update `GetStates` to check the store type is implemented before retrieving states. Add tests. * Fix defect in DeleteState, update it to check state store type is valid * Add tests for `DeleteState` method --------- Co-authored-by: Radek Simko <radek.simko@gmail.com>	8 months ago
Daniel Banck	2563b07813	Allow list events with only warnings (#37415 ) This updates the event processing logic. Terraform now allows error and warning diagnostics for list events with all other fields set to null. The combination of a warning with a valid result is still possible.	9 months ago
Kristin Laemmert	0374f04424	Add ValidateActionConfig to provider interface, protocol & internal implementations (#37345 ) * Add ValidateActionConfig to provider interface and protocol * Update internal/provider-simple-v6/provider.go Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com> --------- Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	9 months ago
Daniel Schmidt	a2ce38ce12	use gomock generated mocks for the action invoke stream API	10 months ago
Daniel Schmidt	ac132d1b15	add provider implementation for actions	10 months ago
Samsondeen	e178088a5b	unwrap nested config (#37235 )	10 months ago
Samsondeen	cacd7861e5	add nested config block to list block (#37229 )	11 months ago
Samsondeen	685ff9f192	Schema representation of list block config and results (#37209 )	11 months ago
Daniel Banck	cb58a15f3d	Implement ListResource RPC (TF-25509) (#37092 ) * Implement ListResource RPC via callbacks * Implement ListResource with iterators * Change `ListResourceResponse` to slice * Turn ListResourceResponse into a struct * Add a limit for ListResource * explicitly cancel stream when listing resources --------- Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	11 months ago
Daniel Banck	44ae7da18e	Update Plugin Protocol for List and Implement `ValidateListResourceConfig` (#37007 ) * Minor auto-formatting changes * Add list RPC and schema protobuf definitions * make protobuf * make generate * Add ValidateListResourceConfig implementation	11 months ago
Daniel Banck	421fe3580f	Check GetResourceIdentitySchemas diagnostics and return early (#36999 )	11 months ago
Austin Valle	5c4c669882	Fix `ImportResourceState` RPC response decoding for identity data (#36806 ) * Fix `ImportResourceState` RPC response decoding for identity data * add tests for importy by identity * re-run action for flakey UI test	1 year ago
Daniel Banck	b2b42c0fb4	Store resource identities in state (TF-23255) (#36464 ) * Persist resource identity in Terraform state * make syncdeps * Move identity schema merging closer to the protocol * mock GetResourceIdentitySchemas * Fix identity refresh tests * Add more tests * Change grcpwrap upgrade identity * Review feedback * Remove unnecessary version conversion * Check if GetResourceIdentitySchemas RPC call is implemented * Update function signature docs * Adapt protocol changes * Check unimplemented error for identities in GetSchema	1 year ago
James Bardin	6f5007efe7	grpc mock tests	2 years ago
Jeff Bonhag	8b2941455a	Upgrade go-tfe from 1.51.0 to 1.58.0 (#35495 ) * go get github.com/hashicorp/go-tfe@v1.58.0 * Switch to go.uber.org/mock for mocks	2 years ago
Daniel Schmidt	5b8f77d2a4	stacks: add deferred actions to plugin protocol We are moving the deferred reason from plans/deferring to providers to have a single representation of deferred reason to be used from providers to the plan. Using the plan's representation causes circular dependencies. Co-authored-by: Matej Risek <matej.risek@hashicorp.com>	2 years ago
Brian Flad	c7a44bfc9a	Support Private State with MoveResourceState (#34575 ) This change ensures that providers receive the source private state and can store potentially differing private state as part of a move, rather than always copying the source private state to the target. This functionality has not yet been released and therefore there are no compatibility concerns.	2 years ago
James Bardin	f9713485a5	add mock tests for GetProviderSchemaOptional	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Brian Flad	0b404f4a95	Return early on GetProviderSchema RPC responses with error diagnostics Reference: https://github.com/hashicorp/terraform/issues/31047 Prevent potential panics and immediately return provider-defined errors diagnostics. Previously: ``` --- FAIL: TestGRPCProvider_GetSchema_ResponseErrorDiagnostic (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x17fa752] goroutine 13 [running]: testing.tRunner.func1.2({0x191a100, 0x2236330}) /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1389 +0x24e testing.tRunner.func1() /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1392 +0x39f panic({0x191a100, 0x2236330}) /usr/local/Cellar/go/1.18.2/libexec/src/runtime/panic.go:838 +0x207 github.com/hashicorp/terraform/internal/plugin6/convert.ProtoToConfigSchema(0x0) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin6/convert/schema.go:110 +0x52 github.com/hashicorp/terraform/internal/plugin6/convert.ProtoToProviderSchema(...) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin6/convert/schema.go:98 github.com/hashicorp/terraform/internal/plugin6.(GRPCProvider).GetProviderSchema(0xc00004a200) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin6/grpc_provider.go:152 +0x29a github.com/hashicorp/terraform/internal/plugin6.TestGRPCProvider_GetSchema_ResponseErrorDiagnostic(0x0?) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin6/grpc_provider_test.go:158 +0x265 testing.tRunner(0xc0001031e0, 0x1a733d8) /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1439 +0x102 created by testing.(T).Run /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1486 +0x35f ``` Previously: ``` --- FAIL: TestGRPCProvider_GetSchema_ResponseErrorDiagnostic (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x18a2732] goroutine 7 [running]: testing.tRunner.func1.2({0x1a5e720, 0x250be50}) /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1389 +0x24e testing.tRunner.func1() /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1392 +0x39f panic({0x1a5e720, 0x250be50}) /usr/local/Cellar/go/1.18.2/libexec/src/runtime/panic.go:838 +0x207 github.com/hashicorp/terraform/internal/plugin/convert.ProtoToConfigSchema(0x0) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin/convert/schema.go:104 +0x52 github.com/hashicorp/terraform/internal/plugin/convert.ProtoToProviderSchema(...) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin/convert/schema.go:92 github.com/hashicorp/terraform/internal/plugin.(GRPCProvider).GetProviderSchema(0xc00004a600) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin/grpc_provider.go:149 +0x29a github.com/hashicorp/terraform/internal/plugin.TestGRPCProvider_GetSchema_ResponseErrorDiagnostic(0x0?) /Users/bflad/src/github.com/hashicorp/terraform/internal/plugin/grpc_provider_test.go:130 +0x265 testing.tRunner(0xc0001031e0, 0x1be9500) /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1439 +0x102 created by testing.(T).Run /usr/local/Cellar/go/1.18.2/libexec/src/testing/testing.go:1486 +0x35f ```	4 years ago
Chris Arcand	369264865e	internal/plugin[6]: Add generated mocks	5 years ago
Martin Atkins	b40a4fb741	Move plugin/ and plugin6/ to internal/plugin{,6}/ This is part of a general effort to move all of Terraform's non-library package surface under internal in order to reinforce that these are for internal use within Terraform only. If you were previously importing packages under this prefix into an external codebase, you could pin to an earlier release tag as an interim solution until you've make a plan to achieve the same functionality some other way.	5 years ago

33 Commits (da74b59ea1d3aa4d7706579c95f63c778f2e515e)