1044 Commits (d3284bdc4ef12832fcc2fc62738fda2d816fd2ab)

Author	SHA1	Message	Date
Alisdair McDiarmid	d3284bdc4e	Merge pull request #31220 from FooBartn/string-starts-ends-with-funcs ... feat: add startswith and endswith funcs	4 years ago
Jeff Bonhag	f30738d965	Add golden reference test for JSON plan (#31362) ... * Add golden JSON test for Terraform plan * Add data source to golden JSON plan * Move output comparison code into shared helper function * Add note for maintainer to contact TFC when UI changes UI changes may potentially impact the behavior of structured run output on TFC. * Add test_data_source to other mock providers	4 years ago
Tom Bamford	dc1f5bccf8	Merge pull request #31070 from hashicorp/f/removing-adal-auth ... backend/azurerm: exclusively using Microsoft Graph/MSAL and removing Azure Active Directory Graph/ADAL	4 years ago
Brian Sidebotham	a6aa75931b	Update internal/command/fmt.go ... Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>	4 years ago
Brian Sidebotham	7dd199cbd0	Fixes #30072 - Update documentation to show that the old DIR option can target a single file instead	4 years ago
Radek Simko	7feef1c4aa	Use hashicorp/terraform-registry-address as a decoupled library (#28338) ... * refactor: Use tfaddr for provider address parsing * refactor: Use tfaddr for module address parsing * deps: introduce hashicorp/terraform-registry-address	4 years ago
Martin Atkins	de8eef1da5	addrs: Format string instance keys in an HCL-compatible way ... So far we've only ever needed to re-parse address strings that happen not to contain instance keys and so we've gotten away with our serialization of these not being quite right, but given how liberally we've expected to be able to use address strings from this package for wire format interchange it seems likely that this is going to surprise us eventually. Now we'll use an escaping scheme compatible with HCL's parser rather than Go's parser, and so we can safely rely on hclsyntax.ParseTraversal as part of reversing this operation to transform an address string back into an address equivalent to the value it was created from.	4 years ago
James Bardin	26c569e384	s/Capabilities/ServerCapabilities/	4 years ago
James Bardin	fd742cd544	add e2e test with provider schema capabilities ... enable destroy planning for the simple providers used in the e2e tests	4 years ago
James Bardin	6706d52832	check PlanDestroy capability in plugins ... This is most easily handled in the plugin code, without involving Terraform core. The biggest change here other than checking the PlanDestroy capability, is the removal of the schema helper methods in the plugins. With the addition of the capabilities field, combined with the necessity of checking diagnostics from the schema, the helpers have outlived their usefulness. Perhaps there's a better pattern for these repetitive calls, but for now there isn't too extra verbosity involved.	4 years ago
James Bardin	b9f1a5ac57	add Schema Capabilities to protocol	4 years ago
James Bardin	9487cfba28	add test for planned private data in destroy	4 years ago
James Bardin	96c720517f	fixup broken test fixtures ... some of the minimal test provider implementations didn't check for null values.	4 years ago
James Bardin	acba1159e4	add provider metas to destroy plan	4 years ago
James Bardin	ccd2c7820a	plan resource destroy ... Call PlanResourceDestroy during a destroy plan. This allows providers two new abilities: - They can evaluate if the plan is valid, notifying users of any potential errors before an apply is started, which may not be able to complete. - They can inspect and modify their private data during a destroy plan just like they can with an other plan operation.	4 years ago
James Bardin	e95bfe6d19	fix test mocks to behave when planning destroys	4 years ago
James Bardin	1214a16a63	Merge pull request #31347 from hashicorp/jbardin/remove-etcdv3 ... remove deprecated etcdv3 backend	4 years ago
Martin Atkins	b88e29e473	configs: Show tailored message for optional attrs experiment ... Since we've both concluded the module_variables_optional_attrs experiment and made experiments available only in alpha releases in the same minor release, we accidentally made the more general message about experiments not being available mask the specific message about the experiment being concluded. In order to give better feedback to those who were participating in the experiment in earlier Terraform releases, we'll retain a minimal exception to our checks to allow the "experiment has concluded" error message to shine through if and only if that is the only selected experiment.	4 years ago
Joshua Barton	fd3798b276	tests: add test cases around empty values	4 years ago
Joshua Barton	c73c0ad63c	feat: add startswith and endswith funcs	4 years ago
James Bardin	d61d3e9fd8	remove deprecated etcdv3 backend	4 years ago
Liam Cervante	acb79a7545	Standardise how blank lines are added to plan for unchanged blocks (#31330) ... * Standardise blank lines added to plan for unchanged blocks * Fix copy-paste error inside NestingList logic	4 years ago
Liam Cervante	d876e68e2d	Fail global required_version check if it contains any prerelease fields (#31331) ... * Fail global required_version check if it contains any prerelease fields * go mod tidy * Improve required_version prerelease not supported error string * Add prerelease version constraint unit tests * Fix side-effects by populating global diags too soon	4 years ago
James Bardin	953c448f9a	add simple error indicating backend removal ... There are no good options for inserting diagnostics into the backend lookup, or creating a backend which reports it's removal because none of the init or GetSchema functions return any errors. Keep a registry of the removed backend so that we can at least notify users that a backend was removed vs an invalid name.	4 years ago
James Bardin	799ab6c951	remove deprecated etcd backend ... This allows us to remove the manual replace directives github.com/dgrijalva/jwt-go and google.golang.org/grpc, so that we can remove the CVE warnings and update the grpc packages. While the etcdv3 backend is also marked as deprecated, the changes here are done in a manner to keep that backend working for the time being.	4 years ago
Martin Atkins	90ea7b0bc5	tfdiags: Treat unknown-related or sensitive-related messages differently ... By observing the sorts of questions people ask in the community, and the ways they ask them, we've inferred that various different people have been confused by Terraform reporting that a value won't be known until apply or that a value is sensitive as part of an error message when that message doesn't actually relate to the known-ness and sensitivity of any value. Quite reasonably, someone who sees Terraform discussing an unfamiliar concept like unknown values can assume that it must be somehow relevant to the problem being discussed, and so in that sense Terraform's current error messages are giving "too much information": information that isn't actually helpful in understanding the problem being described, and in the worst case is a distraction from understanding the problem being described. With that in mind then, here we introduce an explicit annotation on diagnostic objects that are directly talking about unknown values or sensitive values, and then the diagnostic renderer will react to that to avoid using the terminology "known only after apply" or "sensitive" in the generated diagnostic annotations unless we're rendering a message that is explicitly related to one of those topics. This ends up being a bit of a cross-cutting concern because the code that generates these diagnostics and the code that renders them are in separate packages and are not directly aware of each other. With that in mind, the logic for actually deciding for a particular diagnostic whether it's flagged in one of these special ways lives inside the tfdiags package as an intermediation point, which both the diagnostic generator (in the core package) and the diagnostic renderer can both depend on.	4 years ago
Martin Atkins	31aee9650e	command/format: Include function call information in diagnostics ... When an error occurs in a function call, the error message text often includes references to particular parameters in the function signature. This commit improves that reporting by also including a summary of the full function signature as part of the diagnostic context in that case, so a reader can see which parameter is which given that function arguments are always assigned positionally and so the parameter names do not appear in the caller's source code.	4 years ago
Martin Atkins	8405f46bc5	tfdiags: Expose the "extra information" concept from HCL ... HCL's diagnostic model now includes the idea of "extra information" which works by attaching an initially-opaque interface value to each diagnostic and then asking callers to type-assert against that value to sniff for particular interfaces in order to discover additional machine-readable context about a certain diagnostic message. This commit echoes that idea into our tfdiags API, for now only for diagnostics that are backed by an hcl.Diagnostic. All other implementations of the diagnostic interface just always return nil, which means they never carry any "extra information". As is typical for our wrapping abstraction, we have here also a modified copy of HCL's helper function for conveniently probing a diagnostic for information of a particular type, designed to work with our diagnostic interface instead of HCL's concrete diagnostic type.	4 years ago
James Bardin	77e6b622f8	Merge pull request #31283 from hashicorp/jbardin/plan-import ... Use plan graph for importing resources	4 years ago
James Bardin	142ce15ed6	remove unused field and extra assignment	4 years ago
Alisdair McDiarmid	a5f307b5e4	Merge pull request #31293 from dennygursky/main ... Performance: string builder speedup for Module.String()	4 years ago
Alisdair McDiarmid	ad52076025	addrs: Add tests for Module.String	4 years ago
James Bardin	c43df009db	add required attr to import test ... Missing required attributes should not prevent importing	4 years ago
Dennis Gursky	2c1b1f3aa1	Update module.go ... making code more similar to https://github.com/hashicorp/terraform/blob/main/internal/addrs/module_instance.go	4 years ago
Denny Gursky	8a694e81ff	string builder speed up for Module.String()	4 years ago
Alisdair McDiarmid	64cf53bd7e	configs: Fix check block configuration diagnostics ... When validating self-references for resource and data source preconditions and postconditions, we previously did not nil-check the block's condition field, which caused a panic when the block had no condition. While fixing this I noticed that we were not validating that there are no self-references in the error message, so fixed that.	4 years ago
James Bardin	4981942191	remove -allow-missing-config from import	4 years ago
James Bardin	03fc2b09df	remove errant fmt.Println	4 years ago
James Bardin	77cca0af7c	remove import transformer	4 years ago
James Bardin	c002bab730	update test fixtures for better imports	4 years ago
James Bardin	e97ae28441	Combine all plan graphs, including import ... Combine all plan-time graphs into a single graph builder, because _everything is a plan_! Convert the import graph to a plan graph. This should resolve a few edge cases about things not being properly evaluated during import, and takes a step towards being able to _plan_ an import.	4 years ago
Martin Atkins	fda0579537	Experiments supported only in alpha/dev builds ... We originally introduced the idea of language experiments as a way to get early feedback on not-yet-proven feature ideas, ideally as part of the initial exploration of the solution space rather than only after a solution has become relatively clear. Unfortunately, our tradeoff of making them available in normal releases behind an explicit opt-in in order to make it easier to participate in the feedback process had the unintended side-effect of making it feel okay to use experiments in production and endure the warnings they generate. This in turn has made us reluctant to make use of the experiments feature lest experiments become de-facto production features which we then feel compelled to preserve even though we aren't yet ready to graduate them to stable features. In an attempt to tweak that compromise, here we make the availability of experiments _at all_ a build-time flag which will not be set by default, and therefore experiments will not be available in most release builds. The intent (not yet implemented in this PR) is for our release process to set this flag only when it knows it's building an alpha release or a development snapshot not destined for release at all, which will therefore allow us to still use the alpha releases as a vehicle for giving feedback participants access to a feature (without needing to install a Go toolchain) but will not encourage pretending that these features are production-ready before they graduate from experimental. Only language experiments have an explicit framework for dealing with them which outlives any particular experiment, so most of the changes here are to that generalized mechanism. However, the intent is that non-language experiments, such as experimental CLI commands, would also in future check Meta.AllowExperimentalFeatures and gate the use of those experiments too, so that we can be consistent that experimental features will never be available unless you explicitly choose to use an alpha release or a custom build from source code. Since there are already some experiments active at the time of this commit which were not previously subject to this restriction, we'll pragmatically leave those as exceptions that will remain generally available for now, and so this new approach will apply only to new experiments started in the future. Once those experiments have all concluded, we will be left with no more exceptions unless we explicitly choose to make an exception for some reason we've not imagined yet. It's important that we be able to write tests that rely on experiments either being available or not being available, so here we're using our typical approach of making "package main" deal with the global setting that applies to Terraform CLI executables while making the layers below all support fine-grain selection of this behavior so that tests with different needs can run concurrently without trampling on one another. As a compromise, the integration tests in the terraform package will run with experiments enabled _by default_ since we commonly need to exercise experiments in those tests, but they can selectively opt-out if they need to by overriding the loader setting back to false again.	4 years ago
Alisdair McDiarmid	479c71f93d	Merge pull request #31210 from hashicorp/update-optional-type-attributes ... Edit type constraints docs for style and flow	4 years ago
Alisdair McDiarmid	0f39ead096	Merge pull request #31263 from hashicorp/alisdair/backend-remote-locks-helper-lockerror-test ... states/remote: Check for LockError error type	4 years ago
Alisdair McDiarmid	c7bc82bd87	Merge pull request #31235 from hashicorp/alisdair/json-plan-unknown-outputs ... json-output: Extended detail for unknown outputs	4 years ago
Alisdair McDiarmid	7fcf9734ef	Merge pull request #31236 from hashicorp/alisdair/json-plan-fix-tuple-set-unknown ... json-output: Fix unknowns for tuples and sets	4 years ago
Alisdair McDiarmid	d2087fa98b	states/remote: Check for LockError error type ... When attempting to lock a remote state backend, failure due to an existing lock should return an instance of LockError. This allows the wrapping code to retry until the specified timeout, instead of immediately exiting. This commit adds a test for this in the TestRemoteLocks test helper, which is used in many of the remote state backend test suites.	4 years ago
Alisdair McDiarmid	b0b69d3fad	Merge pull request #31256 from nvanheuverzwijn/vanheu/http-patch ... http-backend: http backend lock error return LockError instead of generic error	4 years ago
Nicolas Vanheuverzwijn	bb1c134b94	http-backend: http backend lock error return LockError instead of generic error	4 years ago
Martin Atkins	dc5964f8a3	refactoring: Use addrs.Map for maps with addresses as keys ... We introduced the addrs.UniqueKey and addrs.UniqueKeyer mechanics as part of implementing the ValidateMoves and ApplyMoves functions, as a way to better encapsulate the solution to the problem that lots of our address types aren't comparable and so cannot be used directly as map keys. However, exposing addrs.UniqueKey handling directly in the logic adds various noise to the algorithms and, in particular, obscures the fact that MoveResults.Changes and MoveResult.Blocked both have different map key types. Here then we'll use the new addrs.Map helper type, which encapsulates the idea of a map from an addrs.UniqueKeyer type to an arbitrary value type, using the unique keys as the map keys internally. This does unfortunately mean that we lose the conventional Go map access syntax and have to use a method-based API instead, but I (subjectively) think that's an okay compromise in return for avoiding the need to keep track inline of which addrs.UniqueKey values correspond with which real addresses. This is intended as an entirely-mechanical change, with equivalent behavior to what it replaced. If anything here is doing something materially different than what it replaced then that's a mistake.	4 years ago