23 Commits (cef46ef953face71f52f4e900a0ea2132ebfae88)

Author	SHA1	Message	Date
Sander van Harmelen	af1a471a05	command/state: update and fix the state list command	8 years ago
Martin Atkins	04f076d780	addrs: Implement Equal for resource address types ... This is primarily to get good default behavior for test helpers that do deep comparison of values, but may also be convenient elsewhere.	8 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	ba894ee05c	addrs: More string parsing helpers for addresses ... Our main "parse" methods in this package work with hcl.Traversals, but we're gradually adding helpers to parse these directly froms strings since the visual noise of doing the traversal parse first is inconvenient in situations where addresses are coming from non-config locations where no source information is available anyway.	8 years ago
Martin Atkins	00199cd2ed	addrs: "Less" comparison method for resource and module instances ... This can be used to sort lists of resource instance and module instance addresses, such as in a rendered plan.	8 years ago
Martin Atkins	c036613ed3	addrs: Helper function for parsing absolute provider config strings	8 years ago
Martin Atkins	6bbfbab93e	core: Produce correct references for destroy nodes ... Prior to the introduction of our "addrs" package, we represented destroy nodes as a special kind of address string ending in ".destroy" or ".destroy-cbd". Using references to resolve these dependencies is a strange idea to begin with, since these are not user-visible addresses, but rather than refactor that now we instead have these weird pseudo-address types ResourcePhase and ResourceInstancePhase that correspond go those weird address suffixes, thus restoring the prior behavior. In future we should rework this so that destroy node edges are not handled as references at all, and instead handled as part of DestroyEdgeTransformer where there's better context for implementing this logic and it can be maintained and tested in a single place.	8 years ago
Martin Atkins	26e820d829	addrs: Don't return zero-length slice in Reference.Remaining. ... Although this rarely matters, making it always be nil when empty makes deep assertions simpler in tests. This also includes a minor update to the test in the core package that first encountered this problem, to improve the quality of its output on failure.	8 years ago
Martin Atkins	4833d2aa79	addrs: helper wrappers for parsing addresses in strings ... Our "Parse..." functions all take hcl.Traversal objects rather than strings, assuming that in most cases we've already parsed a traversal out of some larger construct (usually a config file) before interpreting it as an address. However, there are some situations -- particularly tests -- where being able to easily parse a string directly is helpful. These new "Parse...Str" functions all wrap the function of the same name with no "Str" suffix and first parse the string with the HCL native syntax traversal parser. As noted in the function doc comments, this should not be used in "real" code except in exceptional circumstances, since it creates addresses and diagnostics that do not have useful source location information for reporting diagnostics.	8 years ago
Martin Atkins	f107a4bc33	addrs: Generate special string for invalid ProviderConfig ... The zero value of ProviderConfig is not a valid provider config address, so we'll generate a special string for that in order to make that clear in case one sneaks in somewhere. This can happen, for example, in the core flow of resolving provider inheritance during the ProviderTransformer if a caller attempts to access the resolved provider before that transformer has run.	8 years ago
Martin Atkins	5e8445b7a5	addrs: Resource.String shouldn't ever crash ... Previously we had a panic in here for invalid resource modes. While that does always indicate a programming error, it's frustrating to have a crasher inside a String method since it often impedes our ability to report an error properly, since the error reporting itself can crash. Instead we'll just return an invalid string and hope the caller really is bailing out with an error message.	8 years ago
Martin Atkins	119c80d5e2	addrs: ModuleInstance methods for building AbsProviderConfig ... These helpers, similar to other such methods on ModuleInstance, are useful for programmatically constructing provider config addresses, particularly in tests where this is more straightforward than parsing from strings.	8 years ago
Martin Atkins	b9c4780f07	addrs: Helper methods for converting module calls to absolute modules	8 years ago
Martin Atkins	c97dd145b9	addrs: Module.Call method ... This is a helper for splitting a non-root module path into a callee and call pair, similar to the method of the same name on ModuleInstance.	8 years ago
Martin Atkins	072322336e	addrs: AbsProviderConfig.Inherited method ... This helper deals with the address wrangling required to find the address that a provider configuration might inherit from if no explicit configuration is given and instead configuration is taken from the parent module. This method is not generally useful, and is here mainly just to help the provider-related graph transformations in the main terraform package.	8 years ago
Martin Atkins	02b25e7057	addrs: flesh out functionality ready to replace terraform.ResourceAddress ... This "kitchen sink" commit is mainly focused on supporting "targets" as a new sub-category of addresses, for use-case like the -target CLI option, but also includes some other functionality to get closer to replacing terraform.ResourceAddress and fill out some missing parts for representing various other address types that are currently represented as strings in the "terraform" package.	8 years ago
Martin Atkins	c6598a3f86	addrs: ParseAbsProviderConfig function ... This is for parsing the type of provider configuration address we write into state in order to remember which provider configuration is responsible for each resource.	8 years ago
Martin Atkins	8ca174b133	addrs: implement String for AbsResource and AbsResourceInstance	8 years ago
Martin Atkins	fca07d1a61	addrs: AbsProviderConfig type ... Fitting with the usual naming scheme, this is the combination of a module instance address and a provider config.	8 years ago
Martin Atkins	cd51864d84	configs: Start using the new "addrs" package types for modules ... We initially just mimicked our old practice of using []string for module paths here, but the addrs package now gives us a pair of types that better capture the two different kinds of module addresses we are dealing with: static addresses (nodes in the configuration tree) and dynamic/instance addresses (which can represent the situation where multiple instances are created from a single module call). This distinction still remains rather artificial since we don't yet have support for count or for_each on module calls, but this is intended to lay the foundations for that to be added later, and in the mean time just gives us some handy helper functions for parsing and formatting these address types.	8 years ago
Martin Atkins	e5dfa17433	addrs: All Referenceable implementations support String() ... This gives us a convenient way to convert back to a string representation that matches what the user would've written in configuration.	8 years ago
Martin Atkins	63041ffa09	addrs: ParseRef function, for parsing references in expressions ... This function corresponds to terraform.NewInterpolatedVariable, but built with HCL2 primitives. It accepts a hcl.Traversal, which is what is returned from the HCL2 API functions to find which variables are referenced in a given expression.	8 years ago
Martin Atkins	b9d84f2944	addrs: new package for representing addresses ... This package is intended to contain all the functionality for parsing, representing, and formatting addresses of objects within Terraform. It will eventually subsume the responsibilities of both the InterpolatedVariable and ResourceAddress types in the "terraform" package, but for the moment is just a set of types for representing these things, lacking any way to parse or format them. The remaining functionality will follow in subsequent commits.	8 years ago