terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	6cd22a4c9a	helper/schema: emit warning when using data source resource shim For backward compatibility we will continue to support using the data sources that were formerly logical resources as resources for the moment, but we want to warn the user about it since this support is likely to be removed in future. This is done by adding a new "deprecation message" feature to schema.Resource, but for the moment this is done as an internal feature (not usable directly by plugins) so that we can collect additional use-cases and design a more general interface before creating a compatibility constraint.	10 years ago
Martin Atkins	6a468dcd83	helper/schema: Resource can be writable or not In the "schema" layer a Resource is just any "thing" that has a schema and supports some or all of the CRUD operations. Data sources introduce a new use of Resource to represent read-only resources, which require some different InternalValidate logic.	10 years ago
Martin Atkins	0e0e3d73af	core: New ResourceProvider methods for data resources This is a breaking change to the ResourceProvider interface that adds the new operations relating to data sources. DataSources, ValidateDataSource, ReadDataDiff and ReadDataApply are the data source equivalents of Resources, Validate, Diff and Apply (respectively) for managed resources. The diff/apply model seems at first glance a rather strange workflow for read-only resources, but implementing data resources in this way allows them to fit cleanly into the standard plan/apply lifecycle in cases where the configuration contains computed arguments and thus the read must be deferred until apply time. Along with breaking the interface, we also fix up the plugin client/server and helper/schema implementations of it, which are all of the callers used when provider plugins use helper/schema. This would be a breaking change for any provider plugin that directly implements the provider interface, but no known plugins do this and it is not recommended. At the helper/schema layer the implementer sees ReadDataApply as a "Read", as opposed to "Create" or "Update" as in the managed resource Apply implementation. The planning mechanics are handled entirely within helper/schema, so that complexity is hidden from the provider implementation itself.	10 years ago
Mitchell Hashimoto	b728e55861	helper/schema: Resource.Data should set latest schema version	10 years ago
Mitchell Hashimoto	19609bde0e	helper/schema: can specify Importer on Resource, InternalValidate	10 years ago
Mitchell Hashimoto	b8121ea63e	helper/schema: Resource.Data to return a ResourceData for a Resource	10 years ago
Radek Simko	8bdd92187c	Merge pull request #4446 from TimeIncOSS/f-schema-new-resource helper/schema: Allow identification of a new resource in update func	10 years ago
Paul Hinze	c70eab6500	aws: undeprecate min_elb_capacity; restore min capacity waiting It was a mistake to switched fully to `==` when activating waiting for capacity on updates in #3947. Users that didn't set `min_elb_capacity == desired_capacity` and instead treated it as an actual "minimum" would see timeouts for every create, since their target numbers would never be reached exactly. Here, we fix that regression by restoring the minimum waiting behavior during creates. In order to preserve all the stated behavior, I had to split out different criteria for create and update, criteria which are now exhaustively unit tested. The set of fields that affect capacity waiting behavior has become a bit of a mess. Next major release I'd like to rework all of these into a more consistently named block of config. For now, just getting the behavior correct and documented. (Also removes all the fixed names from the ASG tests as I was hitting collision issues running them over here.) Fixes #4792	10 years ago
Radek Simko	4c6ceef9b8	helper/schema: Allow identification of a new resource in update func	10 years ago
Panagiotis Moustafellos	e4845f75cc	removed extra parentheses	11 years ago
Radek Simko	641b701830	schema: Make validation more strict	11 years ago
Paul Hinze	7eb72e7a12	helper/schema: record schema version when destroy fails This was just a missed exit from the resource.Apply function - subsequent refreshes would add the SchemaVersion back into the state, but having the state recorded once without the meta information can cause problems with Atlas's remote state checksumming.	11 years ago
Mitchell Hashimoto	dd24ed4b76	helper/schema: blank ID refresh doesn't exist [GH-1905]	11 years ago
Paul Hinze	1e3d1b07e6	helper/schema: validate ConflictsWith against top-level The runtime impl of ConfictsWith uses Resource.Get(), which makes it work with any other attribute of the resource - the InternalValidate was only checking against the local schemaMap though, preventing subResource from using ConflictsWith properly. It's a lot of wiring and it's a bit ugly, but it's not runtime code, so I'm a bit less concerned about that aspect. This should take care of the problem mentioned in #1909	11 years ago
Paul Hinze	66dbf91ffd	helper/schema: ensure ForceNew set when Update is not If a given resource does not define an `Update` function, then all of its attributes must be specified as `ForceNew`, lest Applys fail with "doesn't support update" like #1367. This is something we can detect automatically, so this adds a check for it when we validate provider implementations.	11 years ago
Paul Hinze	3ba8ed536b	helper/schema: record schema version on apply We were previously only recording the schema version on refresh. This caused the state to be incorrectly written after a `terraform apply` causing subsequent commands to run the state through an unnecessary migration.	11 years ago
Paul Hinze	3d4b55e557	helper/schema: schema versioning & migration Providers get a per-resource SchemaVersion integer that they can bump when a resource's schema changes format. Each InstanceState with an older recorded SchemaVersion than the cureent one is yielded to a `MigrateSchema` function to be transformed such that it can be addressed by the current version of the resource's Schema.	11 years ago
Mitchell Hashimoto	48b9614556	helper/schema: Exists API	11 years ago
Mitchell Hashimoto	d0ce67a5b7	helper/schema: on destroy/create, reset state to be empty [GH-464]	12 years ago
Mitchell Hashimoto	9b2b3a963f	ResourceDiff => InstanceDiff	12 years ago
Mitchell Hashimoto	81d9d70296	helper/schema: conforms to new API, tests pass	12 years ago
Mitchell Hashimoto	c9a541d95b	helper/schema: generate a full diff in destroy/create cycle	12 years ago
Mitchell Hashimoto	0c9b65f3f4	helper/schema: documentation	12 years ago
Mitchell Hashimoto	40e5608fa9	helper/schema: return the prior state if Data is an error	12 years ago
Mitchell Hashimoto	37cf52fa27	helper/schema: if no ID is set then return nil	12 years ago
Mitchell Hashimoto	5fc41cc272	helper/schema: properly put "id" into attributes	12 years ago
Mitchell Hashimoto	021a23fe99	helper/schema: if update sets the ID to blank, it deletes the resource	12 years ago
Mitchell Hashimoto	2444986fe8	helper/schema: nice error if update isn't supported	12 years ago
Mitchell Hashimoto	c418681cc3	helper/schema: create/update/delete should work for Resource	12 years ago
Mitchell Hashimoto	894187ec18	helper/schema: Resource.Refresh	12 years ago
Mitchell Hashimoto	51a44db6c2	helper/schema: move InternalValidate to schemaMap	12 years ago
Mitchell Hashimoto	a33e4bcdf0	helper/schema: properly validate sub-resources	12 years ago
Mitchell Hashimoto	7bc0be4b81	helper/schema: couple more tests around Computed (+ fix)	12 years ago
Mitchell Hashimoto	4af387b986	helper/schema: validation	12 years ago
Mitchell Hashimoto	31067ee8f6	helper/schema: ResourceData, starting tests	12 years ago
Mitchell Hashimoto	7f14708e71	helper/schema: list ForceNew	12 years ago
Mitchell Hashimoto	01b6b5f48e	helper/schema: initial work	12 years ago

37 Commits (cdcff09d99d8d1a0142f583f7fab650ca54e781d)