551 Commits (cdcff09d99d8d1a0142f583f7fab650ca54e781d)

Author	SHA1	Message	Date
James Nugent	6c23181686	Merge pull request #8383 from kjmkznr/import-aws-s3-b-notification ... provider/aws: Support import `aws_s3_bucket_notification`	10 years ago
Paul Stack	bf755bb5c9	Merge pull request #8585 from hashicorp/f-diff-suppression ... helper/schema: Add diff suppression callback	10 years ago
James Nugent	85ec09111b	helper/schema: Add diff suppression callback ... This commit adds a new callback, DiffSuppressFunc, to the schema.Schema structure. If set for a given schema, a callback to the user-supplied function will be made for each attribute for which the default type-based diff mechanism produces an attribute diff. Returning `true` from the callback will suppress the diff (i.e. pretend there was no diff), and returning false will retain it as part of the plan. There are a number of motivating examples for this - one of which is included as an example: 1. On SSH public keys, trailing whitespace does not matter in many cases - and in some cases it is added by provider APIs. For digitalocean_ssh_key resources we previously had a StateFunc that trimmed the whitespace - we now have a DiffSuppressFunc which verifies whether the trimmed strings are equivalent. 2. IAM policy equivalence for AWS. A good proportion of AWS issues relate to IAM policies which have been "normalized" (used loosely) by the IAM API endpoints. This can make the JSON strings differ from those generated by iam_policy_document resources or template files, even though the semantics are the same (for example, reordering of `bucket-prefix/` and `bucket-prefix/*` in an S3 bucket policy. DiffSupressFunc can be used to test for semantic equivalence rather than pure text equivalence, but without having to deal with the complexity associated with a full "provider-land" diff implementation without helper/schema.	10 years ago
James Bardin	e0014198e1	Merge pull request #8560 from hashicorp/jbardin/race2 ... Fix races in WaitForState	10 years ago
Mitchell Hashimoto	aaaed823af	Merge pull request #8508 from TimeIncOSS/f-schema-all-validation-errors ... schema: Return all validation errors together from InternalValidate	10 years ago
James Bardin	481f12cf2c	Remove `first` variable an extra if block ... clean up the code slighly by moving the Sleep in WaitForState to the end of the loop.	10 years ago
James Bardin	82be35a797	Fix races in WaitForState ... The WaitForState method can't read the result values in a timeout because they are still owned by the running goroutine. Keep all values scoped inside the goroutine, and save them into an atomic.Value to be returned. Fixes race introduced in #8510	10 years ago
Radek Simko	506c118383	helper/resource: Show last state in timeout err message	10 years ago
Radek Simko	aef2513b44	helper/resource: Fix WaitForState tests	10 years ago
Radek Simko	b90ab0b705	schema: Return all validation errors together from InternalValidate	10 years ago
James Nugent	df06d5623d	Merge pull request #8249 from meteor/glasser/name-prefix-timestamp ... core: name_prefix names now start with a timestamp	10 years ago
Kazunori Kojima	ed05161fd0	provider/aws: Support import `aws_s3_bucket_notification`	10 years ago
James Nugent	6ae7140251	Merge pull request #8370 from hashicorp/dtolnoy-wait ... Do not sleep between first attempt or between successful attempts	10 years ago
James Nugent	0a5acaa0d8	Change error message return structure	10 years ago
David Tolnay	9d3f40a513	Fix bad message from TimeoutError ... Before: Error creating IAM Role my-role: timeout while waiting for state to become 'success'. last error: %!s(<nil>)	10 years ago
David Tolnay	e27a735da2	Do not sleep between first attempt or between successful attempts	10 years ago
David Glasser	4ad825fe08	core: name_prefix names now start with a timestamp ... This means that two resources created by the same rule will get names which sort in the order they are created. The rest of the ID is still random base32 characters; we no longer set the bit values that denote UUIDv4. The length of the ID returned by PrefixedUniqueId is not changed by this commit; that way we don't break any resources where the underlying resource has a name length limit. Fixes #8143.	10 years ago
James Nugent	b551981cc7	testing: Add ComposeAggregateTestFunc ... This commit adds a function which composes a series of TestFuncs, but will run all tests before returning an error, unlike ComposeTestFunc. This is useful when verifying contents of state in acceptance tests and it is desirable to see all the failing cases in one run for slow resources.	10 years ago
Mitchell Hashimoto	f26d1b40e0	Merge pull request #8215 from hashicorp/f-signalwrapper ... helper/signalwrapper and azurerm_storage_account listens for signals	10 years ago
Mitchell Hashimoto	8dafcb36fd	providers/azurerm: cancellable storage account creation	10 years ago
Mitchell Hashimoto	d8337920f9	helper/signalwrapper: more tests	10 years ago
Mitchell Hashimoto	bdcea55117	helper/signalwrapper	10 years ago
James Nugent	b681ab23d3	testing: Add TestCheckResourceAttrSet helper ... This commit adds a TestCheckFunc which ensures that a value is set for a given name/key combination. It is primarily useful for ensuring that computed values are set where it is not possible to know the expected value ahead of time.	10 years ago
Paul Hinze	3dccfa0cc9	terraform: diffs with only tainted set are non-empty ... Fixes issue where a resource marked as tainted with no other attribute diffs would never show up in the plan or apply as needing to be replaced. One unrelated test needed updating due to a quirk in the testDiffFn logic - it adds a "type" field diff if the diff is non-Empty. NBD	10 years ago
James Bardin	1af7ee87a2	Silence log output when not verbose ... Set the default log package output to iotuil.Discard during tests if the `-v` flag isn't set. If we are verbose, then apply the filter according to the TF_LOG env variable.	10 years ago
James Bardin	074be9ae56	Another race in resource.Retry	10 years ago
Paul Hinze	261043fd1a	Merge pull request #7523 from hashicorp/f-aws-beanstalk-env-poll-timing ... provider/aws: Beanstalk environments, bump the minimum timeout between API calls	10 years ago
Paul Hinze	614806d59f	helper/resource: Fix import test harness, which was modifying state ... Maps are reference types, it turns out :D	10 years ago
clint shryock	de60481428	provider/aws: Rework Beanstalk optional polling ... expose a poll_interval for users to configure polling for updates	10 years ago
David Tolnay	7096e4d3da	Return nonnegative hash if int is 32 bits	10 years ago
Paul Hinze	3b732131d2	Merge pull request #7446 from hashicorp/b-jit-resource-validate ... core: rerun resource validation before plan and apply	10 years ago
Paul Hinze	ad27190852	Merge pull request #7448 from dtolnay/timeout ... Timing out is not success	10 years ago
Paul Hinze	afccf62e3e	Merge pull request #7459 from hashicorp/r-resource-unit-test ... helper/resource: Consolidate unit test override	10 years ago
Paul Hinze	4a1b36ac0d	core: rerun resource validation before plan and apply ... In #7170 we found two scenarios where the type checking done during the `context.Validate()` graph walk was circumvented, and the subsequent assumption of type safety in the provider's `Diff()` implementation caused panics. Both scenarios have to do with interpolations that reference Computed values. The sentinel we use to indicate that a value is Computed does not carry any type information with it yet. That means that an incorrect reference to a list or a map in a string attribute can "sneak through" validation only to crop up... 1. ...during Plan for Data Source References 2. ...during Apply for Resource references In order to address this, we: * add high-level tests for each of these two scenarios in `provider/test` * add context-level tests for the same two scenarios in `terraform` (these tests proved _really_ tricky to write!) * place an `EvalValidateResource` just before `EvalDiff` and `EvalApply` to catch these errors * add some plumbing to `Plan()` and `Apply()` to return validation errors, which were previously only generated during `Validate()` * wrap unit-tests around `EvalValidateResource` * add an `IgnoreWarnings` option to `EvalValidateResource` to prevent active warnings from halting execution on the second-pass validation Eventually, we might be able to attach type information to Computed values, which would allow for these errors to be caught earlier. For now, this solution keeps us safe from panics and raises the proper errors to the user. Fixes #7170	10 years ago
Paul Hinze	5656d7388c	helper/resource: Consolidate unit test override ... I noticed we had two mechanisms for unit test override. One that dropped a sentinel into the env var, and another with a struct member on TestCase. This consolidates the two, using the cleaner struct member internal mechanism and the nicer `resource.UnitTest()` entry point.	10 years ago
David Tolnay	7e1cd34819	Timing out is not success	10 years ago
Clint	a84aa5e914	Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436)	10 years ago
Radek Simko	37d57f4a85	Improve naming convention (resultSet -> exists)	10 years ago
Radek Simko	917ad44cf0	helper/schema: Fix readSet implementation (DiffFieldReader)	10 years ago
Radek Simko	c738c5a9a3	helper/schema: Implement reader-specific readList method	10 years ago
Radek Simko	378b526dc3	helper/schema: Add regression tests for nested Set/List ... Although DiffFieldReader was the one mostly responsible for a buggy behaviour more tests were added throughout the debugging process most of which would fail without the bugfix. - ResourceData - MultiLevelFieldReader - MapFieldReader - DiffFieldReader	10 years ago
Patrick Sodré	80936e3562	provider/triton: add machine domain names (#7149) ... * vendor joyent/gosdc/cloudapi * provider/triton: Add machine domain names - Includes acceptance test.	10 years ago
James Nugent	dbf725bd68	core: Allow dynamic attributes in helper/schema ... The helper/schema framework for building providers previously validated in all cases that each field being set in state was in the schema. However, in order to support remote state in a usable fashion, the need has arisen for the top level attributes of the resource to be created dynamically. In order to still be able to use helper/schema, this commit adds the capability to assign additional fields. Though I do not forsee this being used by providers other than remote state (and that eventually may move into Terraform Core rather than being a provider), the usage and semantics are: To opt into dynamic attributes, add a schema attribute named "__has_dynamic_attributes", and make it an optional string with no default value, in order that it does not appear in diffs: "__has_dynamic_attributes": { Type: schema.TypeString Optional: true } In the read callback, use the d.UnsafeSetFieldRaw(key, value) function to set the dynamic attributes. Note that other fields in the schema _are_ copied into state, and that the names of the schema fields cannot currently be used as dynamic attribute names, as we check to ensure a value is not already set for a given key.	10 years ago
James Nugent	9c7cf639b3	testing: Allow acceptance test to run as unit test ... This commit adds a flag to acceptance tests in order to make appropriately named tests work during `make test` irrespective of the TF_ACC environment variable. This should only be used on tests which are known to be fast.	10 years ago
clint shryock	7d71b8cc3c	helper and terraform interpolate test update	10 years ago
James Bardin	2c7b702d1f	Merge pull request #7091 from hashicorp/jbardin/serialize ... Serialization for hash panics on TypeMap	10 years ago
James Bardin	bab031aac5	Add test for TypeMap in a Schema	10 years ago
James Bardin	d8fbaa7924	Serialization for hash panics on TypeMap ... The serializeCollectionMemberForHash helper can't be called for the MapType values, because MapType doesn't have a schema.Elem. Instead, we can write the key/value pairs directly to the buffer. This still doesn't allow for nested maps or lists, but we need to define that use case before committing to it here.	10 years ago
James Nugent	074545e536	core: Use .% instead of .# for maps in state ... The flatmapped representation of state prior to this commit encoded maps and lists (and therefore by extension, sets) with a key corresponding to the number of elements, or the unknown variable indicator under a .# key and then individual items. For example, the list ["a", "b", "c"] would have been encoded as: listname.# = 3 listname.0 = "a" listname.1 = "b" listname.2 = "c" And the map {"key1": "value1", "key2", "value2"} would have been encoded as: mapname.# = 2 mapname.key1 = "value1" mapname.key2 = "value2" Sets use the hash code as the key - for example a set with a (fictional) hashcode calculation may look like: setname.# = 2 setname.12312512 = "value1" setname.56345233 = "value2" Prior to the work done to extend the type system, this was sufficient since the internal representation of these was effectively the same. However, following the separation of maps and lists into distinct first-class types, this encoding presents a problem: given a state file, it is impossible to tell the encoding of an empty list and an empty map apart. This presents problems for the type checker during interpolation, as many interpolation functions will operate on only one of these two structures. This commit therefore changes the representation in state of maps to use a "%" as the key for the number of elements. Consequently the map above will now be encoded as: mapname.% = 2 mapname.key1 = "value1" mapname.key2 = "value2" This has the effect of an empty list (or set) now being encoded as: listname.# = 0 And an empty map now being encoded as: mapname.% = 0 Therefore we can eliminate some nasty guessing logic from the resource variable supplier for interpolation, at the cost of having to migrate state up front (to follow in a subsequent commit). In order to reduce the number of potential situations in which resources would be "forced new", we continue to accept "#" as the count key when reading maps via helper/schema. There is no situation under which we can allow "#" as an actual map key in any case, as it would not be distinguishable from a list or set in state.	10 years ago
James Nugent	cb9ef298f3	core: Defeat backward compatibilty in mapstructure ... The mapstructure library has a regrettable backward compatibility concern whereby a WeakDecode of []interface{}{} into a target of map[string]interface{} yields an empty map rather than an error. One possibility is to switch to using Decode instead of WeakDecode, but this loses the nice handling of type conversion, requiring a large volume of code to be added to Terraform or HIL in order to retain that behaviour. Instead we add a DecodeHook to our usage of the mapstructure library which checks for decoding []interface{}{} or []string{} into a map and returns an error instead. This has the effect of defeating the code added to retain backwards compatibility in mapstructure, giving us the correct (for our circumstances) behaviour of Decode for empty structures and the type conversion of WeakDecode. The code is identical to that in the HIL library, and packaged into a helper.	10 years ago