29 Commits (ccf19fbf5e2b61ba62efd1ac47a3a3fd3917d494)

Author	SHA1	Message	Date
James Bardin	5f063ae94a	make grpcErr work for either plugin type ... Extract a better function name and make the errors generic for different plugin types.	6 years ago
James Bardin	b4cb64d986	convert rpc errors ... Terraform does not use rpc errors for any error communication, so these are always something that went wrong in outside of the plugin protocol. The most common example of which is a provider crash, which would return "rpc error: code = Unavailable desc = transport is closing". Replace these error codes with something a little more presentable for the user, and insert the calling method name to help correlate it to the operation that failed.	6 years ago
James Bardin	353937411d	handle empty json	6 years ago
James Bardin	e3804810a9	Accept JSON encoded dynamic values from providers ... Core was previously ignoring JSON-encoded dynamic values, but these are technically supported, so we must either error or accept the value. Since we already have the decoder for Json state, it's minimal effort to support this on all plugin methods too. This change also gives providers an easy way to implement the UpgradeResourceState method. The obvious implementation of returning the same JSON-encoded value has tripped up a few providers not using the legacy SDK already, and we should have at least indicated that the value was being lost.	6 years ago
Paddy	e6592dc710	Add support for provider metadata to modules. (#22583) ... Implement a new provider_meta block in the terraform block of modules, allowing provider-keyed metadata to be communicated from HCL to provider binaries. Bundled in this change for minimal protocol version bumping is the addition of markdown support for attribute descriptions and the ability to indicate when an attribute is deprecated, so this information can be shown in the schema dump. Co-authored-by: Paul Tyng <paul@paultyng.net>	6 years ago
Radek Simko	cba55a4e12	plugin: Pass TerraformVersion from ConfigureRequest	7 years ago
James Bardin	dcab82e897	send and receive Private through ReadResource ... Send Private data blob through ReadResource as well. This will allow for extra flexibility for future providers that may want to pass data out of band through to their resource Read functions.	7 years ago
James Bardin	9a2a6d14bd	Stop grpc server when running ACC tests ... The grpc server does not shutdown when the listener is closed. Since tests aren't run through go-plugin, which has a separate RPC Shutdown channel to stop the server, we need to track and stop the server directly.	7 years ago
James Bardin	a3d58665ad	use LegacyResourceSchema ... rather than the previous .CoreConfigSchemaForShimming	7 years ago
James Bardin	746aac8bda	increase grpc recv limit ... Some providers may generate quite large schemas, and the internal default grpc response size limit is 4MB. 64MB should cover most any use case, and if we get providers nearing that we may want to consider a finer-grained API to fetch individual resource schemas.	7 years ago
Martin Atkins	31299e688d	core: Allow legacy SDK to opt out of plan-time safety checks ... Due to the inprecision of our shimming from the legacy SDK type system to the new Terraform Core type system, the legacy SDK produces a number of inconsistencies that produce only minor quirky behavior or broken edge-cases. To retain compatibility with those existing weird behaviors, the legacy SDK opts out of our safety checks. The intent here is to allow existing providers to continue to do their previous unsafe behaviors for now, accepting that this will allow certain quirky bugs from previous releases to persist, and then gradually migrate away from the legacy SDK and remove this opt-out on a per-resource basis over time. As with the apply-time safety check opt-out, this is reserved only for the legacy SDK and must not be used in any new SDK implementations. We still include any inconsistencies as warnings in the logs as an aid to anyone debugging weird behavior, so that they can see situations where blame may be misplaced in the user-visible error messages.	7 years ago
Martin Atkins	1530fe52f7	core: Legacy SDK providers opt out of our new apply result check ... The shim layer for the legacy SDK type system is not precise enough to guarantee it will produce identical results between plan and apply. In particular, values that are null during plan will often become zero-valued during apply. To avoid breaking those existing providers while still allowing us to introduce this check in the future, we'll introduce a rather-hacky new flag that allows the legacy SDK to signal that it is the legacy SDK and thus disable the check. Once we start phasing out the legacy SDK in favor of one that natively understands our new type system, we can stop setting this flag and thus get the additional safety of this check without breaking any previously-released providers. No other SDK is permitted to set this flag, and we will remove it if we ever introduce protocol version 6 in future, assuming that any provider supporting that protocol will always produce consistent results.	7 years ago
Martin Atkins	bdcac8792d	plugin: Use correct schema when marshaling imported resource objects ... Previously we were using the type name requested in the import to select the schema, but a provider is free to return additional objects of other types as part of an import result, and so it's important that we perform schema selection separately for each returned object. If we don't do this, we get confusing downstream errors where the resulting object decodes to the wrong type and breaks various invariants expected by Terraform Core. The testResourceImportOther test in the test provider didn't catch this previously because it happened to have an identical schema to the other resource type being imported. Now the schema is changed and also there's a computed attribute we can set as part of the refresh phase to make sure we're completing the Read call properly during import. Refresh was working correctly, but we didn't have any tests for it as part of the import flow.	7 years ago
James Bardin	6f54bfaa7c	send config during apply	7 years ago
Martin Atkins	53926ea581	plugin: Fix incorrect trace log message in provider Close ... Was incorrectly printing out "PlanResourceChange" instead of "Close".	7 years ago
James Bardin	924b97238f	Handle StateFuncs in provider shim ... Any state modifying functions can only be run once during the plan-apply cycle. When regenerating the Diff during ApplyResourceChange, strip out all StateFunc and CustomizeDiff functions from the schema. Thew NewExtra diff field was where config data that was modified by a StateFunc was stored, and needs to be maintained between plan and apply. During PlanResourceChange, store any NewExtra data from the Diff in the PlannedPrivate data, and re-insert the NewExtra data into the Diff generated during ApplyResourceChange.	7 years ago
Martin Atkins	4fe9632f09	plugin: Establish our current plugin protocol as version 5 ... The main significant change here is that the package name for the proto definition is "tfplugin5", which is important because this name is part of the wire protocol for references to types defined in our package. Along with that, we also move the generated package into "internal" to make it explicit that importing the generated Go package from elsewhere is not the right approach for externally-implemented SDKs, which should instead vendor the proto definition they are using and generate their own stubs to ensure that the wire protocol is the only hard dependency between Terraform Core and plugins. After this is merged, any provider binaries built against our helper/schema package will need to be rebuilt so that they use the new "tfplugin5" package name instead of "proto". In a future commit we will include more elaborate and organized documentation on how an external codebase might make use of our RPC interface definition to implement an SDK, but the primary concern here is to ensure we have the right wire package name before release.	7 years ago
James Bardin	3bdd3b2a6e	update plugin client with PrepareProviderConfig	8 years ago
James Bardin	3a0c2f1b67	close grpc TestListener	8 years ago
James Bardin	0d4d572c39	start work on helper/resource test fixtures ... The helper resource tests won't pass for now, as they use a terraform.MockProvider which can't be used in the schema.Provider shims.	8 years ago
James Bardin	a14fe7ae0c	missing diagnostics in pugin protocol ... Some call diagnostics were being missed	8 years ago
James Bardin	795161f615	update to start a new process for each plugin ... Modify the plugin factories to create a new plugin process for each individual plugin.	8 years ago
James Bardin	35b375d3ee	check responses for nil values ... While providers shouldn't return nil values, we need to protect against them. Always assign valid null cty values when the response contains a nil.	8 years ago
Martin Atkins	a7342de274	core: Properly handle no-op changes in plan ... Previously we just left these out of the plan altogether, but in the new plan types we intentionally include change information for every resource instance, even if no changes are actually planned, to allow alternative plan file viewers to show what isn't changing as well as what is.	8 years ago
Martin Atkins	5d744e6824	plugin: TRACE log for each GRPC-remoted plugin call	8 years ago
Martin Atkins	4bf19797f3	plugin: Fix deadlock in getSchema where mutex is never unlocked ... On the second call here this would fail to release the lock.	8 years ago
James Bardin	c07ce1cd4b	move conversion functions into separate package ... Managing which function need to be shared between the terraform plugin and the helper plugin without creating cycles was becoming difficult. Move all functions related to converting between terraform and proto type into plugin/convert.	8 years ago
James Bardin	b403023841	serve the new version 5 grpc plugins ... Use the new go-plugin version negotiation to server th appropriate plugin type when the client requests protocol version 5.	8 years ago
James Bardin	c1d4a63fae	GRPCProvider and GRPCProvisioner clients ... Here we add the GRPCProvisioner and GRPCProvider which implement the core provisioners.Interface and providers.Interface, and translate betweeen the core types and the grpc protocol.	8 years ago