terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	bd1a215580	helper/resource: Ignore Removed attributes for ImportStateVerify Due to the lossiness of our legacy models for diff and state, shimming a diff and then creating a state from it produces a different result than shimming a state directly. That means that ImportStateVerify no longer works as expected if there are any Computed attributes in the schema where d.Set isn't called during Read. Fixing that for every case would require some risky changes to the shim behavior, so we're instead going to ask provider developers to address it by adding `d.Set` calls where needed, since that is the contract for "Computed" anyway -- a default value should be produced during Create, and thus by extension during Import. However, since a common situation where this occurs is attributes marked as "Removed", since all of the code that deals with them has generally been deleted, we'll avoid problems in that case here by treating Removed attributes as ignored for the purposes of ImportStateVerify. This required exporting some functionality that was formerly unexported in helper/schema, but it's a relatively harmless schema introspection function so shouldn't be a big deal to export it.	7 years ago
James McGill	035d56409f	helper/schema: handle TypeMap elem consistently with other collection types For historical reasons, the handling of element types for maps is inconsistent with other collection types. Here we begin a multi-step process to make it consistent, starting by supporting both the "consistent" form of using a schema.Schema and an existing erroneous form of using a schema.Type directly. In subsequent commits we will phase out the erroneous form and require the schema.Schema approach, the same as we do for TypeList and TypeSet.	8 years ago
James Bardin	01be1a5ecd	Check for interpolated values when reading a map Accessing an interpolated value in a map through ConfigFieldReader can fail, because GetRaw can't access interpolated values, so check if the value exists at all by looking in the config. If the config has a value, assume our map's value is interpolated and proceed as such. We also need to lookup the correct schema to properly read a field from a nested structure. - Maps previously always defaulted to TypeString. Now check if Elem is a ValueType and use that if applicable - Lists now return the schema for nested element types, defaulting to a TypeString like maps. This only allows maps and lists to be nested one level deep, and the inner map or list must only contain string values.	10 years ago
James Bardin	c4eefd4b5e	Allow primitive type in maps via all FieldReaders Now that we can read primitive type out of a map, each field reader needs to be able to set the proper type as expected.	10 years ago
Mitchell Hashimoto	7834cf7190	helper/schema: computed bool fields should not crash Fixes #7715 If a bool field was computed and the raw value was not convertable to a boolean, helper/schema would crash. The correct behavior is to try not to read the raw value when the value is computed and to simply mark that it is computed. This does that (and matches the behavior of the other primitives).	10 years ago
Clint	a84aa5e914	Revert "helper/schema: Make nested Set(s) in List(s) work" (#7436 )	10 years ago
Radek Simko	c738c5a9a3	helper/schema: Implement reader-specific readList method	10 years ago
Martin Atkins	cc8e8a55de	helper/schema: Default hashing function for sets A common issue with new resource implementations is not considering parts of a complex structure that's used inside a set, which causes quirky behavior. The schema helper has enough information to provide a default reasonable implementation of a set function that includes all non-computed attributes in a deterministic way. Here we implement such a function and use it when no explicit hashing function is provided. In order to achieve this we encapsulate the construction of the zero value for a schema in a new method schema.ZeroValue, which allows us to put the fallback logic to the new default function in a single spot. It is no longer valid to use &Set{F: schema.Set} and all uses of that construct should be replaced with schema.ZeroValue().(*Set) .	11 years ago
Sam Boyer	b82bd0c280	Condense switch fallthroughs into expr lists	11 years ago
Andrew Langhorn	bb4f7415ca	Rename "The The" so that they can play songs again Other than the fact that "The the" doesn't really make any sense anywhere that it's used in Terraform, they're a post-punk band from the UK. Fixes "The The" so that they can get back to playing songs.	11 years ago
Mitchell Hashimoto	0bc0c03fec	helper/schema: zero value set should set function [GH-1009]	11 years ago
Dave Cunningham	18c26cb2eb	Add some missing Float cases	11 years ago
Mitchell Hashimoto	1fcd24cf67	helper/schema: add float type	11 years ago
Mitchell Hashimoto	e9a4aaaca7	helper/schema: full object test for addrToSchema	11 years ago
Mitchell Hashimoto	e57f3f69b1	helper/schema: empty maps, support reading objects directly	11 years ago
Mitchell Hashimoto	f0af1c36f5	helper/schema: nested resource fields should be zero-valued on get	11 years ago
Mitchell Hashimoto	b4bf813151	helper/schema: too big to fail	11 years ago
Mitchell Hashimoto	7e379cb1a1	helper/schema: field readers no longer take a schema as arg	11 years ago
Mitchell Hashimoto	73726e83b2	helper/schema: DiffFieldReader for reading data from a diff	11 years ago
Mitchell Hashimoto	9447973015	helper/schema: ConfigFieldReader and generic helpers	11 years ago
Mitchell Hashimoto	5f063d321f	helper/schema: FieldReader needs to return computed status	11 years ago
Mitchell Hashimoto	f416e0edf0	helper/schema: FieldReader and MapFieldReader	11 years ago

22 Commits (ccf19fbf5e2b61ba62efd1ac47a3a3fd3917d494)