9 Commits (ccf19fbf5e2b61ba62efd1ac47a3a3fd3917d494)

Author	SHA1	Message	Date
James Bardin	f9dfa98533	test to make sure a data source is planned ... The data source here needs to be re-read during apply, because its config is changing.	7 years ago
Martin Atkins	e39c69750c	core: Specialized errors for incorrect indexes in resource reference ... In prior versions of Terraform we permitted inconsistent use of indexes in resource references, but in as of 0.12 the index usage must correlate properly with whether "count" is set on the resource. Since users are likely to have existing configurations with incorrect usage, here we introduce some specialized error messages for situations where we can detect such issues statically. This seems to cover all of the common patterns we've seen in practice. Some usage patterns will fall back on a less-helpful dynamic error here, but no configurations coming from 0.11 can end up that way because 0.11 did not permit forms such as aws_instance.no_count[count.index].bar that this validation would not be able to "see". Our configuration upgrade tool also contains a fix for this already, but it takes a more conservative approach of adding the index [1] rather than [count.index] because it can't be sure (without human help) if correlation of indices is what was intended.	7 years ago
James Bardin	c70be3c328	failing tests when using resources with count ... Two different tests failing around resourced with count	7 years ago
James Bardin	f0e51aca1a	test a nil computed value within an expression ... Comparing a nil-computed value was returning unknown, preventing the data source from being evaluated.	7 years ago
James Bardin	5303137b8c	udpate test configs to work with hcl2 ... The last 2 broken tests will be hanlded later	8 years ago
Chris Marchesi	d41b806789	core: Restore CountBoundaryTransformer to apply, add/adjust tests ... Moving the transformer wholesale looks like it broke some tests, with some actually doing legit work in normalizing singular resources from a foo.0 notation to just foo. Adjusted the TestPlanGraphBuilder to account for the extra meta.count-boundary nodes in the graph output now, as well as added another context test that tests this case. It appears the issue happens during validate, as this is where the state can be altered to a broken state if things are not properly transformed in the plan graph.	9 years ago
Chris Marchesi	2802d319d2	core: Move CountBoundaryTransformer to the plan graph builder ... This fixes interpolation issues on grandchild data sources that have multiple instances (ie: counts). For example, baz depends on bar, which depends on foo. In this instance, after an initial TF run is done and state is saved, the next refresh/plan is not properly transformed, and instead of the graph/state coming through as data.x.bar.0, it comes through as data.x.bar. This breaks interpolations that rely on splat operators - ie: data.x.bar.*.out.	9 years ago
Mitchell Hashimoto	dd8ee38ba8	providers/test: additional testing via integration tests	9 years ago
James Nugent	fb150ef72f	provider/test: Add test of data source count.index ... This adds a unit test to the test provider that verifies count.index behaves correctly. Although not ideal this is hard to implement as a context test without changing around the (non helper/schema) implementation of the x_data_source.	10 years ago