terraform

Commit Graph

Author	SHA1	Message	Date
Paul Stack	3472cab7d6	provider/aws: Fix panic in aws_acm_certificate datasource (#10051 ) Fixes #10042 Fixes #9989 Another panic was found with this resource. IT essentially was causing a panic when no certificates were found. This was due to the casting of status to []string There are times when there are no statuses passed in. Made the error message a lot more generic now rather than having something like this ``` No certificate with statuses [] for domain mytestdomain.com found in this region. ``` This now becomes: ``` No certificate for domain mytestdomain.com found in this region. ``` Also, added a test to show that the panic is gone ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAwsAcmCertificateDataSource_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... \| grep -v /terraform/vendor/) 2016/11/11 15:11:33 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAwsAcmCertificateDataSource_ -timeout 120m === RUN TestAccAwsAcmCertificateDataSource_noMatchReturnsError --- PASS: TestAccAwsAcmCertificateDataSource_noMatchReturnsError (6.07s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws6.094s ```	10 years ago
Paul Stack	d66359b046	provider/aws: Fix panic when passing statuses to aws_acm_certificate (#9990 ) Fixes #9989 When passing a list of statuses to the acm_certificate data source, we were trying to cast a schema.TypeList directly to []string We need to do it via an []interface{} and then cast to string when ranging over the results. Without this, we get a panic	10 years ago
James Nugent	3361047e38	provider/aws: Address acm_certificate review items	10 years ago
Paul Hinze	ccd745c96f	provider/aws: New Data Source: aws_acm_certificate Use this data source to get the ARN of a certificate in AWS Certificate Manager (ACM). The process of requesting and verifying a certificate in ACM requires some manual steps, which means that Terraform cannot automate the creation of ACM certificates. But using this data source, you can reference them by domain without having to hard code the ARNs as input. The acceptance test included requires an ACM certificate be pre-created in and information about it passed in via environment variables. It's a bit sad but there's really no other way to do it.	10 years ago

4 Commits (cba9d3d2ec61cd4aef0fd71fe9d72eb4e11acacd)