1288 Commits (cba55a4e12aec01464fb400eff115a3653ca337d)

Author	SHA1	Message	Date
Kristin Laemmert	f4af55d611	command/console: use user-supplied plugin-dir (#22616) ... Previously `terraform console` would output an `init required` error if it was run in a directory originally `init`ed with a `-plugin-dir` specified. Fixes #17826	7 years ago
Martin Atkins	8272d3b101	command/cliconfig: Remove command dependency ... This was a leftover from the migration of these types from the main package, but we don't actually need or want this here because this particular detail is still handled by the main package, and because the cliconfig package must not depend on the command package in order to avoid an import cycle.	7 years ago
Martin Atkins	1e2da4f776	command/cliconfig: New CredentialsSource implementation ... This new implementation is not yet used, but should eventually replace the technique of composing together various types from the svchost/auth package, since our requirements are now complex enough that they're more straightforward to express in direct code within a single type than as a composition of the building blocks in the svchost/auth package.	7 years ago
Hasan Ramezani	f7b1ef876c	command/workspace: Added `show` subcommand to workspace command help text. (#22367)	7 years ago
Kristin Laemmert	c9d62bb2f6	command: discard output from flags package and return errs directly (#22373) ... Any command using meta.defaultFlagSet *might* occasionally exit before the flag package's output got written. This caused flag error messages to get lost. This PR discards the flag package output in favor of directly returning the error to the end user.	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Pam Selle	ce8e7811ae	Merge pull request #18823 from minamijoyo/fix-multibyte-trucate ... command/hook_ui: Truncate the ID considering multibyte characters	7 years ago
kmoe	3a0c1794b6	Merge pull request #22320 from hashicorp/svh/f-fmt-help ... Mention the -no-color option	7 years ago
Sander van Harmelen	e81fafeefa	Mention the -no-color option ... This option is a valid option for the fmt subcommand, but it isn't listed in the help text.	7 years ago
James Bardin	3cda2bd7a5	Merge pull request #22299 from hashicorp/jbardin/state-mv ... allow moving resource to new modules not in state	7 years ago
hiroqn	de4235698b	command/0.12upgrade: honor user-supplied plugin-dir ... Fixes #21594	7 years ago
James Bardin	32f7f58345	allow moving resource to new modules not in state ... Create the missing modules in the state when moving resources to a module that doesn't yet exist. This allows for refactoring of configuration into new modules, without having to create dummy resources in the module before the "state mv" operations.	7 years ago
Martin Atkins	e1590d0a70	command/cliconfig: Factor out CLI config handling ... This is just a wholesale move of the CLI configuration types and functions from the main package into its own package, leaving behind some type aliases and wrappers for now to keep existing callers working. This commit alone doesn't really achieve anything, but in future commits we'll expand the functionality in this package.	7 years ago
James Bardin	8b2646c2a6	Merge pull request #22149 from hashicorp/jbardin/state-show-deposed ... account for deposed in terraform show	7 years ago
James Bardin	345dfaccb6	Account for deposed instances in show command, adding the details for ... each deposed instance. Prevent crash if the current instance is missing.	7 years ago
Kristin Laemmert	a16e1fc0a1	command/init: omit a warning if -backend-config is used with no backend (#22164) ... * command/init: omit a warning if -backend-config is used with no backend block Terraform would silently accept - and swallow - `-backend-config` on the CLI when there was no `backend` block. Since it is mostly expected to override existing backend configuration, terraform should omit a warning if there is no backend configuration to override. If the user intended to override the default (local) backend configuration, they can first add a `backend` block to the `terraform` block to silence the warning (or just ignore it): ```hcl terraform { backend "local" {} } ```	7 years ago
Alex Pilon	d5997e05db	prune dead code from command/meta	7 years ago
appilon	b143c04216	Merge pull request #22125 from hashicorp/appilon/move-VarEnvPrefix ... [SDK cleanup] Move VarEnvPrefix out of terraform pkg	7 years ago
Alex Pilon	e3bc1e7d5c	move VarEnvPrefix out of terraform pkg	7 years ago
Alex Pilon	0450f487fa	move IsEmptyDir to configs package	7 years ago
James Bardin	e4640a43d7	fix show-json test to expect error from nested mod ... One of the show json command tests expected no error when presented with an invalid configuration in a nested module. Modify the test created in PR #21569 so that it can still verify there is no panic, but now expect an error from init.	7 years ago
Masayuki Morita	ca9b643c73	docs: Fix typo in (*Meta) RunOperation comments	7 years ago
Pam Selle	1666df3668	Merge pull request #21911 from Biteable/no-nopop-in-plan-show ... Fixes #21907	7 years ago
Antoine Jacoutot	37a6331ebf	command/version: drop empty line on version check (#14858) ... We always add an empty line when asking/checking the version. We should only do that if there is a new version available. While this is purely cosmetic, it reads better and is consistent with packer.	7 years ago
Dirk Avery	02efe97a59	command/import: change import message to 'prepared' (#20018) ... * Change import message to 'prepared' * Update command/hook_ui.go Co-Authored-By: Kristin Laemmert <mildwonkey@users.noreply.github.com>	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Jon Burgess	c0b1220a92	Fixes #21907 ... Don't show no-ops in `terraform show`, since it's not something that will change any state.	7 years ago
Martin Atkins	b1e92b3769	vendor: go get github.com/hashicorp/hcl2@0b64543c968c ... This includes a fix to make sure that an expression with a static string index, like foo["bar"], will be parsed as a traversal rather than as a dynamic index expression.	7 years ago
Pam Selle	82dcd5276e	Normalize in the fmt -check test	7 years ago
Radek Simko	f342824647	Merge pull request #21334 from hashicorp/b-cmd-show-reduce-whitespaces ... command/format: Reduce extra whitespaces & new lines	7 years ago
Tim Sharpe	615110e13e	provisioner: new Puppet provisioner (#18851) ... * Basic Puppet provisioner * (fixup) fix snake_case use in Bolt * (fixup) Remove unused ValidateFunc * (fixup) Check bolt result status * (lint) go fmt * Requested changes * Remove PE autodetection * Apply suggestions from @svanharmelen Co-Authored-By: rodjek <tim@sharpe.id.au> * Tag all JSON fields in bolt output * Defer comm.Disconnect() as suggested * Make bolt timeout configurable * Update builtin/provisioners/puppet/resource_provisioner.go Co-Authored-By: rodjek <tim@sharpe.id.au> * Make extension_requests and custom_attributes configurable	7 years ago
James Bardin	e71e3d85a9	Merge pull request #21611 from hashicorp/jbardin/private-data-read ... Make sure resource private data is carried through the entire resource lifecycle	7 years ago
James Bardin	ac2219ba6e	don't lose Private state data during copy ... Fix the scope of the private data copy in DeepCopy. Make sure Dependencies matches nil vs empty so that Equal compares correctly between copied states	7 years ago
Ivan Kalita	5b6b1663ef	backend/http: implement retries for the http backend (#19702) ... Fixes #19619	7 years ago
Kristin Laemmert	b9f114aa25	command/show (json): marshal the state snapshot included with the plan file (#21597) ... * command/show: marshal the state snapshot from the planfile The planfile contains a state snapshot with certain resources updated (outputs and datasources). Previously `terraform show -json PLANFILE` was using the current state instead of the state inside the plan as intended. This caused an issue when the state included a terraform_remote_state datasource. The datasource's state gets refreshed - and therefore upgraded to the current state version - during plan, but that won't persist to state until apply. * update comment to reflect new return	7 years ago
Kristin Laemmert	06a3333316	note: this is an unusual edgecase in the category of "probably should not happen" ... If https://github.com/hashicorp/terraform/issues/21543 is fixed, we can remove this check.	7 years ago
Kristin Laemmert	703f024cbd	command/show (-json): fix panic if a moduleCall has a nil config ... In the unlikely event that a moduleCall has a nil config - for example, if a nested module call includes a variable with a typo in an attribute - continue gracefully.	7 years ago
Kristin Laemmert	65fc037ecb	command/show (plan -json): fix panic (#21541) ... * command/show -json: fix panic afterUnknown should return only bools, not values. * command/jsonplan: let's delete some redundant code! the plan output was somewhat inconsistent with return values for "after_unknown". This strives to fix that. If all "after" values are known, return an empty object instead of iterating over values. Also fixing some typos and general copypasta.	7 years ago
James Bardin	7f5ffbfe90	Merge pull request #21439 from hashicorp/jbardin/init-backend ... init always prompts for migration with most remote backend configurations	7 years ago
James Bardin	06dfc4abd8	allow setting -backend-config='' to unset override ... There is currently no way to unset -backend-config during init, since not setting that option assumes the user will use the saved config. Allow setting `-backend-config=""` to specify no overrides.	7 years ago
Martin Atkins	d512584497	command/jsonplan: Don't panic with mixtures of known/unknown/empty ... The omitUnknowns and unknownAsBool functions were previously trying hard to preserve the same collection types in the output as they had in the input, by attempting to keep everything matched up so that the results would be valid. Unfortunately, this turns out to be a harder problem than we originally thought: it was possible for a collection value going in to produce inconsistent element types out (and thus a panic) in the following situations: - when a collection with mixed known and unknown values was passed in to omitUnknowns. - when a collection of collections where the inner collections are a mixture of empty and not empty in unknownAsNull. The results of these functions are only used to marshal to JSON anyway, and JSON serialization can't distinguish between the three sequence types or the two mapping types, so in practice we can just standardize on converting all sequences to tuple and all mappings to object here and not change the resulting output at all, and then we don't have to worry about making sure all of the inner types get preserved exactly. A nice consequence of that relaxation is that we can now do what we originally wanted to do with unknownAsBool, and omit map keys and object attributes altogether if their values would've been false, producing a much more compact result. This is easiest to do now when there's only one known user of this JSON plan output, and we know that user will treat both false and omitted as the same here.	7 years ago
James Bardin	c017149b31	don't store prepared backend config ... The backend gets to "prepare" the configuration before Configure is called, in order to validate the values and insert defaults. We don't want to store this value in the "config state", because it will often not match the raw config after it is prepared, forcing unecessary backend migrations during init. Since PrepareConfig is always called before Configure, we can store the config value directly, and assume that it will be prepared in the same manner each time.	7 years ago
James Bardin	ee9a618369	don't migrate backend during init without override ... If the backend config hashes match during init, and there are no new backend override options, then we assume the existing config is OK. Since init should be idempotent, we should be able to run init with no options or config changes, and not effect the backends at all.	7 years ago
James Bardin	cefc927e48	failing test for backend re-init	7 years ago
Sander van Harmelen	8fd3aa91a0	Merge pull request #21234 from hashicorp/svh/f-init-v0.12 ... Always try to select a workspace after initialization (v0.12)	7 years ago
Radek Simko	12f7ac1374	command/format: Reduce extra whitespaces & new lines	7 years ago
Martin Atkins	63fa1ac418	vendor: go get github.com/hashicorp/hcl2@master ... This includes a small fix to ensure the parser doesn't produce an invalid body for block parsing syntax errors, and instead produces an incomplete result that calling applications like Terraform can still analyze. The problem here was affecting our version-constraint-sniffing code, which intentionally tried to find a core version constraint even if there's a syntax error so that it can report that a new version of Terraform is a likely cause of the syntax error. It was working in most cases, unless it was the "terraform" block itself that contained the error, because then we'd try to analyze a broken hcl.Block with a nil body. This includes a new test for "terraform init" that exercises this recovery codepath.	7 years ago
Sander van Harmelen	d9ba0c69ea	Always try to select a workspace after initialization ... There are a number of use cases that can require a user to select a workspace after initializing Terraform. To make sure we cover all these use cases, we will always call the selectWorkspace method to verify a valid workspace is already selected or (if needed) offer to select one before moving on.	7 years ago
Martin Atkins	6adcc7ab73	vendor: go get github.com/zclconf/go-cty@master ... cty now guarantees that sets of primitive values will iterate in a reasonable order. Previously it was the caller's responsibility to deal with that, but we invariably neglected to do so, causing inconsistent ordering. Since cty prioritizes consistent behavior over performance, it now imposes its own sort on set elements as part of iterating over them so that calling applications don't have to worry so much about it. This change also causes cty to consistently push unknown and null values in sets to the end of iteration, where before that was undefined. This means that our diff output will now consistently list additions before removals when showing sets, rather than the ordering being undefined as before. The ordering of known, non-null, non-primitive values is still not contractually fixed but remains consistent for a particular version of cty.	7 years ago
Martin Atkins	eed605ac05	[WIP] Re-enable the end-to-end tests (#20044) ... * internal/initwd: Allow deprecated relative module paths In Terraform 0.11 we deprecated this form but didn't have any explicit warning for it. Now we'll still accept it but generate a warning. In a future major release we will drop this form altogether, since it is ambiguous with registry module source addresses. This codepath is covered by the command/e2etest suite. * e2e: Skip copying .exists file, if present We use this only in the "empty" test fixture in order to let git know that the directory exists. We need to skip copying it so that we can test "terraform init -from-module=...", which expects to find an empty directory. * command/e2etests: Re-enable and fix up the e2etest "acctests" We disabled all of the tests that accessed remote services like the Terraform Registry while they were being updated to support the new protocols we now expect. With those services now in place, we can re-enable these tests. Some details of exactly what output we print, etc, have intentionally changed since these tests were last updated. * e2e: refactor for modern states and plans * command/e2etest: re-enable e2etests and update for tf 0.12 compatibility plugin/discovery: mkdirAll instead of mkdir when creating cache dir	7 years ago