1217 Commits (c73a5fc07da195af2ee2b2958a04e495df00a7b1)

Author	SHA1	Message	Date
Martin Atkins	cbc548eb36	command: Do CLI init of backend loaded from plan ... If we don't do this, we can't produce any output when applying a saved plan file. Here we also introduce a check to the local backend's ReportResult function so that it won't panic if CLI init is skipped, although that will no longer happen in the apply-from-file case due to the change described in the previous paragraph.	8 years ago
James Bardin	52c0032aed	update provisioners for multiple processes ... The "internal" provisioners are still run in a separate process, and need to be updated to restart on each walk.	8 years ago
James Bardin	795161f615	update to start a new process for each plugin ... Modify the plugin factories to create a new plugin process for each individual plugin.	8 years ago
Martin Atkins	412439ae01	command: Un-stub tests that were previously hanging on the inmem backend ... The underlying bug has now been fixed, in b3b62429a7 .	8 years ago
Martin Atkins	058a1d81b0	command/format: Remove tests for plan.go ... plan.go as a whole will be removed before too long, so there's no point in us updating all of these tests to use the new plan types.	8 years ago
Martin Atkins	3b8d46418f	command/format: print correctly nested blocks with labels	8 years ago
Martin Atkins	b0016e9cf6	command: Allow tests to run to completion without panics or hangs ... There are still 160 test failures as of this commit, but at least the test program can run to completion and list out all the failures.	8 years ago
Martin Atkins	d446d32d96	command: Fix TestApply for new mock provider interface ... It must now provide a basic implementation of plan and apply for its mock provider, which in this case can just pass through the proposed value generated by core because there are no computed attributes in this schema.	8 years ago
Martin Atkins	5021e0e098	command: Fix TestApply_destroyTargeted for new provider and state types	8 years ago
Martin Atkins	db3ea65e8b	command: Fix TestApply_destroy for new provider and state types	8 years ago
Martin Atkins	be7bce493e	command: Update plugins_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	dc0b5292a6	command: Update refresh_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	b195c712a3	command: Update plan_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	54c1616d73	command: Update import_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	65341b0973	command: Update apply_test.go for new provider types ... This only makes it compile. It does not yet ensure that the tests pass.	8 years ago
Martin Atkins	d9051be66d	command: Use new provider and provisioner types in test helpers ... This moves our build errors from the test helpers out into the tests themselves. We'll update the tests in subsequent commits.	8 years ago
Martin Atkins	a43b7df282	core: Handle forced-create_before_destroy during the plan walk ... Previously we used a single plan action "Replace" to represent both the destroy-before-create and the create-before-destroy variants of replacing. However, this forces the apply graph builder to jump through a lot of hoops to figure out which nodes need it forced on and rebuild parts of the graph to represent that. If we instead decide between these two cases at plan time, the actual determination of it is more straightforward because each resource is represented by only one node in the plan graph, and then we can ensure we put the right nodes in the graph during DiffTransformer and thus avoid the logic for dealing with deposed instances being spread across various different transformers and node types. As a nice side-effect, this also allows us to show the difference between destroy-then-create and create-then-destroy in the rendered diff in the CLI, although this change doesn't fully implement that yet.	8 years ago
Martin Atkins	b428746cfd	command: UiHook to report when it gets incorrect values ... For PreApply hook purposes we only actually use the Delete, Create, and Update actions, because other actions are handled in different ways than a direct call to ApplyResourceChange. However, if there's a bug in core that causes it to pass a different action, it's better for us to mark it as being explicitly unknown in the UI rather than simply defaulting to "Modifying...", which can thus obscure the problem and make for a confusing result.	8 years ago
Martin Atkins	a37d5268eb	command/format: Render unified diff for list and tuple value changes	8 years ago
Martin Atkins	30a46ed8ed	command/format: Further refinement on the heuristic JSON-based diff ... We'll now show an "update" symbol prior to the argument to this synthetic jsonencode(...) call, for consistency with how we show nested values in other cases and to attach a verb to any "# forces replacement". We'll also show a special form in the case where the value seems to differ only in whitespace, so users can understand what's going on in that hopefully-rare situation, particularly if those whitespace-only changes end up forcing us to replace a remote object.	8 years ago
Martin Atkins	783205948c	command/format: JSON value formatting heuristic not for primitive values ... Since our own syntax for primitive values is similar to that of JSON, and since we permit automatic conversions from number and bool to string, we must do this special JSON value diff formatting only if the value is a JSON array or object to avoid confusing results.	8 years ago
Martin Atkins	4406b06ef8	command/format: Don't include commas after elements in map diffs ... Although commas are allowed in this context, it's not idiomatic to use them.	8 years ago
Martin Atkins	ce157c7f23	command/format: show deep diffs for old/new JSON strings ... Because so far we've not supported dynamically-typed complex data structures, several providers have used strings containing JSON to stand in for these. In order to get a readable diff in those cases, we'll recognize situations where old and new are both JSON and present a diff of the effective value of the JSON, using a faux call to the jsonencode(...) function to indicate when we've done so. This is a bit of a "cute" heuristic, but is important at least for now until we can migrate away from that practice of passing large JSON strings to providers and use dynamically-typed attributes instead.	8 years ago
Martin Atkins	9706a00b3a	command/format: correct alignment for multi-line values in map diff	8 years ago
Martin Atkins	04d8c17be8	command/format: Nice rendering for changes to map values	8 years ago
Martin Atkins	a2f4b8b058	command/format: Show resource diff with header "comment" ... This extra comment line gives us a place to show the full resource address (since the block header line only includes type and name) and also allows us to explain in long form the meaning of the change icon on the following line.	8 years ago
Martin Atkins	239a54ad6f	command: initial structural diff rendering ... This is a light adaptation of our earlier prototype of structural diff rendering, as a starting point for what we'll actually ship. This is not consistent with the latest mocks, so will need some additional work before it is ready, but integrating this allows us to at least see the plan contents while fixing up remaining issues elsewhere.	8 years ago
Martin Atkins	a7342de274	core: Properly handle no-op changes in plan ... Previously we just left these out of the plan altogether, but in the new plan types we intentionally include change information for every resource instance, even if no changes are actually planned, to allow alternative plan file viewers to show what isn't changing as well as what is.	8 years ago
Martin Atkins	5731703de5	command/format: show planned changes in rendered plan ... This codepath is going to be significantly changed before release to make it support structural diff of the new data types, but this lets us lean on the old renderer to produce partial output in the mean time while we continue to work on getting things working end-to-end after the considerable refactoring that's been going on.	8 years ago
Martin Atkins	44bc7519a6	terraform: More wiring in of new provider types ... This doesn't actually work yet, but it builds and then panics in a pretty satisfying way.	8 years ago
Martin Atkins	a3403f2766	terraform: Ugly huge change to weave in new State and Plan types ... Due to how often the state and plan types are referenced throughout Terraform, there isn't a great way to switch them out gradually. As a consequence, this huge commit gets us from the old world to a _compilable_ new world, but still has a large number of known test failures due to key functionality being stubbed out. The stubs here are for anything that interacts with providers, since we now need to do the follow-up work to similarly replace the old terraform.ResourceProvider interface with its replacement in the new "providers" package. That work, along with work to fix the remaining failing tests, will follow in subsequent commits. The aim here was to replace all references to terraform.State and its downstream types with states.State, terraform.Plan with plans.Plan, state.State with statemgr.State, and switch to the new implementations of the state and plan file formats. However, due to the number of times those types are used, this also ended up affecting numerous other parts of core such as terraform.Hook, the backend.Backend interface, and most of the CLI commands. Just as with 5861dbf3fc before, I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Kristin Laemmert	ce5e66e178	plugin/discovery provider installer: download providers from the registry ... Terraform will query the public registry at https://registry.terraform.io for providers, instead of https://releases.hashicorp.com.	8 years ago
Martin Atkins	479c6b2466	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	8 years ago
Martin Atkins	adb88eaa16	configupgrade: Analysis of input configuration ... In order to properly migrate the contents of resource, data, provider and provisioner blocks we will need the provider's schema in order to understand what is expected, so we can resolve some ambiguities inherent in the legacy HCL AST. This includes an initial prototype of migrating the content of resource blocks just to verify that the information is being gathered correctly. As with the rest of the upgrade_native.go file, this will be reorganized significantly once the basic end-to-end flow is established and we can see how to organize this code better.	8 years ago
Martin Atkins	eac8779870	command: validate must set values for root variables ... Since the intent of the validate command is to check config validity regardless of context (input variables, state, etc), we use unknown values of the requested type here, which will then allow us to complete type checking against the specified types of the variables without assuming any particular values.	8 years ago
Martin Atkins	ffe5f7c4e6	command: 0.12upgrade command ... This is the frontend to the work-in-progress codepath for upgrading the source code for a module written for Terraform v0.11 or earlier to use the new syntax and idiom of v0.12. The underlying upgrade code is not yet complete as of this commit, and so the command is not yet very useful. We will continue to iterate on the upgrade code in subsequent commits.	8 years ago
Martin Atkins	0742e756e5	tfdiags: Sort order for diagnostics ... Because we gather together diagnostics from many different parts of the codebase, the list often ends up being in a non-ideal order. Here we define a partial ordering for diagnostics that should hopefully make them easier to scan when many are present, by grouping together diagnostics that are of the same severity and belong to the same file. We use sort.Stable here because we have a partial order and so we need to make sure that diagnostics that do not have a relative ordering will remain in their original order. This sorting is applied just in time before rendering the diagnostics in command.Meta.showDiagnostics.	8 years ago
Martin Atkins	2ef56b3e05	Fix up some missed "go fmt" ... Because of the size of some of these files, automatic format-on-save was implicitly disabled in my editor, which I didn't notice before committing.	8 years ago
Martin Atkins	dc7f793be9	command: terraform fmt to use new HCL formatter ... This doesn't yet include test updates, since there are problems in core currently blocking these tests from running. The tests will therefore be updated in a subsequent commit.	8 years ago
Martin Atkins	a270a18a4d	command: Update tests for changes in "terraform" package ... This is not exhaustive, but it gets the tests in this package compiling again and gets most of them working.	8 years ago
Martin Atkins	fc7871c5ee	command/import: default provider config in same module ... Previously we were defaulting the provider configuration selection to a provider in the root module inferred from the resource type name. This is close, but not quite right: we need to _start_ with a provider configuration in the same module as we're importing into, and then our provider resolution steps during import graph construction will use that as a starting point for a walk up the tree to find the nearest matching configuration (which might eventually still be in the root, but not necessarily).	8 years ago
Martin Atkins	f085af4ba6	command: update "terraform console" for HCL2 ... This now uses the HCL2 parser and evaluator APIs and evaluates in terms of a new-style *lang.Scope, rather than the old terraform.Interpolator type that is no longer functional. The Context.Eval method used here behaves differently than the Context.Interpolater method used previously: it performs a graph walk to populate transient values such as input variables, local values, and output values, and produces its scope in terms of the result of that graph walk. Because of this, it is a lot more robust than the prior method when asked to resolve references other than those that are persisted in the state.	8 years ago
Martin Atkins	9ca13d5c1d	command/validate: make sure diagnostics is always present and an array ... Previously an empty diagnostics would appear as "null" in the JSON output, since that is how encoding/json serializes a nil slice. It's more convenient for users of dynamic languages to keep the type consistent in all cases, since they can then just iterate the list without needing a special case for when it is null.	8 years ago
Martin Atkins	c937c06a03	terraform: ugly huge change to weave in new HCL2-oriented types ... Due to how deeply the configuration types go into Terraform Core, there isn't a great way to switch out to HCL2 gradually. As a consequence, this huge commit gets us from the old state to a _compilable_ new state, but does not yet attempt to fix any tests and has a number of known missing parts and bugs. We will continue to iterate on this in forthcoming commits, heading back towards passing tests and making Terraform fully-functional again. The three main goals here are: - Use the configuration models from the "configs" package instead of the older models in the "config" package, which is now deprecated and preserved only to help us write our migration tool. - Do expression inspection and evaluation using the functionality of the new "lang" package, instead of the Interpolator type and related functionality in the main "terraform" package. - Represent addresses of various objects using types in the addrs package, rather than hand-constructed strings. This is not critical to support the above, but was a big help during the implementation of these other points since it made it much more explicit what kind of address is expected in each context. Since our new packages are built to accommodate some future planned features that are not yet implemented (e.g. the "for_each" argument on resources, "count"/"for_each" on modules), and since there's still a fair amount of functionality still using old-style APIs, there is a moderate amount of shimming here to connect new assumptions with old, hopefully in a way that makes it easier to find and eliminate these shims later. I apologize in advance to the person who inevitably just found this huge commit while spelunking through the commit history.	8 years ago
Martin Atkins	4ed06a9227	terraform: HCL2-flavored module dependency resolver ... For the moment this is just a lightly-adapted copy of ModuleTreeDependencies named ConfigTreeDependencies, with the goal that the two can live concurrently for the moment while not all callers are yet updated and then we can drop ModuleTreeDependencies and its helper functions altogether in a later commit. This can then be used to make "terraform init" and "terraform providers" work properly with the HCL2-powered configuration loader.	8 years ago
Martin Atkins	ebafa51723	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	8 years ago
Martin Atkins	5782357c28	backend: Update interface and implementations for new config loader ... The new config loader requires some steps to happen in a different order, particularly in regard to knowing the schema in order to decode the configuration. Here we lean directly on the configschema package, rather than on helper/schema.Backend as before, because it's generally sufficient for our needs here and this prepares us for the helper/schema package later moving out into its own repository to seed a "plugin SDK".	8 years ago
Martin Atkins	618883596a	command: remove "terraform push" ... The remote API this talks to will be going away very soon, before our next major release, and so we'll remove the command altogether in that release. This also removes the "encodeHCL" function, which was used only for adding a .tfvars-formatted file to the uploaded archive.	8 years ago
Martin Atkins	9a004e3f9d	command: "terraform validate" JSON support ... In the long run we'd like to offer machine-readable output for more commands, but for now we'll just start with a tactical feature in "terraform validate" since this is useful for automated testing scenarios, editor integrations, etc, and doesn't include any representations of types that are expected to have breaking changes in the near future.	8 years ago
Martin Atkins	bfd9392eb8	command: beginnings of new config loader in "terraform validate" ... As part of some light reorganization of our commands, this new implementation no longer does validation of variables and will thus avoid the need to spin up a fully-valid context. Instead, its focus is on validating the configuration itself, regardless of any variables, state, etc. This change anticipates us later adding a -validate-only flag to "terraform plan" which will then take over the related use-case of checking if a particular execution of Terraform is valid, _including_ the state, variables, etc. Although leaving variables out of validate feels pretty arbitrary today while all of the variable sources are local anyway, we have plans to allow per-workspace variables to be stored in the backend in future and at that point it will no longer be possible to fully validate variables without accessing the backend. The "terraform plan" command explicitly requires access to the backend, while "terraform validate" is now explicitly for local-only validation of a single module. In a future commit this will be extended to do basic type checking of the configuration based on provider schemas, etc.	8 years ago
Martin Atkins	fd5b7b42b8	command: new Meta methods for accessing the new config loader ... We need to share a single config loader across all callers because that allows us to maintain the source code cache we'll use for snippets in error messages. Nothing calls this yet. Callers will be gradually updated away from Module and Config in subsequent commits.	8 years ago
Martin Atkins	bd10b84a8e	command/format: include source snippets in diagnostics ... If we get a diagnostic message that references a source range, and if the source code for the referenced file is available, we'll show a snippet of the source code with the source range highlighted. At the moment we have no cache of source code, so in practice this codepath can never be visited. Callers to format.Diagnostic will be gradually updated in subsequent commits.	8 years ago
Sander van Harmelen	b1fdbd7db8	Allow enhanced backends to pass custom exit codes ... In some cases this is needed to keep the UX clean and to make sure any remote exit codes are passed through to the local process. The most obvious example for this is when using the "remote" backend. This backend runs Terraform remotely and stream the output back to the local terminal. When an error occurs during the remote execution, all the needed error information will already be in the streamed output. So if we then return an error ourselves, users will get the same errors twice. By allowing the backend to specify the correct exit code, the UX remains the same while preserving the correct exit codes.	8 years ago
Sander van Harmelen	67db9da000	Add checks for all flags we currently don’t support ... For Plan only: -module-depth=n For Plan & Apply -parallelism=m -refresh=false -var “foo=bar” and -var-file=foo	8 years ago
Kevin Carmody	7ac9a576bb	Update wrong usage workspace command description ... Small update to the description to include available commands, rather than similar looking but wrong ones.	8 years ago
Sander van Harmelen	36bd5d6480	Make sure the state is locked before it is used ... Both the `taint` and `untaint` commands had a small logical error that caused them you first get the state and then lock it.	8 years ago
Sean Chittenden	d749420a25	Fix drift caused from gofmt when running make dev and go 1.11. ... A fresh checkout of `origin/master` does not build atm using the `dev` target because `master` has not been formatted using `gofmt` from Go 1.11 (tis has been the case for a while if you've been running devel). None of the drift in question is especially new but now that Go 1.11 has been released and gofmt's formatting guidelines have been updated, it would be *really* nice if the code in `master` reflected the current tooling in order to avoid having to fight this drift locally. * 8mo: https://github.com/hashicorp/terraform/blame/master/backend/remote-state/s3/backend_test.go#L260-L261 * 6mo: https://github.com/hashicorp/terraform/blame/master/builtin/provisioners/chef/linux_provisioner_test.go#L124 * 1yr: 7cfeffe36b/command/init.go (L75-L76) * 12d: 7cfeffe36b/command/meta_backend_test.go (L1437) * 2yr: 7cfeffe36b/helper/schema/resource_timeout_test.go (L26) * 4yr: 7cfeffe36b/helper/schema/schema_test.go (L2059) * 1yr: 7cfeffe36b/plugin/discovery/get_test.go (L151)	8 years ago
Oleg Butuzov	2ac15fdae4	command: Fix inconsistent spacing in "terraform push -help" ... Fixes #18775	8 years ago
Sander van Harmelen	ce2869dced	Merge pull request #18760 from hashicorp/f-remote-backend ... backend/migrations: migrate the default state	8 years ago
Sander van Harmelen	f410a5bb26	backend/migrations: migrate the default state ... Certain backends (currently only the `remote` backend) do not support using both the default and named workspaces at the same time. To make the migration easier for users that currently use both types of workspaces, this commit adds logic to ask the user for a new workspace name during the migration process.	8 years ago
Sander van Harmelen	1696ade924	backend/migrations: check all workspaces ... This commit fixes a bug that (in the case of the `local` backend) would only check if the selected workspace had a state when deciding to preform a migration. When the selected workspace didn’t have a state (but other existing workspace(s) did), the migration would not be preformed and the other workspaces would be ignored.	8 years ago
Sander van Harmelen	7fb2d1b8de	Implement the Enterprise enhanced remote backend	8 years ago
Sander van Harmelen	179b32d426	Add a `CredentialsForHost` method to disco.Disco ... By adding this method you now only have to pass a `*disco.Disco` object around in order to do discovery and use any configured credentials for the discovered hosts. Of course you can also still pass around both a `*disco.Disco` and a `auth.CredentialsSource` object if there is a need or a reason for that!	8 years ago
Sander van Harmelen	495d1ea350	Use New() instead of `once.Do(b.init)`	8 years ago
Sander van Harmelen	97d1c46602	Update the backend import names ... It’s a purely cosmetic change, but I find it easier to read them like this.	8 years ago
Aurelie Vache	7a29a03e21	command: help text for "workspace" to include "list" verb ... One of the subcommands lists out the existing workspaces.	8 years ago
Kristin Laemmert	33877bd579	cli: update tests	8 years ago
Lyle Franklin	26b907387d	cli: Remove error on empty outputs when `-json` is set (#11721) ... - Fixes #11696 - This changes makes `terraform output -json` return '{}' instead of throwing an error about "no outputs defined" - If `-json` is not set, the user will receive an error as before - This UX helps new users to understand how outputs are used - Allows for easier automation of TF CLI as an empty set of outputs is usually acceptable, but any other error from `output` would be re-raised to the user.	8 years ago
Kristin Laemmert	b8a1a77f6b	command: fix spelling in error message - fixes #18065 (#18241)	8 years ago
James Bardin	545e77e184	Merge pull request #17711 from hashicorp/jbardin/cleanup-temps ... cleanup temp files	8 years ago
James Bardin	e980156451	cleanup temp files from command tests ... Rather than try to modify all the hundreds of calls to the temp helper functions, and cleanup the temp files at every call site, have all tests work within a single temp directory that is removed at the end of TestMain.	8 years ago
Masayuki Morita	1e2bb07504	command: Restore `auto-approve` flag in the output of `apply -help`	8 years ago
James Bardin	90a75422fb	unlock state in console, import, graph, and push ... The state locking improvements for the regular command had the side effect of locking the state in the console, import, graph and push commands. Those commands had been updated to get a state via the Backend.Context method, which locks the state whenever possible, and now need to call Unlock directly. Add Unlock calls to all commands that call Context directly.	8 years ago
Martin Atkins	6aefa5835c	Merge #17218: Add -auto-approve to "terraform destroy" for consistency	8 years ago
James Bardin	dc8036636a	Merge pull request #17422 from hashicorp/jbardin/state-locking ... Add StateLocker interface to backend operations	8 years ago
James Bardin	2b97585d46	improve clistate.Locker docs	8 years ago
Uriel Corfa	07a20365de	cli: "terraform state list" -id argument ... A new -id option to "terraform state list" which constraints the output of the command to resources whose id is equal to the flag value.	8 years ago
James Bardin	bdd475e149	use the new clistate.Locker in commands ... Use the new StateLocker field to provide a wrapper for locking the state during terraform.Context creation in the commands that directly manipulate the state.	8 years ago
James Bardin	e9a76808df	create clistate.Locker interface ... Simplify the use of clistate.Lock by creating a clistate.Locker instance, which stores the context of locking a state, to allow unlock to be called without knowledge of how the state was locked. This alows the backend code to bring the needed UI methods to the point where the state is locked, and still unlock the state from an outer scope. Provide a NoopLocker as well, so that callers can always call Unlock without verifying the status of the lock. Add the StateLocker field to the backend.Operation, so that the state lock can be carried between the different function scopes of the backend code. This will allow the backend context to lock the state before it's read, while allowing the different operations to unlock the state when they complete.	8 years ago
James Bardin	12bda53558	Revert "create clistate.Locker interface" ... This reverts commit e88bd74bb7.	8 years ago
James Bardin	3de0d24554	Revert "use the new clistate.Locker in commands" ... This reverts commit 400f6ca4c5.	8 years ago
James Bardin	400f6ca4c5	use the new clistate.Locker in commands ... Use the new StateLocker field to provide a wrapper for locking the state during terraform.Context creation in the commands that directly manipulate the state.	8 years ago
James Bardin	e88bd74bb7	create clistate.Locker interface ... Simplify the use of clistate.Lock by creating a clistate.Locker instance, which stores the context of locking a state, to allow unlock to be called without knowledge of how the state was locked. This alows the backend code to bring the needed UI methods to the point where the state is locked, and still unlock the state from an outer scope.	8 years ago
James Bardin	a37acb1837	gofmt with go1.10	8 years ago
James Bardin	ecd9ef0f77	ignore error in plan shutdown test ... The error was being silently dropped before. There is an interpolation error, because the plan is canceled before some of the resources can be evaluated. There might be a better way to handle this in the walk cancellation, but the behavior has not changed. Make the plan and apply shutdown match implementation-wise	8 years ago
James Bardin	67a6152091	move backend operation cancellation into meta ... Create a single command method for running and operation with cancellation.	8 years ago
James Bardin	7cba68326a	always wait for a RunningOperation to return ... If the user wishes to interrupt the running operation, only the first interrupt was communicated to the operation by canceling the provided context. A second interrupt would start the shutdown process, but not communicate this to the running operation. This order of event could cause partial writes of state. What would happen is that once the command returns, the plugin system would stop the provider processes. Once the provider processes dies, all pending Eval operations would return return with an error, and quickly cause the operation to complete. Since the backend code didn't know that the process was shutting down imminently, it would continue by attempting to write out the last known state. Under the right conditions, the process would exit part way through the writing of the state file. Add Stop and Cancel CancelFuncs to the RunningOperation, to allow it to easily differentiate between the two signals. The backend will then be able to detect a shutdown and abort more gracefully. In order to ensure that the backend is not in the process of writing the state out, the command will always attempt to wait for the process to complete after cancellation.	8 years ago
Laura Martin	6e1e614a56	Change -force to -auto-approve when destroying ... Since an early version of Terraform, the `destroy` command has always had the `-force` flag to allow an auto approval of the interactive prompt. 0.11 introduced `-auto-approve` as default to `false` when using the `apply` command. The `-auto-approve` flag was introduced to reduce ambiguity of it's function, but the `-force` flag was never updated for a destroy. People often use wrappers when automating commands in Terraform, and the inconsistency between `apply` and `destroy` means that additional logic must be added to the wrappers to do similar functions. Both commands are more or less able to run with similar syntax, and also heavily share their code. This commit updates the command in `destroy` to use the `-auto-approve` flag making working with the Terraform CLI a more consistent experience. We leave in `-force` in `destroy` for the time-being and flag it as deprecated to ensure a safe switchover period.	8 years ago
James Bardin	6f41a80b3a	slow down the plan shutdown tests for slow hosts ... The plan shutdown test often fail on slow CI hosts, becase the plan completes befor the main thread can cancel it. Since attempting to make the MockProvider concurrent proved too invasive for now, just slow the test down a bit to help ensure Stop gets called.	8 years ago
Masayuki Morita	338d5cad70	Remove duplicated help messages from `workspace --help` ... Fixes #17165	8 years ago
Masayuki Morita	f440dba137	Standardize on log level "WARN" rather than "WARNING"	8 years ago
Martin Atkins	a6008b8a48	v0.11.2	8 years ago
James Bardin	61c2be3e95	Merge pull request #16969 from hashicorp/jbardin/reset-plugin-dir ... allow init to reset -plugin-dir	8 years ago
James Bardin	7d5f7cb22f	Merge pull request #16961 from hashicorp/jbardin/mock-provider-race ... minor race issue in mockResourceProvider	8 years ago
James Bardin	504ea578ee	Merge pull request #16920 from hashicorp/jbardin/init-future-state ... check state version during init	8 years ago
James Bardin	dec2da1dda	Merge pull request #17044 from hashicorp/jbardin/plugin-dir-internal ... -plugin-dir short-circuits discovery of internal plugins	8 years ago
James Bardin	6367572455	Merge pull request #16882 from Techcadia/f-provider-logging ... [Add] Pathing and Override to DEBUG Command	8 years ago
James Bardin	fe3aff91f3	missingPlugins should not return internal plugins ... Filter the internal plugins out beforehand, so we don't attempt to locate them at all during init.	8 years ago
James Bardin	5a975d9997	add test for internal plugins with -plugin-dir ... -plugin-dir was short-circuiting the discovery for internal plugins	8 years ago
James Bardin	5a9e0cf763	create a new InternalProviders test ... Remove the legacy InternalProviders global. The terraform provider is the only one run internally.	8 years ago
James Bardin	ba84faf4e1	remove the plugin path only for an empty string ... To avoid breaking automation where plugin-path was assumed to be set permanently, only remove the plugin-path record if it was explicitly set to and empty string.	8 years ago
James Bardin	f62b71710a	Merge pull request #16939 from hashicorp/jbardin/migrate-confirm ... remove extra backend migration prompts	8 years ago
James Bardin	f45205feb7	re-word state migration prompts ... The existing prompts were worded as if backend configurations were named, but they can only really be referenced by their type. Change the wording to reference them as type "X backend". When migrating state, refer to the backends as the "previously configured" and "newly configured", since they will often have the same type.	8 years ago
James Bardin	4b49a323c3	go fmt ... slight change to go fmt coming in 0.10	8 years ago
James Bardin	79e985366f	allow init to reset -plugin-dir ... Remove the recorded -plugin-dir during init if the flag is not provided.	8 years ago
James Bardin	d76482cd89	don't try to interrupt diff in shutdown test ... Rather than relying on interrupting Diff, just make sure Stop was called on the provider. The DiffFn is protected by a mutex in the mock provider, which means that the tests can't rely on concurent calls to diff working.	8 years ago
James Bardin	e63a3474d5	kill the flag error writer after 2 seconds ... There's no point in trying to track these, they're lost after each test. Kill them after a short delay so we don't have goroutines from every single command test to wade through if we have a stack dump.	8 years ago
James Bardin	885e4cde81	don't loop indefinitely in confirm method ... Only check for input twice in the meta.confirm method. This prevents an errant newline from aborting the run while allowing Terraform to exit if there is no input available. We don't just check for a tty, since we still rely on being able to pipe input in for testing. Remove the redundant confirmation loops in the migration code, and only use the confirm method.	8 years ago
James Bardin	7d2da9865e	inputFalse test should attempt migration and check error ... Make sure the init inputFalse test actually errors from missing input, since skipping input will still fail later during provider initialization. We need to make sure there are two different states that aren't a noop for migration, and reset the command struct for each run. Also verify that we don't go into an infinite loop if there is no input.	8 years ago
James Bardin	909dff36a8	remove extra "yes" confirmation in tests ... There were two tests that had the duplicate confirmations hard-coded in the input stream.	8 years ago
James Bardin	7c93b2e5e6	remove duplicate backend migration prompts ... The duplicate prompts can be confusing when the user confirms that a migration should happen and we immediately prompt a second time for the same thing with slightly different wording. The extra hand-holding that this provides for legacy remote states is less critical now, since it's been 2 major release cycles since those were removed.	8 years ago
James Bardin	ea4cb6a20e	check state version during init ... The init command needs to parse the state to resolve providers, but changes to the state format can cause that to fail with difficult to understand errors. Check the terraform version during init and provide the same error that would be returned by plan or apply.	8 years ago
Martin Atkins	f1079257ac	command: show a special error message when importing in an empty dir ... If users run "terraform import" in a directory with no Terraform configuration files, it's likely that they've made a mistake either by being in the wrong directory or forgetting to use the -config option on the command line. To help users find their mistake in this case, we'll now produce a specialized error message for this situation: Error: No Terraform configuration files The directory /home/user/example does not contain any Terraform configuration files (.tf or .tf.json). To specify a different configuration directory, use the -config="..." command line option. While here, this also converts some of the other existing messages to diagnostics so that we can show any configuration warnings along with the error message, and move towards the new standard error presentation.	8 years ago
Techcadia	e681907c50	[Add] Pathing and Override Output to DEBUG Command	8 years ago
Nolan Davidson	653db95df7	Initial implementation of a habitat provisioner ... First pass at loading the config data using the TF schema. Signed-off-by: Nolan Davidson <ndavidson@chef.io>	8 years ago
Martin Atkins	9a5c865040	command: validate config as part of loading it ... Previously we required callers to separately call .Validate on the root module to determine if there were any value errors, but we did that inconsistently and would thus see crashes in some cases where later code would try to use invalid configuration as if it were valid. Now we run .Validate automatically after config loading, returning the resulting diagnostics. Since we return a diagnostics here, it's possible to return both warnings and errors. We return the loaded module even if it's invalid, so callers are free to ignore returned errors and try to work with the config anyway, though they will need to be defensive against invalid configuration themselves in that case. As a result of this, all of the commands that load configuration now need to use diagnostic printing to signal errors. For the moment this just allows us to return potentially-multiple config errors/warnings in full fidelity, but also sets us up for later when more subsystems are able to produce rich diagnostics so we can show them all together. Finally, this commit also removes some stale, commented-out code for the "legacy" (pre-0.8) graph implementation, which has not been available for some time.	8 years ago
James Bardin	12b7dac124	Merge pull request #16833 from hashicorp/jbardin/plan-shutdown ... Fully enable shutdown for plan and refresh in the local backend	8 years ago
Eyal Posener	e1dadaae44	command: use newer version of "complete" library ... This takes care of filtering results for us, so we don't need to do it on our end anymore.	8 years ago
James Bardin	2941ed464c	replace the testShutdownHook with a check for Stop ... Now that the local backend can be cancelled during plan and refresh, we don't really need the testShutdownHook. Simplify the tests by just checking for Stop being called on the provider.	8 years ago
James Bardin	e2501d7830	make apply shutdown test completely deterministic ... Add a shutdown hook to verify that a context has been correctly cancelled, so we can remove the sleep and stop guessing. Add a plan version of the shutdown test as well.	9 years ago
James Bardin	3aaa1e9d04	make plans cancellable ... There was no cancellation context for a plan, so it would always have to run to completion as SIGINT was being swallowed. Move the shutdown channel to the command Meta since it's used in multiple commands.	9 years ago
Martin Atkins	ba0514106a	return tfdiags.Diagnostics from validation methods ... Validation is the best time to return detailed diagnostics to the user since we're much more likely to have source location information, etc than we are in later operations. This change doesn't actually add any detail to the messages yet, but it changes the interface so that we can gradually introduce more detailed diagnostics over time. While here there are some minor adjustments to some of the messages to improve their consistency with terminology we use elsewhere.	9 years ago
James Bardin	3c807e5427	update state test strings in command package	9 years ago
Martin Atkins	3b180d7f8a	Merge #16543: Bring the "terraform" provider back into core	9 years ago
Martin Atkins	d4ee58ce59	Re-integrate the "terraform" provider into the main binary ... As part of the 0.10 core/provider split we moved this provider, along with all the others, out into its own repository. In retrospect, the "terraform" provider doesn't really make sense to be separated since it's just a thin wrapper around some core code anyway, and so re-integrating it into core avoids the confusion that results when Terraform Core and the terraform provider have inconsistent versions of the backend code and dependencies. There is no good reason to use a different version of the backend code in the provider than in core, so this new "internal provider" mechanism is stricter than the old one: it's not possible to use an external build of this provider at all, and version constraints for it are rejected as a result. This provider is also run in-process rather than in a child process, since again it's just a very thin wrapper around code that's already running in Terraform core anyway, and so the process barrier between the two does not create enough advantage to warrant the additional complexity.	9 years ago
James Bardin	964054efc0	update tests for updated output	9 years ago
James Bardin	1bf64ec788	add "Updating" output and fix output tests	9 years ago
James Bardin	9c334fe012	update init output ... Change "Downloading" to 'Initializing" to match the provider loading dialog. List each module being loaded. If a regisry module is being downloaded, list the registry host, and the version discovered. Show the source string from the config that is being fetched, rather than the go-getter url. The full source can be found in the logs for debugging. Add much more extensive logging	9 years ago
James Bardin	523b121341	fix get test working directory ... use a temp dir and cleanup	9 years ago
Martin Atkins	3da5fefdc1	command: Allow TF_DATA_DIR env var to override data directory ... This allows the user to customize the location where Terraform stores the files normally placed in the ".terraform" subdirectory, if e.g. the current working directory is not writable.	9 years ago
Martin Atkins	400038eda4	command: "terraform apply" uses interactive confirmation by default ... In the 0.10 release we added an opt-in mode where Terraform would prompt interactively for confirmation during apply. We made this opt-in to give those who wrap Terraform in automation some time to update their scripts to explicitly opt out of this behavior where appropriate. Here we switch the default so that a "terraform apply" with no arguments will -- if it computes a non-empty diff -- display the diff and wait for the user to type "yes" in similar vein to the "terraform destroy" command. This makes the commonly-used "terraform apply" a safe workflow for interactive use, so "terraform plan" is now mainly for use in automation where a separate planning step is used. The apply command remains non-interactive when given an explicit plan file. The previous behavior -- though not recommended -- can be obtained by explicitly setting the -auto-approve option on the apply command line, and indeed that is how all of the tests are updated here so that they can continue to run non-interactively.	9 years ago
James Bardin	53c8c1e208	e2e test for `init -from-module` ... Pull down the hashicorp/vault/aws module into the current directory with init.	9 years ago
James Bardin	f64851242e	use Storage.GetModule for init -from-module ... This will enable copying any module source into a target directory.	9 years ago
James Bardin	5203c66116	pass command credentials into module.Storage	9 years ago
James Bardin	3a495ffe56	rename ModuleStorage to Storage ... get rid of stutter and use module.Storage	9 years ago
James Bardin	f2a7b94692	use the new ModuleStorage in the command package ... Update the command package to use the new module storage. Move the old command output strings into the module storage itself. This could be moved back later either by using ui callbacks, or designing a module storage interface once we know what the final requirements will look like.	9 years ago
Martin Atkins	5347f82f9a	command: Include provider versions in "terraform version" ... We encourage users to share the "terraform version" output as part of filing an issue, but previously it only printed the core Terraform version and this left provider maintainers with no information about which _provider_ version an issue relates to. Here we make a best effort to show versions for providers, though we will omit some or all of them if either "terraform init" hasn't been run (and so no providers were selected yet) or if there are other inconsistencies that would cause Terraform to object on startup and require a re-run of "terraform init".	9 years ago
Martin Atkins	34cecfa839	command/e2etest: fix incorrect "terraform version" test ... Two different errors here caused this test to pass even though it was incorrect: the wanted version string was incorrect, but the test for it was also inverted, and so together this made the test pass even though it was actually not testing the output at all.	9 years ago
James Bardin	47c45788bc	Merge pull request #16406 from hashicorp/jbardin/version-package ... Add a standalone version package for all of terraform	9 years ago
Patrick Van Stee	a4a53f6f99	command/validate: Load plugins from plugin_path file ... This was added to other commands in 0.10 but was missed on "validate".	9 years ago
James Bardin	36b8be43e8	use the new version package ... Update all references to the version values to use the new package. The VersionString function was left in the terraform package specifically for the aws provider, which is vendored. We can remove that last call once the provider is updated.	9 years ago
Martin Atkins	865e61b4ea	main+command: provide service disco and creds to commands ... The command package is the main place we need access to these, so that we can use them during init (to install packages, for example) and so that we can use them to configure remote backends. For the moment we're just providing an empty credentials object, which will start to include both statically-configured and helper-program-provided credentials sources in subsequent commits.	9 years ago
Martin Atkins	6f7bc4f5d7	command: use c.showDiagnostics for backend operation errors ... This allows richer diagnostics produced by some subsystems to be displayed in full-fidelity to the user.	9 years ago
Martin Atkins	5cd00a13ec	command: use new diagnostics output for config errors ... This uses the new diagnostics printer for config-related errors in the main five commands that deal with config. The immediate motivation for this is to allow HCL2-produced diagnostics to be printed out in their full fidelity, though it also slightly changes the presentation of other errors so that they are not presented in all red text, which can be hard to read on some terminals.	9 years ago
Martin Atkins	ea81e75a4e	command: utility for rendering tfdiag diagnostics ... This new method showDiagnostics takes any value that would be accepted by tfdiags.Append and renders it to the UI. This is intended to encourage consistent handling of the different kinds of errors and diagnostics that can be produced, and allow richer error objects like the HCL2 diagnostics to be easily unwrapped and shown in their full-fidelity.	9 years ago
Martin Atkins	fc20f419dd	config and command: use errwrap to propagate config load errors ... Previously we were using fmt.Sprintf and thus forcing the stringification of the wrapped error. Using errwrap allows us to unpack the original error at the top of the stack, which is useful when the wrapped error is really a hcl.Diagnostics containing potentially-multiple errors and possibly warnings.	9 years ago
Martin Atkins	86343fa895	Remove test output file accidentally added in 52c97e9f ... Also, fix the missing gitignore rule that caused this to be added in the first place.	9 years ago
James Bardin	91442b7146	Merge pull request #15680 from brunomcustodio/etcdv3-backend ... [WIP] etcd v3 backend with lock support.	9 years ago
Martin Atkins	30e6f4e066	command/e2etest: test installation of plugins from cache ... This is a tough one to unit tests because the behavior is tangled up in the code that hits releases.hashicorp.com, so we'll add this e2etest as some extra insurance that this works end-to-end.	9 years ago
Martin Atkins	5c0670fdf4	command: allow callers to activate a plugin cache ... Here we add a new caller-settable field to command.Meta that activates a read-through cache directory for plugin installation.	9 years ago
Martin Atkins	73d1298572	command/e2etest: test the "running in automation" workflow ... Since we now have a guide that recommends some specific ways to run Terraform in automation, we can mimic those suggestions in an e2e test and thus ensure they keep working. Here we test the three different approaches suggested in the guide: - init, plan, apply (main case) - init, apply (e.g. for deploying to a QA/staging environment) - init, plan (e.g. for verifying a pull request)	9 years ago
Martin Atkins	cb6d4e5f20	command/e2etest: fix TestPrimarySeparatePlan test ... In 6712192724 we stopped counting data source destroys in the destroy tally since they are an implementation detail. This caused this test to start failing, though since the new behavior is correct here we just update the test to match.	9 years ago
Martin Atkins	ece06c35b8	command: parameter autocomplete for "terraform workspace ..." ... Shell tab completion for all of the subcommands under "terraform workspace", providing the appropriate kind of auto-complete for each argument, along with completion for for any flags.	9 years ago
Martin Atkins	793da43a72	command: workspace name autocomplete helper ... This helper is a Predictor for the "complete" package that tries to auto-complete workspace names from the current backend, if it's initialized and operable.	9 years ago
Martin Atkins	e4f18c3f4d	command: multi-argument autocomplete helper ... The predictors built in to the "complete" package assume that the same type of argument is repeated indefinitely, but most Terraform commands don't work like that, so this helper allows us to define a sequence of predictors that apply to each argument in turn.	9 years ago
Martin Atkins	2ed9aa6077	command: autocomplete data for "terraform init"	9 years ago
Martin Atkins	82fefbc599	command: add some common autocomplete predictors ... We use boolean flags and module sources in a lot of places, so we'll define global predictors for these which we can use across many commands.	9 years ago
Sunny	8928c5a60a	command/state-rm: tell the user how many items were removed	9 years ago
Jack Bruno	3f2136d7ee	cli: terraform import -ignore-missing-config ... This new option allows importing without configuration present. Configuration is required by default as a confirmation that the provided resource name is correct, but it can be useful to override this in tools that wrap Terraform to do more involved operations.	9 years ago
Jearvon Dharrie	5afe1d39d1	Add `/downloads` to the outdated version message	9 years ago
Martin Atkins	0fe43c8977	cli: allow disabling "next steps" message in terraform plan ... In #15884 we adjusted the plan output to give an explicit command to run to apply a plan, whereas before this command was just alluded to in the prose. Since releasing that, we've got good feedback that it's confusing to include such instructions when Terraform is running in a workflow automation tool, because such tools usually abstract away exactly what commands are run and require users to take different actions to proceed through the workflow. To accommodate such environments while retaining helpful messages for normal CLI usage, here we introduce a new environment variable TF_IN_AUTOMATION which, when set to a non-empty value, is a hint to Terraform that it isn't being run in an interactive command shell and it should thus tone down the "next steps" messaging. The documentation for this setting is included as part of the "...in automation" guide since it's not generally useful in other cases. We also intentionally disclaim comprehensive support for this since we want to avoid creating an extreme number of "if running in automation..." codepaths that would increase the testing matrix and hurt maintainability. The focus is specifically on the output of the three commands we give in the automation guide, which at present means the following two situations: * "terraform init" does not include the final paragraphs that suggest running "terraform plan" and tell you in what situations you might need to re-run "terraform init". * "terraform plan" does not include the final paragraphs that either warn about not specifying "-out=..." or instruct to run "terraform apply" with the generated plan file.	9 years ago
Martin Atkins	b95610c173	Merge #15387: terraform fmt -check option ... This new option causes fmt to return a non-zero exit code if any inconsistencies are detected.	9 years ago
Martin Atkins	fe4cfd03b5	command/format: restore "(forces new resource)" caption ... In 3ea1592 the plan rendering was refactored to add an extra indirection of producing a display-oriented plan object first and then rendering from that object. There was a logic error while adapting the existing plan rendering code to use the new display-oriented object: the core InstanceDiff object sets the "Destroy" flag (a boolean) for both DiffDestroy and DiffDestroyCreate, and so this code previously checked r.Destroy to recognize the "destroy-create" case. This was incorrectly adapted to a check for the display action being DiffDestroy, when it should actually have been DiffDestroyCreate. The effect of this bug was to cause the "(forces new resource)" annotations to not be displayed on attributes, though the resource-level information still correctly reflected that a new resource was required. This fix restores the attribute-level annotations.	9 years ago
Bruno Miguel Custodio	52c97e9fc9	First steps towards an 'etcdv3' backend.	9 years ago
Martin Atkins	83414beb8f	command: various adjustments to the diff presentation ... The previous diff presentation was rather "wordy", and not very friendly to those who can't see color either because they have color-blindness or because they don't have a color-supporting terminal. This new presentation uses the actual symbols used in the plan output and tries to be more concise. It also uses some framing characters to try to separate the different stages of "terraform plan" to make it easier to visually navigate. The apply command also adopts this new plan presentation, in preparation for "terraform apply" (with interactive plan confirmation) becoming the primary, safe workflow in the next major release. Finally, we standardize on the terminology "perform" and "actions" rather than "execute" and "changes" to reflect the fact that reading is now an action and that isn't actually a _change_.	9 years ago
Martin Atkins	d4efc95191	command: show resource actions using resource addresses ... Previously we were using the internal resource id syntax in the UI. Now we'll use the standard user-facing resource address syntax instead.	9 years ago
Martin Atkins	3ea159297c	command/format: improve consistency of plan results ... Previously the rendered plan output was constructed directly from the core plan and then annotated with counts derived from the count hook. At various places we applied little adjustments to deal with the fact that the user-facing diff model is not identical to the internal diff model, including the special handling of data source reads and destroys. Since this logic was just muddled into the rendering code, it behaved inconsistently with the tally of adds, updates and deletes. This change reworks the plan formatter so that it happens in two stages: - First, we produce a specialized Plan object that is tailored for use in the UI. This applies all the relevant logic to transform the physical model into the user model. - Second, we do a straightforward visual rendering of the display-oriented plan object. For the moment this is slightly overkill since there's only one rendering path, but it does give us the benefit of letting the counts be derived from the same data as the full detailed diff, ensuring that they'll stay consistent. Later we may choose to have other UIs for plans, such as a machine-readable output intended to drive a web UI. In that case, we'd want the web UI to consume a serialization of the _display-oriented_ plan so that it doesn't need to re-implement all of these UI special cases. This introduces to core a new diff action type for "refresh". Currently this is used _only_ in the UI layer, to represent data source reads. Later it would be good to use this type for the core diff as well, to improve consistency, but that is left for another day to keep this change focused on the UI.	9 years ago
Sunny	3a1582c1b9	command/validate: read terraform.tfvars file for variable values ... This is now consistent with the handling of this file for other commands.	9 years ago
Sunny	2d849f8650	command/init: check required_version ... Previously we were checking required_version only during "real" operations, and not during initialization. Catching it during init is better because that's the first command users run on a new working directory.	9 years ago
Martin Atkins	c12d64f340	Use t.Helper() in our test helpers ... Go 1.9 adds this new function which, when called, marks the caller as being a "helper function". Helper function stack frames are then skipped when trying to find a line of test code to blame for a test failure, so that the code in the main test function appears in the test failure output rather than a line within the helper function itself. This covers many -- but probaly not all -- of our test helpers across various packages.	9 years ago
Radek Simko	4e8ccb3127	Merge pull request #15828 from hashicorp/e2e-decoupling ... tools/terraform-bundle: Add e2e tests	9 years ago
Radek Simko	aabab16069	command/init: Remove extra whitespace	9 years ago
Michael Handler	817d1c4869	Output duration in UiHook after successful operation completion.	9 years ago
James Bardin	18af7750d4	Merge pull request #14720 from sevagh/master ... Add salt-masterless provisioner	9 years ago
Radek Simko	9e7e4ff4fb	e2e: Decouple logic for running e2e tests	9 years ago
Radek Simko	28b33c9299	plugin: Display version + source when initializing plugins	9 years ago
Radek Simko	38cb98fb0c	Comply w/ latest changes in mitchellh/cli	9 years ago
James Bardin	ea3e87b584	Merge pull request #15768 from hashicorp/jbardin/remote-import ... Don't ForceLocal for the import backend	9 years ago
James Bardin	5bcc1bae59	Merge pull request #15769 from hashicorp/jbardin/discovery-paths ... load legacy plugin paths	9 years ago
James Bardin	2bb5007690	Merge pull request #15683 from hashicorp/jbardin/remote-state-lineage ... Remove strict lineage check in remote.State	9 years ago
James Bardin	37932c3cd6	make state_rm flag description match state_mv	9 years ago
James Bardin	4034f988df	update import command docs ... Fix the -state and -state-out wording to be consistent with other commands. Remove the erroneous reference to remote state in the website version of the flag description.	9 years ago
James Bardin	54998933f5	load Meta.PluginOverrides in dicovery ... Make sure the override paths from the legacy rc file are loaded for discovery.	9 years ago
James Bardin	fa20d43d80	test loading of Meta.PluginOverrides ... These are currently being skipped in discovery	9 years ago
James Bardin	e3748901b4	Don't ForceLocal for the import backend ... While the `local.Local` backend is the only implementation of `backend.Local`, creating the backend with `ForceLocal` bypasses the `backend.Backend` in the `local.Local` causing a local state to be implicitly created rather than using the configured state backend. Add a test that imports into a configured backend (using the "local" backend as a remote state proxy). This further confirms the confusing nature of ForceLocal, as the backend _is_ local, but not from the viewpoint of meta.Backend.	9 years ago
Sevag Hanssian	867760ed56	Add salt-masterless provisioner	9 years ago
James Bardin	eadda50f02	Merge pull request #15652 from hashicorp/jbardin/state-command ... state commands with remote state backends	9 years ago
James Bardin	55d18dcef2	update state rm amd mv docs ... Update the documentation to match the current behavior, and make the usage output and website docs match.	9 years ago
James Bardin	07b0101fb5	update workspace new test for inmem backend ... The existing test assumed local state files.	9 years ago
James Bardin	16e8e405c7	create failing test cases for remote lineage issue ... Some remote backend would fail on `-state push -force`, or `workspace new -state` because of a new strict lineage check in remote.State.	9 years ago
Martin Atkins	8a7a0a7459	command: terraform init -from-module=... ... This restores the earlier behavior of the first positional argument to terraform init in 0.9, but as a command line option. The positional argument was removed to improve consistency with other commands that take a working directory as their first positional argument. It was originally intended that this functionality would return in a later release along with some other general improvements to Terraform's module handling, but we're introducing here an interim solution that uses the existing module source concept, to allow for easier porting of workflows that previously depended on the automatic copy behavior. In a future release this feature may change again as the module improvements design firms up, but we expect it to be broadly compatible with this temporary state.	9 years ago
James Bardin	51547ad2ba	add tests for state commands through a backend	9 years ago
James Bardin	5b4ae36cb0	don't print help for state loading errors ... These already include detailed messages, and it's not a usage issue, it's a config or file location issue.	9 years ago
James Bardin	33ba6774e0	Make the state commands use the real command.Meta ... In order to use a backend for the state commands, we need an initialized meta. Use a single Meta instance rather than temporary ones to make sure the backends are initialized properly.	9 years ago
James Bardin	45a9edb763	make state mv and rm work with remote states ... The default value for the -state flag was overriding the location of any remote state.	9 years ago
Kyle McCullough	ad896b65c9	command: add -check flag to fmt (#15304)	9 years ago
James Bardin	0bca383b6b	Merge pull request #15528 from alrs/command-swallowed-errors ... Fix swallowed errors in command package.	9 years ago
Lars Lehtonen	119996b815	Return immediately after newly-added error condition	9 years ago
James Bardin	eb02467298	Merge pull request #15588 from hashicorp/jbardin/no-graph-config ... graph should not panic with no config	9 years ago
James Bardin	f10163ecc7	graph should not panic with no config ... The backends replace a nil module tree with an empty one before building the graph, so the graph command needs to do the same.	9 years ago
Martin Atkins	23f9c8785e	command/e2etest: an initial test for the primary workflow ... This e2etest runs an init, plan, apply, destroy sequence against a test configuration using the real template and null providers downloaded from the official repository. This test _does_ trample a bit on the scope of some already-existing tests, but this is mainly just to check our assumptions about how Terraform behaves to ensure that we can reach our main conclusion here: that the main Terraform workflow commands interact correctly with each other in real use and we can complete the full workflow.	9 years ago
Martin Atkins	52df81ee49	command/e2etest: test that we can install provider plugins ... We already have good tests for the business logic around provider installation, but the existing tests all stub out the main repository server. This test completes that coverage by verifying that the installer is able to run against the real repository and install an official release of the template provider.	9 years ago
Martin Atkins	0e0b0d125a	command/e2etest: "terraform version" test ... This basic test is here primarily because it's one of the few that can run without reaching out to external services, and so it means our usual test runs will catch situations where the main executable build is somehow broken. The version command itself is not very interesting to test, but it's convenient in that its behavior is very predictable and self-contained.	9 years ago
Martin Atkins	fee61a44b4	command/e2etest: end-to-end testing harness ... Previously we had no automated testing of whether we can produce a Terraform executable that actually works. Our various functional tests have good coverage of specific Terraform features and whole operations, but we lacked end-to-end testing of actual usage of the generated binary, without any stubbing. This package is intended as a vehicle for such end-to-end testing. When run normally under "go test" it will produce a build of the main Terraform binary and make it available for tests to execute. The harness exposes a flag for whether tests are allowed to reach out to external network services, controlled with our standard TF_ACC environment variable, so that basic local tests can be safely run as part of "make test" while more elaborate tests can be run easily when desired. It also provides a separate mode of operation where the included script make-archive.sh can be used to produce a self-contained test archive that can be copied to another system to run the tests there. This is intended to allow testing of cross-compiled binaries, by shipping them over to the target OS and architecture to run without requiring a full Go compiler installation on the target system. The goal here is not to test again functionality that's already well-covered by our existing tests, but rather to test chains of normal operations against the build binary that are not otherwise tested together.	9 years ago
Lars Lehtonen	8501d83e6c	Fix swallowed errors in command package.	9 years ago
James Bardin	583cc350a9	fix minor races in workspace tests ... The improved err scanner loop in meta causes these to race. There's no need to write back to the same commands struct, so just use a new instance in each iteration.	9 years ago
James Bardin	f7f1e8e406	Sort arguments in Meta.process ... Meta.process was relying on the system readdir to order the arguments, but readdir doesn't guarantee any ordering. Read the directory contents as a whole and sort them in place before adding the tfvars files.	9 years ago
James Bardin	0fdcf2c01e	properly cleanup and print correct error messages ... Some Meta tests were not cleaning up their temp directories. The process test wasn't printing the correct arguments in the error messages.	9 years ago
Robert Liebowitz	4bf2269784	Add test case for autoloading tfvars	9 years ago
Robert Liebowitz	e67ecb5ce2	Restructure Meta.process to logically group code	9 years ago
Robert Liebowitz	8d98fdecac	Autoload only .auto.tfvars files	9 years ago
Robert Liebowitz	006744bfe0	Use all tfvars files in working directory ... As a side effect, several commands that previously did not have a failure state can now fail during meta-parameter processing.	9 years ago
Martin Atkins	39c4d6ab1f	Merge #15424: Improve robustness of state persistence handling ... Previously the APIs for state persistence and management had some problematic cases where we depended on hidden mutations of the state structure as side-effects of otherwise-innocent-looking operations, which was a frequent cause of accidental regressions due to faulty assumptions. This new model attempts to isolate certain state mutations to just within the state managers, and makes the state managers work on separated snapshots of the state rather than on the "live" object to reduce the risk of race conditions.	9 years ago
Martin Atkins	fee1197cf9	command: terraform state rm to require at least one argument ... Due to how the state filter machinery works, passing no arguments is valid and matches _all_ resources. It is very unlikely that someone wants to remove everything from state, so this ends up being a very dangerous default for the "terraform state rm" command, and surprising for someone who perhaps runs it looking for the usage information. So we'll be pragmatic here and reject the no-arguments case for this command, accepting that it makes the unlikely case of intentionally deleting all resources harder in order to make it less likely that it will happen _unintentionally_. If someone does really want to remove all resources from the state, they can provide an explicit empty string argument, but this isn't documented because it's a weird case that doesn't seem worth mentioning. This fixes #15283.	9 years ago
James Bardin	fb397060eb	add some Serial checks to apply and refresh tests	9 years ago
James Bardin	054716c397	use testStateRead helper in apply tests ... We have a helper function that we hardly ever use. TODO: convert the rest of the manual ReadState calls eventually.	9 years ago
James Bardin	501cbeaffe	testState shouldn't rely on mods from WriteState ... The state returned from the testState helper shouldn't rely on any mutations caused by WriteState. The Init function (which is analogous to NewState) shoudl set any required fields.	9 years ago
Mike Helmick	9d7fce2f69	command: "terraform workspace show" to print current workspace name ... This command serves as an alternative to the human-oriented list of workspaces for scripting use-cases where it's useful to know the _current_ workspace name.	9 years ago
Martin Atkins	4d53eaa6df	state: more robust handling of state Serial ... Previously we relied on a constellation of coincidences for everything to work out correctly with state serials. In particular, callers needed to be very careful about mutating states (or not) because many different bits of code shared pointers to the same objects. Here we move to a model where all of the state managers always use distinct instances of state, copied when WriteState is called. This means that they are truly a snapshot of the state as it was at that call, even if the caller goes on mutating the state that was passed. We also adjust the handling of serials so that the state managers ignore any serials in incoming states and instead just treat each Persist as the next version after what was most recently Refreshed. (An exception exists for when nothing has been refreshed, e.g. because we are writing a state to a location for the first time. In that case we _do_ trust the caller, since the given state is either a new state or it's a copy of something we're migrating from elsewhere with its state and lineage intact.) The intent here is to allow the rest of Terraform to not worry about serials and state identity, and instead just treat the state as a mutable structure. We'll just snapshot it occasionally, when WriteState is called, and deal with serials _only_ at persist time. This is intended as a more robust version of #15423, which was a quick hotfix to an issue that resulted from our previous slopping handling of state serials but arguably makes the problem worse by depending on an additional coincidental behavior of the local backend's apply implementation.	9 years ago
Radek Simko	14614a5423	command/validate: Add flag to check that all variables are specified (#13872) ... * command/validate: Add flag to check that all variables are specified * Rename config-only to check-variables	9 years ago
Jake Champlin	9944ea6886	core: Skip provider checksum validation based on env var ... Skips checksum validation if the `TF_SKIP_PROVIDER_VERIFY` environment variable is set. Undocumented variable, as the primary goal is to significantly improve the local provider development workflow.	9 years ago
James Bardin	da1c45b566	Merge pull request #15412 from hashicorp/jbardin/windows-delete-workspace ... Unlock state before workspace deletion	9 years ago
James Bardin	1c78dfb286	Unlock state before workspace deletion ... We need to release the lock just before deleting the state, in case the backend can't remove the resource while holding the lock. This is currently true for Windows local files. TODO: While there is little safety in locking while deleting the state, it might be nice to be able to coordinate processes around state deletion, i.e. in a CI environment. Adding Delete() as a required method of States would allow the removal of the resource to be delegated from the Backend to the State itself.	9 years ago
David Glasser	14af879fe0	command: also print plan for destroy	9 years ago
David Glasser	039d36bf91	command: add "apply -auto-approve=false" flag ... A common reason to want to use `terraform plan` is to have a chance to review and confirm a plan before running it. If in fact that is the only reason you are running plan, this new `terraform apply -auto-approve=false` flag provides an easier alternative to P=$(mktemp -t plan) terraform refresh terraform plan -refresh=false -out=$P terraform apply $P rm $P The flag defaults to true for now, but in a future version of Terraform it will default to false.	9 years ago
James Bardin	22074f1029	Merge pull request #15408 from hashicorp/jbardin/import-plugin-dir ... Make sure import uses complete plugin path	9 years ago
Patrick Aikens	7775ef809b	Display correct to and from backends in copy message when migrating to new remote state (#15318)	9 years ago
James Bardin	85b9069eb7	test import with -plugin-dir ... The import command wasn't loading the full plugin path for discovery. Run a basic plugin init sequence, and verify we can find a plugin (even though the plugin is invalid and will fail).	9 years ago
James Bardin	0cbd51c365	find -plugin-dir during import ... The import command wasn't loading the plugin path at all, relying on the local directory for binaries. Load the plugin dir into Meta, and pass in ForceLocal for consistency. The Backend returned was going to be a Local anyway, so the added check wasn't ensuring anything.	9 years ago
Martin Atkins	3df164502a	command: don't prompt for state migration if TF_INPUT is set ... The "confirm" method was directly checking the meta struct's input field, but that only represents the -input command line flag, and doesn't respect the TF_INPUT environment variable. By calling the Input method instead, we check both. This fixes #15338.	9 years ago
James Bardin	833cc9a6c5	Fix state mv/rm -backup documentation ... There is only one backup made, contrary to the help text. We may want to implement that, but the documentation should match the current behavior.	9 years ago
James Bardin	6e7baaaeff	don't load the backend when -state is provided ... When using a `state` command, if the `-state` flag is provided we do not want to modify the Backend state. In this case we should always create a local state instance. The backup flag was also being ignored, and some tests were relying on that, which have been fixed.	9 years ago
James Bardin	5f939b42fe	test that `state mv -state` doesn't use Backend ... If we provide a -state flag to a state command, we do not want terraform to modify the backend state. This test fails since the state specified in the backend doesn't exist	9 years ago
James Bardin	4893fcc24f	improve plugin error formatting ... Remove "checksum" from the error, and only indicate that the plugin has changed. Always show requested versions even if it's "any", and found versions of plugins.	9 years ago
James Bardin	103ab20b00	add required and found versions to error output ... Provide the user with feedback showing the version requirements and the versions found when there's is a plugin error	9 years ago
James Bardin	7a955f990c	make display plugin checksum error to user ... The error follows a generic message, so can be ignored by users who may not understand the implications.	9 years ago
Martin Atkins	0dc6d97a37	command/format: minor adjustments to plan rendering ... This change makes various minor adjustments to the rendering of plans in the output of "terraform plan": - Resources are identified using the standard resource address syntax, rather than exposing the legacy internal representation used in the module diff resource keys. This fixes #8713. - Subjectively, having square brackets in the addresses made it look more visually "off" when the same name but with different indices were shown together with differing-length "symbols", so the symbols are now all padded and right-aligned to three characters for consistent layout across all operations. - The -/+ action is now more visually distinct, using several different colors to help communicate what it will do and including a more obvious "(new resource required)" marker to help draw attention to this not being just an update diff. This fixes #15350. - The resources are now sorted in a manner that sorts index [10] after index [9], rather than after index [1] as we did before. This makes it easier to scan the list and avoids the common confusion where it seems that there are only 10 items when in fact there are 11-20 items with all the tens hiding further up in the list.	9 years ago
Martin Atkins	40e2fbb8e9	command: init to allow plugin init without backend init ... Previously init would crash if given these options: -backend=false -get-plugins=true This is because the state is used as a source of provider dependency information, and we need to instantiate the backend to get the state. To avoid the crash, we now use the following adjusted behavior: - if -backend=true, we behave as before - if -backend=false, we instead try to instantiate the backend the same way any other command would, without modifying its configuration - if we're able to instantiate the backend, we use it to fetch state for dependency resolution purposes - if the backend is not instantiable then we assume it's not yet configured and proceed with a nil state, which may cause us to see an incomplete picture of the dependencies but still allows the install to succeed. Subsequently running "terraform plan" will not work until the backend is (re-)initialized, so the incomplete picture of required plugins is safe.	9 years ago
Martin Atkins	3dc7d618f7	command: avoid empty string constraints in plugin install errors ... This takes care of a few dangling cases where we were still stringifying empty version constraints, which creates confusing error messages due to it stringing as the empty string. For the "no suitable versions available" message, we fall back on the "provider not found" message if no versions were found even though it's unconstrained. This should only happen in an edge case where the provider's index page exists on the releases server but no versions are yet present. For the message about plugin protocol versions, this again is an edge case since with no constraints this should happen only if we release an incompatible Terraform version but don't release a new version of the plugin that's compatible. In this case we just show the constraint as "(any version)" to make sure we always show _something_.	9 years ago
James Bardin	c10f5caf05	Merge pull request #15345 from hashicorp/jbardin/plugin-sig ... verify automatically downloaded plugins	9 years ago
Martin Atkins	9c2fe3456b	command: purge unused plugins as a side effect of plugin installation ... Previously we only did this when _upgrading_, but that's unnecessarily specific and confusing since e.g. plugins can get upgraded implicitly by constraint changes, which would not then trigger the purge process. Instead, we'll assume that the user is able to easily re-download plugins that were purged here, or if they need more specific guarantees they will manage manually a plugin directory and disable the auto-install behavior using `-plugin-dir`.	9 years ago
Martin Atkins	d48dcbb4a5	command: more-helpful error messages from plugin installation ... Now we are able to recognize and handle a few special error situations from plugin installation with more verbose error messages that give the user better feedback on how to proceed.	9 years ago
James Bardin	0a47228065	add -verify-plugins flag to init ... This provides the user with the option to disable plugin signature verification.	9 years ago
James Bardin	6728c48d8c	fix whitespace around backend init success message ... make it better match the surrounding messages.	9 years ago
James Bardin	da385c4268	Don't show plugin init message if there are none ... Skip the message and plugin initialization if there are none in the config.	9 years ago
James Bardin	2e57d284cb	Merge pull request #15323 from hashicorp/jbardin/constraint-suggestion ... remove "~> 0.0" constraint suggestions	9 years ago
James Bardin	ec99b6910b	remove "~> 0.0" constraint suggestions ... Don't suggest constraints when the available plugin isn't versioned. Add zero version const for comparisons.	9 years ago
James Bardin	270eedd4b8	always pass in the full plugin path to dicovery ... Discovery no longer tries to walk into OS_ARCH dirs, so always pass in the full search path.	9 years ago
James Bardin	be2069ac81	add -plugin-dir option ... The -plugin-dir option lets the user specify custom search paths for plugins. This overrides all other plugin search paths, and prevents the auto-installation of plugins. We also make sure that the availability of plugins is always checked during init, even if -get-plugins=false or -plugin-dir is set.	9 years ago
James Bardin	000e860706	Add plugin dir scaffolding ... add pluginDir to command.Meta, the flag to initialize it, and the methods to save and restore it.	9 years ago