27136 Commits (c60dd7c783aea2f9c17d2959dda2f6af12e64872)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Atkins	c60dd7c783	command: Improve consistency of the command short descriptions ... The short description of our commands (as shown in the main help output from "terraform") was previously very inconsistent, using different tense/mood for different commands. Some of the commands were also using some terminology choices inconsistent with how we currently talk about the related ideas in our documentation. Here I've tried to add some consistency by first rewriting them all in the imperative mood (except the ones that just are just subcommand groupings), and tweaking some of the terminology to hopefully gel better with how we present similar ideas in our recently-updated docs. While working on this I inevitably spotted some similar inconsistencies in the longer-form help output of some of the commands. I've not reviewed all of these for consistency, but I did update some where the wording was either left inconsstent with the short form changes I'd made or where the prose stood out to me as particularly inconsistent with our current usual documentation language style. All of this is subjective, so I expect we'll continue to tweak these over time as we continue to develop our documentation writing style based on user questions and feedback.	6 years ago
Martin Atkins	545ceb03fb	main: Emphasize only the primary workflow commands in our help ... A long time ago we introduced this separation between "common commands" and "all other commands", but over the intervening years we've not really done a good job of classifying new commands we've added and so by default most of them ended up being classified as "common". In the interests of making this output more useful for those getting started, this switches the two categories so that "Main commands" is now the curated list, and "all other commands" is the bucket for everything else. The intent here is that the "main commands" are the ones users are likely to try as part of their initial learning of Terraform, while the other commands are for less common situations where the user is more likely to learn about a specific command in some other context, like a tutorial about a special situation. The "main commands" are also now ordered by the sequence users will typically run them in, rather than alphabetical order. That's a subjective readability tradeoff, but I think as long as the list stays relatively short (which it should) it's still relatively easy to scan and find a particular command in the shortlist.	6 years ago
Martin Atkins	ac729c4696	main: Hide several commands from our help ... These are commands that either no longer do anything aside from emitting an error message or are just backward-compatibility aliases for other commands. This generalizes our previous situation where we were specifically hiding "internal-plugin", and does so in a way that fixes the long-standing cosmetic bug that the column width in the help output was chosen based on the hidden command "internal-plugin", which is unfortunately also the longest command in our command set.	6 years ago
Martin Atkins	90906f3842	command: Remove the useless "debug" subcommand ... This is just a husk of a container command that has no nested commands under it, so it isn't serving any purpose.	6 years ago
Martin Atkins	024670968f	getproviders: Consistent ordering of terms in VersionConstraintsString ... An earlier commit made this remove duplicates, which set the precedent that this function is trying to canonically represent the _meaning_ of the version constraints rather than exactly how they were expressed in the configuration. Continuing in that vein, now we'll also apply a consistent (though perhaps often rather arbitrary) ordering to the terms, so that it doesn't change due to irrelevant details like declarations being written in a different order in the configuration. The ordering here is intended to be reasonably intuitive for simple cases, but constraint strings with many different constraints are hard to interpret no matter how we order them so the main goal is consistency, so those watching how the constraints change over time (e.g. in logs of Terraform output, or in the dependency log file) will see fewer noisy changes that don't actually mean anything.	6 years ago
Pam Selle	077a893712	Update CHANGELOG.md	6 years ago
Pam Selle	cb052f1005	Merge pull request #26711 from hashicorp/provider-sens-exp-0.14 ... [0.14 port] Add provider sensitivity propagation experiment	6 years ago
Pam Selle	2657fdb390	Add provider sensitivity propagation experiment ... Rolls back marking attributes providers mark as sensitive to an `experiment` and adds associated docs and adjustments to the upgrade guide.	6 years ago
Alisdair McDiarmid	9c17a74a04	Update CHANGELOG.md	6 years ago
Alisdair McDiarmid	f6b0779511	Merge pull request #26705 from hashicorp/alisdair/suppress-duplicate-version-constraints-014 ... internal: Suppress duplicate version constraints	6 years ago
Alisdair McDiarmid	11341dd98e	internal: Suppress duplicate version constraints ... A set of version constraints can contain duplicates. This can happen if multiple identical constraints are specified throughout a configuration. When rendering the set, it is confusing to display redundant constraints. This commit changes the string renderer to only show the first instance of a given constraint, and adds unit tests for this function to cover this change. This also fixes a bug with the locks file generation: previously, a configuration with redundant constraints would result in this error on second init: Error: Invalid provider version constraints on .terraform.lock.hcl line 6: (source code not available) The recorded version constraints for provider registry.terraform.io/hashicorp/random must be written in normalized form: "3.0.0".	6 years ago
Martin Atkins	3478c41234	Update CHANGELOG.md	6 years ago
Arthur Burkart	3487bd5b7b	lang/funcs: "anytrue" function ... This is an analog to the "alltrue" function, using OR as the reduce operator rather than AND. This also includes some simplification of the "alltrue" implementation to implement it similarly as a sort of reduce operation with AND as the reduce operator, but with the same effective behavior.	6 years ago
Petros Kolyvas	9fe4bae145	Merge branch 'v0.14' of github:hashicorp/terraform into v0.14	6 years ago
Petros Kolyvas	11046cc60d	website: Fix for documentation around local-name conflicts (#26689) ... * Fixes #26684 * Update provider-requirements.html.md Removing additional/extra newlines * Update provider-requirements.html.md And now some trailing spaces. le sigh	6 years ago
James Bardin	0898b6f058	Merge pull request #26688 from hashicorp/jbardin/backport-26687 ... 0.14 backport of #26687	6 years ago
James Bardin	b7ff718f7d	do not return warnings as errors from eval ... Warnings alone cannot be returned from eval nodes, since are still treated as errors.	6 years ago
James Bardin	3f9cafd6e0	Merge pull request #26675 from hashicorp/jbardin/backport-26674 ... 0.14 backport of 26674	6 years ago
Petros Kolyvas	0e615834ee	Tool-specific provisioner docs change to red notice box (#26681)	6 years ago
Petros Kolyvas	d7ce84a0c7	Gandi provider URL update	6 years ago
Jakson Rodrigues	793fec2318	Fixed config argument on example (#26304)	6 years ago
Justin Long	b18d0ba989	Clear wording that bucket must pre-exist (#26276) ... Experienced similar issue as https://github.com/hashicorp/terraform/issues/18417 this updates the documentation so that it's more clear a storage bucket must exist prior to configuring the backend.	6 years ago
Thanonchai	26f03392d4	Update config.html.md (#26622) ... * Update config.html.md When reading this page, I couldn't find the list of the "supported backends to the left". They're actually on a different page, so thought I'd update it so that others wouldn't find it confusing like me. If this is ok with you, would it be possible to label this PR with 'hacktoberfest-accepted'? I'm still new to this. If not, I'd be alright. Thank you! * Update config.html.md Swapped the full URL in the link for a relative path Co-authored-by: Petros Kolyvas <petros@hashicorp.com>	6 years ago
Pam Selle	c8dd5c53aa	Update CHANGELOG.md	6 years ago
James Bardin	c4bf897b8a	don't read data sources that are to be removed ... We can directly remove orphaned data sources from the refesh state.	6 years ago
Pam Selle	0268d513c3	Update CHANGELOG.md	6 years ago
James Bardin	2a768b0433	update tests ... Some tests could not handle reading orphaned resources. It also turns out the ReadResource mock never returned the correct state in the default case at all.	6 years ago
James Bardin	c667f499b2	Read orphaned resources during plan ... This forces orphaned resources to be re-read during planning, removing them from the state if they no longer exist. This needs to be done for a bare `refresh` execution, since Terraform should remove instances that don't exist and are not in the configuration from the state. They should also be removed from state so there is no Delete change planned, as not all providers will gracefully handle a delete operation on a resource that does not exist.	6 years ago
Alisdair McDiarmid	71538b3314	Update CHANGELOG.md	6 years ago
Alisdair McDiarmid	92aec6af06	Merge pull request #26661 from hashicorp/alisdair/fix-locksfile-unconstrained-versions-v014 ... internal: Fix lockfile constraint output for 1.2.*	6 years ago
Martin Atkins	32d79289eb	Update CHANGELOG.md	6 years ago
Martin Atkins	139b24942e	Update CHANGELOG.md	6 years ago
Martin Atkins	339347d2a0	Update CHANGELOG.md	6 years ago
Martin Atkins	b39e830f8f	lang/funcs: textencodebase64 and textdecodebase64	6 years ago
Martin Atkins	ba21e33372	lang/funcs: Rename the base64 character encoding functions ... These were initially introduced as functions with "encode" and "decode" prefixes, but that doesn't match with our existing convention of putting the encoding format first so that the encode and decode functions will group together in a alphabetically-ordered function list. "text" is not really a defined serialization format, but it's a short word that hopefully represents well enough what these functions are aiming to encode and decode, while being consistent with existing functions like jsonencode/jsondecode, yamlencode/yamldecode, etc. The "base64" at the end here is less convincing because there is precedent for that modifier to appear both at the beginning and the end in our existing function names. I chose to put it at the end here because that seems to be our emergent convention for situations where the base64 encoding is a sort of secondary modifier alongside the primary purpose of the function, as we see with "filebase64". (base64gzip is an exception here, but it seems outvoted by the others.)	6 years ago
r0bnet	76ffe8aa7d	lang/funcs: Functions for encoding text in specific character encodings	6 years ago
Alisdair McDiarmid	6d2f7f3f82	Merge pull request #26650 from hashicorp/alisdair/ignore-changes-sensitive-014 ... terraform: Fix sensitive values in ignore changes	6 years ago
Alisdair McDiarmid	eb5c3a9a28	internal: Fix lockfile constraint output for 1.2.* ... If a configuration requires a partial provider version (with some parts unspecified), Terraform considers this as a constrained-to-zero version. For example, a version constraint of 1.2 will result in an attempt to install version 1.2.0, even if 1.2.1 is available. When writing the dependency locks file, we previously would write 1.2.*, as this is the in-memory representation of 1.2. This would then cause an error on re-reading the locks file, as this is not a valid constraint format. Instead, we now explicitly convert the constraint to its zero-filled representation before writing the locks file. This ensures that it correctly round-trips. Because this change is made in getproviders.VersionConstraintsString, it also affects the output of the providers sub-command.	6 years ago
Martin Atkins	660ede3231	replacefile: don't create the temporary file in TMPDIR ... ioutil.TempFile has a special case where an empty string for its dir argument is interpreted as a request to automatically look up the system temporary directory, which is commonly /tmp . We don't want that behavior here because we're specifically trying to create the temporary file in the same directory as the file we're hoping to replace. If the file gets created in /tmp then it might be on a different device and thus the later atomic rename won't work. Instead, we'll add our own special case to explicitly use "." when the given filename is in the current working directory. That overrides the special automatic behavior of ioutil.TempFile and thus forces the behavior we need. This hadn't previously mattered for earlier callers of this code because they were creating files in subdirectories, but this codepath was failing for the dependency lock file due to it always being created directly in the current working directory. Unfortunately since this is a picky implementation detail I couldn't find a good way to write a unit test for it without considerable refactoring. Instead, I verified manually that the temporary filename wasn't in /tmp on my Linux system, and hope that the comment inline will explain this situation well enough to avoid an accidental regression in future maintenence.	6 years ago
Alisdair McDiarmid	f07b4dd175	Update CHANGELOG.md	6 years ago
Alisdair McDiarmid	d28568e565	terraform: Fix sensitive values in ignore changes ... Because ignore_changes configuration can refer to resource arguments which are assigned sensitive values, we need to unmark the resource object before processing.	6 years ago
Pam Selle	8bf70c2cf6	Merge pull request #26649 from hashicorp/pselle/0.14-codecov ... [build][0.14] only run codecov on main branch	6 years ago
Pam Selle	c4911b9230	Only run codecov on master	6 years ago
Pam Selle	25f14c681e	Merge pull request #26646 from hashicorp/pselle/docs-0.14 ... [0.14 cherry pick] 0.14 guide updates	6 years ago
Pam Selle	a5b70e972a	Add note to upgrade guide about provider sensitivity (#26643) ... * Add note to upgrade guide about provider sensitivity Now that sensitivity follows attributes providers mark as sensitive, add this note to the upgrade guide. Co-authored-by: Alisdair McDiarmid <alisdair@users.noreply.github.com>	6 years ago
James Bardin	fff53cae9a	update CHANGELOG.md	6 years ago
James Bardin	527f3e654c	Merge pull request #26641 from hashicorp/jbardin/backport-26638 ... 0.14 backport 26638	6 years ago
James Bardin	060f8acc08	compare empty strings as null in sets ... The Legacy SDK cannot handle missing strings from objects in sets, and will insert an empty string when planning the missing value. This subverts the `couldHaveUnknownBlockPlaceholder` check, and causes errors when `dynamic` is used with NestingSet blocks. We don't have a separate codepath to handle the internals of AssertObjectCompatible differently for the legacy SDK, but we can treat empty strings as null strings within set objects to avoid the failed assertions.	6 years ago
Pam Selle	9ef9d3e952	Merge pull request #26635 from hashicorp/pselle/sensitivity-providers ... [0.14 port] Mark attributes providers mark as sensitive	6 years ago
Alisdair McDiarmid	a18415686b	Merge pull request #26630 from hashicorp/alisdair/sensitive-values-provisioners-014 ... Fixes for sensitive values used as input to provisioners	6 years ago