948 Commits (be543414ec00c743375fa78dabc087b8dc38eb82)

Author	SHA1	Message	Date
Martin Atkins	c12d64f340	Use t.Helper() in our test helpers ... Go 1.9 adds this new function which, when called, marks the caller as being a "helper function". Helper function stack frames are then skipped when trying to find a line of test code to blame for a test failure, so that the code in the main test function appears in the test failure output rather than a line within the helper function itself. This covers many -- but probaly not all -- of our test helpers across various packages.	9 years ago
Radek Simko	4e8ccb3127	Merge pull request #15828 from hashicorp/e2e-decoupling ... tools/terraform-bundle: Add e2e tests	9 years ago
Radek Simko	aabab16069	command/init: Remove extra whitespace	9 years ago
Michael Handler	817d1c4869	Output duration in UiHook after successful operation completion.	9 years ago
James Bardin	18af7750d4	Merge pull request #14720 from sevagh/master ... Add salt-masterless provisioner	9 years ago
Radek Simko	9e7e4ff4fb	e2e: Decouple logic for running e2e tests	9 years ago
Radek Simko	28b33c9299	plugin: Display version + source when initializing plugins	9 years ago
Radek Simko	38cb98fb0c	Comply w/ latest changes in mitchellh/cli	9 years ago
James Bardin	ea3e87b584	Merge pull request #15768 from hashicorp/jbardin/remote-import ... Don't ForceLocal for the import backend	9 years ago
James Bardin	5bcc1bae59	Merge pull request #15769 from hashicorp/jbardin/discovery-paths ... load legacy plugin paths	9 years ago
James Bardin	2bb5007690	Merge pull request #15683 from hashicorp/jbardin/remote-state-lineage ... Remove strict lineage check in remote.State	9 years ago
James Bardin	37932c3cd6	make state_rm flag description match state_mv	9 years ago
James Bardin	4034f988df	update import command docs ... Fix the -state and -state-out wording to be consistent with other commands. Remove the erroneous reference to remote state in the website version of the flag description.	9 years ago
James Bardin	54998933f5	load Meta.PluginOverrides in dicovery ... Make sure the override paths from the legacy rc file are loaded for discovery.	9 years ago
James Bardin	fa20d43d80	test loading of Meta.PluginOverrides ... These are currently being skipped in discovery	9 years ago
James Bardin	e3748901b4	Don't ForceLocal for the import backend ... While the `local.Local` backend is the only implementation of `backend.Local`, creating the backend with `ForceLocal` bypasses the `backend.Backend` in the `local.Local` causing a local state to be implicitly created rather than using the configured state backend. Add a test that imports into a configured backend (using the "local" backend as a remote state proxy). This further confirms the confusing nature of ForceLocal, as the backend _is_ local, but not from the viewpoint of meta.Backend.	9 years ago
Sevag Hanssian	867760ed56	Add salt-masterless provisioner	9 years ago
James Bardin	eadda50f02	Merge pull request #15652 from hashicorp/jbardin/state-command ... state commands with remote state backends	9 years ago
James Bardin	55d18dcef2	update state rm amd mv docs ... Update the documentation to match the current behavior, and make the usage output and website docs match.	9 years ago
James Bardin	07b0101fb5	update workspace new test for inmem backend ... The existing test assumed local state files.	9 years ago
James Bardin	16e8e405c7	create failing test cases for remote lineage issue ... Some remote backend would fail on `-state push -force`, or `workspace new -state` because of a new strict lineage check in remote.State.	9 years ago
Martin Atkins	8a7a0a7459	command: terraform init -from-module=... ... This restores the earlier behavior of the first positional argument to terraform init in 0.9, but as a command line option. The positional argument was removed to improve consistency with other commands that take a working directory as their first positional argument. It was originally intended that this functionality would return in a later release along with some other general improvements to Terraform's module handling, but we're introducing here an interim solution that uses the existing module source concept, to allow for easier porting of workflows that previously depended on the automatic copy behavior. In a future release this feature may change again as the module improvements design firms up, but we expect it to be broadly compatible with this temporary state.	9 years ago
James Bardin	51547ad2ba	add tests for state commands through a backend	9 years ago
James Bardin	5b4ae36cb0	don't print help for state loading errors ... These already include detailed messages, and it's not a usage issue, it's a config or file location issue.	9 years ago
James Bardin	33ba6774e0	Make the state commands use the real command.Meta ... In order to use a backend for the state commands, we need an initialized meta. Use a single Meta instance rather than temporary ones to make sure the backends are initialized properly.	9 years ago
James Bardin	45a9edb763	make state mv and rm work with remote states ... The default value for the -state flag was overriding the location of any remote state.	9 years ago
Kyle McCullough	ad896b65c9	command: add -check flag to fmt (#15304)	9 years ago
James Bardin	0bca383b6b	Merge pull request #15528 from alrs/command-swallowed-errors ... Fix swallowed errors in command package.	9 years ago
Lars Lehtonen	119996b815	Return immediately after newly-added error condition	9 years ago
James Bardin	eb02467298	Merge pull request #15588 from hashicorp/jbardin/no-graph-config ... graph should not panic with no config	9 years ago
James Bardin	f10163ecc7	graph should not panic with no config ... The backends replace a nil module tree with an empty one before building the graph, so the graph command needs to do the same.	9 years ago
Martin Atkins	23f9c8785e	command/e2etest: an initial test for the primary workflow ... This e2etest runs an init, plan, apply, destroy sequence against a test configuration using the real template and null providers downloaded from the official repository. This test _does_ trample a bit on the scope of some already-existing tests, but this is mainly just to check our assumptions about how Terraform behaves to ensure that we can reach our main conclusion here: that the main Terraform workflow commands interact correctly with each other in real use and we can complete the full workflow.	9 years ago
Martin Atkins	52df81ee49	command/e2etest: test that we can install provider plugins ... We already have good tests for the business logic around provider installation, but the existing tests all stub out the main repository server. This test completes that coverage by verifying that the installer is able to run against the real repository and install an official release of the template provider.	9 years ago
Martin Atkins	0e0b0d125a	command/e2etest: "terraform version" test ... This basic test is here primarily because it's one of the few that can run without reaching out to external services, and so it means our usual test runs will catch situations where the main executable build is somehow broken. The version command itself is not very interesting to test, but it's convenient in that its behavior is very predictable and self-contained.	9 years ago
Martin Atkins	fee61a44b4	command/e2etest: end-to-end testing harness ... Previously we had no automated testing of whether we can produce a Terraform executable that actually works. Our various functional tests have good coverage of specific Terraform features and whole operations, but we lacked end-to-end testing of actual usage of the generated binary, without any stubbing. This package is intended as a vehicle for such end-to-end testing. When run normally under "go test" it will produce a build of the main Terraform binary and make it available for tests to execute. The harness exposes a flag for whether tests are allowed to reach out to external network services, controlled with our standard TF_ACC environment variable, so that basic local tests can be safely run as part of "make test" while more elaborate tests can be run easily when desired. It also provides a separate mode of operation where the included script make-archive.sh can be used to produce a self-contained test archive that can be copied to another system to run the tests there. This is intended to allow testing of cross-compiled binaries, by shipping them over to the target OS and architecture to run without requiring a full Go compiler installation on the target system. The goal here is not to test again functionality that's already well-covered by our existing tests, but rather to test chains of normal operations against the build binary that are not otherwise tested together.	9 years ago
Lars Lehtonen	8501d83e6c	Fix swallowed errors in command package.	9 years ago
James Bardin	583cc350a9	fix minor races in workspace tests ... The improved err scanner loop in meta causes these to race. There's no need to write back to the same commands struct, so just use a new instance in each iteration.	9 years ago
James Bardin	f7f1e8e406	Sort arguments in Meta.process ... Meta.process was relying on the system readdir to order the arguments, but readdir doesn't guarantee any ordering. Read the directory contents as a whole and sort them in place before adding the tfvars files.	9 years ago
James Bardin	0fdcf2c01e	properly cleanup and print correct error messages ... Some Meta tests were not cleaning up their temp directories. The process test wasn't printing the correct arguments in the error messages.	9 years ago
Robert Liebowitz	4bf2269784	Add test case for autoloading tfvars	9 years ago
Robert Liebowitz	e67ecb5ce2	Restructure Meta.process to logically group code	9 years ago
Robert Liebowitz	8d98fdecac	Autoload only .auto.tfvars files	9 years ago
Robert Liebowitz	006744bfe0	Use all tfvars files in working directory ... As a side effect, several commands that previously did not have a failure state can now fail during meta-parameter processing.	9 years ago
Martin Atkins	39c4d6ab1f	Merge #15424: Improve robustness of state persistence handling ... Previously the APIs for state persistence and management had some problematic cases where we depended on hidden mutations of the state structure as side-effects of otherwise-innocent-looking operations, which was a frequent cause of accidental regressions due to faulty assumptions. This new model attempts to isolate certain state mutations to just within the state managers, and makes the state managers work on separated snapshots of the state rather than on the "live" object to reduce the risk of race conditions.	9 years ago
Martin Atkins	fee1197cf9	command: terraform state rm to require at least one argument ... Due to how the state filter machinery works, passing no arguments is valid and matches _all_ resources. It is very unlikely that someone wants to remove everything from state, so this ends up being a very dangerous default for the "terraform state rm" command, and surprising for someone who perhaps runs it looking for the usage information. So we'll be pragmatic here and reject the no-arguments case for this command, accepting that it makes the unlikely case of intentionally deleting all resources harder in order to make it less likely that it will happen _unintentionally_. If someone does really want to remove all resources from the state, they can provide an explicit empty string argument, but this isn't documented because it's a weird case that doesn't seem worth mentioning. This fixes #15283.	9 years ago
James Bardin	fb397060eb	add some Serial checks to apply and refresh tests	9 years ago
James Bardin	054716c397	use testStateRead helper in apply tests ... We have a helper function that we hardly ever use. TODO: convert the rest of the manual ReadState calls eventually.	9 years ago
James Bardin	501cbeaffe	testState shouldn't rely on mods from WriteState ... The state returned from the testState helper shouldn't rely on any mutations caused by WriteState. The Init function (which is analogous to NewState) shoudl set any required fields.	9 years ago
Mike Helmick	9d7fce2f69	command: "terraform workspace show" to print current workspace name ... This command serves as an alternative to the human-oriented list of workspaces for scripting use-cases where it's useful to know the _current_ workspace name.	9 years ago
Martin Atkins	4d53eaa6df	state: more robust handling of state Serial ... Previously we relied on a constellation of coincidences for everything to work out correctly with state serials. In particular, callers needed to be very careful about mutating states (or not) because many different bits of code shared pointers to the same objects. Here we move to a model where all of the state managers always use distinct instances of state, copied when WriteState is called. This means that they are truly a snapshot of the state as it was at that call, even if the caller goes on mutating the state that was passed. We also adjust the handling of serials so that the state managers ignore any serials in incoming states and instead just treat each Persist as the next version after what was most recently Refreshed. (An exception exists for when nothing has been refreshed, e.g. because we are writing a state to a location for the first time. In that case we _do_ trust the caller, since the given state is either a new state or it's a copy of something we're migrating from elsewhere with its state and lineage intact.) The intent here is to allow the rest of Terraform to not worry about serials and state identity, and instead just treat the state as a mutable structure. We'll just snapshot it occasionally, when WriteState is called, and deal with serials _only_ at persist time. This is intended as a more robust version of #15423, which was a quick hotfix to an issue that resulted from our previous slopping handling of state serials but arguably makes the problem worse by depending on an additional coincidental behavior of the local backend's apply implementation.	9 years ago
Radek Simko	14614a5423	command/validate: Add flag to check that all variables are specified (#13872) ... * command/validate: Add flag to check that all variables are specified * Rename config-only to check-variables	9 years ago
Jake Champlin	9944ea6886	core: Skip provider checksum validation based on env var ... Skips checksum validation if the `TF_SKIP_PROVIDER_VERIFY` environment variable is set. Undocumented variable, as the primary goal is to significantly improve the local provider development workflow.	9 years ago
James Bardin	da1c45b566	Merge pull request #15412 from hashicorp/jbardin/windows-delete-workspace ... Unlock state before workspace deletion	9 years ago
James Bardin	1c78dfb286	Unlock state before workspace deletion ... We need to release the lock just before deleting the state, in case the backend can't remove the resource while holding the lock. This is currently true for Windows local files. TODO: While there is little safety in locking while deleting the state, it might be nice to be able to coordinate processes around state deletion, i.e. in a CI environment. Adding Delete() as a required method of States would allow the removal of the resource to be delegated from the Backend to the State itself.	9 years ago
David Glasser	14af879fe0	command: also print plan for destroy	9 years ago
David Glasser	039d36bf91	command: add "apply -auto-approve=false" flag ... A common reason to want to use `terraform plan` is to have a chance to review and confirm a plan before running it. If in fact that is the only reason you are running plan, this new `terraform apply -auto-approve=false` flag provides an easier alternative to P=$(mktemp -t plan) terraform refresh terraform plan -refresh=false -out=$P terraform apply $P rm $P The flag defaults to true for now, but in a future version of Terraform it will default to false.	9 years ago
James Bardin	22074f1029	Merge pull request #15408 from hashicorp/jbardin/import-plugin-dir ... Make sure import uses complete plugin path	9 years ago
Patrick Aikens	7775ef809b	Display correct to and from backends in copy message when migrating to new remote state (#15318)	9 years ago
James Bardin	85b9069eb7	test import with -plugin-dir ... The import command wasn't loading the full plugin path for discovery. Run a basic plugin init sequence, and verify we can find a plugin (even though the plugin is invalid and will fail).	9 years ago
James Bardin	0cbd51c365	find -plugin-dir during import ... The import command wasn't loading the plugin path at all, relying on the local directory for binaries. Load the plugin dir into Meta, and pass in ForceLocal for consistency. The Backend returned was going to be a Local anyway, so the added check wasn't ensuring anything.	9 years ago
Martin Atkins	3df164502a	command: don't prompt for state migration if TF_INPUT is set ... The "confirm" method was directly checking the meta struct's input field, but that only represents the -input command line flag, and doesn't respect the TF_INPUT environment variable. By calling the Input method instead, we check both. This fixes #15338.	9 years ago
James Bardin	833cc9a6c5	Fix state mv/rm -backup documentation ... There is only one backup made, contrary to the help text. We may want to implement that, but the documentation should match the current behavior.	9 years ago
James Bardin	6e7baaaeff	don't load the backend when -state is provided ... When using a `state` command, if the `-state` flag is provided we do not want to modify the Backend state. In this case we should always create a local state instance. The backup flag was also being ignored, and some tests were relying on that, which have been fixed.	9 years ago
James Bardin	5f939b42fe	test that `state mv -state` doesn't use Backend ... If we provide a -state flag to a state command, we do not want terraform to modify the backend state. This test fails since the state specified in the backend doesn't exist	9 years ago
James Bardin	4893fcc24f	improve plugin error formatting ... Remove "checksum" from the error, and only indicate that the plugin has changed. Always show requested versions even if it's "any", and found versions of plugins.	9 years ago
James Bardin	103ab20b00	add required and found versions to error output ... Provide the user with feedback showing the version requirements and the versions found when there's is a plugin error	9 years ago
James Bardin	7a955f990c	make display plugin checksum error to user ... The error follows a generic message, so can be ignored by users who may not understand the implications.	9 years ago
Martin Atkins	0dc6d97a37	command/format: minor adjustments to plan rendering ... This change makes various minor adjustments to the rendering of plans in the output of "terraform plan": - Resources are identified using the standard resource address syntax, rather than exposing the legacy internal representation used in the module diff resource keys. This fixes #8713. - Subjectively, having square brackets in the addresses made it look more visually "off" when the same name but with different indices were shown together with differing-length "symbols", so the symbols are now all padded and right-aligned to three characters for consistent layout across all operations. - The -/+ action is now more visually distinct, using several different colors to help communicate what it will do and including a more obvious "(new resource required)" marker to help draw attention to this not being just an update diff. This fixes #15350. - The resources are now sorted in a manner that sorts index [10] after index [9], rather than after index [1] as we did before. This makes it easier to scan the list and avoids the common confusion where it seems that there are only 10 items when in fact there are 11-20 items with all the tens hiding further up in the list.	9 years ago
Martin Atkins	40e2fbb8e9	command: init to allow plugin init without backend init ... Previously init would crash if given these options: -backend=false -get-plugins=true This is because the state is used as a source of provider dependency information, and we need to instantiate the backend to get the state. To avoid the crash, we now use the following adjusted behavior: - if -backend=true, we behave as before - if -backend=false, we instead try to instantiate the backend the same way any other command would, without modifying its configuration - if we're able to instantiate the backend, we use it to fetch state for dependency resolution purposes - if the backend is not instantiable then we assume it's not yet configured and proceed with a nil state, which may cause us to see an incomplete picture of the dependencies but still allows the install to succeed. Subsequently running "terraform plan" will not work until the backend is (re-)initialized, so the incomplete picture of required plugins is safe.	9 years ago
Martin Atkins	3dc7d618f7	command: avoid empty string constraints in plugin install errors ... This takes care of a few dangling cases where we were still stringifying empty version constraints, which creates confusing error messages due to it stringing as the empty string. For the "no suitable versions available" message, we fall back on the "provider not found" message if no versions were found even though it's unconstrained. This should only happen in an edge case where the provider's index page exists on the releases server but no versions are yet present. For the message about plugin protocol versions, this again is an edge case since with no constraints this should happen only if we release an incompatible Terraform version but don't release a new version of the plugin that's compatible. In this case we just show the constraint as "(any version)" to make sure we always show _something_.	9 years ago
James Bardin	c10f5caf05	Merge pull request #15345 from hashicorp/jbardin/plugin-sig ... verify automatically downloaded plugins	9 years ago
Martin Atkins	9c2fe3456b	command: purge unused plugins as a side effect of plugin installation ... Previously we only did this when _upgrading_, but that's unnecessarily specific and confusing since e.g. plugins can get upgraded implicitly by constraint changes, which would not then trigger the purge process. Instead, we'll assume that the user is able to easily re-download plugins that were purged here, or if they need more specific guarantees they will manage manually a plugin directory and disable the auto-install behavior using `-plugin-dir`.	9 years ago
Martin Atkins	d48dcbb4a5	command: more-helpful error messages from plugin installation ... Now we are able to recognize and handle a few special error situations from plugin installation with more verbose error messages that give the user better feedback on how to proceed.	9 years ago
James Bardin	0a47228065	add -verify-plugins flag to init ... This provides the user with the option to disable plugin signature verification.	9 years ago
James Bardin	6728c48d8c	fix whitespace around backend init success message ... make it better match the surrounding messages.	9 years ago
James Bardin	da385c4268	Don't show plugin init message if there are none ... Skip the message and plugin initialization if there are none in the config.	9 years ago
James Bardin	2e57d284cb	Merge pull request #15323 from hashicorp/jbardin/constraint-suggestion ... remove "~> 0.0" constraint suggestions	9 years ago
James Bardin	ec99b6910b	remove "~> 0.0" constraint suggestions ... Don't suggest constraints when the available plugin isn't versioned. Add zero version const for comparisons.	9 years ago
James Bardin	270eedd4b8	always pass in the full plugin path to dicovery ... Discovery no longer tries to walk into OS_ARCH dirs, so always pass in the full search path.	9 years ago
James Bardin	be2069ac81	add -plugin-dir option ... The -plugin-dir option lets the user specify custom search paths for plugins. This overrides all other plugin search paths, and prevents the auto-installation of plugins. We also make sure that the availability of plugins is always checked during init, even if -get-plugins=false or -plugin-dir is set.	9 years ago
James Bardin	000e860706	Add plugin dir scaffolding ... add pluginDir to command.Meta, the flag to initialize it, and the methods to save and restore it.	9 years ago
James Bardin	f723270e3e	search the vendor directory for plugins ... The default location for users to manually add plugins will be ./terraform.d/plugins/	9 years ago
James Bardin	4f5e92e4c0	reverse init test to check for dataDir in PWD ... init should always write intternal data to the current directory, even when a path is provided. The inherited behavior no longer applies to the new use of init.	9 years ago
James Bardin	55bf19e548	always write to dataDir in the current directory ... Now that init can take a directory for configuration, the old behavior of writing the .terraform data directory into the target path no longer makes sense. Don't change the dataDir field during init, and write to the default location. Clean up all references to Meta.dataDir, and only use the getter method in case we chose to dynamically override this at some point.	9 years ago
Martin Atkins	6979a07754	command: init -upgrade for provider plugins ... Now when -upgrade is provided to "terraform init" (and plugin installation isn't disabled) it will: - ignore the contents of the auto-install plugin directory when deciding what is "available", thus causing anything there to be reinstalled, possibly at a newer version. - if installation completes successfully, purge from the auto-install plugin directory any plugin-looking files that aren't in the set of chosen plugins. As before, plugins outside of the auto-install directory are able to take precedence over the auto-install ones, and these will never be upgraded nor purged. The thinking here is that the auto-install directory is an implementation detail directly managed by Terraform, and so it's Terraform's responsibility to automatically keep it clean as plugins are upgraded. We don't yet have the -plugin-dir option implemented, but once it is it should circumvent all of this behavior and just expect providers to be already available in the given directory, meaning that nothing will be auto-installed, -upgraded or -purged.	9 years ago
Martin Atkins	f753974bb3	plugin/discovery: Installer interface, and provider implementation ... Previously we had a "getProvider" function type used to implement plugin fetching. Here we replace that with an interface type, initially with just a "Get" function. For now this just simplifies the interface by allowing the target directory and protocol version to be members of the struct rather than passed as arguments. A later change will extend this interface to also include a method to purge unused plugins, so that upgrading frequently doesn't leave behind a trail of unused executable files.	9 years ago
Gavin Williams	5834333ea3	command: terraform get -upgrade ... As of this commit this just upgrades modules, but this option will also later upgrade plugins and indeed anything else that's being downloaded and installed as part of the init.	9 years ago
James Bardin	be900e8085	Merge pull request #15258 from hashicorp/jbardin/remove-providers ... Remove providers from core	9 years ago
James Bardin	cbbbcea4b9	stop err scanner goroutines between tests	9 years ago
James Bardin	77a32f3df0	remove "core" distinction ... Since there is little left that isn't core, remove the distinction for now to reduce confusion, since a "core" binary will mostly work except for provisioners.	9 years ago
James Bardin	7e7f53954d	remove internal provider test from command pkg	9 years ago
James Bardin	81ac0ed204	re-generate plugin list	9 years ago
Radek Simko	4e85f552e7	Merge pull request #15246 from hashicorp/b-fix-cmd-provider-crash ... command/providers: Avoid crash when no configs found	9 years ago
James Bardin	a30007b41d	Merge pull request #15032 from hashicorp/jbardin/init ... change init args to remove source copy	9 years ago
Radek Simko	f5ff67c530	command/providers: Add regression test	9 years ago
Radek Simko	ee30df3efd	command/providers: Enable processing of meta-parameters ... This will enable proper colouring of the output, like for other commands.	9 years ago
Radek Simko	86fbcfac83	command/providers: Avoid crash when no configs found	9 years ago
Martin Atkins	f7ce6a15f8	backend: Operation.Environment renamed to "Workspace" ... This is part of an effort to switch this terminology across all of Terraform.	9 years ago
Martin Atkins	418a8a8bc9	command + backend: rename various API objects to "Workspace" terminology ... We're shifting terminology from "environment" to "workspace". This takes care of some of the main internal API surface that was using the old terminology, though is not intended to be entirely comprehensive and is mainly just to minimize the amount of confusion for maintainers as we continue moving towards eliminating the old terminology.	9 years ago
Martin Atkins	5f9f13ab8f	command: show warnings from backend config validation ... Previously we just silently ignored warnings from validating the backend config, but now that we have a deprecated argument it's important to print these out so users can respond to the deprecation warning.	9 years ago
Martin Atkins	31d556894f	command: shallow UI-focused rename of "environment" to "workspace" ... Feedback after 0.9 was that the term "environment" was confusing due to it colliding with several other concepts, such as OS environment variables, a non-aligned Terraform Enterprise concept, and differing ideas of "environment" within various organizations. This new term "workspace" is intended to ease some of that confusion. This term is not used anywhere else in Terraform today, and we expect it to not be used in a manner that would be confusing within user organizations. This begins a deprecation cycle for the "terraform env" family of commands, instead moving to an equivalent set of "terraform workspace" commands. There are some remaining references to the old "environment" concept in the code, which will be cleaned up in a separate change. This change is instead focused on text visible in the UI and wording within code comments for the benefit of human maintainers of the code.	9 years ago
David Glasser	c25d848ffb	core: allow overriding environment name via env var ... This allows you to run multiple concurrent terraform operations against different environments from the same source directory. Fixes #14447. Also removes some dead code which appears to do the same thing as the function I modified.	9 years ago
James Bardin	2bfcdbbd08	change init args to remove source copy ... When init was modified in 0.9 to initialize a terraform working directory, the legacy behavior was kept to copy or fetch module sources. This left the init command without the ability that the plan and apply commands have to target a specific directory for the operation. This commit removes the legacy behavior altogether, and allows init to target a directory for initialization, bringing it into parity with plan and apply. If one want to copy a module to the target or current directory, that will have to be done manually before calling init. We can later reintroduce fetching modules with init without breaking this new behavior, by adding the source as an optional second argument. The unit tests testing the copying of sources with init have been removed, as well as some out of date (and commented out) init tests regarding remote states.	9 years ago
James Bardin	d1c50efb01	change providers.json to lock.json ... It might not just be for providers, and it's in the plugins dir, so lock.json seems descriptive enough.	9 years ago
James Bardin	08592c2602	update plugin name in command test	9 years ago
James Bardin	a529b64cc8	better init error output ... Provide log-form message when a provider isn't found, along with the desired constraints.	9 years ago
James Bardin	fdbfc17fae	missing constraints passed erroniously ... ConstrainVersions was documented as returning nil, but it was instead returning an empty set. Use the Count() method to check for nil or empty. Add test to verify failed constraints will show up as missing.	9 years ago
Martin Atkins	766f8e5d64	command init: remove confusing uses of "environment" in the usage ... "environment" is a very overloaded term, so here we prefer to use the term "working directory" to talk about a local directory where operations are executed on a given Terraform configuration.	9 years ago
Martin Atkins	3c429b3628	command init: show log output for each provider plugin downloaded ... Each provider plugin will take at least a few seconds to download, so providing feedback about each one should make users feel less like Terraform has hung. Ideally we'd show ongoing progress during the download, but that's not possible without re-working go-getter, so we'll accept this as an interim solution for now.	9 years ago
Martin Atkins	4571a16b15	command: remove Meta.forceProviderSHA256s ... This was added with the idea of using it to override the SHA256 hashes to match those hypothetically stored in a plan, but we already have a mechanism elsewhere for populating context fields from plan fields, so this is not actually necessary.	9 years ago
Martin Atkins	9aae06db97	command: update mockGetProvider.GetProvider for new interface ... The expected type was changed in the mainline code but the tests were not updated to match.	9 years ago
Martin Atkins	4ba20f9c1c	command init: show suggested constraints for unconstrained providers ... When running "terraform init" with providers that are unconstrained, we will now produce information to help the user update configuration to constrain for the particular providers that were chosen, to prevent inadvertently drifting onto a newer major release that might contain breaking changes. A ~> constraint is used here because pinning to a single specific version is expected to create dependency hell when using child modules. By using this constraint mode, which allows minor version upgrades, we avoid the need for users to constantly adjust version constraints across many modules, but make major version upgrades still be opt-in. Any constraint at all in the configuration will prevent the display of these suggestions, so users are free to use stronger or weaker constraints if desired, ignoring the recommendation.	9 years ago
James Bardin	e0f2235f66	update init command with new GetProvider signature ... GetProvider needs the plugin protocol version to be passed in	9 years ago
Martin Atkins	032f71f1ff	command: produce provider lock file during "terraform init" ... Once we've installed the necessary plugins, we'll do one more walk of the available plugins and record the SHA256 hashes of all of the plugins we select in the provider lock file. The file we write here gets read when we're building ContextOpts to initialize the main terraform context, so any command that works with the context will then fail if any of the provider binaries change.	9 years ago
Martin Atkins	6ba6508ec9	command: pass the locked plugin hashes into ContextOpts ... By reading our lock file and passing this into the context, we ensure that only the plugins referenced in the lock file can be used. As of this commit there is no way to create that lock file, but that will follow soon as part of "terraform init". We also provide a way to force a particular set of SHA256s. The main use for this is to allow us to persist a set of plugins in the plan and check the same plugins are used during apply, but it may also be useful for automated tests.	9 years ago
Martin Atkins	720670fae7	command: helper to manage the provider plugins lock file ... This is just a JSON file with the SHA256 digests of the plugin executables.	9 years ago
Martin Atkins	7d0a98af46	command: provider resolver to also check SHA256 constraints when set ... In addition to looking for matching versions, the caller can also optionally require a specific executable by its SHA256 digest.	9 years ago
Martin Atkins	e3401947a6	plugin/discovery: PluginRequirements can specify SHA256 digests ... As well as constraining plugins by version number, we also want to be able to pin plugins to use specific executables so that we can detect drift in available plugins between commands. This commit allows such requirements to be specified, but doesn't yet specify any such requirements, nor validate them.	9 years ago
Martin Atkins	9a398a7793	command: require resource to be in config before import ... Previously we encouraged users to import a resource and _then_ write the configuration block for it. This ordering creates lots of risk, since for various reasons users can end up subsequently running Terraform without any configuration in place, which then causes Terraform to want to destroy the resource that was imported. Now we invert this and require a minimal configuration block be written first. This helps ensure that the user ends up with a correlated resource config and state, protecting against any inconsistency caused by typos. This addresses #11835.	9 years ago
Martin Atkins	7d8719150c	command: validate import resource address early ... Previously we deferred validation of the resource address on the import command until we were in the core guts, which caused the error responses to be rather unhelpful. By validating these things early we can give better feedback to the user.	9 years ago
Martin Atkins	f6305fcc27	command: remove commented-out, misplaced tests ... For some reason there was a block of commented-out tests for the refresh command in the test file for the import command. Here we remove them to reduce the noise in this file.	9 years ago
James Bardin	044ad5ef59	rename some Constraints methods per code review	9 years ago
James Bardin	2994c6ac5d	add init getPlugin test ... add a mock plugin getter, and test that we can fetch requested version of the plugins.	9 years ago
James Bardin	4c32cd432a	make getProvider pluggable	9 years ago
James Bardin	66ebff90cd	move some more plugin search path logic to command ... Make less to change when we remove the old search path	9 years ago
James Bardin	2749946f5c	basic plugin getter ... Add discovery.GetProviders to fetch plugins from the relases site. This is an early version, with no tests, that only (probably) fetches plugins from the default location. The URLs are still subject to change, and since there are no plugin releases, it doesn't work at all yet.	9 years ago
James Bardin	7d2d951f27	Rename VersionSet to Constraints ... VersionSet is a wrapper around version.Contraints, so rename it it as such.	9 years ago
James Bardin	718ede0636	have Meta.Backend use a Config rather than loading ... Instead of providing the a path in BackendOpts, provide a loaded *config.Config instead. This reduces the number of places where configuration is loaded.	9 years ago
Martin Atkins	3af0ecdf01	command: "terraform providers" command ... This new command prints out the tree of modules annotated with their associated required providers. The purpose of this command is to help users answer questions such as "why is this provider required?", "why is Terraform using an older version of this provider?", and "what combination of modules is creating an impossible provider version situation?" For configurations using many modules this sort of question is likely to come up a lot once we support versioned providers. As a bonus use-case, this command also shows explicitly when a provider configuration is being inherited from a parent module, to help users to understand where the configuration is coming from for each module when some child modules provide their own provider configurations.	9 years ago
Martin Atkins	4ab8973520	core: provide config to all import context tests ... We're going to use config to determine provider dependencies, so we need to always provide a config when instantiating a context or we'll end up loading no providers at all. We previously had a test for running "terraform import -config=''" to disable the config entirely, but this test is now removed because it makes no sense. The actual functionality its testing still remains for now, but it will be removed in a subsequent commit when we start requiring that a resource to be imported must already exist in configuration.	9 years ago
Martin Atkins	c835ef8ff3	Update tests for the new ProviderResolver interface ... Rather than providing an already-resolved map of plugins to core, we now provide a "provider resolver" which knows how to resolve a set of provider dependencies, to be determined later, and produce that map. This requires the context to be instantiated in a different way, so this very noisy diff is a mostly-mechanical update of all of the existing places where contexts get created for testing, using some adapted versions of the pre-existing utilities for passing in mock providers.	9 years ago
Martin Atkins	7ca592ac06	core: use ResourceProviderResolver to resolve providers ... Previously the set of providers was fixed early on in the command package processing. In order to be version-aware we need to defer this work until later, so this interface exists so we can hold on to the possibly-many versions of plugins we have available and then later, once we've finished determining the provider dependencies, select the appropriate version of each provider to produce the final set of providers to use. This commit establishes the use of this new mechanism, and thus populates the provider factory map with only the providers that result from the dependency resolution process. This disables support for internal provider plugins, though the mechanisms for building and launching these are still here vestigially, to be cleaned up in a subsequent commit. This also adds a new awkward quirk to the "terraform import" workflow where one can't import a resource from a provider that isn't already mentioned (implicitly or explicitly) in config. We will do some UX work in subsequent commits to make this behavior better. This breaks many tests due to the change in interface, but to keep this particular diff reasonably easy to read the test fixes are split into a separate commit.	9 years ago
Martin Atkins	d6b6dbb5c6	command: correct provider name in the test fixture for push ... Currently this doesn't matter much, but we're about to start checking the availability of providers early on and so we need to use the correct name for the mock set of providers we use in command tests, which includes only a provider named "test". Without this change, the "push" tests will begin failing once we start verifying this, since there's no "aws" provider available in the test context.	9 years ago
Martin Atkins	9b4f15c261	plugin: move Client function into plugin, from plugin/discovery ... Having this as a method of PluginMeta felt most natural, but unfortunately that means that discovery must depend on plugin and plugin in turn depends on core Terraform, thus making the discovery package hard to use without creating dependency cycles. To resolve this, we invert the dependency and make the plugin package be responsible for instantiating clients given a meta, using a top-level function.	9 years ago
Martin Atkins	8364383c35	Push plugin discovery down into command package ... Previously we did plugin discovery in the main package, but as we move towards versioned plugins we need more information available in order to resolve plugins, so we move this responsibility into the command package itself. For the moment this is just preserving the existing behavior as long as there are only internal and unversioned plugins present. This is the final state for provisioners in 0.10, since we don't want to support versioned provisioners yet. For providers this is just a checkpoint along the way, since further work is required to apply version constraints from configuration and support additional plugin search directories. The automatic plugin discovery behavior is not desirable for tests because we want to mock the plugins there, so we add a new backdoor for the tests to use to skip the plugin discovery and just provide their own mock implementations. Most of this diff is thus noisy rework of the tests to use this new mechanism.	9 years ago
Jake Champlin	7894478c8c	Merge pull request #14681 from svanharmelen/f-review ... Use `helpers.shema.Provisoner` in Chef provisioner V2	9 years ago
James Bardin	dbe9599820	remove dead code	9 years ago
James Bardin	b3795e2d29	remove old state hook code	9 years ago
Mat Schaffer	76d4abd12a	Fix typo on state migration input error	9 years ago
Vladislav Rassokhin	df4342bc3d	Regenerate plugin list since provisioners were changed in previous commits	9 years ago
David Glasser	783908ee25	core: fix bad Sprintf in backend migration message (#14601) ... Before this, invoking this codepath would print Terraform has successfully migrated from legacy remote state to your configured remote state.%!(EXTRA string=s3)	9 years ago
Paul Stack	055c18e302	core/provider-split: Split out the Oracle OPC provider to new structure (#14362) ... * core/providersplit: Split OPC Provider to separate repo As we march towards Terraform 0.10.0, we are going to start building the terraform providers as separate binaries - this will allow us to continually release them. Before we go to 0.10.0, we need to be able to continue building providers in the same manner, therefore, we have hardcoded the path of the provider in the generate-plugins.go file The interim solution will require us to vendor the opc provider and any child dependencies, but when we get to 0.10.0, we will no longer have to do this - the core will auto download the plugin binary. The plugin package will have it's own dependencies vendored as well. * core/providersplit: Removing the builtin version of OPC provider * core/providersplit: Vendoring the OPC plugin * core/providersplit: update internal plugin list * core/providersplit: remove unused govendor item	9 years ago
yanndegat	21d8125d5c	provider/ovh: new provider (#12669) ... * vendor: add go-ovh * provider/ovh: new provider * provider/ovh: Adding PublicCloud User Resource * provider/ovh: Adding VRack Attachment Resource * provider/ovh: Adding PublicCloud Network Resource * provider/ovh: Adding PublicCloud Subnet Resource * provider/ovh: Adding PublicCloud Regions Datasource * provider/ovh: Adding PublicCloud Region Datasource * provider/ovh: Fix Acctests using project's regions	9 years ago
Dmitrii Korotovskii	ace0456d58	http provider and http request data source	9 years ago
James Bardin	947db2304a	it's possible to get a nil diff in PreApply ... Looking through the operations in node_resource_apply and node_resource_destroy, there are multiple nil checks for diffApply, so one we need to continue to assume that the diff can be nil through there until we ensure that it is non-nill in all cases. So regardless of how we came to get a nil diff in the UiHook PreApply method, we need to check it.	9 years ago
Justin LaRose	c6ad44de10	update error response when env does not exist (#14009)	9 years ago
stack72	898ac02854	Merge branch 'feature/gitlab_provider' of https://github.com/richardc/terraform into richardc-feature/gitlab_provider	9 years ago
Edward Betts	be265479a9	correct spelling mistakes (#13979)	9 years ago
James Bardin	6ef7c83ec5	add data-loss warning to SIGINT handler in apply ... Warning user about data loss after receiving an interrupt.	9 years ago
Richard Clamp	631b0b865c	provider/gitlab: add gitlab provider and `gitlab_project` resource ... Here we add a basic provider with a single resource type. It's copied heavily from the `github` provider and `github_repository` resource, as there is some overlap in those types/apis. ~~~ resource "gitlab_project" "test1" { name = "test1" visibility_level = "public" } ~~~ We implement in terms of the [go-gitlab](https://github.com/xanzy/go-gitlab) library, which provides a wrapping of the [gitlab api](https://docs.gitlab.com/ee/api/) We have been a little selective in the properties we surface for the project resource, as not all properties are very instructive. Notable is the removal of the `public` bool as the `visibility_level` will take precedent if both are supplied which leads to confusing interactions if they disagree.	9 years ago