92 Commits (bbd258bd933822c65afba5f2fcfb623be79fb4df)

Author	SHA1	Message	Date
Liam Cervante	0f0414d484	Fix partial address representation in plan for deferred actions (#34966) ... * Fix partial address representation in plan * reflect new type in stacks	2 years ago
Liam Cervante	55600d815e	Add support for partial addresses and targets that start with 'resource.' (#35333) ... * Add support for partial addresses and targets that start with 'resource.' * fix broken tests	2 years ago
Liam Cervante	5172cb5e27	deferred actions: allow unknown foreach attributes within import blocks (#35311) ... * deferred actions: allow unknown foreach attributes within import blocks * remember to fail tests when diags returned	2 years ago
Liam Cervante	765ec6e923	Complete implementation of targeting with deferred resources (#34971)	2 years ago
Liam Cervante	28797e7938	Add the deferred changes into the plan (#34946) ... * Add the deferred changes into the plan * add copywrite headers	2 years ago
Martin Atkins	5d87e32eb9	moduleaddrs: Split module source address parsing from package addrs ... Our package addrs ends up getting imported from just about ever other package in Terraform, because it contains the types we use to talk about various different kinds of objects. Therefore we typically try to keep its transitive dependency graph relatively small, because anything it depends on becomes an indirect dependency of nearly everything else. A while back we moved the module source address models into package addrs, which also brought with them the code for parsing strings to produce those addresses. Unfortunately, remote module source addresses are defined using the external dependency go-getter, which is pretty heavy itself and also brings with it numerous other external dependencies such as the AWS SDK, the Google Cloud Platform SDK, etc. Since only relatively few packages actually need to _parse_ source addresses -- with most either not caring about them at all or only consuming addresses that were already parsed by someone else -- we'll move the parser functions into their own package, while keeping the resulting address types in package addrs. This does still retain the package addrs dependency on external module github.com/hashicorp/terraform-registry-address, which is not ideal but that one at least has a relatively shallow dependency subgraph, so there's not so much urgency to tidy that one.	2 years ago
Martin Atkins	8e02f5dd21	addrs: PartialExpandedResource module address accessors ... This is kinda awkward because this address type represents both resources whose own instances are not expanded yet and resources belonging to whole modules whose instance keys haven't been expanded yet, and those two cases have different address types. However, in return for this awkward API only for the rare case where we need to isolate the module instance address, the rest of the system gets to not worry very much about this distinction: it can share most code between the two cases, since they both need similar evaluation treatment anyway.	2 years ago
Martin Atkins	d37436a39a	addrs: ModuleInstance.AbsCall ... This is just a variation of the pre-existing ModuleInstance.Call that returns its result as a single value of type AbsModuleCall. This should really have been the signature of ModuleInstance.Call in the first place, but it took us some time to realize that we would benefit from an absolute address type for module calls themselves as opposed to the instances they imply once expanded, and so AbsModuleCall didn't exist at the time we originally wrote ModuleInstance.Call. Perhaps one day we'll update all existing callers of ModuleInstance.Call to use ModuleInstance.AbsCall instead, but for now we'll be pragmatic and keep both to avoid causing unnecessary churn.	2 years ago
Martin Atkins	f3c48314ab	addrs: AbsModuleCall.StaticModule ... This new method calculates the static Module address corresponding to the receiver, effectively discarding any instance keys present in the containing module instance path.	2 years ago
Martin Atkins	869750da61	namedvals: A new package to encapsulate the tracking of named values ... Currently we have a slightly different treatment for each of the different kinds of named values, which makes it hard to generalize the implementations of their very similar behaviors. This package should over time take ownership of the problem of tracking all three kinds of named value during a graph walk, with result data structures that use this information (such as state and plan objects) copying the relevant values out of here only once the graph walk is complete. Nothing is using this yet, though. Some retrofitting of this into Terraform Core will follow in subsequent commits.	2 years ago
Martin Atkins	908c5fa44f	addrs: PartialExpandedModule.String correct for entirely-unexpanded ... This logic was previously incorrect for any case where the number of expanded steps was zero, causing the string representation to begin with a dot when it ought not to.	2 years ago
kmoe	a718f70f85	Add removed block (#34251) ... * terraform: remove redundant code NodeDestroyResourceInstance is never instantiated with a DeposedKey of anything other than states.NotDeposed, so the deleted code is never run. Deposed objects get a NodeDestroyDeposedResourceInstanceObject instead. * tfdiags: add helper func * configs: introduce removed block type * terraform: add forget action * renderer: render forget actions * terraform: deposed objects can be forgotten Deposed objects encountered during planning spawn NodePlanDeposedResourceInstanceObject, which previously generated a destroy change. Now it will generate a forget change if the deposed object is a forget target, and a destroy change otherwise. The apply graph gains a new node type, NodeForgetDeposedResourceInstanceObject, whose execution simply removes the object from the state. * configs: add RemoveTarget address type * terraform: modules can be forgotten * terraform: error if removed obj still in config * tests: better error on restore state fail * Update CHANGELOG.md	2 years ago
Martin Atkins	ce267925e6	addrs: Graph of addresses ... This is another contribution to our slowly-growing library of data structures of address types that implement UniqueKeyer. This is currently just a wrapper around *dag.AcyclicGraph which avoids the need for the caller to type-assert the results and which has hopefully less confusing method names for analyzing the edges. However, that's just an implementation detail and we should not expose that in the public API of this type.	2 years ago
Martin Atkins	d9a4f9a06b	instances: Methods for retrieving the instance keys of modules/resources ... These new methods both take into account the possibility of there being unknown keys, which will be useful for the expression evaluator to decide whether it can return a specific type or not.	2 years ago
Martin Atkins	4d0087e3ef	addrs: PartialExpandedModule and PartialExpandedResource ... In preparation for making it not an error to have unknown values in count or for_each arguments, we will need a way to talk about the as-yet-undetermined set of module or resource instance addresses that will result once we _do_ learn the instance keys in a later step. Unlike many of our address types these have unexported internals so that we can do some semi-uncool things with our address types that external callers are not normally supposed to do. This means they therefore need a bunch more methods than our address types typically need so that it's possible to access the relevant parts of the internal representation.	2 years ago
Martin Atkins	f1d68e89c0	addrs: AbsLocalValue is a UniqueKeyer	2 years ago
Martin Atkins	1c734048af	addrs: Add a missing copyright comment	2 years ago
Martin Atkins	7634f00f0f	addrs: AbsProviderConfig.Equal ... As with other Equal (or sometimes "Equals") methods in this package, this returns true if the two given provider configuration addresses represent the same object.	2 years ago
Martin Atkins	ac562eeb6f	states: State.AllResourceInstanceObjectAttrs returns a set ... Originally we had this function returning a slice of an anonymous struct type because we hadn't yet recognized "resource instance object" as a first-class address type. We do now have addrs.AbsResourceInstanceObject to represent that sort of thing, and so we'll use that here. This also means we can return a set of addresses rather than a slice, which is semantically better as this set of addresses is not inherently ordered. Some existing callers were depending on the sort.SliceStable we were originally doing to make the result dependable, and so now we have a generic helper for turning addrs.Set into a sorted slice of the same type using our address types' "Less" methods that describe their natural or preferred ordering.	2 years ago
Martin Atkins	5372d5eb98	stacks+rpcapi(stacks): Model deposed objects for resource instances ... Previously we incorrectly assumed that resource instances only have one "current" object each. However, resource instances can also have deposed objects which we must also keep track of. This is a breaking change to the rpcapi since we're now using a new message type for a resource instance _object_ address in several places. That breakage is intentional here because at the time of writing this commit the rpcapi is not yet in any stable release and we want to force updating our existing internal client to properly handle deposed objects too.	2 years ago
Martin Atkins	13e26b60dd	addrs: Adopt DeposedKey as an address type; remove states.Generation ... Previously we had states.DeposedKey as our representation of the unique keys used to differentiate between multiple deposed objects on the same resource instance. That type is useful in various places, but its presence in the "states" package made it troublesome to import for some callers. Since its purpose is as an identifier, this type is more at home in the "addrs" package. The states package retains a small number of aliases to preserve compatibility with a few existing callers for now, until we have the stomach for a more invasive change. This also removes the largely-redundant states.Generation interface type, which initially was intended as a way to distinguish between "current" objects and deposed objects, but didn't really add anything because we already have addrs.NotDeposed to represent that situation. Instead, we just ended up with various bits of boilerplate adapter code converting between the two representations. Everything now uses addrs.DeposedKey and uses addrs.NotDeposed to identify non-deposed objects.	2 years ago
Martin Atkins	c5e2755ffa	core: Allow passing in externally-configured provider instances ... Normally Terraform Core expects what it sees as the root module to be a self-contained root module which defines all of the provider configurations it needs. This commit is the start of making it valid for the apparent root module to actually be a shared module, which means it'd expect to receive provider configurations from its caller rather than defining them itself. The caller of the "root" module is the Terraform Core caller written in Go, so this is essentially a Go equivalent of the "providers" argument in a "module" block in the Terraform language.	2 years ago
Martin Atkins	e0797ab913	stackaddrs: Addresses for things inside components ... In the stacks model a component is essentially a container for a tree of normal Terraform modules, and so anything that can appear in a Terraform module can in principle appear inside a component. With that in mind here we define a generic type that can represent anything from package addrs belonging either to a stack configuration (before instance expansion) or to a stack instance (after instance expansion), and some aliases for a few combinations that make sense together, such as stackaddrs.AbsResourceInstance being an addrs.AbsResourceInstance belonging to a stackaddrs.AbsComponentInstance. We'll probably add more aliases here later, but this is a starting set that I expect will arise while implementing the planning-related models for stacks.	2 years ago
Martin Atkins	e4d372c490	collections: Generic Set and Map types ... This is a generalization of the similar types previously implemented in package addrs, now available for a type in any package as long as we can write a suitable rule for calculating a unique key for each distinct value of that type. Hopefully these eventually get replaced by future Go standard library functions, but this is here to fill that gap for us in the meantime.	2 years ago
Martin Atkins	6f1aeb1c11	addrs: RootProviderConfig type ... Due to how things have evolved we previously lacked any type which can represent a fully-qualified provider configuration that doesn't at least imply belonging to a particular module: - AbsProviderConfig represents a provider configuration belonging to some explicitly-specified module. - LocalProviderConfig doesn't specify a module but still needs to be resolved within the context of a module in order to understand what its LocalName field represents. This new RootProviderConfig type still doesn't fully fill that gap, but deals with a narrower problem of describing provider configurations in the root module without having to know any of the local names defined in that module. In a future commit we'll use this to allow callers to pass in pre-configured provider instances to Terraform Core, which will invert the usual provider instantiation model to allow planning against modules that are designed to "inherit" provider configurations from their callers, even when the caller is Go code rather than a "module" block.	2 years ago
Martin Atkins	8a1ede7235	addrs: LocalProviderConfig and AbsProviderConfig are UniqueKeyers	2 years ago
Liam Cervante	4ce385a19b	testing framework: implement overrides in terraform graph (#34169) ... * testing framework: implement overrides in terraform graph * fix bug for modules and module instances * add test for ModuleInstance.ContainingModule()	2 years ago
Liam Cervante	05f877166d	terraform test: parse mocking structures with test files (#34143)	3 years ago
Liam Cervante	8912396504	Reserve state and plan keywords in test files (#33846)	3 years ago
CJ Horton	98b81d3c50	add missing copyright headers	3 years ago
Liam Cervante	9742f22c4e	Introduce 'run' keyword for referencing outputs from earlier run blocks (#33683) ... * introduce 'run' keyword for referencing outputs from earlier run blocks * fix code consistency	3 years ago
hashicorp-copywrite[bot]	53c34ff49c	Update copyright file headers to BUSL-1.1	3 years ago
Liam Cervante	c9bc7e8479	Add input validation into the 'checks' outputs and tracking (#33481)	3 years ago
Liam Cervante	f74a8d16cf	[testing framework] implement expect_failures functionality (#33443)	3 years ago
Liam Cervante	212ae6c4ba	Introduce separate testing scope for reference validation (#33339)	3 years ago
hashicorp-copywrite[bot]	325d18262e	[COMPLIANCE] Add Copyright and License Headers	3 years ago
Liam Cervante	87c457781d	Checks: Refactor existing check addrs and add new check block addr (#32733) ... * Add support for scoped resources * refactor existing checks addrs and add check block addr * address comments	3 years ago
Liam Cervante	d212a72d1d	structured run output: impose canonical ordering on jsonstate and jsonplan packages (#32649)	3 years ago
fatahfattah	8a31f0a6c8	addrs: ModuleSourceRemote.String correctly handles query string in URL ... Previously it would append the "subdir" portion onto the query string, producing an invalid result.	4 years ago
Martin Atkins	0e4e9f7706	addrs: Be explicit about checkable object address kinds ... Previously we were attempting to infer the checkable object address kind of a given address by whether it included "output" in the position where a resource type name would otherwise go. That was already potentially risky because we've historically not prevented a resource type named "output", and it's also a forward-compatibility hazard in case we introduce additional object kinds with entirely-new addressing schemes in future. Given that, we'll instead always be explicit about what kind of address we're storing in a wire or file format, so that we can make sure to always use the intended parser when reading an address back into memory, or return an error if we encounter a kind we're not familiar with.	4 years ago
Martin Atkins	3785619f93	core: Use the new checks package for condition tracking ... The "checks" package is an expansion what we previously called plans.Conditions to accommodate a new requirement that we be able to track which checks we're expecting to run even if we don't actually get around to running them, which will be helpful when we start using checks as part of our module testing story because test reporting tools appreciate there being a relatively consistent set of test cases from one run to the next. So far this should be essentially a no-op change from an external functionality standpoint, aside from some minor adjustments to how we report some of the error and warning cases from condition evaluation in light of the fact that the "checks" package can now track errors as a different outcome than a failure of a valid check. As is often the case with anything which changes what we track in the EvalContext and persist between plan and apply, Terraform Core is pretty brittle and so this had knock-on effects elsewhere too. Again, the goal is for these changes to not create any material externally-visible difference, and just to accommodate the new assumption that there will always be a "checks" object available for tracking during a graph walk.	4 years ago
Martin Atkins	9dea19807f	checks: A new package for modeling custom condition checks ... The checks.Checks type aims to encapsulate keeping track of check results during a run and then reporting on them afterwards even if the run was aborted early for some reason. The intended model here is that each new run starts with an entirely fresh checks.Checks, with all of the statuses therefore initially unknown, and gradually populates the check results as we walk the graph in Terraform Core. This means that even if we don't complete the run due to an error or due to targeting options we'll still report anything we didn't visit yet as unknown. This commit only includes the modeling of checks in the checks package. For now this is just dead code, and we'll wire it in to Terraform Core in subsequent commits.	4 years ago
Martin Atkins	696b403bf3	addrs: OutputValue.InModule ... Similar to other address types, this wraps the receiver up in its associated "config" type, binding it to a particular not-yet-expanded module.	4 years ago
Martin Atkins	d06cbfe6c8	addrs: ConfigCheckable type ... Our existing addrs.Checkable represents a particular (possibly-dynamic) object that can have checks associated with it. This new addrs.ConfigCheckable represents static configuration objects that can potentially generate addrs.Checkable objects. The idea here is to allow us to predict from the configuration a set of potential checkable object containers and then dynamically associate the dynamic checkable objects with them as we make progress with planning. This is intended for our integration of checks into the "terraform test" testing harness, to be used instead of the weirdo builtin provider we were using as a placeholder before we had first-class syntax for checks. Test reporting tools find it helpful for there to be a consistent set of test cases from one run to the next so that they can report on trends over multiple runs, and so our ConfigCheckable addresses will serve as the relatively-static "test case" that we'll then associate the dynamic checks with, so that we can still talk about objects in the test result report even if we end up not reaching them due to an upstream conditution failure.	4 years ago
Martin Atkins	783a07d9e8	build: Use Go 1.19 ... Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that. In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.	4 years ago
kmoe	56a1e0d1c6	allow cross-package move statements (#31556)	4 years ago
Radek Simko	7feef1c4aa	Use hashicorp/terraform-registry-address as a decoupled library (#28338) ... * refactor: Use tfaddr for provider address parsing * refactor: Use tfaddr for module address parsing * deps: introduce hashicorp/terraform-registry-address	4 years ago
Martin Atkins	de8eef1da5	addrs: Format string instance keys in an HCL-compatible way ... So far we've only ever needed to re-parse address strings that happen not to contain instance keys and so we've gotten away with our serialization of these not being quite right, but given how liberally we've expected to be able to use address strings from this package for wire format interchange it seems likely that this is going to surprise us eventually. Now we'll use an escaping scheme compatible with HCL's parser rather than Go's parser, and so we can safely rely on hclsyntax.ParseTraversal as part of reversing this operation to transform an address string back into an address equivalent to the value it was created from.	4 years ago
Alisdair McDiarmid	ad52076025	addrs: Add tests for Module.String	4 years ago
Dennis Gursky	2c1b1f3aa1	Update module.go ... making code more similar to https://github.com/hashicorp/terraform/blob/main/internal/addrs/module_instance.go	4 years ago