213 Commits (bb3bbcc0fc8c870626f99b7b2aefdd63ae407d2d)

Author	SHA1	Message	Date
Mitchell Hashimoto	e8ac16b2df	helper/schema: test for empty state	12 years ago
Mitchell Hashimoto	df05483cf6	helper/schema: test pass from SvH	12 years ago
Mitchell Hashimoto	913f9a923e	helper/schema: remove unnecessary code	12 years ago
Mitchell Hashimoto	e5877543b2	helper/schema: track map element counts ... This adds "field.#" values to the state/diff with the element count of a map. This fixes a major issue around not knowing when child elements are computed when doing variable access of a computed map. Example, if you have a schema like this: "foo": &Schema{ Type: TypeMap, Computed: true, } And you access it like this in a resource: ${type.name.foo.computed-field} Then Terraform will error that "field foo could not be found on resource type.name". By adding that "foo.#" is computed, Terraform core will pick up that it WILL exist, so its okay.	12 years ago
Sander van Harmelen	40fa6c3aaa	Fixed a type and reordered the case statements ... Making in more inline with the existing code…	12 years ago
Sander van Harmelen	83c760fcb3	core: refactoring the way sets work internally v2 ... This is a refactored solution for PR #616. Functionally this is still the same change, but it’s implemented a lot cleaner with less code and less changes to existing parts of TF.	12 years ago
Sander van Harmelen	4c23019ab7	core: fixing new test ... Removed the ‘hashcode’ function so we didn’t need to import it here, but also removed the needed type assertion.	12 years ago
Sander van Harmelen	54db46ef1b	Fixing a small logic bug in diffList ... It’s not enough to only check if no new value is set. It can also be that a new value is set, but contains a variable that cannot be interpolated until a depending resource is created during the apply fase. I actually found this one as one of the acceptance tests for the AWS ELB resource was failing. It failed with the following error: ``` --- FAIL: TestAccAWSELB_InstanceAttaching (177.83 seconds) testing.go:121: Step 1 error: Error applying: aws_elb.bar: diffs didn't match during apply. This is a bug with the resource provider, please report a bug. FAIL exit status 1 FAIL github.com/hashicorp/terraform/builtin/providers/aws 177.882s ``` After a quick look I noticed it was actually a bug in core TF so added the test and made sure all unit tests and AWS acceptance tests are now running successfully.	12 years ago
Mitchell Hashimoto	c3ec9f7965	Revert "helper/schema: TypeMap computed should mark diff as cmputed" ... This reverts commit b73078c670.	12 years ago
Mitchell Hashimoto	b73078c670	helper/schema: TypeMap computed should mark diff as cmputed	12 years ago
Emil Hessman	4bfe18b40d	argument and verb formatting fixes reported by go vet ... builtin/providers/aws/tags_test.go:56: unrecognized printf verb 'i' builtin/providers/aws/tags_test.go:59: unrecognized printf verb 'i' config/config_test.go:101: possible formatting directive in Fatal call config/config_test.go:157: possible formatting directive in Fatal call config/module/get_file_test.go:91: missing argument for Fatalf(%s): format reads arg 1, have only 0 args helper/schema/schema.go:341: arg v.Type for printf verb %s of wrong type: schema.ValueType helper/schema/schema.go:656: missing argument for Errorf(%s): format reads arg 2, have only 1 args helper/schema/schema.go:912: arg schema.Type for printf verb %s of wrong type: schema.ValueType terraform/context.go:178: arg v.Type() for printf verb %s of wrong type: github.com/hashicorp/terraform/config.VariableType terraform/context.go:486: arg c.Operation for printf verb %s of wrong type: terraform.walkOperation terraform/diff_test.go💯 arg actual for printf verb %s of wrong type: terraform.DiffChangeType terraform/diff_test.go:235: arg actual for printf verb %s of wrong type: terraform.DiffChangeType	12 years ago
Mitchell Hashimoto	1792334ec4	fmt	12 years ago
Mitchell Hashimoto	81913c58fb	providers/aws: fixing faililng test	12 years ago
Mitchell Hashimoto	61811fce23	helper/schema: remove debug info	12 years ago
Mitchell Hashimoto	f63a5d24e9	helper/schema: diffs for sets should include the full set [GH-457] ... Prior to this, the diff only contained changed set elements. The issue with this is that `getSet`, the internal function that reads a set from the ResourceData, expects that each level (state, config, diff, etc.) has the _full set_ information. This change was done to fix merging issues. Because of this, we need to make sure the full set is visible in the diff.	12 years ago
Mitchell Hashimoto	d0ce67a5b7	helper/schema: on destroy/create, reset state to be empty [GH-464]	12 years ago
Mitchell Hashimoto	d1324678dd	helper/schema: setting empty map works [GH-464]	12 years ago
Mitchell Hashimoto	9ecbbc6fa0	helper/schema: some more unit tests	12 years ago
Mitchell Hashimoto	17d1bb7dde	Revert "Merge pull request #422 from svanharmelen/f-shaving-off-some-cpu-cycles" ... This reverts commit 428cce2478, reversing changes made to 517c5b2ea8.	12 years ago
Mitchell Hashimoto	428cce2478	Merge pull request #422 from svanharmelen/f-shaving-off-some-cpu-cycles ... helper/schema: Shaving off some unneeded calls, saving CPU cycles	12 years ago
Mitchell Hashimoto	8f166458d2	Merge pull request #480 from hashicorp/f-fix-consul ... Consul param should be "key"	12 years ago
Mitchell Hashimoto	5390357e45	helper/schema: sets properly take into account the diff	12 years ago
Mitchell Hashimoto	39edc5dc04	helper/schema: diffing maps that are computed should not result in ... change	12 years ago
Mitchell Hashimoto	37930f51a1	helper/schema: test case for boolean diffs	12 years ago
Mitchell Hashimoto	deec7194a3	helper/schema: validate maps properly [GH-461]	12 years ago
Mitchell Hashimoto	3e1169db61	helper/schema: validate string/bool types [GH-460]	12 years ago
Mitchell Hashimoto	686871310d	terraform: input properly sends on only set input	12 years ago
Mitchell Hashimoto	2b50d44aa4	helper/schema: validate Set is a set type [GH-413]	12 years ago
Mitchell Hashimoto	b4f8b7f43b	helper/resource: RetryError for quitting quickly	12 years ago
Mitchell Hashimoto	2e703afdad	helper/schema: valiate should ignore computed fields	12 years ago
Sander van Harmelen	e003334429	Shaving off some unneeded calls, saving CPU cycles ... I know it’s very unlikely that a user will notice the difference, but why range through the list, generate the set and calculate the hashcode, only to find out that indexMap == nil (e.g. don’t do anything with the generated hashcode). As indexMap is only needed when len(parts) > 0, why not only create and fill it (in one go) when len(parts) > 0?	12 years ago
Armon Dadgar	5a3f80559c	helper/ssh: Cleanups	12 years ago
Mitchell Hashimoto	12c178bc63	helper/schema: don't ask for input if provider default would not be nil	12 years ago
Mitchell Hashimoto	30786ce442	fmt	12 years ago
Mitchell Hashimoto	59349cca11	helper/schema: sets must be treated atomically within ResourceData ... This fixes a seemingly minor issue (GH-255) around plans showing changes when in fact there are none. But in reality this turned out to uncover a really terrible bug. The effect of what was happening was that multiple items in a set were being merged. Now, they were being merged in the right order, so if you didn't have rich types (lists in a set) then you never saw the effect since the later value would overwrite the earlier. But with lists (such as in security groups), you would end up with the lists merging. So, if you had one ingress rule with CIDR blocks and one with SGs, then after the merge both ingress rules would have BOTH CIDR and SGs, resulting in an incorrect plan (GH-255). This fixes the issue by introducing a `getSourceExact` bitflag to the ResourceData source. When this is set, ALL data must come from this level, instead of merging lower levels. In the case of sets and diffs, this is exactly what you want: "Get me the set 'foo' from the config and the config ONLY (not the state or diff or w/e)". Andddddd its fixed. GH-255	12 years ago
Mitchell Hashimoto	3a107d2e50	helper/schema: set the field to empty if it is a list and computed	12 years ago
Mitchell Hashimoto	e5d64318bf	helper/schema: don't say that a set is computed if it exists	12 years ago
Mitchell Hashimoto	36f225dea0	fmt	12 years ago
Mitchell Hashimoto	e0994c717d	helper/schema: fix issues around computed sets	12 years ago
Mitchell Hashimoto	539eca5ee6	Fix failing tests	12 years ago
Mitchell Hashimoto	dcaf653d6f	helper/schema: properly detect that a list is computed	12 years ago
Mitchell Hashimoto	3aa655ad3b	helper/schema: test schema diffs with the interpolation splits	12 years ago
Mitchell Hashimoto	753f6c6f8e	helper/schema: fix failing tests	12 years ago
Mitchell Hashimoto	00bdef3093	providers/aws: test tag removal	12 years ago
Mitchell Hashimoto	6eafac8a34	providers/aws: aws_vpc supports tags	12 years ago
Mitchell Hashimoto	f43528957e	helper/schema: support top-level TypeMap	12 years ago
Mitchell Hashimoto	0db9d98fff	helper/schema: can set Partial(true) multiple times	12 years ago
Mitchell Hashimoto	ef62fa80db	helper/resource: add Retry function	12 years ago
Mitchell Hashimoto	a7c321a028	helper/scheam: support UI defaults	12 years ago
Mitchell Hashimoto	99044a1f14	Add descriptions for AWS inputs	12 years ago