terraform

Commit Graph

Author	SHA1	Message	Date
Martin Atkins	85eda8a059	state/remote: Don't persist snapshot for unchanged state Previously we would write to the backend for every call to PersistState, even if nothing changed since the last write, but update the serial only if the state had changed. The Terraform Cloud & Enterprise state storage have a simple safety check that any future write with an already-used lineage and serial must be byte-for-byte identical. StatesMarshalEqual is intended to detect that, but it only actually detects changes the state itself, and not changes to the snapshot metadata. Because we write the current Terraform version into the snapshot metadata during serialization, we'd previously have an issue where if the first state write after upgrading Terraform to a new version happened to change nothing about the state content then we'd write a new snapshot that differed only by Terraform version, and Terraform Cloud/Enterprise would then reject it. The snapshot header is discarded immediately after decoding, so we can't use information from it when deciding whether to increment the serial. The next best thing is to skip sending no-op snapshot updates to the state client in the first place. These writes are unnecessary anyway, and state storage owners have asked us in the past to elide these to avoid generating noise in their version logs, so we'll also finally meet those requests as a nice side-effect of this change. We didn't previously have tests for the full flow of retrieving and then successively updating persisted state snapshots, so this includes a test which covers that logic and includes an assertion that a no-op update does not get written to the state client.	7 years ago
Martin Atkins	477ea0d360	state/remote: Make tests compile and run to completion One of the tests was hanging, so for now it's stubbed out until we can get to the bottom of the hang on a subsequent pass.	8 years ago
James Bardin	0ad6f08204	Make remote state test run Make them compile against the new interface. The tests will be updated later to check new behavior.	9 years ago
James Bardin	9b76f6e138	Move TestRemoteLocks to state/remote This was legacy remote state client and backends can use this test function without an import cycle.	9 years ago
James Bardin	10f6d7f30f	Add locking for s3 state Use a DynamoDB table to coodinate state locking in S3. We use a simple strategy here, defining a key containing the value of the bucket/key of the state file as the lock. If the keys exists, the locks fails. TODO: decide if locks should automatically be expired, or require manual intervention.	9 years ago
James Bardin	74813821ec	Add remote state init test Verify that a remote state file is correctly initialized in the same manner as used by the `terraform remote config`	10 years ago
James Bardin	3622bfddd6	Revert #7464 and allow an empty state Revert back to using a nil state. The external usage of the state shoudl always check the Empty() method.	10 years ago
James Bardin	24f6d3fe98	Return an error when there's no remote state When refreshing remote state, indicate when no state file was found with an ErrRemoteStateNotFound error. This prevents us from inadvertantly getting a nil state into a terraform.State where we assume there's always a root module.	10 years ago
Mitchell Hashimoto	bfe0edef51	state/remote: passing Atlas state test	11 years ago
Mitchell Hashimoto	b8836ff279	state/remote: consul client	11 years ago

10 Commits (ba7679b6791a306a73062ddd5a00359452e152fc)