1108 Commits (ba7679b6791a306a73062ddd5a00359452e152fc)

Author	SHA1	Message	Date
James Bardin	49439d02d1	sanitize provisioner output strings ... The grpc protocol requires strings to be valid utf8, but because provisioners often don't have control over the command output, invalid utf8 sequences can make it into the response causing grpc transport errors. Replace all invalid utf sequences with the standard utf replacement character in the provisioner output. The code is a direct copy from the go1.13 std library, and can be replaced with strings.ToValidUTF8 once it's available.	6 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	7 years ago
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	7 years ago
James Bardin	a3c374b227	don't lose track of private data in the ACC tests ... If the resource schema version is > 0, the metadata containing the timeout values was overwritten during acceptance tests.	7 years ago
appilon	d3dc1263bf	Merge pull request #22382 from hashicorp/appilon/delete-files ... [CLEANUP] Prune internal usage of config package (with 1 exception)	7 years ago
Radek Simko	ecbfc365a0	Merge pull request #20157 from shinmog/conflictswith ... helper/schema: Add "part" to ConflictsWith validation error	7 years ago
Radek Simko	db7d1826e4	Merge pull request #22312 from ewbankkit/add-rand-ip-address ... helper/acctest: Add function to return random IP address	7 years ago
Radek Simko	7861cc6141	Merge pull request #20309 from chanzuckerberg/ryanking/remove_lifecycle_comment ... helper/schema: Remove comment about nested schema.Resources having their own lifecycle	7 years ago
Radek Simko	350395d804	Add better comment	7 years ago
Radek Simko	a08ad08169	Merge pull request #18277 from ndmckinley/patch-1 ... helper/resource: Minor docs tweak on ImportStateVerify	7 years ago
Alex Pilon	77757d9f5b	prune references to config/module ... delete config/module prune references to config except in terraform/resource.go move, cleanup, and delete inert code	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Alex Pilon	ec0402a238	add case to decoder to assert to slice, then each item to a map	7 years ago
Alex Pilon	6ae281b34f	set Err to true for test ... This was likely meant to be set to Err true but the old parser mistakenly didn't raise an error	7 years ago
Alex Pilon	6de3c32652	comment out failing test	7 years ago
Alex Pilon	83aa07f907	prune NewResourceConfig and update tests	7 years ago
Kit Ewbank	949a6ae695	Add 'RandIpAddress'.	7 years ago
The Terraform Team	176f790323	Merge pull request #22262 from hashicorp/mildwonkey/b-deprecation-warnings ... helper/schema: don't skip deprecation check during validation	7 years ago
Kristin Laemmert	bfd66083de	helper/schema: don't skip deprecation check during validation ... If an attribute was not wholly known, helper/schema was skipping the `validateType` function which (among other things) returned deprecation messages. This PR checks for deprecation before returning when skipping validateType.	7 years ago
Paul Tyng	e400c25358	Minor typo	7 years ago
Paul Tyng	366f70a71e	Update copy for Exists ... You can signal the same information in `Read` with an empty ID if the object does not exist, Implementing `Exists` is not the only way to do so and in some providers is also not the preferred way.	7 years ago
James Bardin	7648f99bca	Merge pull request #22236 from hashicorp/jbardin/nil-in-config ... don't reflect nil in schema validation	7 years ago
James Bardin	016c4f782d	don't reflect nil in schema validation ... Nil values were not previously expected during validation, but they can appear in some situations with the new protocol. Add checks to prevent using zero reflect.Values.	7 years ago
James Bardin	4bed030d40	don't validate MinItems with unknowns in a block ... If there are unknowns, the block may have come from a dynamic declaration, and we can't validate MinItems. Once the blocks are expanded, we will get the full config for validation without any unknown values.	7 years ago
Alex Pilon	7f8f198719	remove UnknownVariabeValue from config and update references to shim	7 years ago
James Bardin	75602df5ef	Revert "Remove removed attribute from applied state" ... This reverts commit 2e2a363052.	7 years ago
James Bardin	8e8eb6d6d3	Merge pull request #21884 from hashicorp/jbardin/validate-null-diags ... don't append nil elements to a diagnostic cty.Path	7 years ago
James Bardin	d4b0788854	don't append nil elements to a diagnostic cty.Path ... If a set element is nil in validateConfigNulls, we don't want to append that element to the diagnostic path, since it doesn't offer any useful info to the user.	7 years ago
James Bardin	0d9f84414a	Merge pull request #21879 from hashicorp/jbardin/sdk-panics ... prevent sdk panics in 2 specific cases	7 years ago
James Bardin	cd3ac50ddb	prevent sdk panics in 2 specific cases ... Fix 2 specific panics in the sdk when reading nil or computed maps from various configurations. The legacy sdk code is too dependent on undefined behavior to attempt to find and fix the root cause at this point. Since the code is essentially frozen for future development, these changes are specifically targeted to only prevent panics from within providers. Because any code effected by these changes would have panicked, there cannot be anything depending on the behavior, and these should be safe to fix.	7 years ago
James Bardin	f362198467	Merge pull request #21806 from hashicorp/jbardin/lost-empty-strings ... prevent an empty string from being lost	7 years ago
James Bardin	9365a2d97d	private and timeout handling in grpc_provider ... Load private data for read, so the resource can get it's configured timeouts if they exist. Ensure PlanResourceChange returns the saved private data when there is an empty diff. Handle the timeout decoding into Meta in the PlanResourceChange, so that it's always there for later operations.	7 years ago
James Bardin	2448d1d38b	move timeout handling to grpc_provider ... simpleDiff is only called from the grpc_provider, and we always need to make sure the timeouts are encoded in the private data.	7 years ago
James Bardin	4dcda04d96	prevent an empty string from being lost ... The helper/schema diff process loses empty strings, causing them to show up as unset (null) during apply. Besides failing to show as set by GetOk, the absence of the value also triggers the schema to insert a default value again during apply. It would also be be preferable if the defaults weren't re-evaluated again during ApplyResourceChange, but that would require a more invasive patch to the field readers, and ensuring the empty string is stored in the plan should block the default.	7 years ago
James Bardin	8ae31aa2db	normalize empty blocks during import ... Like Upgrade, Import is another case where we don't have the context of the configuration and need to ensure missing blocks are normalized.	7 years ago
James Bardin	e6ee78555a	Merge pull request #21721 from hashicorp/jbardin/remove-new-removed ... Remove removed attribute from applied state	7 years ago
James Bardin	814f068dfe	Merge pull request #21711 from hashicorp/jbardin/upgrade-blocks ... Ensure all object attrs & empty blocks in upgrade	7 years ago
James Bardin	dbe22181ae	Ensure all object attrs & empty blocks in upgrade ... When upgrading from a flatmap state, unset blocks would not exist in the state, while they will represented as empty in the new cty.Value. This will cause an unexpected diff in the first plan after upgrade. This situation may normally be applied with no impact, but some providers may have unexpected behavior, and if the attributes force replacement it may require manual alteration of the state to complete the upgrade.	7 years ago
James Bardin	2e2a363052	Remove removed attribute from applied state ... When a Diff contains a NewRemoved attribute (which would have been null in the planned state), the final value is often the "zero" value string for the type, which the provider itself still applies to the state. Rather than risking a change of behavior in helper/schema by fixing the inconsistency, we'll remove the NewRemoved attributes after apply to prevent further issues resulting from the change in planned value.	7 years ago
James Bardin	a036ea0ec8	only seed math/rand once ... Re-seeding the PRNG every time only serves to make the output an obfuscated timestamp. On windows with a low clock resolution, this manifests itself by outputting the same value on calls within the minimum time delta of the clock.	7 years ago
Brian Flad	94078f9029	helper/plugin: Allow missing MigrateState for provider flatmap state upgrades ... Reference: https://github.com/terraform-providers/terraform-provider-aws/issues/8828 Prior to Terraform 0.12, providers were not required to implement the `MigrateState` function when increasing the `SchemaVersion` above `0`. Effectively there is no flatmap state difference between version 0 and defined `SchemaVersion` or lowest `StateUpgrader` `Version` (whichever is lowest) when `MigrateState` is undefined, so here we remove the error and increase the schema version automatically.	7 years ago
James Bardin	4cb6ebe22c	maintain private data through provider ACC tests ... The private->meta data was lost in the test harness.	7 years ago
James Bardin	a056b84cdd	add delete timeout test ... The timeout value is still not being persisted. While it doesn't fix this issue, make sure to always return Private during Plan.	7 years ago
James Bardin	dcab82e897	send and receive Private through ReadResource ... Send Private data blob through ReadResource as well. This will allow for extra flexibility for future providers that may want to pass data out of band through to their resource Read functions.	7 years ago
James Bardin	6055cb632e	filter unknowns from simple lists and maps in sdk ... While there was already a check in the sdk to filter unknowns from validation, it missed the case where those were in simple lists and maps.	7 years ago
James Bardin	c9e1d26c25	remove the legacy schema access ... Having removed the methods, it is straightforward to mechanically update this file to get rid of all references to the "legacy schema". There is now only one config schema type to deal with in the sdk.	7 years ago
James Bardin	c8a2f3840b	remove SkipCoreTypeCheck ... This experiment is no longer needed for handling computed blocks, since the legacy SDK can't reasonably handle Dynamic types, we need to remove this before the final release. Remove LegacySchema functions as well, since handling SkipCoreTypeCheck was the only thing left they were handling.	7 years ago
James Bardin	ec65fb960d	sdk: use core schema for json state upgrade ... When handling the json state in UpgradeResourceState, the schema must be what core uses, because that is the schema used for encoding/decoding the json state. When converting from flatmap to json state, the legacy schema will be used to decode the flatmap to a cty value, but the resulting json will be encoded using the CoreConfigSchema to match what core expects.	7 years ago
James Bardin	cf61a689eb	only hold back empty container changes in apply ... When normalizing the state during read, if the resource was previously imported, most nil-able values will be nil, and we need to prefer the values returned by the latest Read operation. This didn't come up before, because Read is usually working with a state create by plan and Apply which has already shaped the state with the expected empty values. Having the src value preferred only during Apply better follows the intent of this function, which should allow Read to return whatever values it deems necessary. Since Read and Plan use the same normalization logic, the implied Read before plan should take care of any perpetual diffs.	7 years ago
Radek Simko	8a6d1d62b6	stringer: Regenerate files with latest version	7 years ago