175 Commits (ba7679b6791a306a73062ddd5a00359452e152fc)

Author	SHA1	Message	Date
Pam Selle	cca36025d6	Merge pull request #22946 from hashicorp/kmoe/copy_dir_dotfiles ... remove dotfile exclusion in copyDir	7 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	7 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	7 years ago
Martin Atkins	e21f0fa61e	backend/local: Handle interactive prompts for variables in UI layer ... During the 0.12 work we intended to move all of the variable value collection logic into the UI layer (command package and backend packages) and present them all together as a unified data structure to Terraform Core. However, we didn't quite succeed because the interactive prompts for unset required variables were still being handled _after_ calling into Terraform Core. Here we complete that earlier work by moving the interactive prompts for variables out into the UI layer too, thus allowing us to handle final validation of the variables all together in one place and do so in the UI layer where we have the most context still available about where all of these values are coming from. This allows us to fix a problem where previously disabling input with -input=false on the command line could cause Terraform Core to receive an incomplete set of variable values, and fail with a bad error message. As a consequence of this refactoring, the scope of terraform.Context.Input is now reduced to only gathering provider configuration arguments. Ideally that too would move into the UI layer somehow in a future commit, but that's a problem for another day.	7 years ago
James Bardin	1ee851f256	Merge pull request #22846 from hashicorp/jbardin/evaluate-resource ... Always evaluate resources in their entirety	7 years ago
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	7 years ago
Katy Moe	2c44a7aacb	remove dotfile exclusion in copyDir ... copyDir is used in configload/getter.go to copy previously downloaded modules instead of using the go-getter client every time. The go-getter client downloads dotfiles, but copyDir did not copy dotfiles, leading to inconsistent behaviour when reusing the same module source.	7 years ago
James Bardin	86bf674246	change GetResourceInstance to GetResource ... In order to allow lazy evaluation of resource indexes, we can't index resources immediately via GetResourceInstance. Change the evaluation to always return whole Resources via GetResource, and index individual instances during expression evaluation. This will allow us to always check for invalid index errors rather than returning an unknown value and ignoring it during apply.	7 years ago
James Bardin	13e2e10577	fix Min/Max validation during decoding ... We can only validate MinItems >= 1 (equiv to "Required") during decoding, as dynamic blocks each only decode as a single block. MaxItems cannot be validated at all, also because of dynamic blocks, which may have any number of blocks in the config.	7 years ago
James Bardin	731d4226d3	do not validate Min/Max Items in CoerceValue ... Due to both the nature of dynamic blocks, and the need for resources to sometimes communicate incomplete values, we cannot validate MinItems and MaxItems in CoerceValue.	7 years ago
James Bardin	3e03213485	Merge pull request #22478 from hashicorp/jbardin/coerce-value ... don't validate Min/Max block vals in CoerceValue	7 years ago
Daniel Schroeder	628b50f900	configs/configupgrade: typo fix (#22469)	7 years ago
James Bardin	554cedab8a	don't validate Min/Max block vals in CoerceValue ... A provider may not have the data to fill in required block values in all cases during the resource Read operation. This is more common in import, because there is no initial configuration or state, and it's possible some values are only provided in the configuration. The original intent of MinItems and MaxItems in the schema was to enforce configuration constraints, not to enforce what the resource could save in the state. Since the configuration is already statically validated, and the Schema is validated against the configuration in a separate step, we can drop these extra validation constraints in CoerceValue and relax it to only ensure the types conform to what is expected.	7 years ago
Pam Selle	9631e4c73d	Merge pull request #20571 from sergkondr/fix_misspelling ... fix misspelling	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
James Bardin	5878527732	Merge pull request #22221 from hashicorp/jbardin/min-items ... MinItems with dynamic blocks	7 years ago
James Bardin	67dbd6d345	don't check MinItems with unknowns in blocks ... If a block was defined via "dynamic", there will be only one block value until the expansion is known. Since we can't detect dynamic blocks at this point, don't verify MinItems while there are unknown values in the config. The decoder spec can also only check for existence of a block, so limit the check to 0 or 1.	7 years ago
Pam Selle	360068b3cb	Merge pull request #21922 from pselle/resource_for_each ... Resource for_each	7 years ago
Pam Selle	e7d8ac5ad7	Remove panic, update comment	7 years ago
Thayne McCombs	7c678d104f	Add support for for_each for data blocks. ... This also fixes a few things with resource for_each: It makes validation more like validation for count. It makes sure the index is stored in the state properly.	7 years ago
Kristin Laemmert	66f4a48b8c	configs/configupgrade: fix panic on nil hilNode (#22181) ... In some cases (see #22020 for a specific example), the parsed hilNode can be nil. This causes a series of panics. Instead, return an error and move on.	7 years ago
Pam Selle	7d905f6777	Resource for_each	7 years ago
Alex Pilon	0450f487fa	move IsEmptyDir to configs package	7 years ago
James Bardin	8111050c66	ensure we record diagnostics from nested modules ... When loading nested modules, the child module diagnostics were dropped in the recursive function. This mean that the config from the submodules wasn't fully loaded, even though no errors were reported to the user. This caused further problems if the plan was stored in a plan file, when means only the partial configuration was stored for the subsequent apply operation, which would result in unexplained "Resource node has no configuration attached" errors later on. Also due to the child module diagnostics being lost, any newly added nested modules would be silently ignored until `init` was run again manually.	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Kristin Laemmert	2a457115a3	configs: fix panic when the value is missing from version attribute in a provider block	7 years ago
Pam Selle	59c5cc4788	Merge pull request #21254 from davewongillies/gcs ... Add GCS source support for modules	7 years ago
Martin Atkins	e85093ce08	configs/configload: Don't panic when version constraint is added ... Previously, adding a version constraint to a module that was previously recorded without a version in the module manifest would cause a panic. Instead, we now use a slight variant of the "dependencies have changed" error that doesn't try to print out a specific version number.	7 years ago
David Gillies	8b45443b21	Add GCS source support for modules	7 years ago
Martin Atkins	004c2056a7	configs/configupgrade: Use single-line syntax for empty object exprs	7 years ago
Kristin Laemmert	14d625c850	configs/configupgrade: preserve in-line comments for lists (#21299) ... * configs/configupgrade: preserve in-line comments for lists The configupgrade tool was not writing `LineComments` for lists. Now it is! Fixes #21155	7 years ago
Radek Simko	a2ee9fc8f9	Merge pull request #21282 from hashicorp/configupgrade-err-msg-fmt ... configupgrade: Improve error message formatting	7 years ago
Radek Simko	8a6d1d62b6	stringer: Regenerate files with latest version	7 years ago
Radek Simko	81c20ed7ae	configupgrade: Improve error message formatting	7 years ago
Radek Simko	42ba7a3e00	configupgrade: Upgrade indexing of splat syntax	7 years ago
Radek Simko	1f5cadeec0	0.12upgrade: Return error for invalid reference	7 years ago
Martin Atkins	d7f23f0beb	configs/configupgrade: Don't panic if analyzer fails ... Previously we were trying to access a field of the analysis object before checking if analysis produced errors. The analysis function usually returns a nil analysis on error, so this would result in a panic whenever that happened. Now we'll dereference the analysis object pointer only after checking for errors, so we'll get a chance to report the analysis error to the user.	7 years ago
Martin Atkins	1bb47ab9a5	configs/configupgrade: Preserve comments on items in object exprs ... The expression upgrade functionality mostly ignores comments because in the old language the syntax prevented comments from appearing in the middle of expressions, but there was one exception: object expressions. Because HCL 1 used ObjectType both for blocks and for object expressions, that is the one situation where something we consider to be an expression could have inline attached comments in the old language. We migrate these here so we don't lose these comments that don't appear anywhere else. Other comments get gathered up into a general comments set maintained inside the analysis object and so will be printed out as required _between_ expressions, just as they did before.	7 years ago
Martin Atkins	bb118c37a2	configs: Handle "dynamic" blocks as special during override merging ... Previously we were treating "dynamic" blocks in configuration the same as any other block type when merging config bodies, so that dynamic blocks in the override would override any dynamic blocks present in the base, without considering the dynamic block type. It's more useful and intuitive for us to treat dynamic blocks as if they are instances of their given block type for the purpose of overriding. That means a foo block can be overridden by a dynamic "foo" block and vice-versa, and dynamic blocks of different types do not interact at all during overriding. This requires us to recognize dynamic blocks and treat them specially during decoding of a merged body. We leave them unexpanded here because this package is not responsible for dynamic block expansion (that happens in the sibling "lang" package) but we do decode them enough to recognize their labels so we can treat them as if they were blocks of the labelled type.	7 years ago
Martin Atkins	88e76fa9ef	configs/configschema: Introduce the NestingGroup mode for blocks ... In study of existing providers we've found a pattern we werent previously accounting for of using a nested block type to represent a group of arguments that relate to a particular feature that is always enabled but where it improves configuration readability to group all of its settings together in a nested block. The existing NestingSingle was not a good fit for this because it is designed under the assumption that the presence or absence of the block has some significance in enabling or disabling the relevant feature, and so for these always-active cases we'd generate a misleading plan where the settings for the feature appear totally absent, rather than showing the default values that will be selected. NestingGroup is, therefore, a slight variation of NestingSingle where presence vs. absence of the block is not distinguishable (it's never null) and instead its contents are treated as unset when the block is absent. This then in turn causes any default values associated with the nested arguments to be honored and displayed in the plan whenever the block is not explicitly configured. The current SDK cannot activate this mode, but that's okay because its "legacy type system" opt-out flag allows it to force a block to be processed in this way anyway. We're adding this now so that we can introduce the feature in a future SDK without causing a breaking change to the protocol, since the set of possible block nesting modes is not extensible.	7 years ago
Martin Atkins	a20084dc0e	configs/configschema: EmptyValue methods ... These helpers determine the value that would be used for a particular schema construct if the configuration construct it represents is not present (or, in the case of *Block, empty) in the configuration. This is different than cty.NullVal on the implied type because it might return non-null "empty" values for certain constructs if their absence would be reported as such during a decode with no required attributes or blocks.	7 years ago
Martin Atkins	26c1e40ad7	configs/configupgrade: Normalize number literals to decimal ... The v0.12 language supports numeric constants only in decimal notation, as a simplification. For rare situations where a different base is more appropriate, such as unix-style file modes, we've found it better for providers to accept a string containing a representation in the appropriate base, since that way the interpretation can be validated and it will be displayed in the same way in the rendered plan diff, in outputs, etc. We use tv.Value() here to mimick how HCL 1 itself would have interpreted these, and then format them back out in the canonical form, which implicitly converts any non-decimal constants to decimal on the way through.	7 years ago
Kristin Laemmert	3aa4ac43f9	configs/configupgrade: return if hil.Parse() produces an error. (#20920) ... Fixes #20917	7 years ago
Martin Atkins	6c5819f910	configs/configupgrade: Prefer block syntax for list-of-object attributes ... In order to preserve pre-v0.12 idiom for list-of-object attributes, we'll prefer to use block syntax for them except for the special situation where the user explicitly assigns an empty list, where attribute syntax is required in order to allow existing provider logic to differentiate from an implicit lack of blocks.	7 years ago
Kristin Laemmert	da52170797	configupgrade: fix test (#20863)	7 years ago
Kristin Laemmert	1baa1b907e	configs/configupgrade: detect invalid resource names and print a TODO (#20856) ... * configs/configupgrade: detect invalid resource names and print a TODO message In terraform 0.11 and prior it was possible to start a resource name with a number. This is no longer valid, as the resource name would would be ambiguous with number values in HCL expressions. Fixes #19919 * Update configs/configupgrade/test-fixtures/valid/invalid-resource-name/want/resource.tf Co-Authored-By: mildwonkey <mildwonkey@users.noreply.github.com>	7 years ago
Justin Downing	1e32ae243c	grammatical updates to comments and docs (#20195)	7 years ago
Martin Atkins	ea1d5f8fcb	vendor: go get github.com/hashicorp/hcl2@master ... This includes two upstream fixes: - Handle explicit JSON "null" consistently during decode of JSON syntax. - Properly detect the end of a "heredoc" when formatting to avoid messing up indentation of other lines following the heredoc.	7 years ago
Kristin Laemmert	2c60140cad	configs: do not panic if module version is a variable (#20681) ... Fixes #20653	7 years ago
Kristin Laemmert	a15a4acf2f	configs/configupgrade: detect possible relative module sources (#20646) ... * configs/configupgrade: detect possible relative module sources If a module source appears to be a relative local path but does not have a preceding ./, print a #TODO message for the user. * internal/initwd: limit go-getter detectors to those supported by terraform * internal/initwd: move isMaybeRelativeLocalPath check into getWithGoGetter To avoid making two calls to getter.Detect, which potentially makes non-trivial API calls, the "isMaybeRelativeLocalPath" check was moved to a later step and a custom error type was added so user-friendly diagnostics could be displayed in the event that a possible relative local path was detected.	7 years ago