793 Commits (ba7679b6791a306a73062ddd5a00359452e152fc)

Author	SHA1	Message	Date
Martin Atkins	ce68b4d27c	config: Remove legacy interpolation function implementations ... These are often confusing for new contributors, since this looks suspiciously like the right place to add new functions or change the behavior of existing ones. To reduce that confusion, here we remove them entirely from this package (which is now dead code in Terraform 0.12 anyway) and include in the documentation comments a pointer to the current function implementations.	6 years ago
Radek Simko	7860f55e4f	Version tools per Go convention under tools.go	6 years ago
Martin Atkins	39e609d5fd	vendor: switch to HCL 2.0 in the HCL repository ... Previously we were using the experimental HCL 2 repository, but now we'll shift over to the v2 import path within the main HCL repository as part of actually releasing HCL 2.0 as stable. This is a mechanical search/replace to the new import paths. It also switches to the v2.0.0 release of HCL, which includes some new code that Terraform didn't previously have but should not change any behavior that matters for Terraform's purposes. For the moment the experimental HCL2 repository is still an indirect dependency via terraform-config-inspect, so it remains in our go.sum and vendor directories for the moment. Because terraform-config-inspect uses a much smaller subset of the HCL2 functionality, this does still manage to prune the vendor directory a little. A subsequent release of terraform-config-inspect should allow us to completely remove that old repository in a future commit.	7 years ago
Pam Selle	9631e4c73d	Merge pull request #20571 from sergkondr/fix_misspelling ... fix misspelling	7 years ago
Alex Pilon	77757d9f5b	prune references to config/module ... delete config/module prune references to config except in terraform/resource.go move, cleanup, and delete inert code	7 years ago
Alex Pilon	4bf43efcfd	move hcl2shim package to configs	7 years ago
Alex Pilon	c2bc88fc23	prune ResourceProviderFullName and its callers	7 years ago
Alex Pilon	0450f487fa	move IsEmptyDir to configs package	7 years ago
Alex Pilon	7f8f198719	remove UnknownVariabeValue from config and update references to shim	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Pam Selle	f1541adfad	Ensure matching modules with metadata when requested (#21640) ... When a constraint is defined including build metadata, go-version ignores this, and if a user explicitly requests a build version, this will now return that version. Also covers cases when a user adds build metadata to a non-equality constraint, or in a constraint with multiple conditions (ex. >0.8.0+abc, <1.0.0), and gives and error when this occurs.	7 years ago
Radek Simko	8a6d1d62b6	stringer: Regenerate files with latest version	7 years ago
Martin Atkins	88e76fa9ef	configs/configschema: Introduce the NestingGroup mode for blocks ... In study of existing providers we've found a pattern we werent previously accounting for of using a nested block type to represent a group of arguments that relate to a particular feature that is always enabled but where it improves configuration readability to group all of its settings together in a nested block. The existing NestingSingle was not a good fit for this because it is designed under the assumption that the presence or absence of the block has some significance in enabling or disabling the relevant feature, and so for these always-active cases we'd generate a misleading plan where the settings for the feature appear totally absent, rather than showing the default values that will be selected. NestingGroup is, therefore, a slight variation of NestingSingle where presence vs. absence of the block is not distinguishable (it's never null) and instead its contents are treated as unset when the block is absent. This then in turn causes any default values associated with the nested arguments to be honored and displayed in the plan whenever the block is not explicitly configured. The current SDK cannot activate this mode, but that's okay because its "legacy type system" opt-out flag allows it to force a block to be processed in this way anyway. We're adding this now so that we can introduce the feature in a future SDK without causing a breaking change to the protocol, since the set of possible block nesting modes is not extensible.	7 years ago
James Bardin	e024960c74	Revert "filter nulls when shimming a config" ... This reverts commit 97bde5467c.	7 years ago
James Bardin	97bde5467c	filter nulls when shimming a config ... Nulls can't exist in HCL, and the legacy sdk will panic when encountering them. The map shim already did this, just copy the same pattern in the list case.	7 years ago
James Bardin	bb62aba651	add (forces new resource) to provider test diffs ... Add the (forces new resource) annotation to the diff output for provider tests failures when we can. This helps providers narrow down what might be triggering changes when encountering test failures with the new SDK.	7 years ago
Justin Downing	1e32ae243c	grammatical updates to comments and docs (#20195)	7 years ago
Sargun Dhillon	ebb551b86f	config: new "reverse" interpolation function ... It reverses a list.	7 years ago
Sergey Kondrashov	43e7a7b552	fix misspelling	7 years ago
Martin Atkins	995042666a	config/hcl2shim: ValuesSDKEquivalent float64 comparison of numbers ... The SDK uses only the native int and float64 types internally for values that are specified as being "number" in schema, so for SDK purposes only a float64 level of precision is significant. To avoid any weirdness introduced as we shim and un-shim numbers, we'll reduce floating point numbers to float64 precision before comparing them to try to mimic the result the SDK itself would've gotten from comparing its own float64 versions of these values using the Go "==" operator.	7 years ago
Martin Atkins	6b03c81375	config/hcl2shim: ValuesSDKEquivalent function ... This is a first pass of an "approximately equal" function that tries to mimic the reduced precision caused by the field reader abstraction in helper/schema so that we can distinguish between meaningful changes to the proposed new state and incidental ones that just result from the loss of precision in the SDK implementation.	7 years ago
Martin Atkins	4e14ab7557	config: Remove "setproduct" function, which is now in lang/funcs	7 years ago
Martin Atkins	9d11d427a8	config: Rename "product" function to "setproduct" ... This hopefully makes it clearer that it works with sets rather than real numbers, avoiding confusion with "sum", "min", "max", etc.	7 years ago
Fábio Matavelli	acd17d9075	Create product interpolation function ... This creates the product interpolation function that returns the cartesian product of a list of lists.	7 years ago
James Bardin	c7269bec02	Revert "insert empty objects into config from empty blocks" ... This reverts commit 3677522a28. Later changes negate the need for this, and removing these again prevents us from having to strip them back out when helper/schema doesn't want them.	7 years ago
James Bardin	f3c80b4765	add zero values to sets with a flatmap count of 1 ... If a flatmap value has a count of 1 and no other attributes, it usually indicates the equivalent configuration of an empty (or default value) set block. Treat this as containing a single zero value object and insert that into the set.	7 years ago
James Bardin	3677522a28	insert empty objects into config from empty blocks ... When creating a legacy config from a cty.Value, empty nested blocks should corespond to empty objects in the config.	7 years ago
James Bardin	6fee1f24ab	don't add duplicate unknowns to a set ... The flatmap shim was lazily adding duplicate items and letting cty.Set clear them out, but if those duplicates contains unknown values they can't be checked for equality and will end up remaining in the set.	7 years ago
James Bardin	f959b560a2	trim index steps from RequiresNew paths ... Only GetAttrSteps can actually trigger RequiresNew, but the flatmaps paths will point to the indexed value that caused the change.	7 years ago
Martin Atkins	93630cf95f	config/hcl2shim: ConfigValueFromHCL2Block function ... This is a more specialized version of ConfigValueFromHCL2 which is specifically for config values that represent the content of a block body in the configuration. By using the schema of that block we can more precisely emulate the old HCL1/HIL behaviors by distinguishing attributes from blocks and applying some slightly different behaviors for the handling of null values and of empty collections that are representing the absense of blocks of a particular type.	7 years ago
James Bardin	5c436bb820	add a nested map test to hcl2shim	7 years ago
James Bardin	9d8ca4515e	unknown collections in a flatmap ... Unknown collections in a flatmap also need to be converted to unknown values.	7 years ago
Martin Atkins	8cc8bacce3	config/hcl2shim: Treat DynamicVal like any other unknown value in flatmap	7 years ago
Kristin Laemmert	d1f27ce8c2	registry: renaming module-specific registry functions	7 years ago
James Bardin	f4416ee1df	update the new RequiresReplace function ... Make the function work specifically how we need for RequiresReplace. Skip index changes, any set changes are only recorded as the set itself, and filter out duplicate paths. Add a few more tests to check for various nested structures.	7 years ago
James Bardin	30ff37f335	change PathFromFlatmapKey to RequiresReplace ... Rather than try and make a generalized path function here, what we really need in a function to generate the paths needed for RequiresReplace. This needs to take into account that sets elements don't need to be indexed themselves, and changes to collection index values aren't needed.	7 years ago
James Bardin	44e993ec29	add hcl2shim.PathFromFlatmapKey ... PathFromFlatmapKey is used to convert a flatmap key to a cty.Path, and ensures it conforms to the type schema. This is used when handling Diffs, where the ResourceAttrDiffs are indexed by the flatmapped key values, and we need to convert those to addresses to apply to a cty.Value.	7 years ago
James Bardin	05e85885f9	handle Null collections in flatmaps ... When creating a flatmap from a cty.Value, there may be Null collections which don't need to be added to the flatmap at all. Skip over these to avoid panicking in ElementIterator with a Null value.	7 years ago
James Bardin	c28ce02f2a	return a nil flatmap when presented with a NullVal ... A nil flatmap will be encoded as a NullVal of the correct type. When Converting a NullVal back to a flatmap, return nil immediately rather than attempting to build the values.	7 years ago
James Bardin	ac8ee20233	return a NullVal when presented with a nil flatmap ... This allows us to decode the cty.Value back to a nil map, rather than trying to create a map with nil values.	7 years ago
Martin Atkins	479c6b2466	move "configschema" from "config" to "configs" ... The "config" package is no longer used and will be removed as part of the 0.12 release cleanup. Since configschema is part of the "new world" of configuration modelling, it makes more sense for it to live as a subdirectory of the newer "configs" package.	7 years ago
Martin Atkins	299fe25a04	hcl2shim: Handle unknown values when shimming to/from flatmap ... Previously unknown values were round-tripping through flatmap and coming out as known strings containing the UnknownVariableValue. (The classic bug that, ironically, was one of the big reasons to write cty!) Now we properly handle unknown values in both directions: going in to flatmap we write UnknownVariableValue at the appropriate key (as the count for sequences or maps) and then coming out of flatmap we turn UnknownVariableValue back into a cty unknown value of the requested type.	7 years ago
Martin Atkins	ccc1b6990f	config/hcl2shim: shims from flatmap to cty and vice-versa ... These particular shims will have a pretty limited lifetime in mainline Terraform code (primarily to stub out the new expression evaluator against the old state structs until the new format is implemented) but will live on for some time in state migration and provider plugin compatibility shims.	7 years ago
Martin Atkins	ebafa51723	command: Various updates for the new backend package API ... This is a rather-messy, complex change to get the "command" package building again against the new backend API that was updated for the new configuration loader. A lot of this is mechanical rewriting to the new API, but meta_config.go and meta_backend.go in particular saw some major changes to interface with the new loader APIs and to deal with the change in order of steps in the backend API.	7 years ago
Martin Atkins	22d140e883	configschema: Block.CoerceValue method ... The usual way to use a configschema.Block is to obtain a hcldec spec from it and then decode an hcl.Body. There are inevitably situations though where a body has already been decoded into a cty.Value before we know which schema we need to use. This new method CoerceValue is intended to deal with this case, applying the schema to an already-decoded value in what should be an intuitive way for most situations.	7 years ago
Martin Atkins	d6c6f8852c	configschema: include description in schema ... We will need access to this information in order to render interactive input prompts, and it will also be useful in returning schema information to external tools such as text editors that have autocomplete-like functionality.	7 years ago
Martin Atkins	c51d22bdeb	config/hcl2shim: don't put nils in ConfigValue maps ... Absent values are omitted by the old code we are emulating in HCL, so we must do the same here in order to avoid breaking assumptions in the helper/schema layer.	7 years ago
Sander van Harmelen	179b32d426	Add a `CredentialsForHost` method to disco.Disco ... By adding this method you now only have to pass a `*disco.Disco` object around in order to do discovery and use any configured credentials for the discovered hosts. Of course you can also still pass around both a `*disco.Disco` and a `auth.CredentialsSource` object if there is a need or a reason for that!	8 years ago
Sander van Harmelen	9ba33e1958	Merge pull request #18360 from hashicorp/svh/b-close-body ... svchost/disco: make sure to close the response body	8 years ago
Sander van Harmelen	2c0c3771a9	Make sure to close the response body ... And fix a few linter warnings while we're at it…	8 years ago