38 Commits (ba7679b6791a306a73062ddd5a00359452e152fc)

Author	SHA1	Message	Date
James Bardin	1ccf1bd9a2	Update communicator/ssh/communicator.go ... Co-Authored-By: Kristin Laemmert <mildwonkey@users.noreply.github.com>	7 years ago
James Bardin	bbde7e3e35	copy client pointer for keep-alive loop ... If a connection fails and attempts to reconnect after the keep-alive loop started, the client will be pulled out from under the keep-alive requests. Close over a local copy of the client, so that reconnecting doesn't race with the keepalive loop terminating.	7 years ago
Mark	3031aca971	Add SSH cert authentication method for connection via Bastion	7 years ago
Ahmon Dancy	f9db6651b8	Improve ssh connection debug messages ... 1) Mention the host and port in the "Connecting..." message. 2) Mention the username in the post-connection handshaking message. 3) If handshaking fails, mention the user, host, and port in the error message that will eventually be returned to the user.	7 years ago
James Bardin	780ca17884	use keepalive replies to detect dead connections ... An ssh server should always send a reply packet to the keepalive request. If we miss those replies for over 2min, consider the connection dead and abort, rather than block the provisioner indefinitely.	7 years ago
James Bardin	929231a2e9	Merge pull request #20437 from hashicorp/jbardin/ssh-keepalive ... add ssh keepalive messages to communicator	7 years ago
Sherod Taylor	c456d9608b	updated ssh authentication and testing for ssh	7 years ago
James Bardin	b5384100a6	add ssh keepalive messages to communicator ... Long running remote-exec commands with no output may be cutoff during execution. Enable ssh keepalives for all ssh connections.	7 years ago
James Bardin	6cac02df14	print scp error before exiting on error code ... See if there is any additional stderr output before exiting, since it can be helpful in addition to the error status.	7 years ago
James Bardin	abfb43555a	connect communicator during Start ... Match the tested behavior, and that of the ssh implementation, where the communicator automatically connects when starting a command. Remove unused import from legacy dependency handling.	8 years ago
James Bardin	3c30f04e0e	fix ssh logging ... Ensure correct formatting and add a log level to all output.	8 years ago
James Bardin	943972cd8f	retry ssh authentication failures ... Most of the time an ssh authentication failure would be non-recoverable, but some host images can start the ssh service before it is properly configured, or before user authentication data is available. Log ssh authentication errors and allow the provisioner to retry until the connection timeout.	8 years ago
James Bardin	3fbdee0777	clean up remote.Cmd api ... Combine the ExitStatus and Err values from remote.Cmd into an error returned by Wait, better matching the behavior of the os/exec package. Non-zero exit codes are returned from Wait as a remote.ExitError. Communicator related errors are returned directly. Clean up all the error handling in the provisioners using a communicator. Also remove the extra copyOutput synchronization that was copied from package to package.	8 years ago
James Bardin	2d7dc605a0	get communicator errors from a remote.Cmd ... The remote.Cmd struct could not convey any transport related error to the caller, meaning that interrupted commands would show that they succeeded. Change Cmd.SetExited to accept an exit status, as well as an error to store for the caller. Make the status and error fields internal, require serialized access through the getter methods. Users of remote.Cmd should not check both Cmd.Err() and Cmd.ExitStatus() until after Wait returns. Require communicators to call Cmd.Init before executing the command. This will indicate incorrect usage of the remote.Cmd by causing a panic in SetExitStatus.	8 years ago
James Bardin	e41b29d096	Merge pull request #17354 from hashicorp/jbardin/known_hosts ... Verify host keys in ssh connections	8 years ago
James Bardin	c1b35ad69b	have the ssh communicator return fatal errors ... This will let the retry loop abort when there are errors which aren't going to ever be corrected.	8 years ago
James Bardin	1a68fdb4f6	add support for ssh host key checking ... Add `host_key` and `bastion_host_key` fields to the ssh communicator config for strict host key checking. Both fields expect the contents of an openssh formated public key. This key can either be the remote host's public key, or the public key of the CA which signed the remote host certificate. Support for signed certificates is limited, because the provisioner usually connects to a remote host by ip address rather than hostname, so the certificate would need to be signed appropriately. Connecting via a hostname needs to currently be done through a secondary provisioner, like one attached to a null_resource.	8 years ago
Adam Shannon	c9c2823f62	communicator/ssh: add what error details we can for the user ... ssh.Waitmsg's String() method provides output which can include the process status, signal, and message	9 years ago
James Bardin	e1f06e5d0f	Skip upload copy if we know the length ... If the source length is known, we can skip copying the file.	9 years ago
Mitchell Hashimoto	b486354a9c	communicator/ssh: Disconnect() should also kill the actual connection	9 years ago
Mitchell Hashimoto	4b1d9cfd7d	communicator/ssh: don't share rand object to guarantee unique values ... Fixes #10463 I'm really surprised this flew under the radar for years... By having unique PRNGs, the SSH communicator could and would generate identical ScriptPaths and two provisioners running in parallel could overwrite each other and execute the same script. This would happen because they're both seeded by the current time which could potentially be identical if done in parallel... Instead, we share the rand now so that the sequence is guaranteed unique. As an extra measure of robustness, we also multiple by the PID so that we're also protected against two processes at the same time.	9 years ago
Paul Hinze	96c20f0dd7	communicator/{ssh,winrm}: seed random script paths ... Without a seed, the "random" script path locations for the remote-exec provisioner were actually deterministic! Every rand.Int31() would return the same pseudorandom chain starting w/ the numbers: 1298498081, 2019727887, 1427131847, 939984059, ... So here we properly seed the communicators so the script paths are actually random, and multiple runs on a single remote host have much less chance of clobbering each other. Fixes #4186 Kudos to @DustinChaloupka for the correct hunch leading to this fix!	10 years ago
Paul Hinze	7ffa66d1a5	ssh: accept private key contents instead of path ... We've been moving away from config fields expecting file paths that Terraform will load, instead prefering fields that expect file contents, leaning on `file()` to do loading from a path. This helps with consistency and also flexibility - since this makes it easier to shift sensitive files into environment variables. Here we add a little helper package to manage the transitional period for these fields where we support both behaviors. Also included is the first of several fields being shifted over - SSH private keys in provisioner connection config. We're moving to new field names so the behavior is more intuitive, so instead of `key_file` it's `private_key` now. Additional field shifts will be included in follow up PRs so they can be reviewed and discussed individually.	10 years ago
Anthony Scalisi	198e1a5186	remove various typos	11 years ago
Paul Hinze	814d05b96e	communicator/ssh: missing newline on bastion host output	11 years ago
Paul Hinze	98891aef96	Merge pull request #2684 from hashicorp/f-print-bastion-host-details ... communicator/ssh: print ssh bastion host details to output	11 years ago
Paul Hinze	448a6a1b48	communicator/ssh: print ssh bastion host details to output	11 years ago
Paul Hinze	138018c896	communicator/ssh: agent forward failure is not fatal ... On connections where no second hop is made, there's no problem if the agent forwarding connection is denied, so we shouldn't treat that as a fatal error.	11 years ago
Paul Hinze	a7cbbbd258	communicator/ssh: bastion host support ... * adds `bastion_*` fields to `connection` which add configuration for a bastion host * if `bastion_host` is set, connect to that host first, then jump through it to make the SSH connection to `host` * enables SSH Agent forwarding by default	11 years ago
Sander van Harmelen	f146a31ded	Fixing #2033 by adding a small check on the input ... If the input begins with a shebang, we’ll leave it as is. If not we’ll add a default shebang…	11 years ago
Sander van Harmelen	a8dacede24	Improved some logging... ... I added a debug log line in the last commit, only to find out it’s now logging the same info twice. So removed the double entry and tweaked the existing once.	11 years ago
Sander van Harmelen	3881c81a66	Added the exit code as well...	11 years ago
Sander van Harmelen	48f4d499f9	Fixing a small vet warning introduced by PR #1796 ... While fixing the vet warning also tried to improve any feedback by showing the actual output/error instead of just the error code. While testing this I noticed only adding stderr output is not enough as not all error info is send to stderr, but sometimes also to stdout.	11 years ago
Luke Amdor	fbae7884eb	remote-exec (ssh): chmod'ing right path	11 years ago
Luke Amdor	11b4060fee	remote-exec (ssh): checking chmod command	11 years ago
Sander van Harmelen	41748003c0	Updated the PR according to the review comments ... * We now return an error when you set the script_path to C:\Windows\Temp explaining this is currently not supported * The fix in PR #1588 is converted to the updated setup in this PR including the unit tests Last thing to do is add a few tests for the WinRM communicator…	11 years ago
Sander van Harmelen	4a29c714e5	Adding support for WinRM	11 years ago
Sander van Harmelen	c9e9e374bb	Adding some abstractions for the communicators ... This is needed as preperation for adding WinRM support. There is still one error in the tests which needs another look, but other than that it seems like were now ready to start working on the WinRM part…	11 years ago