92 Commits (ba7679b6791a306a73062ddd5a00359452e152fc)

Author	SHA1	Message	Date
Martin Atkins	8f27409007	backend/remote: Support HCL variable values in local operations ... For remote operations, the remote system (Terraform Cloud or Enterprise) writes the stored variable values into a .tfvars file before running the remote copy of Terraform CLI. By contrast, for operations that only run locally (like "terraform import"), we fetch the stored variable values from the remote API and add them into the set of available variables directly as part of creating the local execution context. Previously in the local-only case we were assuming that all stored variables are strings, which isn't true: the Terraform Cloud/Enterprise UI allows users to specify that a particular variable is given as an HCL expression, in which case the correct behavior is to parse and evaluate the expression to obtain the final value. This also addresses a related issue whereby previously we were forcing all sensitive values to be represented as a special string "<sensitive>". That leads to type checking errors for any variable specified as having a type other than string, so instead here we use an unknown value as a placeholder so that type checking can pass. Unpopulated sensitive values may cause errors downstream though, so we'll also produce a warning for each of them to let the user know that those variables are not available for local-only operations. It's a warning rather than an error so that operations that don't rely on known values for those variables can potentially complete successfully. This can potentially produce errors in situations that would've been silently ignored before: if a remote variable is marked as being HCL syntax but is not valid HCL then it will now fail parsing at this early stage, whereas previously it would've just passed through as a string and failed only if the operation tried to interpret it as a non-string. However, in situations like these the remote operations like "terraform plan" would already have been failing with an equivalent error message anyway, so it's unlikely that any existing workspace that is being used for routine operations would have such a broken configuration.	6 years ago
Martin Atkins	9f9f22091e	backend/remote: Unlock workspace if Context fails ... Previously any error case in the Context method would cause us to leave the remote workspace locked on exit, requiring manual action to unlock it.	6 years ago
Martin Atkins	b10f058cbb	backend/remote: Only load variables if we're going to use them ... Some commands don't use variables at all or use them in a way that doesn't require them to all be fully valid and consistent. For those, we don't want to fetch variable values from the remote system and try to validate them because that's wasteful and likely to cause unnecessary error messages. Furthermore, the variables endpoint in Terraform Cloud and Enterprise only works for personal access tokens, so it's important that we don't assume we can _always_ use it. If we do, then we'll see problems when commands are run inside Terraform Cloud and Enterprise remote execution contexts, where the variables map always comes back as empty.	6 years ago
Martin Atkins	a8d01e3940	backend/remote: Report invalid variables only remotely ... The remote backend uses backend.ParseVariableValues locally only to decide if the user seems to be trying to use -var or -var-file options locally, since those are not supported for the remote backend. Other than detecting those, we don't actually have any need to use the results of backend.ParseVariableValues, and so it's better for us to ignore any errors it produces itself and prefer to just send a potentially-invalid request to the remote system and let the remote system be responsible for validating it. This then avoids issues caused by the fact that when remote operations are in use the local system does not have all of the required context: it can't see which environment variables will be set in the remote execution context nor which variables the remote system will set using its own generated -var-file based on the workspace stored variables.	6 years ago
Pam Selle	a5f2f4cbba	Update messaging for .terraformignore	6 years ago
Radek Simko	32f9722d9d	Replace import paths & set UA string where necessary	6 years ago
Paul Thrasher	f2ef8ef317	slow down tfce polling to 1s ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	4e308ef362	typos. some code, some text. ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	d2eaffabea	vendor latest go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	d3fc3dee6e	clean up go mod for go-tfe ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	e2831b3d1e	tfce test additions ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	bc2d888b7b	update to go-tfe 0.3.23 ... this fixes the attr types Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	39817ac476	cost estimation status polling ... Properly wait for cost estimation to finish running before outputting the results. Waits 500 milliseconds between checks, rather than backing off exponentially, because we are not in a run queue. At the point we're waiting, we expect cost estimation to be run in a timely manner.	7 years ago
Paul Thrasher	979bba0f32	tfce mock fix ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Kristin Laemmert	412d459292	backend/remote: remove milseading contents from error message (#22148) ... Previously, terraform was returning a potentially-misleading error message in response to anything other than a 404 from the b.client.Workspaces.Read operation. This PR simplifies Terraform's error message with the intent of encouraging those who encounter it to focus on the error message returned from the tfe client. The added test is odd, and a bit hacky, and possibly overkill.	7 years ago
Kristin Laemmert	190ef537ec	backend/remote: notify users when uploading something other than cwd ... When a TFC workspace is configured without a VCS root, and with a working directory, and a user is running `terraform init` from that same directory, TFC uploads the entire configuration directory, not only the user's cwd. This is not obvious to the user, so we are adding a descriptive message explaining what is being uploaded, and why.	7 years ago
Kristin Laemmert	89eeaed0a0	[WIP] backend/enhanced: start with absolute configuration path (#22096) ... * backend/enhanced: start with absolute config path We recently started normalizing the config path before all "command" operations, which was necessary for consistency but had unexpected consequences for remote backend operations, specifically when a vcs root with a working directory are configured. This PR de-normalizes the path back to an absolute path. * Check the error and add a test It turned out all required logic was already present, so I just needed to add a test for this specific use case.	7 years ago
Radek Simko	5b9f2fafc8	Standardise directory name for test data	7 years ago
Mary Cutrali	e44ca40702	update remote apply language to use proper its/it's	7 years ago
David Celis	5ccccfb91f	Remove pre-alpha cost estimation logic	7 years ago
Sander van Harmelen	394f20f59c	backend/remote: do not unlock after a failed upload ... When changes are made and we failed to upload the state, we should not try to unlock the workspace. Leaving the workspace locked is a good indication something went wrong and also prevents other changes from being applied before the newest state is properly uploaded. Additionally we now output the lock ID when a lock or force-unlock action failed.	7 years ago
Paul Thrasher	151c91ffda	use scanner for reading logs ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	0e27a8862f	remove duplicate remote output line ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Sander van Harmelen	bb12206bca	Fixup the tests	7 years ago
Sander van Harmelen	7cf744241a	Do not use a scanner to read the logs ... Using a scanner can cause issues when reading long lines. Also make sure we return the error correctly while planning.	7 years ago
Paul Thrasher	c7a023a95c	update test for new go-tfe version ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	53f977bee2	TFCE api correct pluralization ... Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Paul Thrasher	e479bd5dc3	update to latest go-tfe ... same version number but pointing to a new sha Signed-off-by: Paul Thrasher <pthrasher@hashicorp.com>	7 years ago
Sander van Harmelen	90bc237b7b	Prevent a panic caused by writing to a nil map	7 years ago
Sander van Harmelen	39a95e4222	backend/remote: correctly load remote variables ... When using `terraform console` in combination with the remote backend, variables defined in Terraform Enterprise were load loaded correctly.	7 years ago
Sander van Harmelen	9f6a126293	backend/remote: check for external updates	7 years ago
Sander van Harmelen	4628fbcc65	Merge pull request #20615 from hashicorp/svh/f-input-context ... core: add a context to the UIInput interface	7 years ago
Sander van Harmelen	973e2a7cf9	core: add a context to the UIInput interface	7 years ago
Sander van Harmelen	0232d84a0d	backend/remote: also retry on server errors ... Enably retrying on server errors in the updated `go-tfe` client and add a retry log hook for writing retry messages to the CLI.	7 years ago
Sander van Harmelen	63e2dcef8a	Merge pull request #20481 from hashicorp/svh/b-exit-code ... backend/remote: exit with 1 when a run is canceled	7 years ago
Sander van Harmelen	01f17fa0ca	backend/remote: exit with 1 when a run is canceled	7 years ago
James Bardin	c814f2da37	Change backend.ValidateConfig to PrepareConfig ... This mirrors the change made for providers, so that default values can be inserted into the config by the backend implementation. This is only the interface and method name changes, it does not yet add any default values.	7 years ago
Sander van Harmelen	58961026a2	backend/remote: use the can-queue-apply permission ... Previously we checked can-update in order to determine if a user had the required permissions to apply a run, but that wasn't sufficient. So we added a new permission, can-queue-apply, that we now use instead.	7 years ago
Sander van Harmelen	54736b068b	backend/remote: use `state.v2` for remote state only ... The API surface area is much smaller when we use the remote backend for remote state only. So in order to try and prevent any backwards incompatibilities when TF runs inside of TFE, we’ve split up the discovery services into `state.v2` (which can be used for remote state only configurations, so when running in TFE) and `tfe.v2.1` (which can be used for all remote configurations).	7 years ago
Sander van Harmelen	aefbec63b1	backend/remote: update the test logic	7 years ago
Sander van Harmelen	3b80f69eec	Merge pull request #20242 from hashicorp/svh/b-scanner-buffer-v0.12 ... backend/remote: fix bufio.Scanner: token too long	7 years ago
Sander van Harmelen	47a00ea34b	backend/remote: cleanup test connections ... Cleanup test connection to prevent file descriptor issues when running the tests on a Mac.	7 years ago
Sander van Harmelen	5249d0fe83	backend/remote: fix bufio.Scanner: token too long	7 years ago
Sander van Harmelen	1e4c20686e	backend/remote: make sure we show the correct error ... Previously we would show two errors when there was a version constraint error. But of course one is enough.	7 years ago
Sander van Harmelen	8937fedb76	backend/remote: fix a small typo	7 years ago
Sander van Harmelen	e08a7e979e	backend/remote: use the correct test operation	7 years ago
Martin Atkins	0c0a437bcb	Move module install functionality over to internal/initwd	7 years ago
Sander van Harmelen	bba03384d5	backend/remote: log early to indicate execution started	7 years ago
Sander van Harmelen	7b51af72b2	backend/remote: compare versions without the prerelease	7 years ago
Sander van Harmelen	55b6153b04	backend/remote: fix an error that prevents checking constraints	7 years ago