terraform

Commit Graph

Author	SHA1	Message	Date
James Bardin	498012c130	don't panic on invalid keys for relevant attrs The PathMatcher used when rendering diffs assumes the caller knows the structure the path was derived from, which is incorrect. RelevantAttributes is derived from references to an object, which may have errors hidden by `try` or `can` functions, or the data may not have been updated to match paths via targeted operations. Even in the case where the data may be incorrect, we can't crash when rendering the data, because the user may not be able to work around the panic with no other information about which resource contains unexpected references.	1 month ago
Samsondeen	ccf00c29ba	terraform test: return error when provider config is invalid (#38140 )	2 months ago
github-actions[bot]	530f2b30ef	Backport of Colorize diag details into v1.14 (#38148 )	2 months ago
Radek Simko	e4a8898d30	v1.14 backport: backend/http: Refresh state earlier (align with other backends) (#38061 ) * backend/http: Refresh state before returning StateMgr This aligns the http backend with the implementation of StateMgr in other remote backends, which in turn enables easier testing of higher level logic that relies on certain backend behaviours. * backend/http: Refactor TestHTTPBackend to allow custom method implementations * add regression test for PR 38027	3 months ago
Radek Simko	4aefefee4b	v1.14 backport: Fix nil pointer dereference in backend state migration (#38028 ) (#38058 ) * fix: handle all StateMgr errors during backend migration Fixes a nil pointer dereference panic that occurs during backend migration when StateMgr returns an error other than ErrDefaultWorkspaceNotSupported. The bug occurred because the code only checked for the specific ErrDefaultWorkspaceNotSupported error. When any other error occurred (such as permission errors like storage.objects.get access denied), destinationState remained nil, but the code continued and attempted to call destinationState.RefreshState(), causing a panic. This fix adds an else clause to catch and return all other errors from StateMgr, preventing the nil pointer dereference and providing users with a clear error message instead of a crash. Fixes #24100 * Add changelog entry for backend migration nil pointer fix 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Mark Hall <mark.hall993@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>	3 months ago
github-actions[bot]	b0ebd07f11	providers lock: include test files when loading configuration (#37904 ) Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	5 months ago
Liam Cervante	e2327fdc31	Backport of ephemeral fixes into v1.14 (#37850 ) * ephemerals: allow root ephemeral outputs in stacks and test * remember to set new opt for apply stage * Stacks: temporarily disable ephemeral outputs in Stack components * don't write ephemeral outputs to state	5 months ago
Kristin Laemmert	dae907de73	update test to not have hardcoded version info	5 months ago
github-actions[bot]	b7b7fdc825	Backport of Allow inconsistent filesystem function results for provider configuration into v1.14 (#37870 ) * allow inconsistent function results for providers Due to the inherently ephemeral nature of provider configuration, inconsistent function results were tolerated while evaluating provider config. This loophole was found to be used by a number of configurations, which took advantage of it to create the equivalent of ephemeral values before they formally existed in the language. In order to work around this, we create a special evaluation scope just for providers, allowing us to override the results check for filesystem functions. I've opted to not further clutter the EvalContext interface since this is intended to be a temporary workaround, and does not contribute to the testing of that interface (the interface is solely for internal unit tests anyway). * provider eval scope test * CHANGELOG --------- Co-authored-by: James Bardin <j.bardin@gmail.com> Co-authored-by: Daniel Schmidt <danielmschmidt92@gmail.com>	5 months ago
Radek Simko	6fd75637df	PSS: Gate experimental logic behind feature flag (#37872 ) This is a partial backport of #37868	5 months ago
Liam Cervante	74a8d2c6a9	actions: connect invoke flag with TFC (#37544 ) (#37747 ) * actions: connect invoke flag with TFC * use latest go-tfe	6 months ago
github-actions[bot]	3c267ecfc6	Backport of Added missing output for the terraform apply cli actions into v1.14 (#37718 ) * backport of commit `f13a3ae8d8` --------- Co-authored-by: Akella Umesh <umesh.akella@gmail.com> Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	6 months ago
James Bardin	082a3810fc	backport of commit `9c2b2c579a`	6 months ago
github-actions[bot]	129d7bd4d4	query: add -query flag to validate command (#37671 ) (#37707 ) Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>	6 months ago
github-actions[bot]	94af117ea4	Backport of evaluate: return diagnostics instead of unknown for uninitialised locals and resources into v1.14 (#37667 ) * no-op commit due to failed cherry-picking * evaluate: return diagnostics instead of unknown for uninitialised locals and resources * changelog * also input variables --------- Co-authored-by: temp <temp@hashicorp.com> Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	7 months ago
github-actions[bot]	2434b319b3	Backport of Handle `-help` usage in stacks plugin into v1.14 (#37655 ) * backport of commit `10f00d437f` * backport of commit `7f0ef4c8d0` --------- Co-authored-by: Mark DeCrane <mark.decrane@hashicorp.com>	7 months ago
github-actions[bot]	20ca183851	list: send non-null "config" object to provider when not present in the list block (#37620 ) (#37662 )	7 months ago
github-actions[bot]	6bb50f4056	Backport of actions: allow invoke only on local execution while TFC adds support into v1.14 (#37654 ) * backport of commit `fa389d2e18` * backport of commit `941d46f334` --------- Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>	7 months ago
Daniel Banck	f6842ce5af	tf query: ready list blocks for beta (#37619 ) (#37630 ) Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com>	7 months ago
Daniel Schmidt	332e0386ea	remove feature flag from invoke flag	7 months ago
Daniel Schmidt	d83cd73ecf	fix action reference	7 months ago
Kristin Laemmert	df113486a1	actions: remove references to action types, linked resources (#37616 ) * action renaming * actions: remove references to action types * actions: remove references to linked_resources or action types from the plan proto	7 months ago
Samsondeen	7379832fb8	query: add identity_version to list_resource_found json output (#37612 )	7 months ago
Daniel Schmidt	871451122f	actions: move schema to single action type and remove linked resources we want to leave the door open to evolve the design in the future based on feedback	7 months ago
Sarah French	6847e763de	Update calls to StateMgr method to use diagnostics more conventionally (#37597 ) * Update call to StateMgr method to use diagnostics more explicitly * Update calling code in remote backend tests * Update calling code in non-test code to handle diags conventionally. * Fix test failure messages from using wrong variable * Additional refactoring	7 months ago
Liam Cervante	ffdf9f2a86	actions: preserve unknown metadata in the json plan (#37611 ) * actions: preserve unknown metadata in the json plan * copywrite headers	7 months ago
Daniel Banck	1ac8497994	Add support for Terraform Search in the cloud backend (TF-25935) (#37479 )	7 months ago
Samsondeen	8097374c3d	Fix panic when generating json config for tf query (#37596 )	7 months ago
Sarah French	90809dc7e8	Skip TestTest_Parallel due to flakiness (#37594 )	7 months ago
Liam Cervante	551ba2e525	Implement controlling destroy functionality within Terraform Test (#37359 ) * Add ability to parse backend blocks present in a test file's run blocks, validate configuration (#36541) * Add ability to parse backend blocks from a run block * Add validation to avoid multiple backend blocks across run blocks that use the same internal state file. Update tests. * Add validation to avoid multiple backend blocks within a single run block. Update tests. * Remove use of quotes in diagnostic messages * Add validation to avoid backend blocks being used in plan run blocks. Update tests. * Correct local backend blocks in new test fixtures * Add test to show that different test files can use same backend block for same state key. * Add validation to enforce state-storage backend types are used * Remove TODO comment We only need to consider one file at a time when checking if a state_key already has a backend associated with it; parallelism in `terraform test` is scoped down to individual files. * Add validation to assert that the backend block must be in the first apply command for an internal state * Consolidate backend block validation inside a single if statement * Add initial version of validation that ensures a backend isn't re-used within a file * Explicitly set the state_key at the point of parsing the config TODO: What should be done with method (moduletest.Run).GetStateKey? * Update test fixture now that reusing backend configs has been made invalid * Add automated test showing validation of reused configuration blocks * Skip test due to flakiness, minor change to test config naming * Update test so it tolerates non-deterministic order run blocks are evaluated in * Remove unnecessary value assignment to r.StateKey * Replace use of GetStateKey() with accessing the state key that's now set during test config parsing * Fix bug so that run blocks using child modules get the correct state key set at parsing time * Update acceptance test to also cover scenario where root and child module state keys are in use * Update test name * Add newline to regex * Ensure consistent place where repeat backend error is raised from * Write leftover test state(s) to file (#36614) * Add additional validation that the backend used in a run is a supported type (#36648) * Prevent test run when leftover state data is present (#36685) * `test`: Set the initial state for a state files from a backend, allow the run that defines a backend to write state to the backend (#36646) * Allow use of backend block to set initial state for a state key * Note about alternative place to keep 'backend factories' * Allow the run block defining the backend to write state to it * Fix rebase * Change to accessing backend init functions via ContextOpts * Add tests demonstrating how runs containing backend blocks use and update persisted state * Fix test fixture * Address test failure due to trouble opening the state file This problem doesn't happen on MacOS, so I assume is due to the Linux environment of GitHub runners. * Fix issue with paths properly I hope * Fix defect in test assertion * Pivot back to approach introduced in `4afc3d7` * Let failing tests write to persistent state, add test case covering that. I split the acceptance tests into happy/unhappy paths for this, which required some of the helper functions' declarations to be raised up to package-level. * Change how we update internal state files, so that information about the associated backend is never lost * Fix UpdateStateFile * Ensure that the states map set by TestStateTransformer associates a backend with the correct run. * Misc spelling fixes in comments and a log * Replace state get/set functions with existing helpers (#36747) * Replace state get/set functions with existing helpers * Compare to string representation of state * Compare to string representation of state * Terraform Test: Allow skipping cleanup of entire test file or individual run blocks (#36729) * Add validation to enforce skip_cleanup=false cannot be used with backend blocks (#36857) * Integrate use of backend blocks in tests with skip_cleanup feature (#36848) * Fix nil pointer error, update test to not be table-driven * Make using a backend block implicitly set skip_cleanup to true * Stop state artefacts being created when a backend is in use and no cleanup errors have occurred * Return diagnostics so calling code knows if cleanup experienced issues or not * Update tests to show that when cleanup fails a state artefact is created * Add comment about why diag not returned * Bug fix - actually pull in the state from the state manager! * Split and simplify (?) tests to show the backend block can create and/or reuse prior state * Update test to use new fixtures, assert about state artefact. Fix nil pointer * Update test fixture in use, add guardrail for flakiness of forced error during cleanup * Refactor so resource ID set in only one place * Add documentation for using a `backend` block during `test` (#36832) * Add backend as a documented block in a run block * Add documentation about backend blocks in run blocks. * Make the relationship between backends and state keys more clear, other improvements * More test documentation (#36838) * Terraform Test: cleanup command (#36847) * Allow cleanup of states that depend on prior runs outputs (#36902) * terraform test: refactor graph edge calculation * create fake run block nodes during cleanup operation * tidy up TODOs * fix tests * remove old changes * Update internal/moduletest/graph/node_state_cleanup.go Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> * Improve diagnostics around skip_cleanup conflicts (#37385) * Improve diagnostics around skip_cleanup conflicts * remove unused dynamic node * terraform test: refactor manifest file for simplicity (#37412) * test: refactor apply and plan functions so no run block is needed * terraform test: write and load state manifest files * Terraform Test: Allow skipping cleanup of entire test file or individual run blocks (#36729) * terraform test: add support for skip_cleanup attr * terraform test: add cleanup command * terraform test: add backend blocks * pause * fix tests * remove commented code * terraform test: make controlling destroy functionality experimental (#37419) * address comments * Update internal/moduletest/graph/node_state_cleanup.go Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> --------- Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> * add experimental changelog entries --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Samsondeen <40821565+dsa0x@users.noreply.github.com> Co-authored-by: Samsondeen Dare <samsondeen.dare@hashicorp.com>	7 months ago
Liam Cervante	00d680d819	apply: include sensitive metadata when comparing changed input values (#37582 ) * apply: include sensitive metadata when comparing changed input values * correct changelog entry	7 months ago
Samsondeen	af8cc7e315	test: create all edges to leaf cleanup nodes (#37564 )	7 months ago
Kristin Laemmert	cad076409c	Fix e2e tests on windows (#37572 ) * close file explicitly (for windows) * drop the config file in the tf.Path root	7 months ago
Kristin Laemmert	cf9c491d9f	fix minor regression in tests (#37570 ) At one point, these tests were explicitly passing an empty cli config filepath so that terraform would ignore any existing cli config file (only relevant if you are running these tests locally), but the behavior changed over time such that it was no longer working for these tests (now if the env var file path is empty, we fall back to the default). The actual behavior is reasonably correct (I've depended on passing in blank config file paths before, so I don't love it, but I don't see a need to break this either) so I've added a small method that drops a blank file in place to fix the behavior and avoid file not found errors.	7 months ago
James Bardin	1cb7d1859f	Merge pull request #37515 from hashicorp/jbardin/generate-config provider GenerateResourceConfig	7 months ago
Sarah French	8503c45013	Update `backend.Backend`'s `StateMgr` method to return diagnostics instead of primitive errors (#37496 ) * Fix S3 backend test affected by making the Workspaces method return errors via diagnostics * Address diagnostics comparison issues in test by ensuring expected diagnostics are defined in the context of the config they're triggered by * Fix failing test case `TestBackendConfig_EC2MetadataEndpoint/envvar_invalid_mode` by making `diagnosticBase` struct comparable * Add compile-time checks that diagnostic types fulfil interfaces * Stop diagnosticBase implementing ComparableDiagnostic, re-add S3-specific comparer code to s3 package * Update tests to use the S3-specific comparer again * Fix test case missed in refactoring * Update the backend.Backend interface to use diagnostics as return value from StateMgr method * Fix calls to `Fatalf`	7 months ago
Sarah French	61a7914dd9	Add test helper to create mock provider that contains a state store (#37556 ) * Add a helper for mocking a provider with a state store * Update tests to use the new helper * Update other test fixtures for consistency The related tests pass before and after this change * Update testing helper to return the underlying type, not the interface	7 months ago
Daniel Schmidt	85717fba7e	actions: add number of invoked actions to plan summary	7 months ago
Daniel Schmidt	ad4371342f	track partial expanded action invocations through deferred action invocation like we do it for resources just simpler because we don't have layered addrs maps	7 months ago
Daniel Schmidt	b2c4766d5e	implement review feedback	7 months ago
Daniel Schmidt	dffeeec81e	partially expand triggers as well	7 months ago
Liam Cervante	5124967f5a	actions: allow skipping refresh when invoking actions (#37541 ) * actions: add invoke graph nodes * fix small bugs * add additional tests * remove whitespace * actions: invoke rendered actions * also fix up apply message * make description headers consistent * fix copyright headers * actions: allow skipping refresh when invoking actions * go generate	7 months ago
Liam Cervante	673717d01a	actions: render invoked actions (#37540 ) * actions: add invoke graph nodes * fix small bugs * add additional tests * remove whitespace * actions: invoke rendered actions * also fix up apply message * make description headers consistent * fix copyright headers * go generate	7 months ago
Liam Cervante	b0ff7c271c	Revert "actions: allow skipping refresh when invoking actions (#37523 )" (#37539 ) This reverts commit `d39fcc4f0b`.	7 months ago
Liam Cervante	8488fbb35c	Revert "actions: render invoked actions (#37522 )" (#37538 ) This reverts commit `0fae555389`.	7 months ago
James Bardin	4c610ac5e6	use the new genconfig types throughout	8 months ago
James Bardin	ddc47f15e7	remove the recursive genconfig resource struct The Resource struct didn't really match the data structure. Refactor this to make it easier to break up the config generation calls so we can pass in final config from the provider.	8 months ago
Daniel Schmidt	176263d936	actions: remove future action types removing them for now, this gives us more flexibility in the future since the schema is not yet locked in	8 months ago
Liam Cervante	e43eeaaf2e	actions: update JSON output to include invoked actions (#37527 ) * actions: update JSON output to include invoked actions * fix more tests	8 months ago
Sarah French	5be24bf1d0	Fix experimental gating of PSS feature (#37526 ) * Stop `state_store` being parsed when experiments aren't enabled * Update tests that show the feature is experimentally gated * Refactor to use unparsed hcl.Block for diagnostics when experiments aren't enabled	8 months ago

1 2 3 4 5 ...

943 Commits (ba63e8080b7fdb1069d00a4ff3e0304c89d1867e)