10 Commits (ba113ff2cd3708d8a0e49df66d649774af5aaa4e)

Author	SHA1	Message	Date
Martin Atkins	783a07d9e8	build: Use Go 1.19 ... Go 1.19's "fmt" has some awareness of the new doc comment formatting conventions and adjusts the presentation of the source comments to make it clearer how godoc would interpret them. Therefore this commit includes various updates made by "go fmt" to acheve that. In line with our usual convention that we make stylistic/grammar/spelling tweaks typically only when we're "in the area" changing something else anyway, I also took this opportunity to review most of the comments that this updated to see if there were any other opportunities to improve them.	4 years ago
Alisdair McDiarmid	c85ae29419	typeexpr: Replace null attr values with defaults ... Previously, when applying defaults to an input variable's given value before type conversion, we would permit `null` attribute values to override a specified default. This behaviour is inconsistent with the intent of the type system underlying Terraform, and represented a divergence from the treatment of `null` as equivalent to unset which exists in resources. The same behaviour exists in top-level variable definitions with `nullable = false`, and we consider this to be the preferred behaviour here too. This commit slightly changes default value application such that an explicit `null` attribute value is treated as equivalent to the attribute being missing. Default values for attributes will now replace explicit nulls.	4 years ago
Alisdair McDiarmid	650380f3ae	configs: Add default argument to optional() ... The optional modifier previously accepted a single argument: the attribute type. This commit adds an optional second argument, which specifies a default value for the attribute. To record the default values for a variable's type, we use a separate parallel structure of `typeexpr.Defaults`, rather than extending `cty.Type` to include a `cty.Value` of defaults (which may in turn include a `cty.Type` with defaults, and so on, and so forth). The new `typeexpr.TypeConstraintWithDefaults` returns a type constraint and defaults value. Defaults will be `nil` unless there are default values specified somewhere in the variable's type.	4 years ago
Alisdair McDiarmid	8f69e36e1b	typeexpr: Add support for nested type defaults ... In type constraints, object attributes may be marked as optional in order to allow them to be omitted from input values. Doing so results in filling the attribute value with a typed `null`. This commit adds a new type `typeexpr.Defaults` which mirrors the structure of a type constraint, storing default values for optional attributes. This will allow specification of non-`null` default values for attributes. The `Defaults` type is a tree structure, each node containing a sub-tree type, a map of children, and for object nodes, a map of defaults. The keys in the children map depend on the type of the node: - Object nodes have children for each attribute; - Tuple nodes have children for each index, with indices converted to string values; - Collection nodes have a single child at the empty string key. When traversing this tree we must take this structure into account, with special cases for map input values which may later be converted to objects. The traversal defined in this commit uses a pre-order transformer in order to pre-populate descendent nodes before their defaults are applied. This allows type nested type default values to be specified more compactly.	4 years ago
Alisdair McDiarmid	c82e291422	typeexpr: More optional modifier tests ... Ensuring that the constraint boolean carries through to the next level of constraint calculation after an optional() modifier.	4 years ago
Alisdair McDiarmid	dde4979c49	typeexpr: Improve diagnostic for any() constraints ... Using the any keyword with arguments (e.g. any(string, bool)) is invalid, but any is not technically a "primitive type keyword". This commit corrects the language in the diagnostic and updates the tests.	4 years ago
Alisdair McDiarmid	356cee7b89	typeexpr: Add test coverage for optional modifier	4 years ago
Alisdair McDiarmid	bf9f733ca2	typeexpr: Import tests from hashicorp/hcl ... This package is a fork of the HCL ext/typeexpr package, but we dropped the tests when bringing it across. This commit imports those tests verbatim.	4 years ago
James Bardin	1f359bab03	internal/typeexpr: staticcheck ... diagnostics were appended to diags shadowing the intended value.	5 years ago
Martin Atkins	0bbbb9c64b	configs: Experimental support for optional object type attributes ... This builds on an experimental feature in the underlying cty library which allows marking specific attribtues of an object type constraint as optional, which in turn modifies how the cty conversion package handles missing attributes in a source value: it will silently substitute a null value of the appropriate type rather than returning an error. In order to implement the experiment this commit temporarily forks the HCL typeexpr extension package into a local internal/typeexpr package, where I've extended the type constraint syntax to allow annotating object type attributes as being optional using the HCL function call syntax. If the experiment is successful -- both at the Terraform layer and in the underlying cty library -- we'll likely send these modifications to upstream HCL so that other HCL-based languages can potentially benefit from this new capability. Because it's experimental, the optional attribute modifier is allowed only with an explicit opt-in to the module_variable_optional_attrs experiment.	5 years ago